)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6e829d645c0ce0cc114c31d5ee8296f94e5a8b4a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update Sphinx version as well."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Remove the doc requirements from lower-constraints, they are not"},{"line_number":18,"context_line":"needed during installation."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"openstackdocstheme renames some variables, so follow the renames"},{"line_number":21,"context_line":"before the next release removes them. A couple of variables are also"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_1511ee04","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":27},"updated":"2020-05-19 14:36:57.000000000","message":"correct but the lower constraints should test that they are still co installable so that when you generate docs using the lower constraints we are sure they are still compatible.","commit_id":"e3fd84d77dbb0b4ae8354409815d395a43c81b14"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d2261fd09538665c657fdcdca16f29528fe66721","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch to newer openstackdocstheme and reno versions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Switch to openstackdocstheme 2.2.0 and reno 3.1.0 versions. Using"},{"line_number":10,"context_line":"these versions will allow especially:"},{"line_number":11,"context_line":"* Linking from HTML to PDF document"},{"line_number":12,"context_line":"* Allow parallel building of documents"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff570b3c_2b1d63bd","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":35},"updated":"2020-05-22 16:39:34.000000000","message":"2.2.1","commit_id":"ec76bef60b6db3a33849fad01730e7c8fa52551b"}],"lower-constraints.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"19070fa932f4b3ab27542148b78e258b199456d7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"msgpack\u003d\u003d0.5.6"},{"line_number":35,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":36,"context_line":"netifaces\u003d\u003d0.10.6"},{"line_number":37,"context_line":"openstackdocstheme\u003d\u003d1.20.0"},{"line_number":38,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":39,"context_line":"oslo.concurrency\u003d\u003d3.20.0"},{"line_number":40,"context_line":"oslo.config\u003d\u003d5.1.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_f539daa3","side":"PARENT","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":18},"updated":"2020-05-19 14:34:44.000000000","message":"we include the docs requirement in the lower constraits job so we shoudl not be removing these.\n\nhttps://github.com/openstack/os-vif/blob/master/tox.ini#L55","commit_id":"64013a860986d0b5b9a37f440f19286f1948ea74"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"044cdfcdb043b6b20d79edf41a6c02b01ac5cd0f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"msgpack\u003d\u003d0.5.6"},{"line_number":35,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":36,"context_line":"netifaces\u003d\u003d0.10.6"},{"line_number":37,"context_line":"openstackdocstheme\u003d\u003d1.20.0"},{"line_number":38,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":39,"context_line":"oslo.concurrency\u003d\u003d3.20.0"},{"line_number":40,"context_line":"oslo.config\u003d\u003d5.1.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_d8684df6","side":"PARENT","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":18},"in_reply_to":"ff570b3c_75ddcade","updated":"2020-05-19 15:23:21.000000000","message":"i would dissagree with that we want the lower constraits job to ensure the docs requriements work.\nthat is why i incldeded them in the first place.\nhttps://github.com/openstack/os-vif/commit/9679783616081fee019cf87724dd951e5756da1c","commit_id":"64013a860986d0b5b9a37f440f19286f1948ea74"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5712b2ffa286de862bf71210761aca46f0b4475b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"msgpack\u003d\u003d0.5.6"},{"line_number":35,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":36,"context_line":"netifaces\u003d\u003d0.10.6"},{"line_number":37,"context_line":"openstackdocstheme\u003d\u003d1.20.0"},{"line_number":38,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":39,"context_line":"oslo.concurrency\u003d\u003d3.20.0"},{"line_number":40,"context_line":"oslo.config\u003d\u003d5.1.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_75ddcade","side":"PARENT","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":18},"in_reply_to":"ff570b3c_f539daa3","updated":"2020-05-19 14:47:34.000000000","message":"Then let\u0027s remove that - it\u0027s really not needed.","commit_id":"64013a860986d0b5b9a37f440f19286f1948ea74"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"044cdfcdb043b6b20d79edf41a6c02b01ac5cd0f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":53,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":54,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  stestr run --black-regex \".tests.functional\" {posargs}"},{"line_number":58,"context_line":"  sphinx-build -W doc/source doc/build"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_d8516d38","side":"PARENT","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":36},"updated":"2020-05-19 15:23:21.000000000","message":"i dont think this is correect.\n\ni intentionally incled the docs requiremtne in the lower-constraits jobs which is why we run sphinx-build below to valideate the docs build works with the lower constratis.\n\nplease revert this and read the lower constratis for the docs requiremetns.","commit_id":"64013a860986d0b5b9a37f440f19286f1948ea74"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"66c1d8d606c92f12c156b2b4c3cf7919cb983740","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":53,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":54,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  stestr run --black-regex \".tests.functional\" {posargs}"},{"line_number":58,"context_line":"  sphinx-build -W doc/source doc/build"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_c294a88d","side":"PARENT","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":36},"in_reply_to":"ff570b3c_18164556","updated":"2020-05-21 09:48:49.000000000","message":"if that was strictly true the we should not be installing the test requirements as they are not runtime requirements.\n\nits for testing co-installablity and validating that the lower constratins we specify in our requirement file are actully sufficent to run our poject so that packages can trust our reqiurements.\n\nthat is why we run the unit tests and docs commands.\nthe only reason we dont run the functional tests too is os-vifs functional tests require ovs and sudo to run and the default job does not grant sudo permissions so we elected to not include them.","commit_id":"64013a860986d0b5b9a37f440f19286f1948ea74"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ab563065a122ef497c5e0920a241902b0a7ff421","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  -c{toxinidir}/lower-constraints.txt"},{"line_number":53,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":54,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":55,"context_line":"  -r{toxinidir}/doc/requirements.txt"},{"line_number":56,"context_line":"commands \u003d"},{"line_number":57,"context_line":"  stestr run --black-regex \".tests.functional\" {posargs}"},{"line_number":58,"context_line":"  sphinx-build -W doc/source doc/build"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_18164556","side":"PARENT","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":36},"in_reply_to":"ff570b3c_d8516d38","updated":"2020-05-19 15:27:08.000000000","message":"Sean, this is the very first project that is doing it this way.\n\nlower-constraints is for co-installable as runtime.\nIf you interpret it differently ;(","commit_id":"64013a860986d0b5b9a37f440f19286f1948ea74"}]}