)]}'
{"os_vif/internal/ip/linux/impl_pyroute2.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06167a208c28b865aeea605e0dcdb54704299b8e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                args[\u0027vlan_id\u0027] \u003d vlan_id"},{"line_number":77,"context_line":"                try:"},{"line_number":78,"context_line":"                    idx \u003d ip.link_lookup(ifname\u003dlink)"},{"line_number":79,"context_line":"                except ipexc.NetlinkError:"},{"line_number":80,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"},{"line_number":81,"context_line":"                if 0 \u003d\u003d len(idx):"},{"line_number":82,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7be4aee0","line":79,"updated":"2020-08-05 09:07:44.000000000","message":"Can you add a TODO to drop this when we bump our minimum version of pyroute2, perhaps with a note about the differences for anyone looking at this code in the future?","commit_id":"37895572127539882a7bc94db92c3de9bfdb435c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"07ec898eeb5c3d2338f71f9e7810ba20b483cf02","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                args[\u0027vlan_id\u0027] \u003d vlan_id"},{"line_number":77,"context_line":"                try:"},{"line_number":78,"context_line":"                    idx \u003d ip.link_lookup(ifname\u003dlink)"},{"line_number":79,"context_line":"                except ipexc.NetlinkError:"},{"line_number":80,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"},{"line_number":81,"context_line":"                if 0 \u003d\u003d len(idx):"},{"line_number":82,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f1f0df93","line":79,"in_reply_to":"9f560f44_7be4aee0","updated":"2020-08-05 10:52:53.000000000","message":"ya i also notice afterwad this is not the only place we call lookup so im going to quickly respin this an pull the lookup an not empty code out into a funciton and use it in add set delete and exists.\n\nill add the TODO in that","commit_id":"37895572127539882a7bc94db92c3de9bfdb435c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e31985ada39e60459042f65b648018e1c63f218a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    idx \u003d ip.link_lookup(ifname\u003dlink)"},{"line_number":79,"context_line":"                except ipexc.NetlinkError:"},{"line_number":80,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"},{"line_number":81,"context_line":"                if 0 \u003d\u003d len(idx):"},{"line_number":82,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"},{"line_number":83,"context_line":"                args[\u0027link\u0027] \u003d idx[0]"},{"line_number":84,"context_line":"            elif self.TYPE_VETH \u003d\u003d dev_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8ca07292","line":81,"range":{"start_line":81,"start_character":15,"end_line":81,"end_character":33},"updated":"2020-08-05 00:22:55.000000000","message":"note that in 0.5.13 it will return a list of len(0) so we will raise exactly the same exception on line 82","commit_id":"37895572127539882a7bc94db92c3de9bfdb435c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06167a208c28b865aeea605e0dcdb54704299b8e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    idx \u003d ip.link_lookup(ifname\u003dlink)"},{"line_number":79,"context_line":"                except ipexc.NetlinkError:"},{"line_number":80,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"},{"line_number":81,"context_line":"                if 0 \u003d\u003d len(idx):"},{"line_number":82,"context_line":"                    raise exception.NetworkInterfaceNotFound(interface\u003dlink)"},{"line_number":83,"context_line":"                args[\u0027link\u0027] \u003d idx[0]"},{"line_number":84,"context_line":"            elif self.TYPE_VETH \u003d\u003d dev_type:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dbd4daeb","line":81,"range":{"start_line":81,"start_character":15,"end_line":81,"end_character":33},"in_reply_to":"9f560f44_8ca07292","updated":"2020-08-05 09:07:44.000000000","message":"nit:\n\n if not len(idx):","commit_id":"37895572127539882a7bc94db92c3de9bfdb435c"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"b0c8638c063a118003a671163e5f69e96309d540","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                 if promisc is True else"},{"line_number":56,"context_line":"                                 utils.unset_mask(flags, ifinfmsg.IFF_PROMISC))"},{"line_number":57,"context_line":"            if master:"},{"line_number":58,"context_line":"                args[\u0027master\u0027] \u003d ip.link_lookup(ifname\u003dmaster)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            if isinstance(check_exit_code, int):"},{"line_number":61,"context_line":"                check_exit_code \u003d [check_exit_code]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_7e3e45c1","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":62},"updated":"2020-08-06 10:57:53.000000000","message":"Should this one also be wrapped, or is it OK? It\u0027s probably super unlikely to fail.","commit_id":"b9431538ab415c3ccdb4fa941aabb334353f0183"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"54a28ece1f2775a8b076bef3548c9c4e1bb97e05","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                                 if promisc is True else"},{"line_number":56,"context_line":"                                 utils.unset_mask(flags, ifinfmsg.IFF_PROMISC))"},{"line_number":57,"context_line":"            if master:"},{"line_number":58,"context_line":"                args[\u0027master\u0027] \u003d ip.link_lookup(ifname\u003dmaster)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            if isinstance(check_exit_code, int):"},{"line_number":61,"context_line":"                check_exit_code \u003d [check_exit_code]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_49cbcda3","line":58,"range":{"start_line":58,"start_character":33,"end_line":58,"end_character":62},"in_reply_to":"9f560f44_7e3e45c1","updated":"2020-08-06 12:22:40.000000000","message":"I missed this /o\\","commit_id":"b9431538ab415c3ccdb4fa941aabb334353f0183"}]}