)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"deprecate ovs-vsctl driver and make native the default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The native ovsdb backend was added in stien with the"},{"line_number":10,"context_line":"intent of makeing it the default in train and removing"},{"line_number":11,"context_line":"the vsctl backend in ussuri."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_671f7e09","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":43},"updated":"2020-08-31 10:24:15.000000000","message":"Stein","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":7,"context_line":"deprecate ovs-vsctl driver and make native the default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The native ovsdb backend was added in stien with the"},{"line_number":10,"context_line":"intent of makeing it the default in train and removing"},{"line_number":11,"context_line":"the vsctl backend in ussuri."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The default was never changed and the deprecation was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_471cfa12","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":17},"updated":"2020-08-31 10:24:15.000000000","message":"making","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"}],"releasenotes/notes/default-to-native-ovsdb-driver-112fb5adf6e19a30.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2073086c969bba5260f33e6f48ed2da7ed3bb281","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"deprecations:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    The ovs-vsctl ovsdb driver is now deprecated for removal."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_3b635644","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":10},"updated":"2020-08-05 09:14:22.000000000","message":"whoops","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2073086c969bba5260f33e6f48ed2da7ed3bb281","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"deprecations:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    The ovs-vsctl ovsdb driver is now deprecated for removal."},{"line_number":6,"context_line":"    The default ovsdb interface has now been updated to native."},{"line_number":7,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":8,"context_line":"    the ovs-vsctl cli. The native backend both out performs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_7b594e8c","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":17},"updated":"2020-08-05 09:14:22.000000000","message":"``ovs-vsctl``","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2073086c969bba5260f33e6f48ed2da7ed3bb281","unresolved":false,"context_lines":[{"line_number":3,"context_line":"deprecations:"},{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    The ovs-vsctl ovsdb driver is now deprecated for removal."},{"line_number":6,"context_line":"    The default ovsdb interface has now been updated to native."},{"line_number":7,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":8,"context_line":"    the ovs-vsctl cli. The native backend both out performs"},{"line_number":9,"context_line":"    the vsctl backend and require no elevated privileges to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_5b5e0a76","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":62},"updated":"2020-08-05 09:14:22.000000000","message":"``native`` ?","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2073086c969bba5260f33e6f48ed2da7ed3bb281","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  - |"},{"line_number":5,"context_line":"    The ovs-vsctl ovsdb driver is now deprecated for removal."},{"line_number":6,"context_line":"    The default ovsdb interface has now been updated to native."},{"line_number":7,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":8,"context_line":"    the ovs-vsctl cli. The native backend both out performs"},{"line_number":9,"context_line":"    the vsctl backend and require no elevated privileges to"},{"line_number":10,"context_line":"    configure the ovsdb. This both improves security and"},{"line_number":11,"context_line":"    reduces plug and unplug time."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_bb56465b","line":8,"range":{"start_line":7,"start_character":4,"end_line":8,"end_character":22},"updated":"2020-08-05 09:14:22.000000000","message":"The ``native`` driver uses the OVS Python bindings instead of invoking the ``ovs-vsctl`` CLI.","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2073086c969bba5260f33e6f48ed2da7ed3bb281","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f560f44_3bc87620","line":12,"updated":"2020-08-05 09:14:22.000000000","message":"I think you need an upgrade section to note that the default has changed too. You\u0027ve mentioned it in deprecations but this is a clear upgrade impact","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``ovs-vsctl`` ovsdb driver is now deprecated for removal."},{"line_number":5,"context_line":"    The default ovsdb interface has now been updated to ``native``."},{"line_number":6,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":7,"context_line":"    the ``ovs-vsctl`` cli. The ``native`` backend both out performs"},{"line_number":8,"context_line":"    the vsctl backend and require no elevated privileges to"},{"line_number":9,"context_line":"    configure the ovsdb. This both improves security and"},{"line_number":10,"context_line":"    reduces plug and unplug time."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_e7d0ae2e","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":25},"updated":"2020-08-31 10:24:15.000000000","message":"CLI","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``ovs-vsctl`` ovsdb driver is now deprecated for removal."},{"line_number":5,"context_line":"    The default ovsdb interface has now been updated to ``native``."},{"line_number":6,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":7,"context_line":"    the ``ovs-vsctl`` cli. The ``native`` backend both out performs"},{"line_number":8,"context_line":"    the vsctl backend and require no elevated privileges to"},{"line_number":9,"context_line":"    configure the ovsdb. This both improves security and"},{"line_number":10,"context_line":"    reduces plug and unplug time."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_67e49e0f","line":7,"range":{"start_line":7,"start_character":55,"end_line":7,"end_character":67},"updated":"2020-08-31 10:24:15.000000000","message":"outperforms","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The default ovsdb interface has now been updated to ``native``."},{"line_number":6,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":7,"context_line":"    the ``ovs-vsctl`` cli. The ``native`` backend both out performs"},{"line_number":8,"context_line":"    the vsctl backend and require no elevated privileges to"},{"line_number":9,"context_line":"    configure the ovsdb. This both improves security and"},{"line_number":10,"context_line":"    reduces plug and unplug time."},{"line_number":11,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_47e19afc","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":13},"updated":"2020-08-31 10:24:15.000000000","message":"``vsctl``","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    reduces plug and unplug time."},{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    os-vif now uses the ``native`` ovsdb driver instead of ``ovs-vsctl``"},{"line_number":14,"context_line":"    This reduces the number of privileged call that os-vif need to make"},{"line_number":15,"context_line":"    and generally improves plugging performance. In future release the"},{"line_number":16,"context_line":"    ``ovs-vsctl`` backend will be removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_a7eeb6ea","line":13,"range":{"start_line":13,"start_character":61,"end_line":13,"end_character":70},"updated":"2020-08-31 10:24:15.000000000","message":"vsctl","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6e110f3afbb1345dde21bba336358e8ee9aa1fec","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    reduces plug and unplug time."},{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    os-vif now uses the ``native`` ovsdb driver instead of ``ovs-vsctl``"},{"line_number":14,"context_line":"    This reduces the number of privileged call that os-vif need to make"},{"line_number":15,"context_line":"    and generally improves plugging performance. In future release the"},{"line_number":16,"context_line":"    ``ovs-vsctl`` backend will be removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_ee97d4ea","line":13,"range":{"start_line":13,"start_character":61,"end_line":13,"end_character":70},"in_reply_to":"9f560f44_a7eeb6ea","updated":"2020-09-01 13:26:56.000000000","message":"ah right the utility is ovs-vsctl but the config value is vsctl","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    os-vif now uses the ``native`` ovsdb driver instead of ``ovs-vsctl``"},{"line_number":14,"context_line":"    This reduces the number of privileged call that os-vif need to make"},{"line_number":15,"context_line":"    and generally improves plugging performance. In future release the"},{"line_number":16,"context_line":"    ``ovs-vsctl`` backend will be removed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_87ebb2da","line":16,"range":{"start_line":16,"start_character":6,"end_line":16,"end_character":15},"updated":"2020-08-31 10:24:15.000000000","message":"vsctl","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5abe6fefe684be39e8ade642226672133a720eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``vsctl`` ovsdb driver is now deprecated for removal."},{"line_number":5,"context_line":"    The default ovsdb interface has now been updated to ``native``."},{"line_number":6,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":7,"context_line":"    the ``ovs-vsctl`` cli. The ``native`` backend both out performs"},{"line_number":8,"context_line":"    the ``vsctl`` backend and require no elevated privileges to"},{"line_number":9,"context_line":"    configure the ovsdb. This both improves security and"},{"line_number":10,"context_line":"    reduces plug and unplug time."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_62e115fd","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":25},"updated":"2020-09-01 14:59:58.000000000","message":"CLI","commit_id":"155aff971489086cf771892231fa865b0d28040f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5abe6fefe684be39e8ade642226672133a720eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``vsctl`` ovsdb driver is now deprecated for removal."},{"line_number":5,"context_line":"    The default ovsdb interface has now been updated to ``native``."},{"line_number":6,"context_line":"    This will use the ovs python binding instead of invoking"},{"line_number":7,"context_line":"    the ``ovs-vsctl`` cli. The ``native`` backend both out performs"},{"line_number":8,"context_line":"    the ``vsctl`` backend and require no elevated privileges to"},{"line_number":9,"context_line":"    configure the ovsdb. This both improves security and"},{"line_number":10,"context_line":"    reduces plug and unplug time."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_42db314e","line":7,"range":{"start_line":7,"start_character":55,"end_line":7,"end_character":67},"updated":"2020-09-01 14:59:58.000000000","message":"outperforms","commit_id":"155aff971489086cf771892231fa865b0d28040f"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7e2940d4e795f8b7686eea05b21b0e1157a4319c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                   since stien (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\""},{"line_number":76,"context_line":"                   help\u003d\u0027The interface for interacting with the OVSDB\u0027),"},{"line_number":77,"context_line":"        # NOTE(sean-k-mooney): This value is a bool for two reasons."},{"line_number":78,"context_line":"        # First I want to allow this config option to be reusable with"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4f6f6cfb","line":75,"updated":"2020-08-05 10:45:43.000000000","message":"im missing a comma","commit_id":"6f514d7bef4dcb98df4b2937441dd47db8d09946"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"be896a0f22f3ea87752e529685b59643eff72048","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\""},{"line_number":76,"context_line":"                   help\u003d\u0027The interface for interacting with the OVSDB\u0027),"},{"line_number":77,"context_line":"        # NOTE(sean-k-mooney): This value is a bool for two reasons."},{"line_number":78,"context_line":"        # First I want to allow this config option to be reusable with"},{"line_number":79,"context_line":"        # non ml2/ovs deployment in the future if required, as such I do not"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0f1a94ca","line":76,"updated":"2020-08-05 02:07:09.000000000","message":"pep8: E999 SyntaxError: invalid syntax","commit_id":"6f514d7bef4dcb98df4b2937441dd47db8d09946"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2073086c969bba5260f33e6f48ed2da7ed3bb281","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since stien (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dbde9ad8","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":19},"updated":"2020-08-05 09:14:22.000000000","message":"I don\u0027t think we run this through textwrap.dedent, so this won\u0027t render correctly. You need to either dedent this yourself (like we do in much of nova) or wrap in single quotes","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7e2940d4e795f8b7686eea05b21b0e1157a4319c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since stien (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_5180ab46","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":19},"in_reply_to":"9f560f44_dbde9ad8","updated":"2020-08-05 10:45:43.000000000","message":"ah right ill just dedent this","commit_id":"48492cc81b475cca68b656c9e2b177949ae74478"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since stien (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_27b466f2","line":72,"range":{"start_line":72,"start_character":25,"end_line":72,"end_character":30},"updated":"2020-08-31 10:24:15.000000000","message":"Stein","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5abe6fefe684be39e8ade642226672133a720eb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since stein (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_82cd4988","line":72,"range":{"start_line":72,"start_character":25,"end_line":72,"end_character":30},"updated":"2020-09-01 14:59:58.000000000","message":"Stein (it\u0027s a proper noun so capitalize)","commit_id":"155aff971489086cf771892231fa865b0d28040f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"069b1f3d3b2e517bcdceb3ecae6af30dd0c55ec9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since stein (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4bd4e0e9","line":72,"range":{"start_line":72,"start_character":25,"end_line":72,"end_character":30},"in_reply_to":"9f560f44_825ee4e6","updated":"2020-09-02 08:30:58.000000000","message":"\u003e i always thought it was a beer glass but ok :P\n\nYou need to have kids to make that joke, dad.","commit_id":"155aff971489086cf771892231fa865b0d28040f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7f76758123a5c498d94457443431c20c9f153b5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since stein (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_825ee4e6","line":72,"range":{"start_line":72,"start_character":25,"end_line":72,"end_character":30},"in_reply_to":"9f560f44_82cd4988","updated":"2020-09-01 19:04:09.000000000","message":"i always thought it was a beer glass but ok :P\nfixed","commit_id":"155aff971489086cf771892231fa865b0d28040f"},{"author":{"_account_id":25733,"name":"Jan Gutter","email":"github@jangutter.com","username":"jangutter"},"change_message_id":"86e61c95b84ecf89f94c41c5a84422184ac27165","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   default\u003d\u0027native\u0027,"},{"line_number":68,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since Stein (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","},{"line_number":76,"context_line":"                   help\u003d\u0027The interface for interacting with the OVSDB\u0027),"},{"line_number":77,"context_line":"        # NOTE(sean-k-mooney): This value is a bool for two reasons."}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_be85f809","line":74,"range":{"start_line":70,"start_character":37,"end_line":74,"end_character":36},"updated":"2020-09-02 09:09:20.000000000","message":"For a potential follow-up (since it\u0027s already hit the gate): I think this was meant to be dedented or single quoted like the text strings above.","commit_id":"d7928102d69dadf653c9f734e5cf8fd504335849"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"84fbaa43d5d868c296ebf30447b565e4f8102498","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   default\u003d\u0027native\u0027,"},{"line_number":68,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since Stein (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","},{"line_number":76,"context_line":"                   help\u003d\u0027The interface for interacting with the OVSDB\u0027),"},{"line_number":77,"context_line":"        # NOTE(sean-k-mooney): This value is a bool for two reasons."}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1c386c39","line":74,"range":{"start_line":70,"start_character":37,"end_line":74,"end_character":36},"in_reply_to":"9f560f44_9e047480","updated":"2020-09-02 11:44:31.000000000","message":"oh ya ill fix that good spot","commit_id":"d7928102d69dadf653c9f734e5cf8fd504335849"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5d631454cb99b23e32622fa19bb74feee2f10b60","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   default\u003d\u0027native\u0027,"},{"line_number":68,"context_line":"                   deprecated_for_removal\u003dTrue,"},{"line_number":69,"context_line":"                   deprecated_since\u003d\u00272.2.0\u0027,"},{"line_number":70,"context_line":"                   deprecated_reason\u003d\"\"\""},{"line_number":71,"context_line":"                   os-vif has supported ovsdb access via python bindings"},{"line_number":72,"context_line":"                   since Stein (1.15.0), starting in Victoria (2.2.0) the"},{"line_number":73,"context_line":"                   ovs-vsctl driver is now deprecated for removal and"},{"line_number":74,"context_line":"                   in future releases it will be be removed."},{"line_number":75,"context_line":"                   \"\"\","},{"line_number":76,"context_line":"                   help\u003d\u0027The interface for interacting with the OVSDB\u0027),"},{"line_number":77,"context_line":"        # NOTE(sean-k-mooney): This value is a bool for two reasons."}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_9e047480","line":74,"range":{"start_line":70,"start_character":37,"end_line":74,"end_character":36},"in_reply_to":"9f560f44_be85f809","updated":"2020-09-02 09:13:01.000000000","message":"Yup, good point","commit_id":"d7928102d69dadf653c9f734e5cf8fd504335849"}],"vif_plug_ovs/ovsdb/ovsdb_lib.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08e5c49d74ebabc7f48e7f9eedcbd688e05be044","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def ovsdb(self):"},{"line_number":40,"context_line":"        if not self._ovsdb:"},{"line_number":41,"context_line":"            self._ovsdb \u003d ovsdb_api.get_instance(self)"},{"line_number":42,"context_line":"        return self._ovsdb"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _ovs_supports_mtu_requests(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_47ca3a6e","line":41,"updated":"2020-08-31 10:24:15.000000000","message":"Do we want to add error handling here now, since we won\u0027t see errors when doing the initial creation of the object?","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6e110f3afbb1345dde21bba336358e8ee9aa1fec","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    @property"},{"line_number":39,"context_line":"    def ovsdb(self):"},{"line_number":40,"context_line":"        if not self._ovsdb:"},{"line_number":41,"context_line":"            self._ovsdb \u003d ovsdb_api.get_instance(self)"},{"line_number":42,"context_line":"        return self._ovsdb"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _ovs_supports_mtu_requests(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_2481ed4b","line":41,"in_reply_to":"9f560f44_47ca3a6e","updated":"2020-09-01 13:26:56.000000000","message":"in the past we had no error handeling and the error would just cause the nova-compute agaent to hard stop.\n\ni could log a warning and call exit() to get the same effect i guess but i dont think we really want to do that.\nnova if i recall correctly catches the os-vif excetptions so i could just catch all excptions log them and rethrow a generic os-vif exception i guess. but im not sure that is needed.","commit_id":"d718707ae801b967e8d9ac48eab7f7854574ead9"}]}