)]}'
{"vif_plug_noop/noop.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cf372893fa146736b4bb8d2beb6eeb4021f4f16e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    supported_port_profiles\u003d[])"},{"line_number":41,"context_line":"            ])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def plug("},{"line_number":44,"context_line":"        self,"},{"line_number":45,"context_line":"        vif: objects.vif.VIFBase,"},{"line_number":46,"context_line":"        instance_info: objects.instance_info.InstanceInfo,"},{"line_number":47,"context_line":"    ) -\u003e None:"},{"line_number":48,"context_line":"        pass"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def unplug("},{"line_number":51,"context_line":"        self,"},{"line_number":52,"context_line":"        vif: objects.vif.VIFBase,"},{"line_number":53,"context_line":"        instance_info: objects.instance_info.InstanceInfo,"},{"line_number":54,"context_line":"    ) -\u003e None:"},{"line_number":55,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_cc30d80a","line":55,"range":{"start_line":43,"start_character":1,"end_line":55,"end_character":12},"updated":"2020-08-20 00:05:57.000000000","message":"i still hate this but fine we can argue over styleing later\ni would like to incude this before the 26th\n\nso for now ill pretend this is on still on one line","commit_id":"27deee88ed2f887b42e321bd26aa3db5351ea45c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fb0efbc10b6ac59f1b0e4b3ae8d884336dd0591e","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from os_vif import objects"},{"line_number":20,"context_line":"from os_vif import plugin"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class NoOpPlugin(plugin.PluginBase):"},{"line_number":24,"context_line":"    \"\"\"A no-op plugin."}],"source_content_type":"text/x-python","patch_set":5,"id":"38b6a58c_b15e8738","line":21,"updated":"2020-12-09 08:28:41.000000000","message":"from os_vif.objects import host_info","commit_id":"37a2cd3fbeb8407d48c034cfde4ae2dc4453d0a0"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fb0efbc10b6ac59f1b0e4b3ae8d884336dd0591e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    generic vhost user without OVS."},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def describe(self) -\u003e objects.host_info.HostPluginInfo:"},{"line_number":33,"context_line":"        return objects.host_info.HostPluginInfo("},{"line_number":34,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":35,"context_line":"            vif_info\u003d["}],"source_content_type":"text/x-python","patch_set":5,"id":"f0d039b5_5a67e5b1","line":32,"range":{"start_line":32,"start_character":26,"end_line":32,"end_character":43},"updated":"2020-12-09 08:28:41.000000000","message":"then use the shorter name: host_info.HostPluginInfo","commit_id":"37a2cd3fbeb8407d48c034cfde4ae2dc4453d0a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31433ea70b0338c0d442b4c97ac1d1d90b0338a8","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def describe(self) -\u003e objects.host_info.HostPluginInfo:"},{"line_number":33,"context_line":"        return objects.host_info.HostPluginInfo("},{"line_number":34,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":35,"context_line":"            vif_info\u003d["},{"line_number":36,"context_line":"                objects.host_info.HostVIFInfo("}],"source_content_type":"text/x-python","patch_set":5,"id":"214b0ac4_8993cdae","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":47},"updated":"2020-12-09 12:46:56.000000000","message":"i think both are fine but if you do refactor then we would want to be consistant and convert this too","commit_id":"37a2cd3fbeb8407d48c034cfde4ae2dc4453d0a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31433ea70b0338c0d442b4c97ac1d1d90b0338a8","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        return objects.host_info.HostPluginInfo("},{"line_number":34,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":35,"context_line":"            vif_info\u003d["},{"line_number":36,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":37,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":38,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":39,"context_line":"                    max_version\u003d\"1.0\","}],"source_content_type":"text/x-python","patch_set":5,"id":"654e558d_6e888335","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":45},"updated":"2020-12-09 12:46:56.000000000","message":"and this","commit_id":"37a2cd3fbeb8407d48c034cfde4ae2dc4453d0a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31433ea70b0338c0d442b4c97ac1d1d90b0338a8","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            plugin_name\u003d\"noop\","},{"line_number":35,"context_line":"            vif_info\u003d["},{"line_number":36,"context_line":"                objects.host_info.HostVIFInfo("},{"line_number":37,"context_line":"                    vif_object_name\u003dobjects.vif.VIFVHostUser.__name__,"},{"line_number":38,"context_line":"                    min_version\u003d\"1.0\","},{"line_number":39,"context_line":"                    max_version\u003d\"1.0\","},{"line_number":40,"context_line":"                    supported_port_profiles\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"649293e2_869a9e0e","line":37,"range":{"start_line":37,"start_character":36,"end_line":37,"end_character":59},"updated":"2020-12-09 12:46:56.000000000","message":"and this i think you get the point.\nim fine with either importing the sub modules or leaving it as it is.\nthe current patch is at least consistent with the rest of the file.","commit_id":"37a2cd3fbeb8407d48c034cfde4ae2dc4453d0a0"}]}