)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"587be884f75823f4e2c743135a44b8d7e93e7d4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the new name recommended by the base zuul jobs [1]:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Path to a pip constraints file. Will be provided to tox via"},{"line_number":12,"context_line":"  ``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported"},{"line_number":13,"context_line":"  name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"While we\u0027re here, we remove a wholly unnecessary layer of environment"},{"line_number":16,"context_line":"variable-based indirection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_e26789b7","line":13,"range":{"start_line":11,"start_character":1,"end_line":13,"end_character":72},"updated":"2020-10-08 12:11:15.000000000","message":"when was this deprecated and or comunitcated to project?","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5e13023f0f9b928a70d85098b82f2c92485d4d41","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the new name recommended by the base zuul jobs [1]:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Path to a pip constraints file. Will be provided to tox via"},{"line_number":12,"context_line":"  ``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported"},{"line_number":13,"context_line":"  name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"While we\u0027re here, we remove a wholly unnecessary layer of environment"},{"line_number":16,"context_line":"variable-based indirection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_45b62d8b","line":13,"range":{"start_line":11,"start_character":1,"end_line":13,"end_character":72},"in_reply_to":"9f560f44_1103e5bf","updated":"2020-10-09 10:10:34.000000000","message":"right but that woudl be a terrible ux which is why we have it. also its one of the env we expect peopel to run before pushing patches so i would not be in favor of removing it as a separate target.","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d6bd20eae5ed2419d3502fa0a2e7b9adf5de2cb7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the new name recommended by the base zuul jobs [1]:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Path to a pip constraints file. Will be provided to tox via"},{"line_number":12,"context_line":"  ``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported"},{"line_number":13,"context_line":"  name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"While we\u0027re here, we remove a wholly unnecessary layer of environment"},{"line_number":16,"context_line":"variable-based indirection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_e5bf93a8","line":13,"range":{"start_line":11,"start_character":1,"end_line":13,"end_character":72},"in_reply_to":"9f560f44_e26789b7","updated":"2020-10-08 13:22:20.000000000","message":"It was a year ago - https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file\n\nBasically, that is done to have common name for constraint which can be used for lower-constraints env also where\nUPPER_CONSTRAINTS_FILE name looks weird to pass the lower constraints so renaming to TOX_CONSTRAINTS_FILE,","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cd5c767a80527acbb04602f4b31950e038044a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the new name recommended by the base zuul jobs [1]:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Path to a pip constraints file. Will be provided to tox via"},{"line_number":12,"context_line":"  ``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported"},{"line_number":13,"context_line":"  name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"While we\u0027re here, we remove a wholly unnecessary layer of environment"},{"line_number":16,"context_line":"variable-based indirection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_f864564b","line":13,"range":{"start_line":11,"start_character":1,"end_line":13,"end_character":72},"in_reply_to":"9f560f44_e5bf93a8","updated":"2020-10-08 14:25:54.000000000","message":"we do not pass UPPER_CONSTRAINTS_FILE to lower constrants and never have\n\nhttps://github.com/openstack/os-vif/commit/96b5a11d35d74faf7c9866dceef66984dbcddae6#\n\nim not sure what the usecase is for TOX_CONSTRAINTS_FILE in the lower_constratits env given that is ment to use the in tree file. using it there would generally be incorrect.","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7420aadfcc368151ce05c3eede6c9ccc77a1b6dd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the new name recommended by the base zuul jobs [1]:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Path to a pip constraints file. Will be provided to tox via"},{"line_number":12,"context_line":"  ``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported"},{"line_number":13,"context_line":"  name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"While we\u0027re here, we remove a wholly unnecessary layer of environment"},{"line_number":16,"context_line":"variable-based indirection."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_1103e5bf","line":13,"range":{"start_line":11,"start_character":1,"end_line":13,"end_character":72},"in_reply_to":"9f560f44_f864564b","updated":"2020-10-08 15:36:39.000000000","message":"\u003e we do not pass UPPER_CONSTRAINTS_FILE to lower constrants and never\n \u003e have\n\nJust because we have doesn\u0027t mean others haven\u0027t.\n\n \u003e https://github.com/openstack/os-vif/commit/96b5a11d35d74faf7c9866dceef66984dbcddae6#\n \u003e \n \u003e im not sure what the usecase is for TOX_CONSTRAINTS_FILE in the\n \u003e lower_constratits env given that is ment to use the in tree file.\n \u003e using it there would generally be incorrect.\n\nWell you don\u0027t actually need a lower-constraints target if you simply override this variable in a job. That\u0027s what gmann is saying.\n\n  # with upper constraints\n  tox -e py36\n\n  # with lower constraints\n  TOX_CONSTRAINTS_FILE\u003dlower-constraints.txt tox -e py36","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"587be884f75823f4e2c743135a44b8d7e93e7d4d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  ``TOX_CONSTRAINTS_FILE`` (deprecated but currently still supported"},{"line_number":13,"context_line":"  name is ``UPPER_CONSTRAINTS_FILE``) environment variable if it exists."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"While we\u0027re here, we remove a wholly unnecessary layer of environment"},{"line_number":16,"context_line":"variable-based indirection."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://opendev.org/zuul/zuul-jobs/raw/branch/master/roles/tox/README.rst"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_425915fb","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":27},"updated":"2020-10-08 12:11:15.000000000","message":"i did that intentionally","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"587be884f75823f4e2c743135a44b8d7e93e7d4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"basepython \u003d python3"},{"line_number":9,"context_line":"usedevelop \u003d True"},{"line_number":10,"context_line":"setenv \u003d"},{"line_number":11,"context_line":"  CONSTRAINTS_OPT\u003d-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":12,"context_line":"deps \u003d"},{"line_number":13,"context_line":"  {env:CONSTRAINTS_OPT}"},{"line_number":14,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_c24b6525","side":"PARENT","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":104},"updated":"2020-10-08 12:11:15.000000000","message":"sigh... i did it this way intentionally as i wanted to have it in the file once and only once so you are regressing that.\n\nthis will also regress anyone that used the old name.","commit_id":"cc15462308e544981be58c4552a2593f5eb27b9c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8cd5c767a80527acbb04602f4b31950e038044a4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"basepython \u003d python3"},{"line_number":9,"context_line":"usedevelop \u003d True"},{"line_number":10,"context_line":"setenv \u003d"},{"line_number":11,"context_line":"  CONSTRAINTS_OPT\u003d-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":12,"context_line":"deps \u003d"},{"line_number":13,"context_line":"  {env:CONSTRAINTS_OPT}"},{"line_number":14,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_f89736ea","side":"PARENT","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":104},"in_reply_to":"9f560f44_222ce148","updated":"2020-10-08 14:25:54.000000000","message":"if we keep this we migth be able to do this\n\n\nUPPER_CONSTRAINTS_FILE\u003d-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}\nCONSTRAINTS_OPT\u003d-c{env:TOX_CONSTRAINTS_FILE:evn:UPPER_CONSTRAINTS_FILE}\n\nim not sure if that is valid syntax but basicaly hav it use TOX_CONSTRAINTS_FILE if its set in the env else use UPPER_CONSTRAINTS_FILE from the env if set which would defualt to https://releases.openstack.org/constraints/upper/master\n\ni think the syntax is wrong but that would be what we would want in terms of precendence.","commit_id":"cc15462308e544981be58c4552a2593f5eb27b9c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b29c1b2bb01dd02a22ffdfa34cf932b4e99e532e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"basepython \u003d python3"},{"line_number":9,"context_line":"usedevelop \u003d True"},{"line_number":10,"context_line":"setenv \u003d"},{"line_number":11,"context_line":"  CONSTRAINTS_OPT\u003d-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":12,"context_line":"deps \u003d"},{"line_number":13,"context_line":"  {env:CONSTRAINTS_OPT}"},{"line_number":14,"context_line":"  -r{toxinidir}/requirements.txt"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_222ce148","side":"PARENT","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":104},"in_reply_to":"9f560f44_c24b6525","updated":"2020-10-08 12:15:08.000000000","message":"Yeah, we somehow need a way to deprecate this as least for one cycle.","commit_id":"cc15462308e544981be58c4552a2593f5eb27b9c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b29c1b2bb01dd02a22ffdfa34cf932b4e99e532e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"usedevelop \u003d True"},{"line_number":10,"context_line":"setenv \u003d"},{"line_number":11,"context_line":"deps \u003d"},{"line_number":12,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":13,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":14,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":15,"context_line":"commands \u003d stestr run --black-regex \".tests.functional\" {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_62d7f923","line":12,"updated":"2020-10-08 12:15:08.000000000","message":"You need to support the env name UPPER_CONSTRAINTS_FILE and just tell it\u0027s deprecate, please.","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bcbb3eb100ffb5ee1c16446df3d75acee9d7630b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"usedevelop \u003d True"},{"line_number":10,"context_line":"setenv \u003d"},{"line_number":11,"context_line":"deps \u003d"},{"line_number":12,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":13,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":14,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":15,"context_line":"commands \u003d stestr run --black-regex \".tests.functional\" {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_d1b20d4a","line":12,"in_reply_to":"9f560f44_62d7f923","updated":"2020-10-08 15:26:29.000000000","message":"\u003e You need to support the env name UPPER_CONSTRAINTS_FILE and just\n \u003e tell it\u0027s deprecate, please.\n\nNo we don\u0027t. tox is a developer tool, not a API consumed by people that we must support. zuul can support both and prefers this style. nova uses it [1]. The bot jobs have been updating stable/* branches of _this repo_ and every other one to uses this for...three (?) cycles now [2].\n\n[1] https://github.com/openstack/nova/blob/2745e685376abbc4c32516837f6074a3de23aa24/tox.ini#L29\n[2] https://review.opendev.org/#/c/750925/","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d6bd20eae5ed2419d3502fa0a2e7b9adf5de2cb7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"usedevelop \u003d True"},{"line_number":10,"context_line":"setenv \u003d"},{"line_number":11,"context_line":"deps \u003d"},{"line_number":12,"context_line":"  -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}"},{"line_number":13,"context_line":"  -r{toxinidir}/requirements.txt"},{"line_number":14,"context_line":"  -r{toxinidir}/test-requirements.txt"},{"line_number":15,"context_line":"commands \u003d stestr run --black-regex \".tests.functional\" {posargs}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9f560f44_25122bb5","line":12,"in_reply_to":"9f560f44_62d7f923","updated":"2020-10-08 13:22:20.000000000","message":"I do not this there is a way to add a deprecation warning here only thing we can do is add a comment for local env to switch to new name but that just comments not deprecation way where a local users of old env var can get a notification. That is why I am ok to do it directly too.\n\nIt is done in the same way for most of the projects in ussuri cycle branch cut https://review.opendev.org/#/c/722520/","commit_id":"4e6c16037c1139e189d2ec7b6a90b43c3b10b16b"}]}