)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"104ceaff923472f536e8636e5ef4c81a7330a889","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Creating oslo.config.opts entry_points for plugins"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To assist with automated configuration validation, we need entry points"},{"line_number":10,"context_line":"for oslo.config.opts for each one of the plugins."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7fc132f917949d147dd6371d54e01a6cfd995aae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa33495_81f668d5","line":10,"updated":"2021-05-05 10:55:00.000000000","message":"that would technically inlcud the noop plugin which you did not include","commit_id":"34f33ca7d49c9b2a844a444f762c65670a9a696f"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"d191bb93ac4a85b2783314e476157808d047364b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Creating oslo.config.opts entry_points for plugins"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To assist with automated configuration validation, we need entry points"},{"line_number":10,"context_line":"for oslo.config.opts for each one of the plugins."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7fc132f917949d147dd6371d54e01a6cfd995aae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"028d7732_91b2b3ab","line":10,"in_reply_to":"baa33495_81f668d5","updated":"2021-05-06 02:45:41.000000000","message":"I should probably have mentioned for each plugins with options, but with your patch, this is now accurate, thanks.","commit_id":"34f33ca7d49c9b2a844a444f762c65670a9a696f"}],"os_vif/opts.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"104ceaff923472f536e8636e5ef4c81a7330a889","unresolved":true,"context_lines":[{"line_number":17,"context_line":"]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from copy import deepcopy"},{"line_number":20,"context_line":"import vif_plug_linux_bridge.linux_bridge"},{"line_number":21,"context_line":"import vif_plug_ovs.ovs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"plugins_list \u003d ["},{"line_number":24,"context_line":"    (\u0027ovs\u0027, vif_plug_ovs.ovs.OvsPlugin),"},{"line_number":25,"context_line":"    (\u0027linux_bridge\u0027, vif_plug_linux_bridge.linux_bridge.LinuxBridgePlugin)"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def list_plugins_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bed40251_22c4d788","line":26,"range":{"start_line":20,"start_character":1,"end_line":26,"end_character":1},"updated":"2021-05-05 10:55:00.000000000","message":"we should do this dynamically\nby first initalising the lib \nhttps://github.com/openstack/os-vif/blob/master/os_vif/__init__.py#L24\n\n\nimport os_vif\nos_vif.initialize()\n_EXT_MANAGER \u003d os_vif._EXT_MANAGER\nplugins_list \u003d [\n    (name, _EXT_MANAGER[name].obj)\n    for name in sorted(_EXT_MANAGER.names())\n]\n\n\nthis will also find any out of tree plugins which is what we want.","commit_id":"34f33ca7d49c9b2a844a444f762c65670a9a696f"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"d191bb93ac4a85b2783314e476157808d047364b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"]"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from copy import deepcopy"},{"line_number":20,"context_line":"import vif_plug_linux_bridge.linux_bridge"},{"line_number":21,"context_line":"import vif_plug_ovs.ovs"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"plugins_list \u003d ["},{"line_number":24,"context_line":"    (\u0027ovs\u0027, vif_plug_ovs.ovs.OvsPlugin),"},{"line_number":25,"context_line":"    (\u0027linux_bridge\u0027, vif_plug_linux_bridge.linux_bridge.LinuxBridgePlugin)"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def list_plugins_opts():"}],"source_content_type":"text/x-python","patch_set":1,"id":"d61c683d_4a1529c0","line":26,"range":{"start_line":20,"start_character":1,"end_line":26,"end_character":1},"in_reply_to":"bed40251_22c4d788","updated":"2021-05-06 02:45:41.000000000","message":"That actually works pretty well and is a lot better. Thanks.","commit_id":"34f33ca7d49c9b2a844a444f762c65670a9a696f"}],"os_vif/tests/unit/test_os_vif.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef58f7259f5498f85d0727ff3910a52c3e4cbb72","unresolved":true,"context_lines":[{"line_number":177,"context_line":"        for group in list_opts:"},{"line_number":178,"context_line":"            for opt in group[1]:"},{"line_number":179,"context_line":"                self.assertTrue(\"oslo_config.cfg\" \u003d\u003d opt.__module__)"},{"line_number":180,"context_line":"        self.assertEqual(len(list_opts), 3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d611f6ee_a5b82655","line":180,"range":{"start_line":180,"start_character":13,"end_line":180,"end_character":24},"updated":"2021-05-10 19:16:39.000000000","message":"assertGreaterEqual \nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertGreaterEqual\n\nif the system has other plugsin installed we still want the unit tests to pass.","commit_id":"2457531285077d94212dc305898ca71c86915c56"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"caa99e45ac7384a23cc75cbe7f871023ae14ac71","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        for group in list_opts:"},{"line_number":178,"context_line":"            for opt in group[1]:"},{"line_number":179,"context_line":"                self.assertTrue(\"oslo_config.cfg\" \u003d\u003d opt.__module__)"},{"line_number":180,"context_line":"        self.assertEqual(len(list_opts), 3)"}],"source_content_type":"text/x-python","patch_set":4,"id":"227ca789_8b383a6d","line":180,"range":{"start_line":180,"start_character":13,"end_line":180,"end_character":24},"in_reply_to":"d611f6ee_a5b82655","updated":"2021-05-11 09:59:41.000000000","message":"My bad, I thought I read it must be exactly 3, apparently my eyes skipped the \"not\". I\u0027ll fix this.","commit_id":"2457531285077d94212dc305898ca71c86915c56"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef58f7259f5498f85d0727ff3910a52c3e4cbb72","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":72,"context_line":"  coverage report"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[testenv:config]"},{"line_number":75,"context_line":"whitelist_externals \u003d"},{"line_number":76,"context_line":"  sed"},{"line_number":77,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"04cd06e7_de30aaf6","line":74,"updated":"2021-05-10 19:16:39.000000000","message":"i need to read this when im not tired but it does not clean up generated.conf\n\nwe might want to leave this change to a different patch or think about a better way to do this then python -c\n\ni think the unit test is enough for now.","commit_id":"c9e8de97bd8dc7200c4fba76f4f9102c58d8c0ac"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"caa99e45ac7384a23cc75cbe7f871023ae14ac71","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":72,"context_line":"  coverage report"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[testenv:config]"},{"line_number":75,"context_line":"whitelist_externals \u003d"},{"line_number":76,"context_line":"  sed"},{"line_number":77,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"c8615afa_e2c2bc25","line":74,"in_reply_to":"04cd06e7_de30aaf6","updated":"2021-05-11 09:59:41.000000000","message":"Yeah, I knew that python -c thing wouldn\u0027t fly very high, it\u0027s a bit too hacky.\n\nSo basically we generate a default config, uncomment all the default settings by leaving the comments in, and validate the generated config. Let\u0027s take this offline, I\u0027ll drop this for now.","commit_id":"c9e8de97bd8dc7200c4fba76f4f9102c58d8c0ac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"15a024e9759429e049e3aa6d689de8c57f59cde8","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  coverage xml -o cover/coverage.xml"},{"line_number":72,"context_line":"  coverage report"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[testenv:config]"},{"line_number":75,"context_line":"whitelist_externals \u003d"},{"line_number":76,"context_line":"  sed"},{"line_number":77,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"7fadfbce_8f475360","line":74,"in_reply_to":"c8615afa_e2c2bc25","updated":"2021-05-11 10:04:34.000000000","message":"yeah im not nessisarly agaisnt using python -c but if we do i think i would prefer it to be in a helper script that we invoke rather then inline.\n\ndroping this for now is fine ans we can think about it later","commit_id":"c9e8de97bd8dc7200c4fba76f4f9102c58d8c0ac"}]}