)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4cfde76b9cd1e13155d0b03ef58b14003a78fa02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"161edc50_2515d648","updated":"2022-05-22 13:57:40.000000000","message":"\u003e Patch Set 3: Code-Review-1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e i have mixed emotions about this if this is being done as part of a cross project effort then maybe but there is no technical requirement to do this min bump so i\u0027m conflicted about requiring a new version of tox for this.\n\u003e \n\u003e in general i think this sets a bad precedent of bumping min version for non technical reasons.\n\u003e \n\u003e -1 until i get other to review this and weigh in on if this is a suffent reason to bump the min tox version\n\nThey deprecated the old whitelist_externals option. Although the change is not quite \"technical\", unfortunately we have no other options than replacing usage of the deprecated option. The current usage would be broken without this, when they remove the deprecated option.","commit_id":"95fbe6abc827404feff5109b4cc72ec723f121a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f6a44ebe6cfae808455f53fee1d973028dacb5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"18b83851_8b841343","updated":"2022-05-30 16:03:51.000000000","message":"recheck old build results","commit_id":"95fbe6abc827404feff5109b4cc72ec723f121a3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ee0bcc6aa149cd8335cebb6dd9638d3fb1d7f7a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0629ac10_0ddddd83","updated":"2022-05-30 17:54:55.000000000","message":"recheck unrelated volume detach failrues.\n\n+2+w because the tox jobs passed which is all this change is affecting","commit_id":"95fbe6abc827404feff5109b4cc72ec723f121a3"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52d4ce11da89d94481d910a2380c30b46fb32d13","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,docs,releasenotes,cover,lower-constraints"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":3,"id":"bdbcf0e9_a0166be2","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":4},"updated":"2021-05-18 15:50:19.000000000","message":"ubuntu 20.04 only has 3.13.2\nhttps://packages.ubuntu.com/source/focal/tox\n\ncentos 8 uses 3.4.0\n\nhttps://centos.pkgs.org/8/epel-x86_64/python3-tox-3.4.0-2.el8.noarch.rpm.html\n\nso this would make it soe we cant use system provide tox on either ubuntu 20.04 or centos 8.","commit_id":"97531c05143e3774bf1f3775cc0008b340659725"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"223fc70d872d6f85d9c100b0cdec5a4f959c8584","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,docs,releasenotes,cover,lower-constraints"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":3,"id":"cefbe810_e1df6667","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":4},"in_reply_to":"bdbcf0e9_a0166be2","updated":"2021-07-01 13:36:42.000000000","message":"Hmm that\u0027s a fair point. Perhaps we should wait until Ubuntu 22.04 and CentOS Stream 9 are a thing before making this change? I\u0027m unaffected on Fedora (currently on 3.23.0 on Fedora 33) but not everyone uses that.","commit_id":"97531c05143e3774bf1f3775cc0008b340659725"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f6a44ebe6cfae808455f53fee1d973028dacb5b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.18.0"},{"line_number":3,"context_line":"envlist \u003d py3,pep8,docs,releasenotes,cover,lower-constraints"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":"ignore_basepython_conflict \u003d True"}],"source_content_type":"text/x-properties","patch_set":3,"id":"db4ea96c_e33bcd5b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":4},"in_reply_to":"cefbe810_e1df6667","updated":"2022-05-30 16:03:51.000000000","message":"ubuntu 22.04 is out an dso is 9 stream so we likely can proceed with this now wihout breaking people im going to recheck this to ensure it is still valid and ill upgrade to +w it that now passes.\n\n\nhttps://packages.ubuntu.com/source/jammy/tox  3.21.4\nand  centos nolonger ships tox.\nhttps://gitlab.com/redhat/centos-stream/rpms/python-tox/-/blob/main/dead.package.c9s","commit_id":"97531c05143e3774bf1f3775cc0008b340659725"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c5e557a0fdf1154d6271970cc09e8d8e0fa58e3","unresolved":true,"context_lines":[{"line_number":30,"context_line":"[testenv:pdf-docs]"},{"line_number":31,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":32,"context_line":"deps \u003d {[testenv:docs]deps}"},{"line_number":33,"context_line":"allowlist_externals \u003d"},{"line_number":34,"context_line":"  rm"},{"line_number":35,"context_line":"  make"},{"line_number":36,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"194389b7_167a0076","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":19},"updated":"2021-05-18 15:23:55.000000000","message":"i wish they had gone with just externals or allowed_externals as allowlist_externals is just really quite irritating as a native English speaker but i guess that is out of our contol","commit_id":"97531c05143e3774bf1f3775cc0008b340659725"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"223fc70d872d6f85d9c100b0cdec5a4f959c8584","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[testenv:pdf-docs]"},{"line_number":31,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":32,"context_line":"deps \u003d {[testenv:docs]deps}"},{"line_number":33,"context_line":"allowlist_externals \u003d"},{"line_number":34,"context_line":"  rm"},{"line_number":35,"context_line":"  make"},{"line_number":36,"context_line":"commands \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"346756cd_8741afa8","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":19},"in_reply_to":"194389b7_167a0076","updated":"2021-07-01 13:36:42.000000000","message":"This is unfortunately out of our hands, yes","commit_id":"97531c05143e3774bf1f3775cc0008b340659725"}]}