)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04ea16e3826f74603f30f5df96b05c69fc2ad8d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"343df108_8f7f350b","updated":"2022-03-25 11:40:09.000000000","message":"i was going to ask you to extend the funcitonal test to cover this but i realise form a blackbox\nfucntional perspective you will not be able to tell if the bridge is created atomically or not so i think the unit test coverage is sufficent.","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4728fcf9fd680b54c9305fe13aa0dba68c507f14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c6f9637_254991bc","updated":"2022-02-21 15:05:09.000000000","message":"recheck\nThanks ","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7b6e3d0b06db8a648387cd26fb2b20c81bcfe9ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"682d6939_7cb7c39e","updated":"2022-02-21 13:58:56.000000000","message":"recheck the linux bridge failure is unlikely to be related as it related to port attach and is also on affected by this change","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f88e3fdd434b774e44814d18e15a0042dee2143","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        vif_name \u003d OvsPlugin.gen_port_name("},{"line_number":200,"context_line":"            constants.OVS_VHOSTUSER_PREFIX, vif.id)"},{"line_number":201,"context_line":"        args \u003d {}"},{"line_number":202,"context_line":"        args[\u0027datapath_type\u0027] \u003d self._get_vif_datapath_type(vif,"},{"line_number":203,"context_line":"                datapath\u003dconstants.OVS_DATAPATH_NETDEV)"},{"line_number":204,"context_line":"        if vif.mode \u003d\u003d \"client\":"},{"line_number":205,"context_line":"            args[\u0027interface_type\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"863cdfc4_b727387d","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":30},"updated":"2022-02-21 14:16:24.000000000","message":"If we are in \"_plug_vhostuser\", this must be always OVS_DATAPATH_NETDEV","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f8d554e597ebf19dd7c4eee48b4091a8c1022fd7","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        vif_name \u003d OvsPlugin.gen_port_name("},{"line_number":200,"context_line":"            constants.OVS_VHOSTUSER_PREFIX, vif.id)"},{"line_number":201,"context_line":"        args \u003d {}"},{"line_number":202,"context_line":"        args[\u0027datapath_type\u0027] \u003d self._get_vif_datapath_type(vif,"},{"line_number":203,"context_line":"                datapath\u003dconstants.OVS_DATAPATH_NETDEV)"},{"line_number":204,"context_line":"        if vif.mode \u003d\u003d \"client\":"},{"line_number":205,"context_line":"            args[\u0027interface_type\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"29bf8ad9_9b5833c5","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":30},"in_reply_to":"39691a0f_a9d9b4a6","updated":"2022-04-01 14:35:11.000000000","message":"Understood","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04ea16e3826f74603f30f5df96b05c69fc2ad8d9","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        vif_name \u003d OvsPlugin.gen_port_name("},{"line_number":200,"context_line":"            constants.OVS_VHOSTUSER_PREFIX, vif.id)"},{"line_number":201,"context_line":"        args \u003d {}"},{"line_number":202,"context_line":"        args[\u0027datapath_type\u0027] \u003d self._get_vif_datapath_type(vif,"},{"line_number":203,"context_line":"                datapath\u003dconstants.OVS_DATAPATH_NETDEV)"},{"line_number":204,"context_line":"        if vif.mode \u003d\u003d \"client\":"},{"line_number":205,"context_line":"            args[\u0027interface_type\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"39691a0f_a9d9b4a6","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":30},"in_reply_to":"863cdfc4_b727387d","updated":"2022-03-25 11:40:09.000000000","message":"for ovs yes. for vpp or vrouter im not sure.\ngiven they have there own plugins however we are porbaly ok to hard code this.\nin general we shoudl look this up but i dont relaly mind either way.","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"}],"vif_plug_ovs/ovsdb/ovsdb_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f88e3fdd434b774e44814d18e15a0042dee2143","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            col_values.append((\u0027options\u0027,"},{"line_number":179,"context_line":"                              {\u0027dpdk-devargs\u0027: devargs_string}))"},{"line_number":180,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":181,"context_line":"            if datapath_type:"},{"line_number":182,"context_line":"                txn.add(self.ovsdb.add_br(bridge, may_exist\u003dTrue,"},{"line_number":183,"context_line":"                                          datapath_type\u003ddatapath_type))"},{"line_number":184,"context_line":"            txn.add(self.ovsdb.add_port(bridge, dev))"},{"line_number":185,"context_line":"            if tag:"},{"line_number":186,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Port\u0027, dev, (\u0027tag\u0027, tag)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"70588e19_105557f7","line":183,"range":{"start_line":181,"start_character":12,"end_line":183,"end_character":71},"updated":"2022-02-21 14:16:24.000000000","message":"+1 !!","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04ea16e3826f74603f30f5df96b05c69fc2ad8d9","unresolved":true,"context_lines":[{"line_number":178,"context_line":"            col_values.append((\u0027options\u0027,"},{"line_number":179,"context_line":"                              {\u0027dpdk-devargs\u0027: devargs_string}))"},{"line_number":180,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":181,"context_line":"            if datapath_type:"},{"line_number":182,"context_line":"                txn.add(self.ovsdb.add_br(bridge, may_exist\u003dTrue,"},{"line_number":183,"context_line":"                                          datapath_type\u003ddatapath_type))"},{"line_number":184,"context_line":"            txn.add(self.ovsdb.add_port(bridge, dev))"},{"line_number":185,"context_line":"            if tag:"},{"line_number":186,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Port\u0027, dev, (\u0027tag\u0027, tag)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d036822_116782d8","line":183,"range":{"start_line":181,"start_character":12,"end_line":183,"end_character":71},"in_reply_to":"70588e19_105557f7","updated":"2022-03-25 11:40:09.000000000","message":"+1","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"04ea16e3826f74603f30f5df96b05c69fc2ad8d9","unresolved":true,"context_lines":[{"line_number":186,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Port\u0027, dev, (\u0027tag\u0027, tag)))"},{"line_number":187,"context_line":"            if col_values:"},{"line_number":188,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, *col_values))"},{"line_number":189,"context_line":"        self.update_device_mtu(dev, mtu, interface_type\u003dinterface_type)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def update_ovs_vif_port(self, dev, mtu\u003dNone, interface_type\u003dNone):"},{"line_number":192,"context_line":"        self.update_device_mtu(dev, mtu, interface_type\u003dinterface_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7842466_ddd9191e","line":189,"range":{"start_line":189,"start_character":8,"end_line":189,"end_character":71},"updated":"2022-03-25 11:40:09.000000000","message":"while your here we have a related dpdk bug where the mtu should be also set in the same tansaction to avoid allocating the port form the default mem pool then moving it to the jumboframe mem pool if you are using jumboframes with dpdk https://bugs.launchpad.net/os-vif/+bug/1959586\n\nif you feel like fixing that too or proably more correctly adding a follow up patch it would be nice to backport those togehter.\n\nthere isnt strictly a dependcy but in termes of testing it would be nice for our downstream QE at least to be abel to test both at the same time.\n\njust a tought we can proceed with this as is.","commit_id":"21b076e7dfb8a28eb520769f0b257e761f863597"}]}