)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ef7ea19949eda9f4f872c1baa5c251aeadbb4496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46e4fba0_e898b0aa","updated":"2022-10-18 10:51:25.000000000","message":"Looks like reasonable according bug reported. Thanks.","commit_id":"2f55e9ea06f975240e3ff5aff21195ec6af76193"}],"vif_plug_ovs/ovsdb/ovsdb_lib.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e67669a177429f96253388b77238595a04554ea","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            self._ovsdb \u003d ovsdb_api.get_instance(self)"},{"line_number":42,"context_line":"        return self._ovsdb"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _ovs_supports_mtu_requests(self, txn):"},{"line_number":45,"context_line":"        return txn.add(self.ovsdb.has_table_column(\u0027Interface\u0027,"},{"line_number":46,"context_line":"                                                   \u0027mtu_request\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _set_mtu_request(self, txn, dev, mtu):"},{"line_number":49,"context_line":"        txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, (\u0027mtu_request\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"db2cf611_9a358147","line":46,"range":{"start_line":44,"start_character":4,"end_line":46,"end_character":66},"updated":"2022-09-15 11:16:34.000000000","message":"this is wong\nthis need to be executed as part of creating the tansaction.","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed495034ed0b90d0627346db5ff7765c9e1cdb82","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            self._ovsdb \u003d ovsdb_api.get_instance(self)"},{"line_number":42,"context_line":"        return self._ovsdb"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _ovs_supports_mtu_requests(self, txn):"},{"line_number":45,"context_line":"        return txn.add(self.ovsdb.has_table_column(\u0027Interface\u0027,"},{"line_number":46,"context_line":"                                                   \u0027mtu_request\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _set_mtu_request(self, txn, dev, mtu):"},{"line_number":49,"context_line":"        txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, (\u0027mtu_request\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"39208a1d_562dc373","line":46,"range":{"start_line":44,"start_character":4,"end_line":46,"end_character":66},"in_reply_to":"db2cf611_9a358147","updated":"2022-09-16 11:18:51.000000000","message":"Done","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e67669a177429f96253388b77238595a04554ea","unresolved":true,"context_lines":[{"line_number":46,"context_line":"                                                   \u0027mtu_request\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _set_mtu_request(self, txn, dev, mtu):"},{"line_number":49,"context_line":"        txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, (\u0027mtu_request\u0027,"},{"line_number":50,"context_line":"                                                     mtu)).execute())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def update_device_mtu(self, txn, dev, mtu, interface_type\u003dNone):"},{"line_number":53,"context_line":"        if not mtu:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c355395_3030b693","line":50,"range":{"start_line":49,"start_character":8,"end_line":50,"end_character":69},"updated":"2022-09-15 11:16:34.000000000","message":"styple wise the convention we have is if function argument dont all fit on one line without going over column 79 all argumets shoudl be move to the next line\n\nso \n\n        txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, (\u0027mtu_request\u0027,\n                                                     mtu)).execute())\nshould be\ntxn.add(\n    self.ovsdb.db_set(\n        \u0027Interface\u0027, dev, (\u0027mtu_request\u0027,mtu)\n    ).execute()\n)\n\nalthough im pretty usre the execute is wrong\n\nso this should be \n\ntxn.add(\n    self.ovsdb.db_set(\n        \u0027Interface\u0027, dev, (\u0027mtu_request\u0027,mtu)\n    )\n)\n\nwhich likely can be\n\ntxn.add(\n    self.ovsdb.db_set(\u0027Interface\u0027, dev, (\u0027mtu_request\u0027,mtu))\n)","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed495034ed0b90d0627346db5ff7765c9e1cdb82","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                                                   \u0027mtu_request\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def _set_mtu_request(self, txn, dev, mtu):"},{"line_number":49,"context_line":"        txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, (\u0027mtu_request\u0027,"},{"line_number":50,"context_line":"                                                     mtu)).execute())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def update_device_mtu(self, txn, dev, mtu, interface_type\u003dNone):"},{"line_number":53,"context_line":"        if not mtu:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b208b98b_3fc06a23","line":50,"range":{"start_line":49,"start_character":8,"end_line":50,"end_character":69},"in_reply_to":"6c355395_3030b693","updated":"2022-09-16 11:18:51.000000000","message":"Done","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e67669a177429f96253388b77238595a04554ea","unresolved":true,"context_lines":[{"line_number":188,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Port\u0027, dev, (\u0027tag\u0027, tag)))"},{"line_number":189,"context_line":"            if col_values:"},{"line_number":190,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, *col_values))"},{"line_number":191,"context_line":"            self.update_device_mtu(txn, dev, mtu,"},{"line_number":192,"context_line":"                                   interface_type\u003dinterface_type)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def update_ovs_vif_port(self, dev, mtu\u003dNone, interface_type\u003dNone):"},{"line_number":195,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":196,"context_line":"            self.update_device_mtu(txn, dev, mtu,"},{"line_number":197,"context_line":"                                   interface_type\u003dinterface_type)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def delete_ovs_vif_port(self, bridge, dev, delete_netdev\u003dTrue):"},{"line_number":200,"context_line":"        self.ovsdb.del_port(dev, bridge\u003dbridge, if_exists\u003dTrue).execute()"}],"source_content_type":"text/x-python","patch_set":1,"id":"415f94cb_45512903","line":197,"range":{"start_line":191,"start_character":0,"end_line":197,"end_character":65},"updated":"2022-09-15 11:16:34.000000000","message":"same for these please reflow the arguments properly\nself.update_device_mtu(\n    txn, dev, mtu, interface_type\u003dinterface_type\n)","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed495034ed0b90d0627346db5ff7765c9e1cdb82","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Port\u0027, dev, (\u0027tag\u0027, tag)))"},{"line_number":189,"context_line":"            if col_values:"},{"line_number":190,"context_line":"                txn.add(self.ovsdb.db_set(\u0027Interface\u0027, dev, *col_values))"},{"line_number":191,"context_line":"            self.update_device_mtu(txn, dev, mtu,"},{"line_number":192,"context_line":"                                   interface_type\u003dinterface_type)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def update_ovs_vif_port(self, dev, mtu\u003dNone, interface_type\u003dNone):"},{"line_number":195,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":196,"context_line":"            self.update_device_mtu(txn, dev, mtu,"},{"line_number":197,"context_line":"                                   interface_type\u003dinterface_type)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def delete_ovs_vif_port(self, bridge, dev, delete_netdev\u003dTrue):"},{"line_number":200,"context_line":"        self.ovsdb.del_port(dev, bridge\u003dbridge, if_exists\u003dTrue).execute()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f58bf42a_0c6725b1","line":197,"range":{"start_line":191,"start_character":0,"end_line":197,"end_character":65},"in_reply_to":"415f94cb_45512903","updated":"2022-09-16 11:18:51.000000000","message":"Done","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"050bc18ca8e7ae660abcb3c8e7da81275950c522","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            )"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def update_ovs_vif_port(self, dev, mtu\u003dNone, interface_type\u003dNone):"},{"line_number":198,"context_line":"        with self.ovsdb.transaction() as txn:"},{"line_number":199,"context_line":"            self.update_device_mtu("},{"line_number":200,"context_line":"                txn, dev, mtu, interface_type\u003dinterface_type"},{"line_number":201,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":5,"id":"e738b93d_15ee7dcb","line":198,"updated":"2022-10-06 11:34:43.000000000","message":"ok this is used form here\n\nhttps://github.com/openstack/os-vif/blob/35705ba59f379aca234206d7a43b14a0c9d3d087/vif_plug_ovs/ovs.py#L235-L23\n\nwhich is for kernel ovs with hybrid plug enabled.\n\nwe do not need to configure the mtu atomically so its oke that that will not be in the same transaction as the port create.\n\nthis path is only taken when the nova-compute agent is restarted so this will be correct.","commit_id":"2f55e9ea06f975240e3ff5aff21195ec6af76193"}],"vif_plug_ovs/tests/unit/ovsdb/test_ovsdb_lib.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e67669a177429f96253388b77238595a04554ea","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                return_value\u003dTrue), \\"},{"line_number":73,"context_line":"                mock.patch.object(self.br, \u0027_set_mtu_request\u0027) as \\"},{"line_number":74,"context_line":"                mock_set_mtu_request:"},{"line_number":75,"context_line":"            self.br.update_device_mtu(\u0027device\u0027, 1500,"},{"line_number":76,"context_line":"                                       constants.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":77,"context_line":"            mock_set_mtu_request.assert_has_calls([mock.call(\u0027device\u0027, 1500)])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test__update_device_mtu_interface_vhostuser_not_supports_mtu_req(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"361f9b5b_9c2ac5ec","side":"PARENT","line":76,"range":{"start_line":75,"start_character":5,"end_line":76,"end_character":78},"updated":"2022-09-15 11:16:34.000000000","message":"just a general comment.\nwe used ot use this older style but it wastes a lot of virtial whitespace so we have tried to avoid ti for the last 2 years or more and slowly have been movign to the other style so if you see the old sylt in use and you are modifying the line you shoudl conider converting.\n\n\nyou should not modify code you dont need too however so dont just change it everyehre in a file.","commit_id":"771dfffcd90dcd7c8c95c41744092f5ad4917be3"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed495034ed0b90d0627346db5ff7765c9e1cdb82","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                return_value\u003dTrue), \\"},{"line_number":73,"context_line":"                mock.patch.object(self.br, \u0027_set_mtu_request\u0027) as \\"},{"line_number":74,"context_line":"                mock_set_mtu_request:"},{"line_number":75,"context_line":"            self.br.update_device_mtu(\u0027device\u0027, 1500,"},{"line_number":76,"context_line":"                                       constants.OVS_VHOSTUSER_INTERFACE_TYPE)"},{"line_number":77,"context_line":"            mock_set_mtu_request.assert_has_calls([mock.call(\u0027device\u0027, 1500)])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test__update_device_mtu_interface_vhostuser_not_supports_mtu_req(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffcfa7dd_d0a076af","side":"PARENT","line":76,"range":{"start_line":75,"start_character":5,"end_line":76,"end_character":78},"in_reply_to":"361f9b5b_9c2ac5ec","updated":"2022-09-16 11:18:51.000000000","message":"Done","commit_id":"771dfffcd90dcd7c8c95c41744092f5ad4917be3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e67669a177429f96253388b77238595a04554ea","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(linux_net, \u0027set_device_mtu\u0027)"},{"line_number":58,"context_line":"    def test__update_device_mtu_interface_not_vhostuser_linux(self,"},{"line_number":59,"context_line":"            mock_set_device_mtu):"},{"line_number":60,"context_line":"        self.br.update_device_mtu(self.mock_transaction,"},{"line_number":61,"context_line":"                                  \u0027device\u0027, 1500, \u0027not_vhost\u0027)"},{"line_number":62,"context_line":"        mock_set_device_mtu.assert_has_calls([mock.call(\u0027device\u0027, 1500)])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @mock.patch(\u0027sys.platform\u0027, constants.PLATFORM_WIN32)"}],"source_content_type":"text/x-python","patch_set":1,"id":"59d0a3d5_644035b4","line":61,"range":{"start_line":60,"start_character":8,"end_line":61,"end_character":62},"updated":"2022-09-15 11:16:34.000000000","message":"same for all of these\nif you split them on to new lines move all args to the new line.\n\nplease fix this in all places you used the old style.","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"ed495034ed0b90d0627346db5ff7765c9e1cdb82","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @mock.patch.object(linux_net, \u0027set_device_mtu\u0027)"},{"line_number":58,"context_line":"    def test__update_device_mtu_interface_not_vhostuser_linux(self,"},{"line_number":59,"context_line":"            mock_set_device_mtu):"},{"line_number":60,"context_line":"        self.br.update_device_mtu(self.mock_transaction,"},{"line_number":61,"context_line":"                                  \u0027device\u0027, 1500, \u0027not_vhost\u0027)"},{"line_number":62,"context_line":"        mock_set_device_mtu.assert_has_calls([mock.call(\u0027device\u0027, 1500)])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @mock.patch(\u0027sys.platform\u0027, constants.PLATFORM_WIN32)"}],"source_content_type":"text/x-python","patch_set":1,"id":"55ec0d37_4d88bc3e","line":61,"range":{"start_line":60,"start_character":8,"end_line":61,"end_character":62},"in_reply_to":"59d0a3d5_644035b4","updated":"2022-09-16 11:18:51.000000000","message":"Done","commit_id":"2b0c8b337dc5d7e518461fecf56d8d19bbb05154"}]}