)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c52fb5fcdca7295f91cee5d7f088e140d08254ae","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix how deprecated_reason of ovsdb_interface is logged"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the deprecation warning of this option appear as a multi-line"},{"line_number":10,"context_line":"message because of the heredoc format but this makes log parsing"},{"line_number":11,"context_line":"complicated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change ensures the message is put into a single line."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b6c1ea1a_ed65317f","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":30},"updated":"2022-11-30 11:39:07.000000000","message":"technially its not a heredoc. its currently a multiline string\n\nand as you can see form nova we have started prefering to use multi line string over sting contatination\n\nhttps://github.com/openstack/nova/blob/master/nova/conf/libvirt.py#L31\n\nso i would prefer not to change this","commit_id":"0df9030972845868af58a529fa2d1c55ce56041c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7fd8691bf288c820954442273bcac14c3bb249df","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix how deprecated_reason of ovsdb_interface is logged"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the deprecation warning of this option appear as a multi-line"},{"line_number":10,"context_line":"message because of the heredoc format but this makes log parsing"},{"line_number":11,"context_line":"complicated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change ensures the message is put into a single line."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"edd5bf14_6cdd0757","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":30},"in_reply_to":"affa326a_2ccd3136","updated":"2022-11-30 13:05:38.000000000","message":"(Just updated the commit message to use more proper wording. (Thanks for pointing that, Sean !)","commit_id":"0df9030972845868af58a529fa2d1c55ce56041c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4fc2ae0b5206c1fb8c6af809e3384ec79fe55d21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix how deprecated_reason of ovsdb_interface is logged"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the deprecation warning of this option appear as a multi-line"},{"line_number":10,"context_line":"message because of the heredoc format but this makes log parsing"},{"line_number":11,"context_line":"complicated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change ensures the message is put into a single line."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"affa326a_2ccd3136","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":30},"in_reply_to":"b6c1ea1a_ed65317f","updated":"2022-11-30 13:04:45.000000000","message":"I agree we can use multiline string for parameter description (descriptions are automatically wrapped by oslo-config-generator when a config file is auto-generated, so I\u0027m not sure how much benefitial to define own new lines, though).\n\nThe main problem with the deprecated_reason attribute is it is put in service logs, where parse-ability would be more important than read-ability in narrowed console.","commit_id":"0df9030972845868af58a529fa2d1c55ce56041c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c52fb5fcdca7295f91cee5d7f088e140d08254ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c2006e3_d2b0810e","updated":"2022-11-30 11:39:07.000000000","message":"soft -1 i would perfer to keep using multi line strings in our config help text.\n\nif other want to make this change then is wont block it","commit_id":"0df9030972845868af58a529fa2d1c55ce56041c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5f8ca499d44c01909f022196c99d7eb18c7b7847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d117898_421f9202","updated":"2022-12-06 11:18:03.000000000","message":"@sean I would be in favor of the change at least because all the other multiline strings are using concat. And this is going to add some sort of benefit until we find better solution.","commit_id":"c0bf2b749574f93f63d1276daf93fcf978ec8dab"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"740cb9c54f0e243a744232adfb2f0c8e4dee6131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ddc20c08_891b29cd","updated":"2022-12-06 13:20:43.000000000","message":"Fair enough. Let\u0027s just remove that whole option if possible as you mentioned I guess","commit_id":"c0bf2b749574f93f63d1276daf93fcf978ec8dab"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ae19dd2240989b370d693139fa826e4703ae2574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad4b0c30_c8594c89","updated":"2022-12-06 11:27:07.000000000","message":"as noted before we exnstively use multi line deprecations reasons in nova\nhttps://github.com/openstack/nova/search?p\u003d3\u0026q\u003ddeprecated_reason\nand we also emit multi line log messages in other places so i dont really think this change makes sense \nif anything we likely should to the opisite for consitency\n\nmake all our help and deprecation strings multi line.","commit_id":"c0bf2b749574f93f63d1276daf93fcf978ec8dab"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"79bdae2c73d3af6f6b48846f56dfb3e59b53fcbe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e79f23dc_7afe6495","in_reply_to":"cc07c2f5_d366de6d","updated":"2023-02-01 07:47:32.000000000","message":"According to the fix we need python-openvswitch 2.16.0+ and Ubuntu jammy ships 2.17.0[2] so we\u0027d be able to remove it soon. But we likely have to hold on until we completely drop Ubuntu focal which is still kept for upgrade path[3].\n\n[1] https://review.opendev.org/c/openstack/ovsdbapp/+/818446\n[2] https://packages.ubuntu.com/jammy/python3-openvswitch\n[3] https://governance.openstack.org/tc/reference/runtimes/2023.1.html\n\nIf we still maintain testing on Focal then we probably have to revert the change I recently made in devstack. (I\u0027ve pushed https://review.opendev.org/c/openstack/devstack/+/872381 )","commit_id":"c0bf2b749574f93f63d1276daf93fcf978ec8dab"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c2fe56f2e94119b023b3b5b213c5e6f9bc8048c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc07c2f5_d366de6d","in_reply_to":"ddc20c08_891b29cd","updated":"2023-02-01 06:41:11.000000000","message":"so i just checked and it looks like ubuntu 22.04 is still shiping with the broken version of the ovs python bindings which can hard lock the nova compute agent for 5 seconds when there is a disconenct. so until that is fixed we still need to use the deprecated vsctl backend on ubuntu to mitigate that.\n\nso we cant really remove this option as we are depending on setting it to vsctl in the ci to not have random test failures due to the ovs connection dropping.","commit_id":"c0bf2b749574f93f63d1276daf93fcf978ec8dab"}]}