)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e9647dd1b78424f2e9cf59f672493a09a630527","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- oslo.utils is imported by actual logic but is not listed as"},{"line_number":15,"context_line":"  a runtime dependency."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- oslo.concurrency and oslo.privsep are both imported by only test"},{"line_number":18,"context_line":"  codes"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1b249bd2_12d98f01","line":16,"updated":"2024-02-19 01:53:33.000000000","message":"yes its a direct and indirect dep.\nits currenlty pulled in indirectly by some of our other oslo deps.","commit_id":"5c7bc5ffce46b7be83397edeb6039e8743960d89"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e9647dd1b78424f2e9cf59f672493a09a630527","unresolved":true,"context_lines":[{"line_number":14,"context_line":"- oslo.utils is imported by actual logic but is not listed as"},{"line_number":15,"context_line":"  a runtime dependency."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- oslo.concurrency and oslo.privsep are both imported by only test"},{"line_number":18,"context_line":"  codes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- oslo.serialization is used by test code but is not listed in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4a03f74b_2a0bc7fa","line":17,"updated":"2024-02-19 01:53:33.000000000","message":"oslo.concurrency is used in the ovs plugin https://github.com/openstack/os-vif/blob/65db98dc4e932e6e0d1225378078e19ea4466f0e/vif_plug_ovs/linux_net.py#L28\nand proably elsehwere.","commit_id":"5c7bc5ffce46b7be83397edeb6039e8743960d89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d4d059f2e38cde452823b545d5602016e0c939","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- oslo.utils is imported by actual logic but is not listed as"},{"line_number":15,"context_line":"  a runtime dependency."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- oslo.concurrency and oslo.privsep are both imported by only test"},{"line_number":18,"context_line":"  codes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- oslo.serialization is used by test code but is not listed in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"450658b2_3491d94d","line":17,"in_reply_to":"4a03f74b_2a0bc7fa","updated":"2024-02-19 01:56:43.000000000","message":"Yes. I overlooked the usages in the additional package directories. Reverted these changes in the latest version.","commit_id":"5c7bc5ffce46b7be83397edeb6039e8743960d89"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e9647dd1b78424f2e9cf59f672493a09a630527","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- oslo.concurrency and oslo.privsep are both imported by only test"},{"line_number":18,"context_line":"  codes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- oslo.serialization is used by test code but is not listed in"},{"line_number":21,"context_line":"  test-requirements.txt ."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This also fixes the workaround for python 2 from setup.py because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"919a7e69_bf27ea53","line":20,"updated":"2024-02-19 01:53:33.000000000","message":"it is but its also used in the production code which is why its only in requirements and not test-requirement\nhttps://github.com/openstack/os-vif/blob/65db98dc4e932e6e0d1225378078e19ea4466f0e/vif_plug_ovs/ovsdb/impl_vsctl.py#L21","commit_id":"5c7bc5ffce46b7be83397edeb6039e8743960d89"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14d4d059f2e38cde452823b545d5602016e0c939","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- oslo.concurrency and oslo.privsep are both imported by only test"},{"line_number":18,"context_line":"  codes"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- oslo.serialization is used by test code but is not listed in"},{"line_number":21,"context_line":"  test-requirements.txt ."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This also fixes the workaround for python 2 from setup.py because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8c103796_fecf460b","line":20,"in_reply_to":"919a7e69_bf27ea53","updated":"2024-02-19 01:56:43.000000000","message":"Yes. So I moved this to requirements.","commit_id":"5c7bc5ffce46b7be83397edeb6039e8743960d89"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e1fb50d296f944cb2084ac521b7b2b01882a5d02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6d55b512_da200d95","updated":"2024-02-22 10:16:21.000000000","message":"not sure we need it before the freeze, but cool with me.","commit_id":"5c41f9f700c8017ffbb3b8b8c348b468158bba59"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"63cb1fb3907f9070164ff2868a90335d0c36aaf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efb8ccab_c9669d67","updated":"2024-02-23 09:16:07.000000000","message":"recheck - openstack-tox-functional-ovs-with-sudo -\u003e\n\ntest_create_ovs_vif_port_with_default_qos failed with:\n\nAssertionError: False is not true : Parameter external_ids of Interface qos-port-native is None not {\u0027iface-status\u0027: \u0027active\u0027, \u0027iface-id\u0027: \u0027iface_id\u0027, \u0027attached-mac\u0027: \u0027ca:fe:ca:fe:ca:fe\u0027, \u0027vm-uuid\u0027: \u0027afbb21e2-4642-41cd-901f-0d73d0ab54da\u0027}","commit_id":"5c41f9f700c8017ffbb3b8b8c348b468158bba59"}],"requirements.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"acbccc75d9fad8d9a3a707aa05b4743ec75d13e9","unresolved":true,"context_lines":[{"line_number":13,"context_line":"oslo.log\u003e\u003d3.30.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":15,"context_line":"oslo.privsep\u003e\u003d1.23.0 # Apache-2.0"},{"line_number":16,"context_line":"oslo.versionedobjects\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":17,"context_line":"ovsdbapp\u003e\u003d0.12.1 # Apache-2.0"},{"line_number":18,"context_line":"pyroute2\u003e\u003d0.5.2;sys_platform!\u003d\u0027win32\u0027 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":19,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"006ea8a4_181d1c11","side":"PARENT","line":16,"updated":"2024-02-19 01:34:45.000000000","message":"https://github.com/openstack/os-vif/blob/65db98dc4e932e6e0d1225378078e19ea4466f0e/vif_plug_ovs/ovsdb/impl_vsctl.py#L60\n\nprivsep is used when using the ovs vsctl backend\n\nit is not used when using the default python backend\nso privsep is still an optional runtime dep.\n\nwe could perhaps list it in extras but that is why it was here.","commit_id":"a10ac95be112e24a387863c71a048a088710c52f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bc62729d0a05fd7f805279805a2193aa9ed2a4e2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"oslo.log\u003e\u003d3.30.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":15,"context_line":"oslo.privsep\u003e\u003d1.23.0 # Apache-2.0"},{"line_number":16,"context_line":"oslo.versionedobjects\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":17,"context_line":"ovsdbapp\u003e\u003d0.12.1 # Apache-2.0"},{"line_number":18,"context_line":"pyroute2\u003e\u003d0.5.2;sys_platform!\u003d\u0027win32\u0027 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":19,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"cef94104_a2c90aaf","side":"PARENT","line":16,"in_reply_to":"006ea8a4_181d1c11","updated":"2024-02-19 01:40:22.000000000","message":"Ah, ok. I noticed I didn\u0027t check the `vif_plug_*` directories...","commit_id":"a10ac95be112e24a387863c71a048a088710c52f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af5d7fd9298b4452eedd99e2d22e25d321a6a999","unresolved":true,"context_lines":[{"line_number":13,"context_line":"oslo.log\u003e\u003d3.30.0 # Apache-2.0"},{"line_number":14,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"},{"line_number":15,"context_line":"oslo.privsep\u003e\u003d1.23.0 # Apache-2.0"},{"line_number":16,"context_line":"oslo.versionedobjects\u003e\u003d1.28.0 # Apache-2.0"},{"line_number":17,"context_line":"ovsdbapp\u003e\u003d0.12.1 # Apache-2.0"},{"line_number":18,"context_line":"pyroute2\u003e\u003d0.5.2;sys_platform!\u003d\u0027win32\u0027 # Apache-2.0 (+ dual licensed GPL2)"},{"line_number":19,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"23b8018e_378093d3","side":"PARENT","line":16,"in_reply_to":"006ea8a4_181d1c11","updated":"2024-02-19 01:39:33.000000000","message":"thats not the only useage of prive sep by the way\nits used for the linux bridge plugin \nhttps://github.com/openstack/os-vif/blob/65db98dc4e932e6e0d1225378078e19ea4466f0e/vif_plug_linux_bridge/linux_net.py#L53\n\n\nand its also used when using ml2/ovs with hybrid plug to enable the iptables firewall\nhttps://github.com/openstack/os-vif/blob/65db98dc4e932e6e0d1225378078e19ea4466f0e/vif_plug_ovs/linux_net.py#L78","commit_id":"a10ac95be112e24a387863c71a048a088710c52f"}]}