)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d27420d06ae5fe50e68a6a801dd156db2506d63b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"11814d62_7ef1ecdb","updated":"2025-02-15 03:35:15.000000000","message":"Because debtcollector is already used, I think we can use it to emit deprecation warning. The library uses warnings.warn internally and allows users to filter these warnings if they want.","commit_id":"6d91bc1617f225188ab8059d0fcf8500a7e9106c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbc29d7efcad73a03f5f37ac947b4ccc33af9ebb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"847c6bcf_d300d15e","in_reply_to":"11814d62_7ef1ecdb","updated":"2025-02-15 19:11:11.000000000","message":"im not usting that because the classs will be loaded on start up and i only wanted ot emit the warning if it was actuly used.","commit_id":"6d91bc1617f225188ab8059d0fcf8500a7e9106c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8c5a16d5706fe41c0569d5224633ee6d8f4b4ada","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ac3f94ce_124f4191","updated":"2025-02-15 05:37:03.000000000","message":"I wonder if linux bridge may be used when iptables_hybrid firewall driver is used ? IIUC in that case instances are connected to its qbr linux bridge, which is connected to ovs bridge by veth pairs.","commit_id":"4d282bf5d4bb1f48bbd6109999bd7c693c508666"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbc29d7efcad73a03f5f37ac947b4ccc33af9ebb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6c198d72_fd10bcd0","in_reply_to":"ac3f94ce_124f4191","updated":"2025-02-15 19:11:11.000000000","message":"hyrbid plug ues linux bridge but it does nto use this code.\n\nthat is handeled int he ovs plugin.","commit_id":"4d282bf5d4bb1f48bbd6109999bd7c693c508666"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82a16606f14c9417fa464f6e47fecd4fbc7e3336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8eb99146_38389657","updated":"2025-02-20 03:05:29.000000000","message":"@ralonsoh@redhat.com\ncan you hit this whn your online tomorrow\nthis is the last patch need to do an os-vif release","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d647147f3fc6b2d707a5bc6a75020cd51d8c1302","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8cf578ab_4270d3af","updated":"2025-02-19 15:30:02.000000000","message":"We agreed on that deprecation at the previous nova meeting","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d0cffce0e7b96dfed8b2fdf752c07ca91ec80949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"29d8527d_f7c8ee66","updated":"2025-02-17 10:53:47.000000000","message":"i should avoid +2 my own patch even if its been modifed but i agree with the current approch of movign the deprecations to the plug method.","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a427b081a1ef00d7fc78ba1e17d5c3dfc0c36dc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f55199f2_cad90a20","updated":"2025-02-21 00:02:23.000000000","message":"recheck , the gates a little quieter so lets see if it will work this time\n\nthe test that is failing used to only fail on the native driver. so we swapped to running only with ovs-vsctl cli driver\nnow its flaky with that too and that make absolutely no sense so i strongly suspect this is entrily down to load.","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"08f701343c3ba247b06de329b00d90a7fde5242d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"27950b97_c1451a43","updated":"2025-02-21 04:44:25.000000000","message":"recheck kernel panic...","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"42ca4a06d66e191a4010296e2c724185176bdd5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"421fab62_4aff987d","updated":"2025-02-20 17:54:51.000000000","message":"recheck load related test instablity","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"007c8a3b1f5926666961adf6a784ea873bb2971c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9cb4257a_8b7bb9a3","updated":"2025-02-23 10:55:49.000000000","message":"recheck os-vif-ovs-iptables","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"63af5e6a23e876cf0654d732199268ff5af39f96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2d96b7b6_d9c277e5","updated":"2025-02-18 08:42:45.000000000","message":"thanks for taking care","commit_id":"cc49f58da7f219009ffa4b6125aa0fa334fb94e9"}],"vif_plug_linux_bridge/linux_bridge.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"10a87dfaba454b24b29c7b60cca2f110d16aa5f9","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@debtcollector.removals.removed_class(\"LinuxBridgePlugin\","},{"line_number":31,"context_line":"                                      category\u003dDeprecationWarning)"},{"line_number":32,"context_line":"class LinuxBridgePlugin(plugin.PluginBase):"},{"line_number":33,"context_line":"    \"\"\"A VIF type that uses a standard Linux bridge device.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"87ef67d5_20dbba15","line":31,"updated":"2025-02-15 19:24:02.000000000","message":"perhasp this is ok what iwll it log?\n\ni expecitly didnt want to have it log whewn we init the class when nova stars up and it does not it just prints as normal\n\nFeb 15 06:10:08.813100 np0039861926 nova-compute[77657]: DEBUG os_vif [-] Loaded VIF plugin class \u0027\u003cclass \u0027vif_plug_linux_bridge.linux_bridge.LinuxBridgePlugin\u0027\u003e\u0027 with name \u0027linux_bridge\u0027 {{(pid\u003d77657) initialize /opt/stack/os-vif/os_vif/__init__.py:44}}\n\nhttps://ea4b2d4f8d5c187742d9-e77ce0ffc4ffea95c693e8c73a486dc2.ssl.cf2.rackcdn.com/941585/6/check/os-vif-ovs-iptables/b55d26e/controller/logs/screen-n-cpu.txt","commit_id":"18ca20aa569a91b4abfae29647845688f33d4352"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c6f741a0c0d1c663b463f9bb055501acedeffe25","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@debtcollector.removals.removed_class(\"LinuxBridgePlugin\","},{"line_number":31,"context_line":"                                      category\u003dDeprecationWarning)"},{"line_number":32,"context_line":"class LinuxBridgePlugin(plugin.PluginBase):"},{"line_number":33,"context_line":"    \"\"\"A VIF type that uses a standard Linux bridge device.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bb4f60f8_bba68d1f","line":31,"in_reply_to":"87ef67d5_20dbba15","updated":"2025-02-16 10:31:51.000000000","message":"removed_class adds deprecation warning into __init__ so the warning is not shown when the class is imported but it is shown when an instance is created.","commit_id":"18ca20aa569a91b4abfae29647845688f33d4352"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"32ee9290a3128cd6fb34b82378d9a86dae485cd3","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@debtcollector.removals.removed_class(\"LinuxBridgePlugin\","},{"line_number":31,"context_line":"                                      category\u003dDeprecationWarning)"},{"line_number":32,"context_line":"class LinuxBridgePlugin(plugin.PluginBase):"},{"line_number":33,"context_line":"    \"\"\"A VIF type that uses a standard Linux bridge device.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fe9b9009_1986cf41","line":31,"in_reply_to":"bb4f60f8_bba68d1f","updated":"2025-02-16 10:34:57.000000000","message":"```\n\u003e\u003e\u003e from vif_plug_linux_bridge.linux_bridge import LinuxBridgePlugin\n\u003e\u003e\u003e LinuxBridgePlugin(CONF)\n\u003cstdin\u003e:1: DeprecationWarning: Using class \u0027LinuxBridgePlugin\u0027 (either directly or via inheritance) is deprecated\n...\n```","commit_id":"18ca20aa569a91b4abfae29647845688f33d4352"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"239c9daafdb6b27f2df9d7d7d43ae22430a3985c","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@debtcollector.removals.removed_class(\"LinuxBridgePlugin\","},{"line_number":31,"context_line":"                                      category\u003dDeprecationWarning)"},{"line_number":32,"context_line":"class LinuxBridgePlugin(plugin.PluginBase):"},{"line_number":33,"context_line":"    \"\"\"A VIF type that uses a standard Linux bridge device.\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"add58e06_49855905","line":31,"in_reply_to":"fe9b9009_1986cf41","updated":"2025-02-16 15:13:32.000000000","message":"right so we explictly do not want to warn in init\n\nwe load all the  classes dynmaicly via initialize https://github.com/openstack/os-vif/blob/master/os_vif/__init__.py#L24-L49\n\nwhich constucts the class in load when it returns\n\nhttps://github.com/openstack/os-vif/blob/master/os_vif/plugin.py#L89\n\n\nso we only want to emit a deprecation warning if you call plug.\n\nwhat confusting is i was not essign the deprecation pring in the nova log.\nin the ci job with this current patch\n\nso the debtcollector.removals.removed_class decorator is not working proerly even in the init case","commit_id":"18ca20aa569a91b4abfae29647845688f33d4352"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"10a87dfaba454b24b29c7b60cca2f110d16aa5f9","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                    supported_port_profiles\u003d[]),"},{"line_number":98,"context_line":"            ])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def plug(self, vif, instance_info):"},{"line_number":101,"context_line":"        \"\"\"Ensure that the bridge exists, and add VIF to it.\"\"\""},{"line_number":102,"context_line":"        network \u003d vif.network"},{"line_number":103,"context_line":"        bridge_name \u003d vif.bridge_name"}],"source_content_type":"text/x-python","patch_set":6,"id":"2b3c07af_184f68eb","line":100,"updated":"2025-02-15 19:24:02.000000000","message":"i was explcity plannign to only log a deprecation fi plug was called because that means the plugin is actully being used on the host.","commit_id":"18ca20aa569a91b4abfae29647845688f33d4352"}]}
