)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2c9f2ef5da2e124ddaea9af729ddebf36274f484","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c13a25e4_0be47a44","updated":"2025-02-25 17:59:34.000000000","message":"can you expalin why you want to do this\n\nthe os-vif interface is intentionally small (effectivly plug and unplug)\nbecause its not a generically resuabel lib for interacting with network backends.\n\n\nat one point we did talk about moving all inteface management logic form neutron and nova ot os-vif but that never happend so wihtout know the usecase this si probably out side teh scope of os-vif","commit_id":"a1e4241e6d2d0e44237929df2bfa9db819fc4724"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d744fad9ad8851a5d71141bd213ee82ece76dce7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af41ac4d_03297ab9","in_reply_to":"68a9918b_de9754b0","updated":"2025-02-26 13:59:16.000000000","message":"right so we have been tryign to fix that on  the ovn/neutron side\n\nmodern neutron/ovn is ment to only send the network-vif-plugged event when teh data plane is configured however there are still some gaps in that process.\nsome on Nova and some on neutron\n\nos we were meant to renable the waiting for that on ovn migration in nova but have not.\n\nif we extend teh interface i dont think we woudl do this as you have  propsoed.\n\nget_vif_external_id is a bit ovs specific to have in the main plugin interface.\n\nlooking at how you were attempting to use it in nova\n\nyou were lookign for a ovn-installed subkey\n\nusing the ovs db as a seconddary side channel to detect if the flows are isntalled is not correct.\n\nthe contract with neutron is that it will call the nova extrenal evnets api and only send the network-vif-plugged event  when that is completed.\n\n\nit woudl be ok for neutron to check for that id to be applied before sendign network-vif-plugged but nova shoudl not be doing that.\n\nif we were to add this to os vif we would likely want the interface to be more like \n\ndef verify_plugged (self, vif):\n\nor something like that so we can encapsulate the knowledge in os-vif without leaking it into nova.\n\ni.e. this logic https://review.opendev.org/c/openstack/nova/+/942786/1/nova/virt/libvirt/vif.py woudl be in the verify_plugged implemation in the ovs plugin.\n\nchanging this workflow is out os scope of a bug fix and we should have a spec to defien the nova, neutron and os-vif chagne required to do this properly.\n\nits fundementally changing several aspect of the api contract and workflow\nand has upgrade impatcs as a result.\n\nthis is also fundamentally not backprotable as propsoed so there need to be wider dicussion on the design before going much futher.","commit_id":"a1e4241e6d2d0e44237929df2bfa9db819fc4724"},{"author":{"_account_id":26832,"name":"Stefan Hoffmann","email":"stefan.hoffmann@cloudandheat.com","username":"shoffmann"},"change_message_id":"a3b7cbbe1b0b9f173b28bf0ed186355d93519b43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68a9918b_de9754b0","in_reply_to":"c13a25e4_0be47a44","updated":"2025-02-26 12:05:34.000000000","message":"Thanks for your feedback. I didn\u0027t finished the bug/feature description at time of pushing, so I didn\u0027t linked to that. Now the bug is updated https://bugs.launchpad.net/nova/+bug/2073254\n\nWe have issues at live-migration in big environments, as VMs with small RAM have connection issues (20 seconds and longer). This is due to the networking backend (OVN) takes some time to apply the changed network topology (multi-chassis option) but libvirt migration already starts.\nSo libvirt is done with the migration but the interface is not configured yet.\n\nThis change helps us to identify if the interface is clamed/installed at ovn, than we can start the migration.\n\nWe can also discuss this further at the nova bug.","commit_id":"a1e4241e6d2d0e44237929df2bfa9db819fc4724"}]}