)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3563cc6fa0e3b3617648a8cbec029c7a324c805","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17880591_b197e993","updated":"2025-05-14 14:23:01.000000000","message":"this seams reasonable to me but it would be good for Rodolfo or other neutron folks to confirm\n\nit would be nice to add a functional test for this also but see comments inline","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"56e7edc42dc0e5ccdec0660990960d586c3997da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"620a3654_aceeb1b7","in_reply_to":"17880591_b197e993","updated":"2025-05-15 11:59:55.000000000","message":"+1, sure this is again something where both teams has to be on the same time, thanks","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"619475f297aea5ed6aad87eeac0ae66a0369f174","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"061fb37c_b3116150","updated":"2025-05-19 13:31:55.000000000","message":"recheck\ntest_create_ovs_vif_port_with_default_qos failures seems not related at least never filed for me.","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"695db941dd4bb27a6bd2857fb65e32afa27b2e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"04aabbc9_8d0b5d28","in_reply_to":"061fb37c_b3116150","updated":"2025-05-19 14:19:34.000000000","message":"it sometiems fails in the gate. we have never really repoduced that localy it seams to be timing related.\n\nwe proably should make it retry the test internally or other wise mark it as flaky but it normlly passes on a recheck","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"375943ee2c315f934a2d447e74f0368abd786de8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99742bb9_53ae58c5","updated":"2025-06-10 12:38:52.000000000","message":"thanks Rodolfo for reviewing, i was pretty happy with this before and my main nit has been adress so im happy to move forward with this.","commit_id":"6b078f4998a3c2424c3d3b8582016a385929bf79"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3563cc6fa0e3b3617648a8cbec029c7a324c805","unresolved":true,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def is_trunk_bridge(bridge_name):"},{"line_number":38,"context_line":"    return bridge_name.startswith(constants.TRUNK_BR_PREFIX)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4ae5dcf2_4da36b3b","line":37,"updated":"2025-05-14 14:23:01.000000000","message":"i propably would have kept this as a staticmethod in the class but this is also ok.","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf2cf8cd7bf155a2c4c490c97106a07a28f943f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def is_trunk_bridge(bridge_name):"},{"line_number":38,"context_line":"    return bridge_name.startswith(constants.TRUNK_BR_PREFIX)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"69abe50a_5295c014","line":37,"in_reply_to":"4ae5dcf2_4da36b3b","updated":"2025-05-16 07:39:06.000000000","message":"Acknowledged","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"}],"vif_plug_ovs/ovsdb/ovsdb_lib.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3563cc6fa0e3b3617648a8cbec029c7a324c805","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                        \u0027attached-mac\u0027: mac,"},{"line_number":170,"context_line":"                        \u0027vm-uuid\u0027: instance_id}"},{"line_number":171,"context_line":"        if ovs.is_trunk_bridge(bridge):"},{"line_number":172,"context_line":"            external_ids[\u0027bridge_name\u0027] \u003d bridge"},{"line_number":173,"context_line":"        col_values \u003d [(\u0027external_ids\u0027, external_ids)] if set_ids else []"},{"line_number":174,"context_line":"        if interface_type:"},{"line_number":175,"context_line":"            col_values.append((\u0027type\u0027, interface_type))"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2651596_eb615b62","line":172,"updated":"2025-05-14 14:23:01.000000000","message":"this is fine. \n\nif this was unconditional would it potintally break neutron.\n\ni.e. would it possibel result in neutron deleting the br-int?\n\nif so it would be good to call that out in a code comment.\n\nim fine with only adding this when required to not store extra info in the db that is not required but i just want to capture an implictiosn to setting this or not seting it in the code as a comment for future use if there are any.","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf2cf8cd7bf155a2c4c490c97106a07a28f943f","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                        \u0027attached-mac\u0027: mac,"},{"line_number":170,"context_line":"                        \u0027vm-uuid\u0027: instance_id}"},{"line_number":171,"context_line":"        if ovs.is_trunk_bridge(bridge):"},{"line_number":172,"context_line":"            external_ids[\u0027bridge_name\u0027] \u003d bridge"},{"line_number":173,"context_line":"        col_values \u003d [(\u0027external_ids\u0027, external_ids)] if set_ids else []"},{"line_number":174,"context_line":"        if interface_type:"},{"line_number":175,"context_line":"            col_values.append((\u0027type\u0027, interface_type))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7281d11e_9629d9d1","line":172,"in_reply_to":"12f2983f_c6d5be25","updated":"2025-05-16 07:39:06.000000000","message":"Done","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"56e7edc42dc0e5ccdec0660990960d586c3997da","unresolved":true,"context_lines":[{"line_number":169,"context_line":"                        \u0027attached-mac\u0027: mac,"},{"line_number":170,"context_line":"                        \u0027vm-uuid\u0027: instance_id}"},{"line_number":171,"context_line":"        if ovs.is_trunk_bridge(bridge):"},{"line_number":172,"context_line":"            external_ids[\u0027bridge_name\u0027] \u003d bridge"},{"line_number":173,"context_line":"        col_values \u003d [(\u0027external_ids\u0027, external_ids)] if set_ids else []"},{"line_number":174,"context_line":"        if interface_type:"},{"line_number":175,"context_line":"            col_values.append((\u0027type\u0027, interface_type))"}],"source_content_type":"text/x-python","patch_set":2,"id":"12f2983f_c6d5be25","line":172,"in_reply_to":"d2651596_eb615b62","updated":"2025-05-15 11:59:55.000000000","message":"yeah, better to fill it only when necessary to avoid that at a time br-int is deleted accidentally by the trunk handler :-)\nI will add comment about it","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"}],"vif_plug_ovs/tests/functional/test_plugin.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ede68dbcac2f0487f25fd962831f41effa1be7ca","unresolved":true,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_plug_trunk_bridge_fills_bridge_name(self):"},{"line_number":223,"context_line":"        mac \u003d \u0027ca:fe:de:ad:be:ef\u0027"},{"line_number":224,"context_line":"        iface_id \u003d \u0027631f52bc-3a07-11ef-a006-1319ef9d6edd\u0027"},{"line_number":225,"context_line":"        vif_name \u003d \u0027port-%s\u0027 % iface_id[:8]"},{"line_number":226,"context_line":"        trunk_id \u003d \u0027ef98b384-3a0f-11ef-9009-47345fca266f\u0027"},{"line_number":227,"context_line":"        bridge_name \u003d \u0027tbr-%s\u0027 % trunk_id[:8]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        network \u003d objects.network.Network("},{"line_number":230,"context_line":"            id\u003dtrunk_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"39289ad3_dd096fbd","line":227,"range":{"start_line":224,"start_character":8,"end_line":227,"end_character":45},"updated":"2025-05-19 14:23:36.000000000","message":"actully you shoudl try and use unique uuid here so that the test cant collied\n\nthease are actully creating bridges and port on ovs so we dont want the cleanup of one test to break the other if they are run in parallel","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"375943ee2c315f934a2d447e74f0368abd786de8","unresolved":true,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_plug_trunk_bridge_fills_bridge_name(self):"},{"line_number":223,"context_line":"        mac \u003d \u0027ca:fe:de:ad:be:ef\u0027"},{"line_number":224,"context_line":"        iface_id \u003d \u0027631f52bc-3a07-11ef-a006-1319ef9d6edd\u0027"},{"line_number":225,"context_line":"        vif_name \u003d \u0027port-%s\u0027 % iface_id[:8]"},{"line_number":226,"context_line":"        trunk_id \u003d \u0027ef98b384-3a0f-11ef-9009-47345fca266f\u0027"},{"line_number":227,"context_line":"        bridge_name \u003d \u0027tbr-%s\u0027 % trunk_id[:8]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        network \u003d objects.network.Network("},{"line_number":230,"context_line":"            id\u003dtrunk_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2de6f92f_c75b11e7","line":227,"range":{"start_line":224,"start_character":8,"end_line":227,"end_character":45},"in_reply_to":"233b8d8f_18a1525f","updated":"2025-06-10 12:38:52.000000000","message":"ok that works \n\ni prefer ot use uuid sentinal class form oslo for this\nor failing that uuidutils.generate_uuid() but that not worth a respin.\n\ni migh tdo a pass in the future and try and make our usage of uuides in the test alitlle more consistent.","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e3715bf1723d05bdb287ceee75908ee21713fab3","unresolved":true,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_plug_trunk_bridge_fills_bridge_name(self):"},{"line_number":223,"context_line":"        mac \u003d \u0027ca:fe:de:ad:be:ef\u0027"},{"line_number":224,"context_line":"        iface_id \u003d \u0027631f52bc-3a07-11ef-a006-1319ef9d6edd\u0027"},{"line_number":225,"context_line":"        vif_name \u003d \u0027port-%s\u0027 % iface_id[:8]"},{"line_number":226,"context_line":"        trunk_id \u003d \u0027ef98b384-3a0f-11ef-9009-47345fca266f\u0027"},{"line_number":227,"context_line":"        bridge_name \u003d \u0027tbr-%s\u0027 % trunk_id[:8]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        network \u003d objects.network.Network("},{"line_number":230,"context_line":"            id\u003dtrunk_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"233b8d8f_18a1525f","line":227,"range":{"start_line":224,"start_character":8,"end_line":227,"end_character":45},"in_reply_to":"39289ad3_dd096fbd","updated":"2025-05-20 13:17:50.000000000","message":"I added uuid.uuid() if that is fine I can change all uuids here to use that","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf2cf8cd7bf155a2c4c490c97106a07a28f943f","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        }"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        self._check_parameter(\u0027Interface\u0027, vif.vif_name,"},{"line_number":251,"context_line":"                              \u0027external_ids\u0027, expected_external_ids)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_plug_non_trunk_leave_bridge_name_empty(self):"},{"line_number":254,"context_line":"        mac \u003d \u0027ca:fe:de:ad:be:ef\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"694164f6_b4a164cb","line":251,"updated":"2025-05-16 07:39:06.000000000","message":"+1","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ede68dbcac2f0487f25fd962831f41effa1be7ca","unresolved":true,"context_lines":[{"line_number":254,"context_line":"        mac \u003d \u0027ca:fe:de:ad:be:ef\u0027"},{"line_number":255,"context_line":"        iface_id \u003d \u0027631f52bc-3a07-11ef-a006-1319ef9d6edd\u0027"},{"line_number":256,"context_line":"        vif_name \u003d \u0027port-%s\u0027 % iface_id[:8]"},{"line_number":257,"context_line":"        bridge_name \u003d \u0027br-int\u0027"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        network \u003d objects.network.Network("},{"line_number":260,"context_line":"            id\u003d\u0027122adbca-3181-11f0-a71a-d77963ddf6d6\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bc7cf3d1_cb5ace76","line":257,"updated":"2025-05-19 14:23:36.000000000","message":"same here  iface_id shoudl be unique\n\ni think we coudl also use a uniq bridge name the imporant thing\nis that it does not match the trunk prefix not that its called br-int","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e3715bf1723d05bdb287ceee75908ee21713fab3","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        mac \u003d \u0027ca:fe:de:ad:be:ef\u0027"},{"line_number":255,"context_line":"        iface_id \u003d \u0027631f52bc-3a07-11ef-a006-1319ef9d6edd\u0027"},{"line_number":256,"context_line":"        vif_name \u003d \u0027port-%s\u0027 % iface_id[:8]"},{"line_number":257,"context_line":"        bridge_name \u003d \u0027br-int\u0027"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        network \u003d objects.network.Network("},{"line_number":260,"context_line":"            id\u003d\u0027122adbca-3181-11f0-a71a-d77963ddf6d6\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c4ee78f4_dda284a8","line":257,"in_reply_to":"bc7cf3d1_cb5ace76","updated":"2025-05-20 13:17:50.000000000","message":"Done","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf2cf8cd7bf155a2c4c490c97106a07a28f943f","unresolved":true,"context_lines":[{"line_number":269,"context_line":"            vif_name\u003dvif_name)"},{"line_number":270,"context_line":"        self.plugin.plug(vif, self.instance)"},{"line_number":271,"context_line":"        self.addCleanup(self._del_bridge, bridge_name)"},{"line_number":272,"context_line":"        expected_external_ids \u003d {"},{"line_number":273,"context_line":"            \u0027attached-mac\u0027: mac,"},{"line_number":274,"context_line":"            # bridge_name is filled only in case of trunk plug"},{"line_number":275,"context_line":"            # \u0027bridge_name\u0027: bridge_name,"},{"line_number":276,"context_line":"            \u0027iface-id\u0027: self.profile_ovs.interface_id,"},{"line_number":277,"context_line":"            \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":278,"context_line":"            \u0027vm-uuid\u0027: self.instance.uuid,"},{"line_number":279,"context_line":"        }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self._check_parameter(\u0027Interface\u0027, vif.vif_name,"},{"line_number":282,"context_line":"                              \u0027external_ids\u0027, expected_external_ids)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2883a8e_7204325b","line":279,"range":{"start_line":272,"start_character":8,"end_line":279,"end_character":9},"updated":"2025-05-16 07:39:06.000000000","message":"nit: i would prefer to do this as follows\n\n```suggestion\n        # bridge_name is filled only in case of trunk plug\n        expected_external_ids \u003d {\n            \u0027attached-mac\u0027: mac,\n            \u0027iface-id\u0027: self.profile_ovs.interface_id,\n            \u0027iface-status\u0027: \u0027active\u0027,\n            \u0027vm-uuid\u0027: self.instance.uuid,\n        }\n```","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e3715bf1723d05bdb287ceee75908ee21713fab3","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            vif_name\u003dvif_name)"},{"line_number":270,"context_line":"        self.plugin.plug(vif, self.instance)"},{"line_number":271,"context_line":"        self.addCleanup(self._del_bridge, bridge_name)"},{"line_number":272,"context_line":"        expected_external_ids \u003d {"},{"line_number":273,"context_line":"            \u0027attached-mac\u0027: mac,"},{"line_number":274,"context_line":"            # bridge_name is filled only in case of trunk plug"},{"line_number":275,"context_line":"            # \u0027bridge_name\u0027: bridge_name,"},{"line_number":276,"context_line":"            \u0027iface-id\u0027: self.profile_ovs.interface_id,"},{"line_number":277,"context_line":"            \u0027iface-status\u0027: \u0027active\u0027,"},{"line_number":278,"context_line":"            \u0027vm-uuid\u0027: self.instance.uuid,"},{"line_number":279,"context_line":"        }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self._check_parameter(\u0027Interface\u0027, vif.vif_name,"},{"line_number":282,"context_line":"                              \u0027external_ids\u0027, expected_external_ids)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d55c319c_cf0e0406","line":279,"range":{"start_line":272,"start_character":8,"end_line":279,"end_character":9},"in_reply_to":"e2883a8e_7204325b","updated":"2025-05-20 13:17:50.000000000","message":"Done","commit_id":"d86c41b59942bf3aacffa6082879c27e3c5b98cd"}],"vif_plug_ovs/tests/unit/ovsdb/test_ovsdb_lib.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3563cc6fa0e3b3617648a8cbec029c7a324c805","unresolved":true,"context_lines":[{"line_number":137,"context_line":"    def test_create_ovs_vif_port_for_trunk(self):"},{"line_number":138,"context_line":"        self._test_create_ovs_vif_port(bridge_name\u003d\u0027tbr-12345\u0027,"},{"line_number":139,"context_line":"                                       check_br_name\u003dTrue)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_create_ovs_vif_port_type_dpdk(self):"},{"line_number":142,"context_line":"        iface_id \u003d \u0027iface_id\u0027"},{"line_number":143,"context_line":"        mac \u003d \u0027ca:fe:ca:fe:ca:fe\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"4ff0432e_fc57e490","line":140,"updated":"2025-05-14 14:23:01.000000000","message":"we do have functional test for trunk prots too.\n\nhttps://github.com/openstack/os-vif/blob/master/vif_plug_ovs/tests/functional/test_plugin.py#L205\n\nit might make sense to add a seocn otone to assert the bridge_name is set in the external ids","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5bf2cf8cd7bf155a2c4c490c97106a07a28f943f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    def test_create_ovs_vif_port_for_trunk(self):"},{"line_number":138,"context_line":"        self._test_create_ovs_vif_port(bridge_name\u003d\u0027tbr-12345\u0027,"},{"line_number":139,"context_line":"                                       check_br_name\u003dTrue)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_create_ovs_vif_port_type_dpdk(self):"},{"line_number":142,"context_line":"        iface_id \u003d \u0027iface_id\u0027"},{"line_number":143,"context_line":"        mac \u003d \u0027ca:fe:ca:fe:ca:fe\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd7e32_1c9bb964","line":140,"in_reply_to":"33ef8363_cda197dd","updated":"2025-05-16 07:39:06.000000000","message":"Done","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"56e7edc42dc0e5ccdec0660990960d586c3997da","unresolved":true,"context_lines":[{"line_number":137,"context_line":"    def test_create_ovs_vif_port_for_trunk(self):"},{"line_number":138,"context_line":"        self._test_create_ovs_vif_port(bridge_name\u003d\u0027tbr-12345\u0027,"},{"line_number":139,"context_line":"                                       check_br_name\u003dTrue)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_create_ovs_vif_port_type_dpdk(self):"},{"line_number":142,"context_line":"        iface_id \u003d \u0027iface_id\u0027"},{"line_number":143,"context_line":"        mac \u003d \u0027ca:fe:ca:fe:ca:fe\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"33ef8363_cda197dd","line":140,"in_reply_to":"4ff0432e_fc57e490","updated":"2025-05-15 11:59:55.000000000","message":"thanks I added functional tests also.","commit_id":"ad25baf4ff9d57009e6053ac0c11dc8b258bfb34"}]}