)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95ef0afbbd89a50d255d1a1500c77a5c63c79a80","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Call port_exists() with the right bridge name. When per_port_bridge is"},{"line_number":10,"context_line":"enabled, br-int was used instead of the dedicated bridge. Fixes OVSDB"},{"line_number":11,"context_line":"errors in nova-compute logs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifcaeb1e2270c77a8806ee122903ae46440736c60"},{"line_number":14,"context_line":"Signed-off-by: Adrien Cunin \u003ca.cunin@syseleven.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"991ddb4c_d6853824","line":12,"updated":"2025-11-07 13:47:07.000000000","message":"you shoudl file a bug and add\n\nCloses-Bug: #\u003cbug number\u003e","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c5f3984f2d4c456305d6ba574730f0b20fd2a9d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Call port_exists() with the right bridge name. When per_port_bridge is"},{"line_number":10,"context_line":"enabled, br-int was used instead of the dedicated bridge. Fixes OVSDB"},{"line_number":11,"context_line":"errors in nova-compute logs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifcaeb1e2270c77a8806ee122903ae46440736c60"},{"line_number":14,"context_line":"Signed-off-by: Adrien Cunin \u003ca.cunin@syseleven.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c7e5d440_7f3857db","line":12,"in_reply_to":"7e704dc7_89cd68aa","updated":"2026-01-08 17:26:36.000000000","message":"Done","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"},{"author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"change_message_id":"b5bcffcea8fc7a71bf3570581fe217b1e3615006","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Call port_exists() with the right bridge name. When per_port_bridge is"},{"line_number":10,"context_line":"enabled, br-int was used instead of the dedicated bridge. Fixes OVSDB"},{"line_number":11,"context_line":"errors in nova-compute logs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifcaeb1e2270c77a8806ee122903ae46440736c60"},{"line_number":14,"context_line":"Signed-off-by: Adrien Cunin \u003ca.cunin@syseleven.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7e704dc7_89cd68aa","line":12,"in_reply_to":"991ddb4c_d6853824","updated":"2025-11-28 14:59:02.000000000","message":"Here is the bug report: https://bugs.launchpad.net/os-vif/+bug/2133225","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"change_message_id":"3d5bdd4d21bb425f6eeb677373dc87d7c17c18b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc02cebf_f1503157","updated":"2025-11-07 13:22:14.000000000","message":"recheck instance in devstack kernel panic","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a06611487e177ff6fac7cca239c9af03f867e012","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a125e8f_bce0e7b0","updated":"2025-11-07 13:52:19.000000000","message":"slawek rodolfo ye were looking at some os-vif bugs a while ago so just an fyi","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"586b61a2506360bcbee172eedba81d4c5e6d4dae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"94450065_1fdf09c4","updated":"2026-01-07 12:27:04.000000000","message":"recheck","commit_id":"7dbe1ed2c445130df868b4780790c2492e69fe73"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9db058dcfa9d5f9ba2b7520262e9fce5bd29bd4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b11e4c9a_49053e60","updated":"2026-01-09 16:54:32.000000000","message":"Nice catch and good FT test","commit_id":"d5cbedafd2088dbc35ed1a09f1be7d96000b2310"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"b2458081073c552135676aadfbc8e2d943fc0c5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41991ef1_664fb793","updated":"2026-01-15 12:18:16.000000000","message":"Test failures are not related to the change. The error in test_plug_unplug_ovs_port_with_qos is probably related to https://bugs.launchpad.net/os-vif/+bug/2087982 where I added another patch https://review.opendev.org/c/openstack/os-vif/+/973455 to hopefully fix the tests","commit_id":"d5cbedafd2088dbc35ed1a09f1be7d96000b2310"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"8a7ab1cb31666dc72b924ebc346dcbe55a11fe8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a8e3c8e_4553fafc","updated":"2026-01-15 10:14:27.000000000","message":"recheck","commit_id":"d5cbedafd2088dbc35ed1a09f1be7d96000b2310"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"6ef870ab31d6fca0a3d0ce94d83611765fcb9fa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5776995_ea06bd20","updated":"2026-01-12 09:20:20.000000000","message":"recheck","commit_id":"d5cbedafd2088dbc35ed1a09f1be7d96000b2310"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"e1d279059d4aec4c5de54eedbbc5279aa98c07cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bdc5d06c_63a89320","updated":"2026-01-14 09:42:40.000000000","message":"recheck","commit_id":"d5cbedafd2088dbc35ed1a09f1be7d96000b2310"},{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"b65035bda7da66a45262438fb11a27ca0b76a82b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1eff3bda_0cddd868","updated":"2026-01-19 14:46:50.000000000","message":"I\u0027d appreciate a fresh \"Workflow +1\" as the original one was removed with the rebase.","commit_id":"1c0a7416cf201bab08491d31fe639d694bd2fb21"}],"vif_plug_ovs/ovs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95ef0afbbd89a50d255d1a1500c77a5c63c79a80","unresolved":true,"context_lines":[{"line_number":223,"context_line":"            # This is a mitigation for the performance regression"},{"line_number":224,"context_line":"            # introduced by the fix for bug #1734320. See bug #2017868"},{"line_number":225,"context_line":"            # for more details."},{"line_number":226,"context_line":"            if not self.ovsdb.port_exists(vif_name, bridge):"},{"line_number":227,"context_line":"                kwargs[\u0027qos_type\u0027] \u003d qos_type"},{"line_number":228,"context_line":"        self.ovsdb.create_ovs_vif_port("},{"line_number":229,"context_line":"            bridge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e42d23bc_b53d4bd8","line":226,"updated":"2025-11-07 13:47:07.000000000","message":"i belive this is correct but you need to add unit test coverage at a miniume and ideally fucntional tests to verify the behvior.\n\n\nwe also need to conside rthe case wehn we are doing hybrid plug vs directlly additn the interface to the integration brdige.\n\nthis code is used for all ovs backends includign OVN.\n\ni belive this chagne is specific to ensure this work for ml2/ovs\n\nfor ml2/ovn the port bridge name shoudl alwasy be the same as the intergation bridge or vif.network.bridge.","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c5f3984f2d4c456305d6ba574730f0b20fd2a9d","unresolved":true,"context_lines":[{"line_number":223,"context_line":"            # This is a mitigation for the performance regression"},{"line_number":224,"context_line":"            # introduced by the fix for bug #1734320. See bug #2017868"},{"line_number":225,"context_line":"            # for more details."},{"line_number":226,"context_line":"            if not self.ovsdb.port_exists(vif_name, bridge):"},{"line_number":227,"context_line":"                kwargs[\u0027qos_type\u0027] \u003d qos_type"},{"line_number":228,"context_line":"        self.ovsdb.create_ovs_vif_port("},{"line_number":229,"context_line":"            bridge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4dcf2d88_4ec9f269","line":226,"in_reply_to":"4d2b934a_ac560409","updated":"2026-01-08 17:26:36.000000000","message":"the bug is now filed but we are still missing a unit test for this.\ni.e. to ensure that we use the correct bridge name.\n\nhttps://a2cc1a309397fb00e30f-b6afd4e7a056a6cd7e33e9056366401b.ssl.cf2.rackcdn.com/openstack/f9bc4ebc08e44fa68bcfcfb054fae20f/cover/z_11d94c8e9c040576_ovs_py.html#t226\n\n\ncan you add a test for \n\n_create_vif_port and mock port_exists and assert its called with the correct port and bridge name.","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dbd9b2aec26f5a05a32e2147a8a1139064106a1c","unresolved":true,"context_lines":[{"line_number":223,"context_line":"            # This is a mitigation for the performance regression"},{"line_number":224,"context_line":"            # introduced by the fix for bug #1734320. See bug #2017868"},{"line_number":225,"context_line":"            # for more details."},{"line_number":226,"context_line":"            if not self.ovsdb.port_exists(vif_name, bridge):"},{"line_number":227,"context_line":"                kwargs[\u0027qos_type\u0027] \u003d qos_type"},{"line_number":228,"context_line":"        self.ovsdb.create_ovs_vif_port("},{"line_number":229,"context_line":"            bridge,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d2b934a_ac560409","line":226,"in_reply_to":"e42d23bc_b53d4bd8","updated":"2025-11-07 13:50:38.000000000","message":"for ml2/ovs with the iptabels drvier it may also be worng cosndierign ensuring that the linux bridge side fof the veth pair does not ahve a qdisc applied but whether we need to do that or not partly depend on what behvior you are currently seeing.\n\nthis is imporant to capture in a bug report so we can understand exactly what you are tryign to fix.\n\nhttps://bugs.launchpad.net/os-vif/+filebug\n\nwe will also likely want to have a release note but we can determin that once we triage the bug.","commit_id":"ccf1451638105ae1a9869390286f1f5bc706b3dd"}],"vif_plug_ovs/tests/functional/test_plugin.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c5f3984f2d4c456305d6ba574730f0b20fd2a9d","unresolved":true,"context_lines":[{"line_number":187,"context_line":"        )"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_plug_unplug_ovs_port_with_qos_per_port_bridge(self):"},{"line_number":190,"context_line":"        with mock.patch.object(self.plugin.config, \u0027per_port_bridge\u0027, True):"},{"line_number":191,"context_line":"            bridge \u003d \u0027br-ppb-\u0027 + self.interface"},{"line_number":192,"context_line":"            vif_name \u003d \u0027port-ppb-\u0027 + self.interface"},{"line_number":193,"context_line":"            qos_type \u003d CONF.os_vif_ovs.default_qos_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"be0fb461_0586e494","line":190,"updated":"2026-01-08 17:26:36.000000000","message":"nit: hum so this is not how you correctly set config options in tests.\n\nwe have a flags help for this which use oslo functions for overriding the defuals\n\nself.flags(per_port_bridge\u003dTrue, group\u003d\u0027os_vif_ovs\u0027)\n\nbut we also are incorrectly patching the config in other test so i guess this is ok.\n\nthere are edgecase where the mock approch wont work properly but in this specific case it should be ok.\n\ni think im fine with cleaning this up independently form your change.","commit_id":"7dbe1ed2c445130df868b4780790c2492e69fe73"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3c5f3984f2d4c456305d6ba574730f0b20fd2a9d","unresolved":true,"context_lines":[{"line_number":241,"context_line":"            self.assertFalse(self._check_port(vif_name, bridge))"},{"line_number":242,"context_line":"            self._check_parameter("},{"line_number":243,"context_line":"                \u0027QoS\u0027, str(qos_uuid), \u0027type\u0027, None"},{"line_number":244,"context_line":"            )"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def test_plug_br_int_isolate_vif_dead_vlan(self):"},{"line_number":247,"context_line":"        with mock.patch.object(self.plugin.config, \u0027isolate_vif\u0027, True):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f84a5f6b_923c39a3","line":244,"updated":"2026-01-08 17:26:36.000000000","message":"over all i think im happy with this test.","commit_id":"7dbe1ed2c445130df868b4780790c2492e69fe73"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9db058dcfa9d5f9ba2b7520262e9fce5bd29bd4d","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            # if they don\u0027t exist"},{"line_number":218,"context_line":"            self.plugin.plug(vif, self.instance)"},{"line_number":219,"context_line":"            self.assertTrue(self._check_bridge(bridge))"},{"line_number":220,"context_line":"            self.assertTrue(self._check_bridge(port_bridge_name))"},{"line_number":221,"context_line":"            self.assertTrue(self._check_port(vif_name, port_bridge_name))"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"            # Plugging a second time should succeed"}],"source_content_type":"text/x-python","patch_set":4,"id":"6af53248_4a2cacb3","line":220,"range":{"start_line":220,"start_character":12,"end_line":220,"end_character":65},"updated":"2026-01-09 16:54:32.000000000","message":"nice to see this check","commit_id":"d5cbedafd2088dbc35ed1a09f1be7d96000b2310"}]}