)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e4f50dfc668ad7ad44fcf954958f84591f99ecf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df3a5188_eb62cae6","updated":"2026-07-14 15:11:43.000000000","message":"This looks OK to me, thanks","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd2cbb8858cc02d1d8269e8f3fe0f751542895d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afc4ab2a_69296e87","updated":"2026-07-14 17:09:32.000000000","message":"actully it would likely be bettter to fix this sepreatly on master first then just rebase this patch as it is\nhttps://zuul.opendev.org/t/openstack/build/80e8f97b6c0a41eb87d759156b705318/log/job-output.txt#3306 \n\nthe failure are not in the filies you are modifying","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"134d24ef290508bb1ac237bbe3f9ea3f61dc1b12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e392a8d_715cdb68","updated":"2026-07-14 17:02:59.000000000","message":"i guess there may have been a mypy release or simialr in the last week\n\nit was passing on the 2026-07-03 in check but its failing now.","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"20ff334b17d59fe1cb43fd6b0233fd544805efb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df1bc2aa_4a7dab48","updated":"2026-07-14 17:06:33.000000000","message":"proably the best path forward is to rebase this to the tip of master to ensure you have all the mypy changes (you should as this was wrritten after they merged and resolve the missing type defs","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc21641ac307e8b78409982b05531acfc2d7742c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5b267f8_5f369610","in_reply_to":"afc4ab2a_69296e87","updated":"2026-07-14 20:02:35.000000000","message":"https://review.opendev.org/c/openstack/os-vif/+/997289 shoudl reslove the issues then we can proceed with this again","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"fdd14a1490072fb9530d2037fd5c17ec8b9e578c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4375437_7099ed8a","updated":"2026-10-09 07:50:22.000000000","message":"Greetings,\nI just found this because I am testing the 2026.1 upgrade. In 2026.1 setting `ovs_create_tap \u003d true` in neutron with multi queue enabled breacks vm creation.\n\nCan this potentially be backported to fix the 2026.1 branch?","commit_id":"8f2d2cc92d6f79c85e03e52d61b0f71d08a0cca2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51db1c3deadaf90b344aac01255ffb6358fcc715","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73d63e03_6eb80958","in_reply_to":"a4375437_7099ed8a","updated":"2026-10-09 14:15:56.000000000","message":"yes it a viable candidate for abckport i \nnot that in 2026.1 ovs_create_tap is false by default and opting in to new configuratoin is a post upgrade task \n\nhttps://opendev.org/openstack/grenade/src/branch/master/README.rst?display\u003dsource#L31-L38\n\nso this is not a upgrade related but.\n\nit is a bug in a new feature when combined with multi queue\n\nthe backport is valid because the feature was added in 2026.1 it would not be valid to backport this futher then that without a stable branch exception.\n\nthis merged on master when master was sill 2026.2 sot 2026.1 would be the first and only backprot branc","commit_id":"8f2d2cc92d6f79c85e03e52d61b0f71d08a0cca2"}],"os_vif/internal/ip/linux/impl_pyroute2.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"55009f6bd4aa7e16a8b8ec0bda947d4adc0e9758","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                tap_mode \u003d mode if mode else \u0027tap\u0027"},{"line_number":133,"context_line":"                args[\u0027mode\u0027] \u003d tap_mode"},{"line_number":134,"context_line":"                if multiqueue:"},{"line_number":135,"context_line":"                    # Enable multiqueue if requested"},{"line_number":136,"context_line":"                    # This sets the IFF_MULTI_QUEUE flag in IFTUN_IFR"},{"line_number":137,"context_line":"                    args[\u0027ifr\u0027] \u003d {\u0027multi_queue\u0027: True}"},{"line_number":138,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ccb8819f_799bbd3f","line":135,"updated":"2026-07-03 11:28:00.000000000","message":"nit: im not sure why this moved  we normally explain the iff before its taken but its ifne","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bd8f30e12b9d1519958af42ee52b9e6aa39467d7","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                tap_mode \u003d mode if mode else \u0027tap\u0027"},{"line_number":133,"context_line":"                args[\u0027mode\u0027] \u003d tap_mode"},{"line_number":134,"context_line":"                if multiqueue:"},{"line_number":135,"context_line":"                    # Enable multiqueue if requested"},{"line_number":136,"context_line":"                    # This sets the IFF_MULTI_QUEUE flag in IFTUN_IFR"},{"line_number":137,"context_line":"                    args[\u0027ifr\u0027] \u003d {\u0027multi_queue\u0027: True}"},{"line_number":138,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c476f37_ea3e2fa3","line":135,"in_reply_to":"ccb8819f_799bbd3f","updated":"2026-07-03 12:39:49.000000000","message":"Claude removed this comment (I don\u0027t know why) and I restored it but in the incorrect place...","commit_id":"f5e6dd0776da0cce47a79de763d8ca1a849b5b49"}]}
