)]}'
{"os_win/exceptions.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"955b894386a5e979328a07ed4e306ebe0f1bae49","unresolved":false,"context_lines":[{"line_number":60,"context_line":"class Win32Exception(OSWinException):"},{"line_number":61,"context_line":"    msg_fmt \u003d _(\"Executing Win32 API function %(func_name)s failed. \""},{"line_number":62,"context_line":"                \"Error code: %(error_code)s. \""},{"line_number":63,"context_line":"                \"Error message: %(error_message)s\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":66,"context_line":"        self.error_code \u003d kwargs.get(\u0027error_code\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_4283a804","line":63,"updated":"2016-01-04 16:42:17.000000000","message":"why remove the \u0027.\u0027 at the end?","commit_id":"4cdd8b0c4798c16fb520ff5718e3a1e3c870f746"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f8a3fd9735726fb41952778b8644d82df9b3e3dc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"class Win32Exception(OSWinException):"},{"line_number":61,"context_line":"    msg_fmt \u003d _(\"Executing Win32 API function %(func_name)s failed. \""},{"line_number":62,"context_line":"                \"Error code: %(error_code)s. \""},{"line_number":63,"context_line":"                \"Error message: %(error_message)s\")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":66,"context_line":"        self.error_code \u003d kwargs.get(\u0027error_code\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_8eae8d96","line":63,"in_reply_to":"fa69d971_4283a804","updated":"2016-01-05 08:49:38.000000000","message":"The error message (which is most likely retrieved and not set by us) will already contain a \u0027.\u0027, so we avoid having two of them.","commit_id":"4cdd8b0c4798c16fb520ff5718e3a1e3c870f746"}],"os_win/tests/test_utilsfactory.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3e0d6ae5c1790c822774377de439b8409d88f4b5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                              class_type\u003d\u0027rdpconsoleutils\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils, \u0027__init__\u0027,"},{"line_number":98,"context_line":"                       lambda *args, **kwargs: None)"},{"line_number":99,"context_line":"    def test_get_iscsi_initiator_utils(self):"},{"line_number":100,"context_line":"        self._test_get_initiator_utils("},{"line_number":101,"context_line":"            expected_class\u003discsi_utils.ISCSIInitiatorUtils)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_6376c7d8","line":98,"updated":"2016-01-11 10:43:08.000000000","message":"don\u0027t think this is necessary anymore? It should have been fixed by inheriting test_base.OsWinBaseTestCase. Can you check pls?","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9abd50d076d7863afa54bcbd3594edfd90eff750","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                              class_type\u003d\u0027rdpconsoleutils\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils, \u0027__init__\u0027,"},{"line_number":98,"context_line":"                       lambda *args, **kwargs: None)"},{"line_number":99,"context_line":"    def test_get_iscsi_initiator_utils(self):"},{"line_number":100,"context_line":"        self._test_get_initiator_utils("},{"line_number":101,"context_line":"            expected_class\u003discsi_utils.ISCSIInitiatorUtils)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_391d5fbe","line":98,"in_reply_to":"fa69d971_6376c7d8","updated":"2016-01-11 11:08:32.000000000","message":"WMI is not the issue here. It\u0027s about the methods beeing called in the costructor.","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"}],"os_win/tests/utils/storage/initiator/test_iscsi_struct.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3e0d6ae5c1790c822774377de439b8409d88f4b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Cloudbase Solutions Srl"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_3e98e8bf","line":2,"updated":"2016-01-11 10:43:08.000000000","message":"rename file to test_iscsidsc_structures?","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9abd50d076d7863afa54bcbd3594edfd90eff750","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Cloudbase Solutions Srl"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_5971330b","line":2,"in_reply_to":"fa69d971_3e98e8bf","updated":"2016-01-11 11:08:32.000000000","message":"Done","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"}],"os_win/tests/utils/storage/initiator/test_iscsi_utils.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3e0d6ae5c1790c822774377de439b8409d88f4b5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            self._win32utils \u003d mock.Mock()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        with mock.patch.object(iscsi_utils.ISCSIInitiatorUtils, \u0027__init__\u0027,"},{"line_number":40,"context_line":"                               mock_init):"},{"line_number":41,"context_line":"            self._initiator \u003d iscsi_utils.ISCSIInitiatorUtils()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self._iscsidsc \u003d mock.patch.object("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_9e8554d0","line":40,"updated":"2016-01-11 10:43:08.000000000","message":"shouldn\u0027t be necessary, since you inherit test_base.OsWinBaseTestCase? Can you check? At the very least, this mock.patch can be put as a decorator, and have self._iscsidsc._win32utils \u003d mock.Mock() in here.","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3e0d6ae5c1790c822774377de439b8409d88f4b5","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        mock_win32utils_run_and_check_output.assert_called_once_with("},{"line_number":254,"context_line":"            error_msg_src\u003discsierr.err_msg_dict)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_add_target_portal(self, login_opts\u003dTrue):"},{"line_number":257,"context_line":"        self._mock_ctypes()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self._initiator._add_target_portal(mock.sentinel.portal,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_34224753","line":256,"updated":"2016-01-11 10:43:08.000000000","message":"login_opts should be None or something else instead of bool.","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9abd50d076d7863afa54bcbd3594edfd90eff750","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        mock_win32utils_run_and_check_output.assert_called_once_with("},{"line_number":254,"context_line":"            error_msg_src\u003discsierr.err_msg_dict)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _test_add_target_portal(self, login_opts\u003dTrue):"},{"line_number":257,"context_line":"        self._mock_ctypes()"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self._initiator._add_target_portal(mock.sentinel.portal,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_199bbb19","line":256,"in_reply_to":"fa69d971_34224753","updated":"2016-01-11 11:08:32.000000000","message":"Done","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3e0d6ae5c1790c822774377de439b8409d88f4b5","unresolved":false,"context_lines":[{"line_number":618,"context_line":""},{"line_number":619,"context_line":"        if not auth_type:"},{"line_number":620,"context_line":"            expected_auth_type \u003d (constants.ISCSI_CHAP_AUTH_TYPE"},{"line_number":621,"context_line":"                                  if not auth_type and creds_specified"},{"line_number":622,"context_line":"                                  else constants.ISCSI_NO_AUTH_TYPE)"},{"line_number":623,"context_line":"        else:"},{"line_number":624,"context_line":"            expected_auth_type \u003d auth_type"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_943d33df","line":621,"updated":"2016-01-11 10:43:08.000000000","message":"if not auth_type is already checked.","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9abd50d076d7863afa54bcbd3594edfd90eff750","unresolved":false,"context_lines":[{"line_number":618,"context_line":""},{"line_number":619,"context_line":"        if not auth_type:"},{"line_number":620,"context_line":"            expected_auth_type \u003d (constants.ISCSI_CHAP_AUTH_TYPE"},{"line_number":621,"context_line":"                                  if not auth_type and creds_specified"},{"line_number":622,"context_line":"                                  else constants.ISCSI_NO_AUTH_TYPE)"},{"line_number":623,"context_line":"        else:"},{"line_number":624,"context_line":"            expected_auth_type \u003d auth_type"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_f9bca76d","line":621,"in_reply_to":"fa69d971_943d33df","updated":"2016-01-11 11:08:32.000000000","message":"Done","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                          self._initiator)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":157,"context_line":"    def test_retry_decorator(self, mock_sleep):"},{"line_number":158,"context_line":"        err_code \u003d 1"},{"line_number":159,"context_line":"        max_retry_count \u003d 5"},{"line_number":160,"context_line":"        retry_interval \u003d 1"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_cfc2e884","line":157,"updated":"2016-02-08 16:50:17.000000000","message":"test_retry_for_err_codes_decorator","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                          self._initiator)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @mock.patch(\u0027time.sleep\u0027)"},{"line_number":157,"context_line":"    def test_retry_decorator(self, mock_sleep):"},{"line_number":158,"context_line":"        err_code \u003d 1"},{"line_number":159,"context_line":"        max_retry_count \u003d 5"},{"line_number":160,"context_line":"        retry_interval \u003d 1"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_f0f19b02","line":157,"in_reply_to":"5a5ae5dd_cfc2e884","updated":"2016-02-09 10:01:57.000000000","message":"Done","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                       \u0027_get_iscsi_target_sessions\u0027)"},{"line_number":598,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":599,"context_line":"                       \u0027_session_on_path_exists\u0027)"},{"line_number":600,"context_line":"    def _test_check_new_session_required(self, mock_session_on_path_exists,"},{"line_number":601,"context_line":"                                         mock_get_iscsi_target_sessions,"},{"line_number":602,"context_line":"                                         sessions\u003dNone,"},{"line_number":603,"context_line":"                                         mpio_enabled\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_94b88912","line":600,"updated":"2016-02-08 16:50:17.000000000","message":"how about _check_new_session_required instead?","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                       \u0027_get_iscsi_target_sessions\u0027)"},{"line_number":598,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":599,"context_line":"                       \u0027_session_on_path_exists\u0027)"},{"line_number":600,"context_line":"    def _test_check_new_session_required(self, mock_session_on_path_exists,"},{"line_number":601,"context_line":"                                         mock_get_iscsi_target_sessions,"},{"line_number":602,"context_line":"                                         sessions\u003dNone,"},{"line_number":603,"context_line":"                                         mpio_enabled\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_b0f803c6","line":600,"in_reply_to":"5a5ae5dd_94b88912","updated":"2016-02-09 10:01:57.000000000","message":"Well, I\u0027ve left \u0027test\u0027 in the method name as it\u0027s actually a test helper, making some assertions.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                mock.sentinel.portal_port,"},{"line_number":623,"context_line":"                mock.sentinel.initiator_name)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_check_new_session_required_no_sessions(self):"},{"line_number":626,"context_line":"        self._test_check_new_session_required()"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def test_check_new_session_required_existing_sessions_no_mpio(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_546451b7","line":625,"updated":"2016-02-08 16:50:17.000000000","message":"how about test_new_session_required_exiting_sessions_no_mpio? the tested method is called _new_session_required anyways.\n\nditto all below.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                mock.sentinel.portal_port,"},{"line_number":623,"context_line":"                mock.sentinel.initiator_name)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    def test_check_new_session_required_no_sessions(self):"},{"line_number":626,"context_line":"        self._test_check_new_session_required()"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def test_check_new_session_required_existing_sessions_no_mpio(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_b01fa308","line":625,"in_reply_to":"5a5ae5dd_546451b7","updated":"2016-02-09 10:01:57.000000000","message":"Done","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def test_login_storage_target_path_exists(self):"},{"line_number":714,"context_line":"        self._test_login_storage_target(login_required\u003dFalse)"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    def test_login_new_storage_target_no_mpio(self):"},{"line_number":717,"context_line":"        self._test_login_storage_target()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def test_login_storage_target_new_path_using_mpio(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_147ed969","line":716,"updated":"2016-02-08 16:50:17.000000000","message":"test_login_new_storage_target_login_required?","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def test_login_storage_target_path_exists(self):"},{"line_number":714,"context_line":"        self._test_login_storage_target(login_required\u003dFalse)"},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"    def test_login_new_storage_target_no_mpio(self):"},{"line_number":717,"context_line":"        self._test_login_storage_target()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def test_login_storage_target_new_path_using_mpio(self):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_f0dbdb4d","line":716,"in_reply_to":"5a5ae5dd_147ed969","updated":"2016-02-09 10:01:57.000000000","message":"login is required in other cases as well, wanted to highlight the fact that in this case, mpio is not used.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        self._test_login_storage_target()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def test_login_storage_target_new_path_using_mpio(self):"},{"line_number":720,"context_line":"        self._test_login_storage_target(mpio_enabled\u003dTrue)"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":723,"context_line":"                       \u0027_get_iscsi_device_from_session\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_f4553df9","line":720,"updated":"2016-02-08 16:50:17.000000000","message":"mpio flag is not used in any way in the tested method, except that it\u0027s being passed in _new_session_required, which is already mocked. I\u0027d say this test is pointless.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        self._test_login_storage_target()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    def test_login_storage_target_new_path_using_mpio(self):"},{"line_number":720,"context_line":"        self._test_login_storage_target(mpio_enabled\u003dTrue)"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":723,"context_line":"                       \u0027_get_iscsi_device_from_session\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_90c4e75f","line":720,"in_reply_to":"5a5ae5dd_f4553df9","updated":"2016-02-09 10:01:57.000000000","message":"It\u0027s passed to \u0027login_storage_target\u0027 and we want to check the flags it\u0027s using in this case.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":736,"context_line":"            mock.PropertyMock(side_effect\u003ddev_num_side_eff))"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        mock_get_dev_side_eff \u003d [None] + [fake_device] * 3"},{"line_number":739,"context_line":"        mock_get_iscsi_device_from_session.side_effect \u003d mock_get_dev_side_eff"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        self._initiator.ensure_lun_available("},{"line_number":742,"context_line":"            mock.sentinel.target_iqn,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_59f48a59","line":739,"updated":"2016-02-08 16:50:17.000000000","message":"would be nice to also include an ISCSIInitiatorAPIException as a side_effect.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":736,"context_line":"            mock.PropertyMock(side_effect\u003ddev_num_side_eff))"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        mock_get_dev_side_eff \u003d [None] + [fake_device] * 3"},{"line_number":739,"context_line":"        mock_get_iscsi_device_from_session.side_effect \u003d mock_get_dev_side_eff"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"        self._initiator.ensure_lun_available("},{"line_number":742,"context_line":"            mock.sentinel.target_iqn,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_30a093a5","line":739,"in_reply_to":"5a5ae5dd_59f48a59","updated":"2016-02-09 10:01:57.000000000","message":"Done","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"510e9d4096169a4f1ce383a915730da3ef82215e","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                       mock.sentinel.target_lun)] * 3)"},{"line_number":751,"context_line":"        self.assertEqual("},{"line_number":752,"context_line":"            3,"},{"line_number":753,"context_line":"            self._initiator._diskutils.rescan_disks.call_count)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":756,"context_line":"                       \u0027_get_iscsi_target_sessions\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_9971a20e","line":753,"updated":"2016-02-08 16:50:17.000000000","message":"could be on the previous line, IMO, but it is a femto nit. Fix if you\u0027re going to send another PS.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"c9e46d8f615ddd8078106f23f5d725c0d3e02319","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                       mock.sentinel.target_lun)] * 3)"},{"line_number":751,"context_line":"        self.assertEqual("},{"line_number":752,"context_line":"            3,"},{"line_number":753,"context_line":"            self._initiator._diskutils.rescan_disks.call_count)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":756,"context_line":"                       \u0027_get_iscsi_target_sessions\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_f080bbf9","line":753,"in_reply_to":"5a5ae5dd_9971a20e","updated":"2016-02-09 10:01:57.000000000","message":"This way, it seemed easier to read.","commit_id":"07f822115cd38a12342f432294847b460af21dff"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"167f548053bfc211bef155c127335af0ca31d15b","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                       mock.sentinel.target_lun)] * 3)"},{"line_number":751,"context_line":"        self.assertEqual("},{"line_number":752,"context_line":"            3,"},{"line_number":753,"context_line":"            self._initiator._diskutils.rescan_disks.call_count)"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    @mock.patch.object(iscsi_utils.ISCSIInitiatorUtils,"},{"line_number":756,"context_line":"                       \u0027_get_iscsi_target_sessions\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_6b084c92","line":753,"in_reply_to":"5a5ae5dd_f080bbf9","updated":"2016-02-09 14:46:51.000000000","message":"Don\u0027t really agree, but it doesn\u0027t matter. :)","commit_id":"07f822115cd38a12342f432294847b460af21dff"}],"os_win/utils/storage/initiator/iscsi_utils.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"3e0d6ae5c1790c822774377de439b8409d88f4b5","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        self._ensure_lun_available(sid, target_iqn, target_lun)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _ensure_lun_available(self, session_id, target_iqn, target_lun):"},{"line_number":407,"context_line":"        @loopingcall.RetryDecorator(max_retry_count\u003d5, max_sleep_time\u003d3,"},{"line_number":408,"context_line":"                                    exceptions\u003d("},{"line_number":409,"context_line":"                                        exceptions.ISCSILunNotAvailable, ))"},{"line_number":410,"context_line":"        def wait_for_lun():"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_963f78b3","line":407,"updated":"2016-01-11 10:43:08.000000000","message":"why not have the @loopingcall on _ensure_lun_available?","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"9abd50d076d7863afa54bcbd3594edfd90eff750","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        self._ensure_lun_available(sid, target_iqn, target_lun)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def _ensure_lun_available(self, session_id, target_iqn, target_lun):"},{"line_number":407,"context_line":"        @loopingcall.RetryDecorator(max_retry_count\u003d5, max_sleep_time\u003d3,"},{"line_number":408,"context_line":"                                    exceptions\u003d("},{"line_number":409,"context_line":"                                        exceptions.ISCSILunNotAvailable, ))"},{"line_number":410,"context_line":"        def wait_for_lun():"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_792677cf","line":407,"in_reply_to":"fa69d971_963f78b3","updated":"2016-01-11 11:08:32.000000000","message":"At the moment, this decorator would not work that way.","commit_id":"57ba0526900462847086d63094ef2a8e9a8a4170"}],"os_win/utils/storage/initiator/iscsierr.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"955b894386a5e979328a07ed4e306ebe0f1bae49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa69d971_82ef6086","line":320,"updated":"2016-01-04 16:42:17.000000000","message":"These should be with _(), for translation purposes.","commit_id":"4cdd8b0c4798c16fb520ff5718e3a1e3c870f746"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f8a3fd9735726fb41952778b8644d82df9b3e3dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa69d971_0e9b7d73","line":320,"in_reply_to":"fa69d971_82ef6086","updated":"2016-01-05 08:49:38.000000000","message":"Done","commit_id":"4cdd8b0c4798c16fb520ff5718e3a1e3c870f746"}]}
