)]}'
{"osc_lib/clientmanager.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9d45b970209a7000fff432a35bb4f2ff7c4137e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"try:"},{"line_number":26,"context_line":"    import keyring"},{"line_number":27,"context_line":"except ImportError:"},{"line_number":28,"context_line":"    keyring \u003d None"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_f4226a00","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":18},"updated":"2016-10-31 23:09:29.000000000","message":"add keyring to requirements or test-requirements? do we want to depend on it? why not make it a hard dependency?","commit_id":"9e5f70d00ed73972e6323040294486db55ce42da"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"8461e9c8c9c738eae57c1e14fa8976d84360acca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"try:"},{"line_number":26,"context_line":"    import keyring"},{"line_number":27,"context_line":"except ImportError:"},{"line_number":28,"context_line":"    keyring \u003d None"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_554c5dc6","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":18},"in_reply_to":"ba5da102_f4226a00","updated":"2017-10-20 00:26:08.000000000","message":"I expect we should probably add it to test-requirements. I\u0027m not really sure how to rely on it. I expect things may want to be more complex that this like --no-auth-cache or something options.","commit_id":"9e5f70d00ed73972e6323040294486db55ce42da"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5057194a2e3b31994652246d2379005bde1b974b","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            return"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        try:"},{"line_number":192,"context_line":"            state \u003d keyring.get_password(\u0027openstackclient\u0027, self.cache_id)"},{"line_number":193,"context_line":"        except RuntimeError:  # the fail backend raises this"},{"line_number":194,"context_line":"            LOG.debug(\u0027Failed to fetch auth from keyring\u0027)"},{"line_number":195,"context_line":"            state \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_2974d933","line":192,"updated":"2016-10-27 16:16:58.000000000","message":"Should we parameterize \u0027openstackclient\u0027 here as it may be a difference CLI consuming osc-lib?  ie, should a stand-alone osc-ironic binary use the same auth cache?","commit_id":"9e5f70d00ed73972e6323040294486db55ce42da"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"8461e9c8c9c738eae57c1e14fa8976d84360acca","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            return"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        try:"},{"line_number":192,"context_line":"            state \u003d keyring.get_password(\u0027openstackclient\u0027, self.cache_id)"},{"line_number":193,"context_line":"        except RuntimeError:  # the fail backend raises this"},{"line_number":194,"context_line":"            LOG.debug(\u0027Failed to fetch auth from keyring\u0027)"},{"line_number":195,"context_line":"            state \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_b5da71e6","line":192,"in_reply_to":"ba5da102_2974d933","updated":"2017-10-20 00:26:08.000000000","message":"I think it\u0027s ok, but can be convinced either way. If the auth information provided is matching then it says that exactly the same auth information was provided. In this case I don\u0027t think it\u0027s a problem to share the cache around? (so long as the cache management is always handled by osc-lib and the other clis aren\u0027t trying to deal with serialization)","commit_id":"9e5f70d00ed73972e6323040294486db55ce42da"}]}