)]}'
{"osc_lib/shell.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f8de87dcb8392f2b4719b5ea62c4804350734c14","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        # NOTE(dtroyer): Save the auth required state of the _current_ command"},{"line_number":439,"context_line":"        #                in the ClientManager"},{"line_number":440,"context_line":"        self.client_manager._auth_required \u003d cmd.auth_required"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        # Validate auth options"},{"line_number":443,"context_line":"        self.cloud \u003d self.cloud_config.get_one_cloud("}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_091bb572","side":"PARENT","line":440,"updated":"2017-05-01 02:45:54.000000000","message":"I think the regression we\u0027re seeing is that our auth_required\u003dTrue command needs that auth during the command\u0027s __init__ method, but self.client_manager._auth_required doesn\u0027t get set until well after that.\n\nAs a workaround we can set self.client_manager._auth_required ourselves, but we need some guidance to know if needing auth in command __init__ should be supported.","commit_id":"ed8ef0df9ff3a095d53be90ce535393078bf267b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"1d6d53bd63624de3b40d779669a7b07d270dfd76","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        # NOTE(dtroyer): Save the auth required state of the _current_ command"},{"line_number":439,"context_line":"        #                in the ClientManager"},{"line_number":440,"context_line":"        self.client_manager._auth_required \u003d cmd.auth_required"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        # Validate auth options"},{"line_number":443,"context_line":"        self.cloud \u003d self.cloud_config.get_one_cloud("}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_323ed5c0","side":"PARENT","line":440,"in_reply_to":"5ff73747_091bb572","updated":"2017-05-01 15:27:22.000000000","message":"We try to defer auth as long as possible, and in all of the in-repo commands it waits until take_action() when the first clients are instantiated to actually do the auth calls.  This is partly due to wanting to avoid server round trips when unnecessary, but also because the entire argument handling -\u003e auth process is a long and complicated dance.  Things like os-client-config tried to move auth plugin loading earlier and caused much grief too.  This revert undoes one of the things required to deal with that.\n\nThe command.__init__() really shouldn\u0027t be _doing_ anything, you\u0027ll see we really don\u0027t use it at all directly in OSC.","commit_id":"ed8ef0df9ff3a095d53be90ce535393078bf267b"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"35b9718b7f4fcd04e8833c81604ab3ce2b8bf3ba","unresolved":false,"context_lines":[{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        # NOTE(dtroyer): Save the auth required state of the _current_ command"},{"line_number":439,"context_line":"        #                in the ClientManager"},{"line_number":440,"context_line":"        self.client_manager._auth_required \u003d cmd.auth_required"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        # Validate auth options"},{"line_number":443,"context_line":"        self.cloud \u003d self.cloud_config.get_one_cloud("}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_b7788f8f","side":"PARENT","line":440,"in_reply_to":"5ff73747_323ed5c0","updated":"2017-05-01 20:57:21.000000000","message":"Thanks Dean, trying this now https://review.openstack.org/#/c/461507/","commit_id":"ed8ef0df9ff3a095d53be90ce535393078bf267b"}]}