)]}'
{"id":"openstack%2Fosc-lib~526413","triplet_id":"openstack%2Fosc-lib~master~Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b","project":"openstack/osc-lib","branch":"master","topic":"bug/1737069","hashtags":[],"change_id":"Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b","subject":"Check auth_url as well as identity version api","status":"ABANDONED","created":"2017-12-07 14:27:52.000000000","updated":"2023-03-28 15:37:56.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2f694db811fd645c6d139b1e1322d3439998c29a","_number":526413,"virtual_id_number":526413,"owner":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-11-06 12:04:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"date":"2020-11-06 10:36:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-26 00:08:28.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2018-07-12 21:43:20.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-11-06 12:04:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8b96420ba2ea4a2c1cb15d4a64ed12a8f4e38b23","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2017-12-07 14:27:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b15038ac4594bd6fd28a8ca678aa6c82a760af30","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-07 15:42:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/13/526413/1/check/openstack-tox-pep8/e6ab651/ : FAILURE in 3m 30s\n- openstack-tox-py27 http://logs.openstack.org/13/526413/1/check/openstack-tox-py27/59b33a8/ : SUCCESS in 3m 31s\n- openstack-tox-py35 http://logs.openstack.org/13/526413/1/check/openstack-tox-py35/5bff8bc/ : SUCCESS in 8m 36s\n- openstack-tox-pypy http://logs.openstack.org/13/526413/1/check/openstack-tox-pypy/b0c5530/ : SUCCESS in 7m 36s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/13/526413/1/check/legacy-tempest-dsvm-neutron-src/3e75a7a/ : SUCCESS in 1h 10m 35s\n- build-openstack-sphinx-docs http://logs.openstack.org/13/526413/1/check/build-openstack-sphinx-docs/77aede0/html/ : SUCCESS in 4m 14s\n- osc-functional-devstack http://logs.openstack.org/13/526413/1/check/osc-functional-devstack/cb5c6d2/ : SUCCESS in 36m 24s\n- osc-functional-devstack-tips http://logs.openstack.org/13/526413/1/check/osc-functional-devstack-tips/4104415/ : RETRY_LIMIT in 18m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a35f56173fce11394ec839afa29b5302654e42b7","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2017-12-08 00:52:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8720de2266463949c82231f45379e72578a313d5","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2017-12-08 01:41:34.000000000","message":"Topic changed from check_auth_url_as_well_when_drop_domain_info to bug/1737069","accounts_in_message":[],"_revision_number":2},{"id":"affb1d8b460bf2980f5cd0c561b2b336e343b4da","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 08:56:58.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 openstack-tox-pep8 : RETRY_LIMIT\n- openstack-tox-py27 openstack-tox-py27 : RETRY_LIMIT\n- openstack-tox-py35 openstack-tox-py35 : RETRY_LIMIT\n- openstack-tox-pypy openstack-tox-pypy : RETRY_LIMIT (non-voting)\n- legacy-tempest-dsvm-neutron-src legacy-tempest-dsvm-neutron-src : RETRY_LIMIT\n- build-openstack-sphinx-docs build-openstack-sphinx-docs : RETRY_LIMIT\n- osc-functional-devstack osc-functional-devstack : RETRY_LIMIT\n- osc-functional-devstack-tips osc-functional-devstack-tips : RETRY_LIMIT (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a4826a1388e24eb0fe776cb1d24946da1aaff293","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2017-12-08 10:07:56.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"8cc95affacc38109ce08544518bc75c6fe818ec1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 13:09:32.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/13/526413/2/check/openstack-tox-pep8/b564dd7/ : SUCCESS in 7m 13s\n- openstack-tox-py27 http://logs.openstack.org/13/526413/2/check/openstack-tox-py27/622a8ca/ : SUCCESS in 3m 44s\n- openstack-tox-py35 http://logs.openstack.org/13/526413/2/check/openstack-tox-py35/58ab94e/ : SUCCESS in 7m 38s\n- openstack-tox-pypy http://logs.openstack.org/13/526413/2/check/openstack-tox-pypy/1e6886e/ : SUCCESS in 4m 14s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/13/526413/2/check/legacy-tempest-dsvm-neutron-src/244bb06/ : FAILURE in 1h 37m 42s\n- build-openstack-sphinx-docs http://logs.openstack.org/13/526413/2/check/build-openstack-sphinx-docs/6cd98cf/html/ : SUCCESS in 5m 01s\n- osc-functional-devstack http://logs.openstack.org/13/526413/2/check/osc-functional-devstack/a2c1b0a/ : SUCCESS in 43m 22s\n- osc-functional-devstack-tips http://logs.openstack.org/13/526413/2/check/osc-functional-devstack-tips/9f04286/ : RETRY_LIMIT in 19m 59s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"75d31a17c9ceed8f835b29e091f207d1c7c6537f","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2017-12-08 17:33:48.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"8d55753eea4a50afd463d65c45d981046f2fe72d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 19:46:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/13/526413/2/check/openstack-tox-pep8/6016c00/ : SUCCESS in 5m 10s\n- openstack-tox-py27 http://logs.openstack.org/13/526413/2/check/openstack-tox-py27/631a2fb/ : SUCCESS in 3m 31s\n- openstack-tox-py35 http://logs.openstack.org/13/526413/2/check/openstack-tox-py35/c5e1279/ : SUCCESS in 4m 27s\n- openstack-tox-pypy http://logs.openstack.org/13/526413/2/check/openstack-tox-pypy/e7add7d/ : SUCCESS in 5m 43s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/13/526413/2/check/legacy-tempest-dsvm-neutron-src/f139584/ : SUCCESS in 1h 22m 55s\n- build-openstack-sphinx-docs http://logs.openstack.org/13/526413/2/check/build-openstack-sphinx-docs/5772350/html/ : SUCCESS in 5m 06s\n- osc-functional-devstack http://logs.openstack.org/13/526413/2/check/osc-functional-devstack/d523095/ : SUCCESS in 36m 21s\n- osc-functional-devstack-tips osc-functional-devstack-tips : RETRY_LIMIT (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9436a401d0746523a28fba2fcd02d71262e288a0","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2018-03-26 00:08:28.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"4c8556e4b1e8aadd5e9f894ad0480a2213120314","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-04-01 12:47:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dbe42b980b70c43ac9444017c498a41eb2573a93","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-01 14:04:29.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/13/526413/3/check/openstack-tox-pep8/6b7cd52/ : SUCCESS in 3m 30s\n- openstack-tox-py27 http://logs.openstack.org/13/526413/3/check/openstack-tox-py27/031dcf4/ : SUCCESS in 3m 52s\n- openstack-tox-py35 http://logs.openstack.org/13/526413/3/check/openstack-tox-py35/406277e/ : SUCCESS in 4m 57s\n- openstack-tox-pypy http://logs.openstack.org/13/526413/3/check/openstack-tox-pypy/103c1de/ : SUCCESS in 4m 24s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/13/526413/3/check/legacy-tempest-dsvm-neutron-src/821309c/ : SUCCESS in 1h 15m 44s\n- build-openstack-sphinx-docs http://logs.openstack.org/13/526413/3/check/build-openstack-sphinx-docs/d1ae200/html/ : SUCCESS in 3m 59s\n- osc-functional-devstack http://logs.openstack.org/13/526413/3/check/osc-functional-devstack/559d042/ : SUCCESS in 44m 23s\n- osc-functional-devstack-tips http://logs.openstack.org/13/526413/3/check/osc-functional-devstack-tips/590462e/ : SUCCESS in 44m 31s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/13/526413/3/check/openstack-tox-lower-constraints/c8f1f5b/ : SUCCESS in 5m 16s","accounts_in_message":[],"_revision_number":3},{"id":"609045d5db4514400ea2e333ffef44fd6c81a125","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-04-06 07:34:19.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nThanks for reviewing, I added reference to launchpad for bug report and fixed import statement place for re. Please check it out.","accounts_in_message":[],"_revision_number":3},{"id":"c95f7f9b706d2aa33e582289a203a1e356717d25","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-08 21:37:24.000000000","message":"Patch Set 3: Code-Review-1\n\nidentity_api_version is actually not related to what version is used for auth. If a person wants to communicate that they want auth version v3 explicitly, they should set auth_type to v3password.","accounts_in_message":[],"_revision_number":3},{"id":"7705575d47dd70d59692120969b5f5da05e4b2ec","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-09 03:28:39.000000000","message":"Patch Set 3:\n\n@Monty Taylor \nI understood \"identity_api_version is actually not related to what version is used for auth.\" and actually this patch come out of this thought.\nAccording to osc-lib implementation, if identity_api version configured to use v3, domain related information dropped even if that information used by auth_url. \n\nwe should not just refer to identity api version to judge if we should drop domain information or not, because other parameter (like auth) depend on these value.","accounts_in_message":[],"_revision_number":3},{"id":"89ad05d066ba1a905c27c1343945fe1b6d268848","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-09 03:30:06.000000000","message":"Patch Set 3:\n\nsorry I explained in the wrong way.\n\u003e if identity_api version configured to use v3, domain related information dropped even if that information used by auth_url. \n\nif identity_api version configured to use v2, domain related information dropped even if that information used by auth_url.","accounts_in_message":[],"_revision_number":3},{"id":"48c7e87753c42190c471286f2dede374b487ae22","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-09 15:00:31.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nGotcha - and yeah, I\u0027ve actually come around to a different point of view on the thing I was saying originally.\n\nSo I think this should be fine - but I think the inline comment should be addressed first.","accounts_in_message":[],"_revision_number":3},{"id":"1735ec16b271ae72b38149b3e26561486b5a0e0e","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-09 15:00:54.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"79ff1710ee8ffff56625f4ade23410971fc970db","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-10 02:35:26.000000000","message":"Patch Set 3:\n\nActually I checked https://github.com/openstack/openstacksdk/blob/master/openstack/config/loader.py which is the code to be in charge of generating config, auth_url seems be defined out of auth key.\n\nI checked with debugger and still seems be out of \"auth\"\n\n\n\u003e /usr/local/lib/python2.7/site-packages/osc_lib/cli/client_config.py(95)_auth_v2_ignore_v3()\n(Pdb) l\n 90\n 91             # NOTE(hieulq): If USER_DOMAIN_NAME, USER_DOMAIN_ID, PROJECT_DOMAIN_ID\n 92             # or PROJECT_DOMAIN_NAME is present and API_VERSION is 2.0, then\n 93             # ignore all domain related configs.\n 94             import pdb; pdb.set_trace()\n 95  -\u003e         if (str(config.get(\u0027identity_api_version\u0027, \u0027\u0027)).startswith(\u00272\u0027) and\n 96                     config.get(\u0027auth_type\u0027).endswith(\u0027password\u0027)):\n 97                 domain_props \u003d [\n 98                     \u0027project_domain_id\u0027,\n 99                     \u0027project_domain_name\u0027,\n100                     \u0027user_domain_id\u0027,\n(Pdb) config[\"auth\"]\n{\u0027project_id\u0027: \u0027***\u0027, \u0027user_domain_name\u0027: \u0027***\u0027, \u0027project_name\u0027: \u0027***\u0027}","accounts_in_message":[],"_revision_number":3},{"id":"19e3336be0e5f42575072b68e6f8fd86dede8345","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-10 18:51:32.000000000","message":"Patch Set 3:\n\nYes - but that\u0027s because your input mock data in the test defines it outside of the auth dict. In normal usage, it should be inside the auth dict. So in this case, the test works, and you\u0027re right about the debugger, but it\u0027s the code and the test cancelling each other out.\n\nBTW - I\u0027m going to port this patch over to openstacksdk (unless you want to) so that we can just do it when we\u0027re processing the parameters in the first place.","accounts_in_message":[],"_revision_number":3},{"id":"e30c069465c39ac21ba6b23f95a684f4f832ac36","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-11 02:32:48.000000000","message":"Patch Set 3:\n\n@Monty Taylor \nSorry I should\u0027ve mentioned the debugger output was captured when i executed openstack cli command not when I execute test.\nSo If we expect auth_url to be inside auth dict, we have to modify openstacksdk so that make sure auth_url to be inside auth dict by another patch for openstacksdk.\nSo I\u0027m gonna change  this patch as you pointed if that behaviour is expected. \nBut after that, we will have to write another patch to make sure auth_url to be in auth dict around https://github.com/openstack/openstacksdk/blob/master/openstack/config/loader.py#L1031\n\n\u003e BTW - I\u0027m going to port this patch over to openstacksdk (unless you want to) so that we can just do it when we\u0027re processing the parameters in the first place.\nDoes this patch indicate literally this https://review.openstack.org/#/c/526413/?\nor indicate the patch to make sure auth_url to be in auth dict?","accounts_in_message":[],"_revision_number":3},{"id":"a7305eaf84c09412f634d390bae213908beac690","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-11 12:57:35.000000000","message":"Patch Set 3:\n\nYes please! If there are cases where it\u0027s not in auth- or it\u0027s not being moved there by loader - then we need to fix them in sdk and write some tests.\n\nthank you very much!","accounts_in_message":[],"_revision_number":3},{"id":"056a22aad09a7bf2c8572c549a9e815a2f2a573e","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-11 14:13:46.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a4f4544d2d891dc2eec677c6237be18f521f2ff5","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-11 14:17:42.000000000","message":"Patch Set 4: Code-Review+2\n\nAwesome!","accounts_in_message":[],"_revision_number":4},{"id":"dd7a52e1c9808817cb5800396244596ff8d8fc3e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-11 15:34:16.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/13/526413/4/check/openstack-tox-pep8/094d431/ : SUCCESS in 5m 00s\n- openstack-tox-py27 http://logs.openstack.org/13/526413/4/check/openstack-tox-py27/d0c6afa/ : SUCCESS in 5m 10s\n- openstack-tox-py35 http://logs.openstack.org/13/526413/4/check/openstack-tox-py35/72b060c/ : SUCCESS in 5m 11s\n- openstack-tox-pypy http://logs.openstack.org/13/526413/4/check/openstack-tox-pypy/f4f35de/ : SUCCESS in 6m 34s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/13/526413/4/check/legacy-tempest-dsvm-neutron-src/2c9b0c8/ : FAILURE in 1h 14m 31s\n- build-openstack-sphinx-docs http://logs.openstack.org/13/526413/4/check/build-openstack-sphinx-docs/9fe1483/html/ : SUCCESS in 6m 14s\n- osc-tox-py27-tips http://logs.openstack.org/13/526413/4/check/osc-tox-py27-tips/6db89f7/ : FAILURE in 10m 06s\n- osc-tox-py35-tips http://logs.openstack.org/13/526413/4/check/osc-tox-py35-tips/d6dbfe0/ : FAILURE in 7m 34s\n- osc-functional-devstack http://logs.openstack.org/13/526413/4/check/osc-functional-devstack/e407860/ : SUCCESS in 43m 41s\n- osc-functional-devstack-tips http://logs.openstack.org/13/526413/4/check/osc-functional-devstack-tips/540f316/ : SUCCESS in 55m 00s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/13/526413/4/check/openstack-tox-lower-constraints/87d3ae3/ : SUCCESS in 8m 54s","accounts_in_message":[],"_revision_number":4},{"id":"6d197594b60954dafa5e4295b879c0b03fba3f94","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-11 16:38:18.000000000","message":"Patch Set 4:\n\n^^^ above error is because of openstacksdk, this won\u0027t resolve until we fixed the issue that auth_url is not in auth dict as we discussed here","accounts_in_message":[],"_revision_number":4},{"id":"6b790650d0138584ee960f7d7d31a8dcc891c370","author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"date":"2018-07-11 17:14:58.000000000","message":"Patch Set 4:\n\n@Monty Taylor \nAfter I got the error in openstackclient related gate, I did some investigation and I started to think this patch should check auth_url key which is not in auth dict.\nI understood your point, auth_url should be in auth dict and actually that movement happened after _auth_v2_ignore_v3 function. the line is here https://github.com/openstack/openstacksdk/blob/master/openstack/config/loader.py#L1041 \nBut this movement happened after _auth_v2_ignore_v3 function unfortunately.\n\nSo If we still want to check auth_url inside auth dict at _auth_v2_ignore_v3 function, we need to store auth_url into auth dict before _auth_v2_ignore_v3 function evaluated. \n\nWhat do you think about it?","accounts_in_message":[],"_revision_number":4},{"id":"1196c08aeee3410d734922b5406da3061709c95d","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2018-07-12 21:43:20.000000000","message":"Patch Set 4: -Code-Review\n\nHrm. This is tricky. If this is happening before the openstacksdk move of auth_url to the auth dict - then I think we really need to do this directly in openstacksdk - because otherwise for a user who puts auth_url in the auth dict directly (all of my clouds.yaml entries have auth_url in auth dict, for instance) will have a different behavior from a user who doesn\u0027t.\n\nI\u0027ll try to look at SDK for this tomorrow morning - but if you beat me to fixing sdk, awesome. :)","accounts_in_message":[],"_revision_number":4},{"id":"8ee01cde8ccf96a79017ee2a659e87aec37828ca","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-06 10:36:40.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":5},{"id":"753975b966b2ae6513c40444a4acc038d4a8c4c1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 12:04:42.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a5f1455a84da4a278104e6bed6fc60a4 : SUCCESS in 3m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d096b72667e646558a85ff154f9f8c11 : SUCCESS in 3m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4d8cfb4b856a4187bb572ad609c78164 : SUCCESS in 3m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/197cc98a5af34015b78689c174d19d5d : SUCCESS in 4m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/551faa7f9c7e44a7970a08c4d6b5d3e8 : SUCCESS in 4m 04s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/997a1d4971fc4c5a9384085c7602e639 : FAILURE in 5m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6f816ba0ff9141a4a2bf0c75ea12b64e : SUCCESS in 3m 28s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/81dfc141f8974a6bb16329a1015d261c : SUCCESS in 54m 58s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/974347714e4640b6a1722c0e9f84d89c : SUCCESS in 54m 47s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"2f694db811fd645c6d139b1e1322d3439998c29a","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-03-28 15:37:56.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"05420eabcd2b14c519228c95a0287c21efdef1e1","revisions":{"d83db109cfa7242aac7aee0182ee0f9c223f8b10":{"kind":"REWORK","_number":1,"created":"2017-12-07 14:27:52.000000000","uploader":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"ref":"refs/changes/13/526413/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/13/526413/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/1"}}},"commit":{"parents":[{"commit":"e65c2aa93f6a2e617c9ab49f80f07de32929d6a2","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/e65c2aa93f6a2e617c9ab49f80f07de32929d6a2"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2017-12-07 14:08:56.000000000","tz":540},"committer":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2017-12-07 14:27:49.000000000","tz":540},"subject":"Check auth_url as well as identity version api","message":"Check auth_url as well as identity version api\n\nWhen check the identity api version whether we should drop\ndomain information from configuration or not, we should check auth_url\nas well. Otherwise the user can not get authenticated if the user use\nthe keystone api v3 for authentication without specifying identity api\nversion by command option or environment variable.\nBecause the default identity api version in configuration is currently\nconfiguread as v2.0\n\nChange-Id: Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/d83db109cfa7242aac7aee0182ee0f9c223f8b10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/d83db109cfa7242aac7aee0182ee0f9c223f8b10"}]},"branch":"refs/heads/master"},"1f155251dd064dab7253cb786442ae83cd279642":{"kind":"REWORK","_number":2,"created":"2017-12-08 00:52:04.000000000","uploader":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"ref":"refs/changes/13/526413/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/13/526413/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/2"}}},"commit":{"parents":[{"commit":"e65c2aa93f6a2e617c9ab49f80f07de32929d6a2","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/e65c2aa93f6a2e617c9ab49f80f07de32929d6a2"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2017-12-08 00:50:58.000000000","tz":540},"committer":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2017-12-08 00:52:01.000000000","tz":540},"subject":"Check auth_url as well as identity version api","message":"Check auth_url as well as identity version api\n\nWhen check the identity api version whether we should drop domain\ninformation from configuration or not, we should check auth_url as well.\nOtherwise the user can not get authenticated if the user use the\nkeystone api v3 for authentication without specifying identity api\nversion by command option or environment variable. Because the default\nidentity api version in configuration is currently configuread as v2.0.\n\nChange-Id: Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/1f155251dd064dab7253cb786442ae83cd279642"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/1f155251dd064dab7253cb786442ae83cd279642"}]},"branch":"refs/heads/master"},"5d75278f1d4d88fae5246242e5bb8256bbcbc705":{"kind":"REWORK","_number":3,"created":"2018-04-01 12:47:29.000000000","uploader":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"ref":"refs/changes/13/526413/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/13/526413/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/3"}}},"commit":{"parents":[{"commit":"5edbb64419a65f9cd963f4e4f2719f1c87ceff5e","subject":"Merge \"add lower-constraints job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/5edbb64419a65f9cd963f4e4f2719f1c87ceff5e"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2018-04-01 12:45:26.000000000","tz":540},"committer":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2018-04-01 12:47:26.000000000","tz":540},"subject":"Check auth_url as well as identity version api","message":"Check auth_url as well as identity version api\n\nWhen check the identity api version whether we should drop domain\ninformation from configuration or not, we should check auth_url as well.\nOtherwise the user can not get authenticated if the user use the\nkeystone api v3 for authentication without specifying identity api\nversion by command option or environment variable. Because the default\nidentity api version in configuration is currently configuread as v2.0.\n\nChange-Id: Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b\nCloses-Bug: #1737069\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/5d75278f1d4d88fae5246242e5bb8256bbcbc705"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/5d75278f1d4d88fae5246242e5bb8256bbcbc705"}]},"branch":"refs/heads/master"},"dd888842eb60ec224a1c0c7976f7cf8a983b50f7":{"kind":"REWORK","_number":4,"created":"2018-07-11 14:13:46.000000000","uploader":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"ref":"refs/changes/13/526413/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/13/526413/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/4"}}},"commit":{"parents":[{"commit":"5edbb64419a65f9cd963f4e4f2719f1c87ceff5e","subject":"Merge \"add lower-constraints job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/5edbb64419a65f9cd963f4e4f2719f1c87ceff5e"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2018-04-01 12:45:26.000000000","tz":540},"committer":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2018-07-11 14:13:33.000000000","tz":540},"subject":"Check auth_url as well as identity version api","message":"Check auth_url as well as identity version api\n\nWhen check the identity api version whether we should drop domain\ninformation from configuration or not, we should check auth_url as well.\nOtherwise the user can not get authenticated if the user use the\nkeystone api v3 for authentication without specifying identity api\nversion by command option or environment variable. Because the default\nidentity api version in configuration is currently configuread as v2.0.\n\nChange-Id: Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b\nCloses-Bug: #1737069\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/dd888842eb60ec224a1c0c7976f7cf8a983b50f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/dd888842eb60ec224a1c0c7976f7cf8a983b50f7"}]},"branch":"refs/heads/master"},"05420eabcd2b14c519228c95a0287c21efdef1e1":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-11-06 10:36:40.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/13/526413/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/13/526413/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/13/526413/5"}}},"commit":{"parents":[{"commit":"0a7bc3eb8c99da0c4c0e0612b78abf015927838b","subject":"Merge \"Add Python3 wallaby unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/0a7bc3eb8c99da0c4c0e0612b78abf015927838b"}]}],"author":{"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","date":"2018-04-01 12:45:26.000000000","tz":540},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-11-06 10:36:40.000000000","tz":0},"subject":"Check auth_url as well as identity version api","message":"Check auth_url as well as identity version api\n\nWhen check the identity api version whether we should drop domain\ninformation from configuration or not, we should check auth_url as well.\nOtherwise the user can not get authenticated if the user use the\nkeystone api v3 for authentication without specifying identity api\nversion by command option or environment variable. Because the default\nidentity api version in configuration is currently configuread as v2.0.\n\nChange-Id: Ib90fc937fb018b9c9dd96c7d87f8ddb7c6c52f0b\nCloses-Bug: #1737069\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/05420eabcd2b14c519228c95a0287c21efdef1e1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/05420eabcd2b14c519228c95a0287c21efdef1e1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
