)]}'
{"id":"openstack%2Fosc-lib~535733","triplet_id":"openstack%2Fosc-lib~master~Id034f3ddb9be5f1a05e99b5d36b3381edda58ddb","project":"openstack/osc-lib","branch":"master","topic":"modify_pep8_style","hashtags":[],"change_id":"Id034f3ddb9be5f1a05e99b5d36b3381edda58ddb","subject":"Replace \u0027assertFalse(a in b)\u0027 with \u0027assertNotIn(a, b)\u0027","status":"MERGED","created":"2018-01-19 11:38:31.000000000","updated":"2020-11-06 12:48:19.000000000","submitted":"2020-11-06 12:46:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"535733-1604666815551-8d692ead","meta_rev_id":"b30cd3323e0190e4e21d8de0458249ed3caf5ef1","_number":535733,"virtual_id_number":535733,"owner":{"_account_id":27361,"name":"Yandy Sun","email":"sunyd@inspur.com","username":"sunyandi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-06 12:46:55.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"disliked":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-11-06 10:31:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2020-11-06 10:32:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2020-11-06 10:32:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-26 00:12:20.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2020-11-06 10:32:05.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-11-06 12:46:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d7e0fec68a2bc9fcb7b48e086cc6ef68f72bca4e","author":{"_account_id":27361,"name":"Yandy Sun","email":"sunyd@inspur.com","username":"sunyandi"},"date":"2018-01-19 11:38:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c67515757d534e5f52fd51358745cc6d56d21542","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-19 13:23:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/33/535733/1/check/openstack-tox-pep8/12c2ff8/ : SUCCESS in 5m 16s\n- openstack-tox-py27 http://logs.openstack.org/33/535733/1/check/openstack-tox-py27/6febea0/ : SUCCESS in 3m 43s\n- openstack-tox-py35 http://logs.openstack.org/33/535733/1/check/openstack-tox-py35/d0d7b54/ : SUCCESS in 3m 46s\n- openstack-tox-pypy http://logs.openstack.org/33/535733/1/check/openstack-tox-pypy/f143212/ : SUCCESS in 4m 20s (non-voting)\n- legacy-tempest-dsvm-neutron-src http://logs.openstack.org/33/535733/1/check/legacy-tempest-dsvm-neutron-src/40893ed/ : SUCCESS in 1h 40m 54s\n- build-openstack-sphinx-docs http://logs.openstack.org/33/535733/1/check/build-openstack-sphinx-docs/aec8fa1/html/ : SUCCESS in 4m 09s\n- osc-functional-devstack http://logs.openstack.org/33/535733/1/check/osc-functional-devstack/f789efa/ : SUCCESS in 43m 29s\n- osc-functional-devstack-tips http://logs.openstack.org/33/535733/1/check/osc-functional-devstack-tips/9503f80/ : SUCCESS in 44m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a4f4e12ec3239fa9588045782db8bb1cc203a2bc","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2018-03-26 00:12:20.000000000","message":"Patch Set 1: Code-Review-1\n\nCould you implement a hacking check in openstack/hacking first?","accounts_in_message":[],"_revision_number":1},{"id":"d755cca63d060e1fc8e65917a5d1a1b34e9d1ce2","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-06 10:31:37.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"b9dbe0aa5020aa2bbb3deda1cd95078b7245a7f4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-06 10:31:54.000000000","message":"Patch Set 1:\n\n\u003e Could you implement a hacking check in openstack/hacking first?\n\nThis was done in I122d250cab90964c346e9d53046a97c25054bc00","accounts_in_message":[],"_revision_number":1},{"id":"d5cc3a180f3a60d14f3609b8973d49093b3cd709","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-11-06 10:32:05.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"fa13e5a93097fcd30953bf90d3855af1a76f653a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 11:44:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0a94f42cbce146eeadfa3767eab99ea9 : SUCCESS in 3m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c9228018c2164593af2149da97002bef : SUCCESS in 3m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7c7bccb29b154706881ce091db11ab24 : SUCCESS in 3m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fcf2ce66390c4a1ea435277576c8a8f3 : SUCCESS in 3m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e53e3af46cd644ae8c1a5b9077d90303 : SUCCESS in 3m 20s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/11febb9c9e6e4c8cbbaaea6b5d43b7cb : SUCCESS in 5m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/60dd16c316654fa5a008eeb35af6d005 : SUCCESS in 3m 51s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/35e81a09398344df8a44ebba12f05dbc : SUCCESS in 56m 55s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8b5cba5fc8554b079404087e441e7f21 : FAILURE in 59m 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"62ad15e3d600fa65627d59ca75fa6d6f238237cf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 11:44:33.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b06d987a3b11597cfc3dbb10b40376ecdb2b63b9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 12:46:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e9a340d5b6bb4255a558ca45f9b044d6 : SUCCESS in 3m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/78d8940f74dd403eb8c0554fc4a6a88d : SUCCESS in 2m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/471e4ab67cff4601b207ac404f88b32d : SUCCESS in 2m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c526e2a111434131a9d3ea12e1baf8dd : SUCCESS in 3m 41s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/0bbd5d9a05104bcdbdcf50c8216b64cc : SUCCESS in 5m 26s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a9014a5a389a490fb496e831e0e03b36 : SUCCESS in 4m 40s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/5567efaa930248e298ee9d3f6ff76810 : SUCCESS in 55m 15s","accounts_in_message":[],"_revision_number":2},{"id":"dbe0f82cdb054dfcc1d73eb8f5c433823da8d868","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 12:46:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"ddd83a36950676206570ce2251cb78733b03280f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 12:48:19.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1eb295e8efdb424f9ebbb5d9baa909ab : SUCCESS in 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"239b001a14d0c567609ce69c85e0ead73fedbac4","revisions":{"64641ab0e6173306f8bb37c15f2dbc961303f16f":{"kind":"REWORK","_number":1,"created":"2018-01-19 11:38:31.000000000","uploader":{"_account_id":27361,"name":"Yandy Sun","email":"sunyd@inspur.com","username":"sunyandi"},"ref":"refs/changes/33/535733/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/33/535733/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/1"}}},"commit":{"parents":[{"commit":"281183216b91b1a38b2e42dc2426e182e5cffab1","subject":"Merge \"Relocate utils tests to match the main code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/281183216b91b1a38b2e42dc2426e182e5cffab1"}]}],"author":{"name":"sunyandi","email":"sunyd@inspur.com","date":"2018-01-19 11:36:45.000000000","tz":480},"committer":{"name":"sunyandi","email":"sunyd@inspur.com","date":"2018-01-19 11:38:18.000000000","tz":480},"subject":"Replace \u0027assertFalse(a in b)\u0027 with \u0027assertNotIn(a, b)\u0027","message":"Replace \u0027assertFalse(a in b)\u0027 with \u0027assertNotIn(a, b)\u0027\n\nTrivial fix.\n\nChange-Id: Id034f3ddb9be5f1a05e99b5d36b3381edda58ddb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/64641ab0e6173306f8bb37c15f2dbc961303f16f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/64641ab0e6173306f8bb37c15f2dbc961303f16f"}]},"branch":"refs/heads/master"},"239b001a14d0c567609ce69c85e0ead73fedbac4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-11-06 10:31:37.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/33/535733/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/33/535733/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/33/535733/2"}}},"commit":{"parents":[{"commit":"0a7bc3eb8c99da0c4c0e0612b78abf015927838b","subject":"Merge \"Add Python3 wallaby unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/0a7bc3eb8c99da0c4c0e0612b78abf015927838b"}]}],"author":{"name":"sunyandi","email":"sunyd@inspur.com","date":"2018-01-19 11:36:45.000000000","tz":480},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-11-06 10:26:20.000000000","tz":0},"subject":"Replace \u0027assertFalse(a in b)\u0027 with \u0027assertNotIn(a, b)\u0027","message":"Replace \u0027assertFalse(a in b)\u0027 with \u0027assertNotIn(a, b)\u0027\n\nTrivial fix.\n\nChange-Id: Id034f3ddb9be5f1a05e99b5d36b3381edda58ddb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/239b001a14d0c567609ce69c85e0ead73fedbac4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/239b001a14d0c567609ce69c85e0ead73fedbac4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
