)]}'
{"osc_lib/shell.py":[{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"b7a5d29bd9141dd8807acca294a8aed679d25ea3","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            profiler \u003d osprofiler_profiler.get()"},{"line_number":157,"context_line":"            trace_id \u003d profiler.get_base_id()"},{"line_number":158,"context_line":"            # Short ID for OpenTracing-based driver (64-bit id)"},{"line_number":159,"context_line":"            short_id \u003d profiler.get_shorten_id(trace_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            # NOTE(dbelova): let\u0027s use warning log level to see these messages"},{"line_number":162,"context_line":"            # printed. In fact we can define custom log level here with value"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_37a6d910","line":159,"updated":"2018-05-16 15:48:32.000000000","message":"is there any impact if we switch to 64-bit ids everywhere?","commit_id":"9071962d96dd3bb2d72fc1fd807953fc97da1750"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"f83c40a35400690838f683f9a2f2cbd25f0b1a52","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            profiler \u003d osprofiler_profiler.get()"},{"line_number":157,"context_line":"            trace_id \u003d profiler.get_base_id()"},{"line_number":158,"context_line":"            # Short ID for OpenTracing-based driver (64-bit id)"},{"line_number":159,"context_line":"            short_id \u003d profiler.get_shorten_id(trace_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            # NOTE(dbelova): let\u0027s use warning log level to see these messages"},{"line_number":162,"context_line":"            # printed. In fact we can define custom log level here with value"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c8a9db90","line":159,"in_reply_to":"5f7c97a3_37a6d910","updated":"2018-05-18 06:59:40.000000000","message":"\u003e is there any impact if we switch to 64-bit ids everywhere?\n\nYes, it is OK to switch to 64-bit with no problem.\nHowever, jaeger will soon support 128-bit ID (for now, 128-bit ID is just for trace id, other still in 64-bit ID).","commit_id":"9071962d96dd3bb2d72fc1fd807953fc97da1750"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"cd926342d0d8a07bbc4fd64f0b84b2dea275bd4a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            profiler \u003d osprofiler_profiler.get()"},{"line_number":157,"context_line":"            trace_id \u003d profiler.get_base_id()"},{"line_number":158,"context_line":"            # Short ID for OpenTracing-based driver (64-bit id)"},{"line_number":159,"context_line":"            short_id \u003d profiler.get_shorten_id(trace_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            # NOTE(dbelova): let\u0027s use warning log level to see these messages"},{"line_number":162,"context_line":"            # printed. In fact we can define custom log level here with value"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d333d061","line":159,"in_reply_to":"5f7c97a3_c8a9db90","updated":"2018-05-18 08:20:15.000000000","message":"I\u0027m more concerned that support of 64-bit IDs requires changes in public API, library release, bump dependency version... But actually Jaeger client doesn\u0027t support querying of the data, which makes all efforts a bit useless.","commit_id":"9071962d96dd3bb2d72fc1fd807953fc97da1750"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"3648794363231120047cb631bad1615404f817c5","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            profiler \u003d osprofiler_profiler.get()"},{"line_number":157,"context_line":"            trace_id \u003d profiler.get_base_id()"},{"line_number":158,"context_line":"            # Short ID for OpenTracing-based driver (64-bit id)"},{"line_number":159,"context_line":"            short_id \u003d profiler.get_shorten_id(trace_id)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            # NOTE(dbelova): let\u0027s use warning log level to see these messages"},{"line_number":162,"context_line":"            # printed. In fact we can define custom log level here with value"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8d7703d5","line":159,"in_reply_to":"5f7c97a3_d333d061","updated":"2018-05-28 03:17:30.000000000","message":"Yep, I agree.","commit_id":"9071962d96dd3bb2d72fc1fd807953fc97da1750"}]}