)]}'
{"id":"openstack%2Fosc-lib~675328","triplet_id":"openstack%2Fosc-lib~master~I022bbf3ce4bdd48b3bdcb008ee872c4f62a7b12b","project":"openstack/osc-lib","branch":"master","topic":"not-found","hashtags":[],"change_id":"I022bbf3ce4bdd48b3bdcb008ee872c4f62a7b12b","subject":"Fix usage of NotFound exception","status":"MERGED","created":"2019-08-08 13:00:01.000000000","updated":"2019-08-22 20:58:40.000000000","submitted":"2019-08-22 20:57:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"675328-1566507443090-b361f005","meta_rev_id":"68d897a81beb003fca7128c81aa0b7420720d8a6","_number":675328,"virtual_id_number":675328,"owner":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-22 20:57:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-09 11:02:55.000000000","_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":2,"date":"2019-08-22 19:11:52.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":1,"date":"2019-08-22 19:11:52.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-22 19:11:52.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-08-22 20:57:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ea6eec045f3b0d61f4d42355214b591fb7dc3d84","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2019-08-08 13:00:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ca0e6cbc76d9aec12182f9bd4053011ba5814e1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 14:39:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://logs.opendev.org/28/675328/1/check/tempest-full/f0a1bef/ : SUCCESS in 1h 35m 46s\n- tempest-full-py3 https://logs.opendev.org/28/675328/1/check/tempest-full-py3/18d3a24/ : SUCCESS in 1h 19m 56s\n- openstack-tox-lower-constraints https://logs.opendev.org/28/675328/1/check/openstack-tox-lower-constraints/659e23e/ : SUCCESS in 5m 56s\n- openstack-tox-pep8 https://logs.opendev.org/28/675328/1/check/openstack-tox-pep8/53c0d0a/ : SUCCESS in 3m 29s\n- openstack-tox-py27 https://logs.opendev.org/28/675328/1/check/openstack-tox-py27/68095ed/ : SUCCESS in 4m 09s\n- openstack-tox-py36 https://logs.opendev.org/28/675328/1/check/openstack-tox-py36/6a01282/ : SUCCESS in 3m 06s\n- openstack-tox-py37 https://logs.opendev.org/28/675328/1/check/openstack-tox-py37/bc90483/ : SUCCESS in 4m 20s\n- osc-tox-py27-tips https://logs.opendev.org/28/675328/1/check/osc-tox-py27-tips/61d13e9/ : SUCCESS in 4m 47s\n- osc-tox-py36-tips https://logs.opendev.org/28/675328/1/check/osc-tox-py36-tips/d36b90b/ : SUCCESS in 5m 21s\n- openstack-tox-docs https://logs.opendev.org/28/675328/1/check/openstack-tox-docs/2649a4e/html/ : SUCCESS in 3m 28s\n- osc-functional-devstack https://logs.opendev.org/28/675328/1/check/osc-functional-devstack/bea3864/ : SUCCESS in 56m 10s\n- osc-functional-devstack-tips https://logs.opendev.org/28/675328/1/check/osc-functional-devstack-tips/5343136/ : SUCCESS in 1h 01m 28s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"956547d7d1277a97a60dfb3466813df1b67436d1","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2019-08-08 14:42:25.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b13aa2978c01edde58a0f1b5b80777e6928e5c48","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 16:21:46.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://logs.opendev.org/28/675328/2/check/tempest-full/973f0f2/ : FAILURE in 1h 16m 40s\n- tempest-full-py3 https://logs.opendev.org/28/675328/2/check/tempest-full-py3/7271651/ : SUCCESS in 1h 32m 56s\n- openstack-tox-lower-constraints https://logs.opendev.org/28/675328/2/check/openstack-tox-lower-constraints/56156de/ : SUCCESS in 5m 25s\n- openstack-tox-pep8 https://logs.opendev.org/28/675328/2/check/openstack-tox-pep8/3c71f78/ : SUCCESS in 5m 25s\n- openstack-tox-py27 https://logs.opendev.org/28/675328/2/check/openstack-tox-py27/b44d7b0/ : SUCCESS in 4m 14s\n- openstack-tox-py36 https://logs.opendev.org/28/675328/2/check/openstack-tox-py36/89a731f/ : SUCCESS in 3m 23s\n- openstack-tox-py37 https://logs.opendev.org/28/675328/2/check/openstack-tox-py37/2806fd7/ : SUCCESS in 4m 47s\n- osc-tox-py27-tips https://logs.opendev.org/28/675328/2/check/osc-tox-py27-tips/d819a49/ : SUCCESS in 5m 20s\n- osc-tox-py36-tips https://logs.opendev.org/28/675328/2/check/osc-tox-py36-tips/46ea209/ : SUCCESS in 5m 07s\n- openstack-tox-docs https://logs.opendev.org/28/675328/2/check/openstack-tox-docs/9570146/html/ : SUCCESS in 3m 24s\n- osc-functional-devstack https://logs.opendev.org/28/675328/2/check/osc-functional-devstack/10a2c8d/ : SUCCESS in 57m 11s\n- osc-functional-devstack-tips https://logs.opendev.org/28/675328/2/check/osc-functional-devstack-tips/b2bea2f/ : SUCCESS in 1h 04m 48s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"864202c7298f2640601c38cc2b4a7b6363735c17","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2019-08-09 11:02:55.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"8dc3dffc3d418cfb393d6ada4b5040d9e6d506bd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 12:48:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://logs.opendev.org/28/675328/2/check/tempest-full/b27c836/ : SUCCESS in 1h 43m 36s\n- tempest-full-py3 https://logs.opendev.org/28/675328/2/check/tempest-full-py3/c08163c/ : SUCCESS in 1h 29m 50s\n- openstack-tox-lower-constraints https://logs.opendev.org/28/675328/2/check/openstack-tox-lower-constraints/026cd15/ : SUCCESS in 6m 02s\n- openstack-tox-pep8 https://logs.opendev.org/28/675328/2/check/openstack-tox-pep8/73bf730/ : SUCCESS in 3m 54s\n- openstack-tox-py27 https://logs.opendev.org/28/675328/2/check/openstack-tox-py27/e8c7919/ : SUCCESS in 3m 07s\n- openstack-tox-py36 https://logs.opendev.org/28/675328/2/check/openstack-tox-py36/5bbf27b/ : SUCCESS in 3m 49s\n- openstack-tox-py37 https://logs.opendev.org/28/675328/2/check/openstack-tox-py37/3c99d69/ : SUCCESS in 4m 04s\n- osc-tox-py27-tips https://logs.opendev.org/28/675328/2/check/osc-tox-py27-tips/d680c72/ : SUCCESS in 4m 17s\n- osc-tox-py36-tips https://logs.opendev.org/28/675328/2/check/osc-tox-py36-tips/2f56d12/ : SUCCESS in 6m 33s\n- openstack-tox-docs https://logs.opendev.org/28/675328/2/check/openstack-tox-docs/5386197/html/ : SUCCESS in 4m 06s\n- osc-functional-devstack https://logs.opendev.org/28/675328/2/check/osc-functional-devstack/348ac16/ : SUCCESS in 58m 36s\n- osc-functional-devstack-tips https://logs.opendev.org/28/675328/2/check/osc-functional-devstack-tips/7f8650f/ : SUCCESS in 57m 57s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e48fb7d28471add6d950d8c6f6486066ad377751","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-22 19:11:52.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"098d462003117c2d14cf0d513b638b0fb823815e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 19:12:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"27bb9631ff35297c3b7a3141603ba6730f13ab92","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 20:57:22.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/4a6e11fe8923444484a97f8cbf354345 : SUCCESS in 1h 38m 51s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/dc00ed50dfbb43fda2a4f29aa20637b7 : SUCCESS in 1h 38m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/89bea401a7f449feb3b9c8b90e7d245e : SUCCESS in 5m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8ce3dd0a5b4f4b4fb7cf3e8f8680ce70 : SUCCESS in 3m 20s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e93c697c17f9450daaae5d3b8cd80c6e : SUCCESS in 3m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c6a3b66323a64bb7a509b7bb163cd576 : SUCCESS in 4m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/882120f0915241bba79ef644cda4d63a : SUCCESS in 6m 28s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/d2562204a1b5458fb0caa6543aaca4d5 : SUCCESS in 4m 37s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/873b4dfa7b1046b8b58f8d3d00487a2f : SUCCESS in 5m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/33f1c8399ebe43d68639cca00a4506e5 : SUCCESS in 4m 53s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/ce0e0f4aa9c9414faa1d68dd94b07547 : SUCCESS in 1h 01m 02s","accounts_in_message":[],"_revision_number":2},{"id":"bc7b341ff19f023193e5d287c6812167898d3e15","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 20:57:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c6aa49d3d470f1062cec3e877bbae0ccff1cbade","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 20:58:40.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/13c0e757cb7f4c4f99aadbbfa6fa0574 : SUCCESS in 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2d4f3da09072b2c6df76f7f720084b1a314c6946","revisions":{"8dfc69c4cc5dceeda59d36da1064c292ebbc6e31":{"kind":"REWORK","_number":1,"created":"2019-08-08 13:00:01.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/28/675328/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/28/675328/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/1"}}},"commit":{"parents":[{"commit":"e78db3b8921c9727bc068b5ce91f766a0347ed65","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/e78db3b8921c9727bc068b5ce91f766a0347ed65"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2019-08-08 12:45:10.000000000","tz":180},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2019-08-08 12:59:58.000000000","tz":180},"subject":"Fix usage of NotFound exception","message":"Fix usage of NotFound exception\n\nAll built-in inheritors of osc_lib.exceptions.ClientException expects\n3 positional arguments: first argument is code, the second one is\nmessage.\n\nosc_lib.api.api.BaseAPI raises NotFound exception with transmitting only\nmessage arguments which goes to position of \u0027code\u0027 argument.\n\nThis patch adds `code\u003d404` argument and passes actual message as\n\u0027message\u0027.\n\nAlso, this patch adds a hack which check that processes code as\nmessage in case when code is not integer and None was found at \u0027message\u0027\nargument.\n\nFunny fact:\nMore than 4 years ago, I proposed a similar fix to oslo-incubator... it\nwas so long...\nhttps://review.opendev.org/#/c/94884 :)\n\nChange-Id: I022bbf3ce4bdd48b3bdcb008ee872c4f62a7b12b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/8dfc69c4cc5dceeda59d36da1064c292ebbc6e31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/8dfc69c4cc5dceeda59d36da1064c292ebbc6e31"}]},"branch":"refs/heads/master"},"2d4f3da09072b2c6df76f7f720084b1a314c6946":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-08-08 14:42:25.000000000","uploader":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"ref":"refs/changes/28/675328/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/28/675328/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/28/675328/2"}}},"commit":{"parents":[{"commit":"e78db3b8921c9727bc068b5ce91f766a0347ed65","subject":"Add Python 3 Train unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/e78db3b8921c9727bc068b5ce91f766a0347ed65"}]}],"author":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2019-08-08 12:45:10.000000000","tz":180},"committer":{"name":"Andrey Kurilin","email":"andr.kurilin@gmail.com","date":"2019-08-08 14:42:23.000000000","tz":0},"subject":"Fix usage of NotFound exception","message":"Fix usage of NotFound exception\n\nAll built-in inheritors of osc_lib.exceptions.ClientException expects\n3 positional arguments: first argument is code, the second one is\nmessage.\n\nosc_lib.api.api.BaseAPI raises NotFound exception with transmitting only\nmessage arguments which goes to position of \u0027code\u0027 argument.\n\nThis patch adds `code\u003d404` argument and passes actual message as\n\u0027message\u0027.\n\nAlso, this patch adds a hack that processes code as message\n n case when code is not an integer and None was found at \u0027message\u0027\nargument.\n\nFunny fact:\nMore than 4 years ago, I proposed a similar fix to oslo-incubator... it\nwas so long ago...\nhttps://review.opendev.org/#/c/94884 :)\n\nChange-Id: I022bbf3ce4bdd48b3bdcb008ee872c4f62a7b12b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/2d4f3da09072b2c6df76f7f720084b1a314c6946"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/2d4f3da09072b2c6df76f7f720084b1a314c6946"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}