)]}'
{"id":"openstack%2Fosc-lib~679474","triplet_id":"openstack%2Fosc-lib~master~Id57fc34c676059d8b13a490bfb74d1ee1ff52891","project":"openstack/osc-lib","branch":"master","topic":"679474","hashtags":[],"change_id":"Id57fc34c676059d8b13a490bfb74d1ee1ff52891","subject":"Handle nested dicts in format_dict()","status":"MERGED","created":"2019-08-30 16:14:18.000000000","updated":"2019-09-02 13:42:50.000000000","submitted":"2019-08-31 19:46:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"679474-1567280775210-1d226e13","meta_rev_id":"5c8297b50a61fa47642f99966d472e356f9efd13","_number":679474,"virtual_id_number":679474,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2019-08-31 19:46:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2019-08-31 05:11:28.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2019-08-31 17:59:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2019-08-31 17:59:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-31 17:59:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2019-08-31 19:46:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8d630f1c81624ea914a01f90f282aeebad242873","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-30 16:14:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"efe8ed9584cb8f034e879209612353998d33e9a5","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-30 16:47:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e7b6c373d7110c92559c0af51d141c804058d4e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-30 18:45:38.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/4582b2d880044a17b7addf4cd6864965 : SUCCESS in 1h 51m 59s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/58a4256c59b54ef0b1c6745a1bb3a7d0 : SUCCESS in 1h 30m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/11cef5e37f0345d492c077e2e4c9e036 : SUCCESS in 9m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cf6176336ff445778530339dfdb8259c : FAILURE in 3m 35s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a4c6abbbf1d2440789949c8943899c19 : SUCCESS in 7m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8d3f4b9a7d75418f9efa7a641bc8cf33 : SUCCESS in 4m 48s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b93773e1d790445698749f559378553b : SUCCESS in 4m 37s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/bfc9c681d60a46acac63f9d8911b957c : SUCCESS in 4m 59s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/96317b66ddbb4a539c0e203968aac169 : SUCCESS in 7m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c80f93cfdcd4825ac89bf31464dc182 : SUCCESS in 4m 16s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/80a6c83cbe3640ca878727464ebfc05e : SUCCESS in 1h 00m 33s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/3a0bd260a6e54ca68414c9504afb2cef : SUCCESS in 1h 21m 39s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"aea8c6c456f7833640589aec2270ff4c3c168a65","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-31 05:04:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b444987978c00b03eebf771c4db6398f195f027c","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2019-08-31 05:11:28.000000000","message":"Patch Set 3: Code-Review+2\n\n+2 to dean\u0027s side","accounts_in_message":[],"_revision_number":3},{"id":"62ff79b3ea80573639ab116082d8cecd8ccd38fb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-31 06:53:34.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/209162ef783142bbb3cca12919409372 : SUCCESS in 1h 48m 22s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5994d79f5deb4f3a9812bac666ac0a10 : SUCCESS in 1h 28m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f3f0eba9c07e4e7d9db3d9446568b423 : SUCCESS in 5m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/14358c7d2ba04da48a756231d9cdfb8a : SUCCESS in 4m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/638d03ca70454d58a6f6a57232a3fa7d : SUCCESS in 4m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/074a889478f7434d904f44a4f801cc34 : SUCCESS in 4m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/636857bf357c4348a64f5537f68ab5df : SUCCESS in 3m 25s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/5eca5c917f514e6d820a8d58e2ae68e9 : SUCCESS in 4m 17s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/5e99af0f17e34d3a9bd212ffe358813b : SUCCESS in 4m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/acffdb4ce37043a59c62bfbd178307f1 : SUCCESS in 4m 41s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a06faac162b24fd6b5eb8625954474a5 : SUCCESS in 4m 30s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/8a6c36c7970c44e2989250bb63a3a99c : SUCCESS in 1h 02m 12s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/8d47d85c358348c39a58d7730ec0983d : FAILURE in 59m 22s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"edac0f880b9730d7a610551c17c80f792f81a78e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-08-31 17:59:41.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nThe -tips failure is in volume tests","accounts_in_message":[],"_revision_number":3},{"id":"77d141f166e14210eaaf3ca99384556de3c682c6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-31 17:59:52.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"dc5fc015351ca498b9e339e36203f5948a53e305","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-31 19:46:14.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/89aba2f0dd904ceda78bd26517a5335b : SUCCESS in 1h 44m 07s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6bac4783a2584bba80197e18a1a9446d : SUCCESS in 1h 37m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/aa3ad32b87044191adeeecabf961a443 : SUCCESS in 4m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c082857e2bc947aab985f55e24ff26c4 : SUCCESS in 4m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6ea8f09f6d7e4ef5a7fd92a04c2b39e3 : SUCCESS in 3m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c9a5834a05a84e4d8f0688addd00da42 : SUCCESS in 3m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/b86a967c655545f5aa293a3e8da02d2f : SUCCESS in 5m 00s\n- osc-tox-py27-tips https://zuul.opendev.org/t/openstack/build/b22d0829d26943f7880779afe2ab3539 : SUCCESS in 5m 14s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/dd7f61b18d49445aa0d0be31a40ba939 : SUCCESS in 5m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7adb5a0cd29d458ba24de00d93466f23 : SUCCESS in 4m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/336437bd5bae4dce96e47b8b83b09634 : SUCCESS in 3m 16s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/1f66d3fe5f01406d87f3595cd85ca23c : SUCCESS in 57m 51s","accounts_in_message":[],"_revision_number":3},{"id":"e98dbfa2cfd99588e6eb12c03211bd8c9cae0487","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-31 19:46:15.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"1d09a850a3833e1a1297938abfcc47d618bab82c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-31 19:47:39.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa6c3a3738dd473bb1e12b4d505151ec : SUCCESS in 1m 09s","accounts_in_message":[],"_revision_number":3},{"id":"5bb2b9de85c091ea66b4f8275f4d03bbe471c846","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-02 12:33:58.000000000","message":"Patch Set 3:\n\nIMO this should ignore fields that have None as value. Currently it outputs things like\n\nproject.domain_id\u003d\u0027None\u0027\n\nwhich is undistinguishable from fields that have the string \"None\" as their value.","accounts_in_message":[],"_revision_number":3},{"id":"bad369881f6415d8d7159356e1495ba59102ba70","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2019-09-02 13:42:50.000000000","message":"Patch Set 3:\n\nAs this is a library function I \u0027m not convinced that making editorial decisions on content is appropriate here.  There is also a difference between a key being present (valued None) and not being present so omitting them is the same problem in the other direction.\n\nHowever, yes, out of \u0027None\u0027 \u003d\u003d None is misleading.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6db6492a7de5f7a3e09473c31e23e03d10f420b6","revisions":{"117915fe601efb383c807c4c33b068cf18072768":{"kind":"REWORK","_number":1,"created":"2019-08-30 16:14:18.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/74/679474/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/74/679474/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/1"}}},"commit":{"parents":[{"commit":"17179a72b021e0e5d848a3c852d297ec9a45e1c7","subject":"Merge \"Cleanups to prepare for OSC 4 release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/17179a72b021e0e5d848a3c852d297ec9a45e1c7"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2019-08-30 16:13:29.000000000","tz":120},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2019-08-30 16:14:16.000000000","tz":120},"subject":"Add a MunchColumn type","message":"Add a MunchColumn type\n\nSome things from sdk come back as Munch or as Resource - both of\nwhich support a to_dict() method to make a plain dict. Add support\nfor columns using it.\n\nChange-Id: Id57fc34c676059d8b13a490bfb74d1ee1ff52891\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/117915fe601efb383c807c4c33b068cf18072768"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/117915fe601efb383c807c4c33b068cf18072768"}]},"branch":"refs/heads/master"},"7be4968e6481ee9f3fedf7f16d394e4b6c08706a":{"kind":"REWORK","_number":2,"created":"2019-08-30 16:47:25.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/74/679474/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/74/679474/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/2"}}},"commit":{"parents":[{"commit":"17179a72b021e0e5d848a3c852d297ec9a45e1c7","subject":"Merge \"Cleanups to prepare for OSC 4 release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/17179a72b021e0e5d848a3c852d297ec9a45e1c7"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2019-08-30 16:13:29.000000000","tz":120},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2019-08-30 16:47:17.000000000","tz":120},"subject":"Handle nested dicts","message":"Handle nested dicts\n\nSome dicts have dicts in them. Handle them.\n\nChange-Id: Id57fc34c676059d8b13a490bfb74d1ee1ff52891\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/7be4968e6481ee9f3fedf7f16d394e4b6c08706a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/7be4968e6481ee9f3fedf7f16d394e4b6c08706a"}]},"branch":"refs/heads/master"},"6db6492a7de5f7a3e09473c31e23e03d10f420b6":{"kind":"REWORK","_number":3,"created":"2019-08-31 05:04:29.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/74/679474/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/74/679474/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/74/679474/3"}}},"commit":{"parents":[{"commit":"17179a72b021e0e5d848a3c852d297ec9a45e1c7","subject":"Merge \"Cleanups to prepare for OSC 4 release\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/17179a72b021e0e5d848a3c852d297ec9a45e1c7"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2019-08-30 16:13:29.000000000","tz":120},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2019-08-31 05:02:47.000000000","tz":-300},"subject":"Handle nested dicts in format_dict()","message":"Handle nested dicts in format_dict()\n\nSome dicts have dicts in them. Handle them.\n\nStory: 2006480\nTask: 36423\nChange-Id: Id57fc34c676059d8b13a490bfb74d1ee1ff52891\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/6db6492a7de5f7a3e09473c31e23e03d10f420b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/6db6492a7de5f7a3e09473c31e23e03d10f420b6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}