)]}'
{"osc_lib/utils/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af10cdd3c6d0c1b56dff2d256aa25fa487ddc77a","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    res_ids \u003d set(res_ids)"},{"line_number":686,"context_line":"    success \u003d set()"},{"line_number":687,"context_line":"    failure \u003d set()"},{"line_number":688,"context_line":"    errors \u003d []"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    while total_time \u003c timeout:"},{"line_number":691,"context_line":"        progress \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_51253c08","line":688,"range":{"start_line":688,"start_character":3,"end_line":688,"end_character":15},"updated":"2020-11-12 11:50:20.000000000","message":"i woudl just add this to wait for status return type\n\nso (success, failures, errors)\nthe let the caller raise the excptrions instead.\n\nthen we dont need a second almost identical function.","commit_id":"43f75945feebf7d35680fa961426e74f9d9f757c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13b44131560a0055abcaba5e738331b4c577e874","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    res_ids \u003d set(res_ids)"},{"line_number":686,"context_line":"    success \u003d set()"},{"line_number":687,"context_line":"    failure \u003d set()"},{"line_number":688,"context_line":"    errors \u003d []"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    while total_time \u003c timeout:"},{"line_number":691,"context_line":"        progress \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"020707ec_5133b3b2","line":688,"range":{"start_line":688,"start_character":3,"end_line":688,"end_character":15},"in_reply_to":"1f621f24_51253c08","updated":"2021-01-08 18:25:39.000000000","message":"I want to mimic the behavior of the existing function as closely as possible so I\u0027m doing things like they were done there","commit_id":"43f75945feebf7d35680fa961426e74f9d9f757c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"af10cdd3c6d0c1b56dff2d256aa25fa487ddc77a","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                # the message"},{"line_number":699,"context_line":"                res \u003d manager.get(res_id)"},{"line_number":700,"context_line":"            except Exception as ex:"},{"line_number":701,"context_line":"                if type(ex).__name__ in exception_name:"},{"line_number":702,"context_line":"                    success.add(res_id)"},{"line_number":703,"context_line":"                    continue"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_118584cf","line":701,"range":{"start_line":701,"start_character":15,"end_line":701,"end_character":54},"updated":"2020-11-12 11:50:20.000000000","message":"this is kind of ugly.\nit works but it would be better to pass an list of excption types not a string to this function.","commit_id":"43f75945feebf7d35680fa961426e74f9d9f757c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"13b44131560a0055abcaba5e738331b4c577e874","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                # the message"},{"line_number":699,"context_line":"                res \u003d manager.get(res_id)"},{"line_number":700,"context_line":"            except Exception as ex:"},{"line_number":701,"context_line":"                if type(ex).__name__ in exception_name:"},{"line_number":702,"context_line":"                    success.add(res_id)"},{"line_number":703,"context_line":"                    continue"},{"line_number":704,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3025b2cc_11e6d63b","line":701,"range":{"start_line":701,"start_character":15,"end_line":701,"end_character":54},"in_reply_to":"1f621f24_118584cf","updated":"2021-01-08 18:25:39.000000000","message":"Agreed, but as above I want to keep this as close to the singular function as possible. In the future we could change that to accept an actual exception type rather than a string","commit_id":"43f75945feebf7d35680fa961426e74f9d9f757c"}]}