)]}'
{"id":"openstack%2Fosc-lib~792236","triplet_id":"openstack%2Fosc-lib~master~Ib7e9958d5a64e6500bc38eed9d3e783d5a48d21f","project":"openstack/osc-lib","branch":"master","hashtags":[],"change_id":"Ib7e9958d5a64e6500bc38eed9d3e783d5a48d21f","subject":"Add check for sdk_connection","status":"MERGED","created":"2021-05-19 18:24:56.000000000","updated":"2021-06-01 12:32:14.000000000","submitted":"2021-05-21 15:51:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"792236","meta_rev_id":"7a163389518aa9d2b4d031e48881a9e9dab99093","_number":792236,"virtual_id_number":792236,"owner":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-21 15:51:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"recommended":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":1,"date":"2021-05-19 18:26:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2021-05-19 18:28:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2021-05-21 14:59:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"CC":[{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-19 18:26:45.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-05-19 18:28:59.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2021-05-19 19:21:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-01 12:32:14.000000000","updated_by":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"reviewer":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"state":"CC"}],"messages":[{"id":"6f925600515d37886e6300191815956438c6d5d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2021-05-19 18:24:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c5d96303b3029872a845bc42ce8c324681181bc4","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-05-19 18:26:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"209aae9f1baa406fce256785db1f7ceab2b87239","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-05-19 18:28:59.000000000","message":"Patch Set 1: Code-Review+2\n\nAre you using osc-lib outside osc\u0026ask?","accounts_in_message":[],"_revision_number":1},{"id":"b59f47cb71cd470e29ec3884f38e99aa2083adae","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-05-19 18:29:34.000000000","message":"Patch Set 1:\n\nAre you using osc-lib outside osc\u0026sdk?","accounts_in_message":[],"_revision_number":1},{"id":"aed230930f8311aa155bd5eb28e6bd8f8cf5427e","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-05-19 18:30:47.000000000","message":"Patch Set 1:\n\nno this showed up in our openstack client usage as integrated with tripleoclient. I wonder if it\u0027s a version mismatch somewhere","accounts_in_message":[],"_revision_number":1},{"id":"8f9cdf6612c8ea19c1f602feb45acfa213725aba","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-05-19 18:32:17.000000000","message":"Patch Set 1:\n\nlooks like we have an older openstackclient than osc-lib\n\npython3-osc-lib-2.4.0-0.20210514160935.1354890.el8.noarch\npython3-osc-placement-2.2.0-0.20210128084958.f7640c9.el8.noarch\npython3-openstacksdk-0.56.0-0.20210504111325.b38e717.el8.noarch\npython3-openstackclient-5.5.0-0.20210330140909.86bca18.el8.noarch\npython-openstackclient-lang-5.5.0-0.20210330140909.86bca18.el8.noarch","accounts_in_message":[],"_revision_number":1},{"id":"b3e189cb08f1ec98f2d01a4cbfa3f4ec93ea36f6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 19:21:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7c74200ef45e480a87941ec76f00b4b7 : SUCCESS in 5m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/87e5ddad267a40938e44f070a7cdc344 : SUCCESS in 4m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/65554e0323e048b6841769ffb96eb4ad : SUCCESS in 4m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/90c3289da038480cbf3f21b537c8b8d6 : SUCCESS in 4m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f339fcd6a44644f384b08669413a94c2 : SUCCESS in 4m 35s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/3bb44e20496c481bbf245e9e9aacd689 : SUCCESS in 5m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ea4a8534a64d4943b285b9683bb677c5 : SUCCESS in 4m 56s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/976b19c6e2724e7d9def1a310933c1c7 : FAILURE in 54m 28s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/cda9d34dee7f4cda83a00fb87416031b : SUCCESS in 52m 21s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"35ab9c91e3e6522813486be65a82b1c7814947c6","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2021-05-19 20:33:27.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9b94222cc96d7e1baab61046b6997e976584841f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 21:51:55.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8caeb271bd4c4489835a5d5ecd05088c : SUCCESS in 5m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ff7595e91b7b4f808c1b7957f22f9608 : SUCCESS in 3m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/54bae1335ef544ee932f375c91b9c41e : SUCCESS in 3m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8d72c1651d0a4b12865bf22cbd4eb39b : SUCCESS in 3m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0eac9aa5ce964d4a9b5ffab56ca5f3c5 : SUCCESS in 3m 33s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/76abd3ee39e24f7387ef87f00c24e4af : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/53a789f1a5834459ba4de295533f2f4b : SUCCESS in 3m 52s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/640234b126b04037be841a089d76570b : FAILURE in 47m 38s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/3d7c5eee7ce640ad9bec498d5a08cd73 : SUCCESS in 1h 12m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"58e9a9e4d30b738bc01d91569cd2fe6257029285","author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"date":"2021-05-20 01:08:24.000000000","message":"Patch Set 1:\n\nlooks like devstack is broken for a reason unrelated to this change.","accounts_in_message":[],"_revision_number":1},{"id":"c8fc37c9a51db6dd1c1236d0ce73fec1767d155c","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-05-21 13:34:15.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"12d854e8bf2cd96ba7ecf994f5ccbd5a4d3f3acc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 14:59:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6adee38eafb44a0698ed79528cf90b62 : SUCCESS in 6m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0b42b30bfb7483db3ec595d9a9211d1 : SUCCESS in 5m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4b967ddc92d045118bef849757fca7eb : SUCCESS in 8m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f08bcf62b96d409c8f396d19e1975e4b : SUCCESS in 8m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9cf641dd64a84abaa791ff8f638b6a6d : SUCCESS in 7m 52s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/0657046391484740a4e13b30e015c46a : SUCCESS in 6m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30d7173862b1433a9056df8deff1362d : SUCCESS in 6m 17s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/dc2e199a42a344449e2903aad4ec5c9c : SUCCESS in 55m 42s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/46f3c455378143b5baea1013541dcef1 : SUCCESS in 1h 00m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f62604b9a96338203c0bd642edf1625d309ea128","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-05-21 14:59:59.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9c2f4bc6939fb924eed9d30fbf6e2a2903b8ead5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 15:00:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"019c1555b08bf38b6b393365cef034e3db7d9626","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 15:51:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1bec42acd2b2426cb40c10ba5968d574 : SUCCESS in 6m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/64f9c10835c04daa8cccad79961d8f57 : SUCCESS in 6m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/41574a51e36a4a399a4b774e91b1c041 : SUCCESS in 6m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1b3656e3c36b425590fcb361e060017d : SUCCESS in 6m 05s\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/1152a045c77b41288593a676a5519645 : SUCCESS in 6m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c101bf67feb49a7a4902a60a865bb23 : SUCCESS in 6m 05s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/50ad466a15fc40489b106367c58453c8 : SUCCESS in 50m 07s","accounts_in_message":[],"_revision_number":1},{"id":"ee81bc1ada24fb77617f1b4c596411ff14170415","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 15:51:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"456b746a731423f10d52b88093aa44771be2da1b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-21 15:52:41.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d8c6b241889d48d2aad6ed8e02df93eb : SUCCESS in 1m 14s","accounts_in_message":[],"_revision_number":1},{"id":"7a163389518aa9d2b4d031e48881a9e9dab99093","author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"date":"2021-06-01 12:32:14.000000000","message":"Patch Set 1:\n\nI was wondering. Should we backport this to Wallaby?\nSee, if the related change does get in the stable at some point, and we forget about this fix, the bug might break some of our jobs.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dd75c8fdbf1662928038103f199d66141107c569","revisions":{"dd75c8fdbf1662928038103f199d66141107c569":{"kind":"REWORK","_number":1,"created":"2021-05-19 18:24:56.000000000","uploader":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"ref":"refs/changes/36/792236/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/36/792236/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/792236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/792236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/792236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/36/792236/1"}}},"commit":{"parents":[{"commit":"1354890f0bd6ea4b0ac8022a9130a15d61525d47","subject":"Merge \"Add Python3 xena unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/1354890f0bd6ea4b0ac8022a9130a15d61525d47"}]}],"author":{"name":"Kevin Carter","email":"kecarter@redhat.com","date":"2021-05-19 18:23:05.000000000","tz":-300},"committer":{"name":"Kevin Carter","email":"kecarter@redhat.com","date":"2021-05-19 18:24:55.000000000","tz":-300},"subject":"Add check for sdk_connection","message":"Add check for sdk_connection\n\nThis change checks if the attribute sdk_connection exists\nbefore attempting to close it. Without this change we\u0027re\nseeing the following exception:\n\n\u003e Could not clean up: \u0027ClientManager\u0027 object has no attribute \u0027sdk_connection\u0027\n\nRelated-Change: https://review.opendev.org/c/openstack/osc-lib/+/765650\nSigned-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e\nChange-Id: Ib7e9958d5a64e6500bc38eed9d3e783d5a48d21f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/dd75c8fdbf1662928038103f199d66141107c569"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/dd75c8fdbf1662928038103f199d66141107c569"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}