)]}'
{"id":"openstack%2Fosc-lib~813236","triplet_id":"openstack%2Fosc-lib~master~Ib39cae4895aef3297b48ef9ff0d13ada6b7b586e","project":"openstack/osc-lib","branch":"master","topic":"sdk-v1-cleanup","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-03-28 15:38:56.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ib39cae4895aef3297b48ef9ff0d13ada6b7b586e","subject":"utils: Remove unnecessary attribute check","status":"ABANDONED","created":"2021-10-08 17:39:12.000000000","updated":"2023-03-28 15:38:56.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b0f14473c1bee3d4eb962e850d62feeda9dfa86b","_number":813236,"virtual_id_number":813236,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-10-13 12:40:53.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-10-08 18:34:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"016d7b682bf2494001ae68d609a1d877efb21d1e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-10-08 17:39:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"20bbb900ebd953abe6dff2a750c884fd8cbf8d57","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-08 18:34:55.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3bd53bd86d074925ada1ea9de0ca4d0f : FAILURE in 5m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9a4db83b8c01445d86efe030d0348048 : FAILURE in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/865ab3d8593a43a1a290a2b1a145f722 : FAILURE in 5m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0bd6eec1348d40aa99b6fe49b83bfb79 : FAILURE in 4m 40s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5a37ed25d46744de90fe3153bd4ddbbd : FAILURE in 5m 32s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/fe22fc9c779649c890d465b3257eeb6a : FAILURE in 6m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/be72ba3662394adb935932ca4a9dffdc : SUCCESS in 5m 41s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/4a81eb19bc89416c8a55a93abe5b7610 : SUCCESS in 50m 37s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/7ba16709f47e425d87cbdd1e7c72f4db : FAILURE in 52m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"eae662a4bd801f0239e91505c4e6e1c2cb5c9bbe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-10-13 11:50:32.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"cba4f3effcc1df695d7299805179ccd2e46202d5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-10-13 12:40:53.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/07868a78f2784c0195c05bbbe4108495 : FAILURE in 4m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e5b2a5c027b84c28aafc6397bcf79185 : SUCCESS in 3m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1dc75978b30c4389bd63b510b6c9a7b5 : FAILURE in 4m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0ef6458c5417434780018f0a55123108 : FAILURE in 3m 46s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/76877ff2bc4b4fef89df37153ca29149 : FAILURE in 4m 22s (non-voting)\n- osc-tox-py36-tips https://zuul.opendev.org/t/openstack/build/47c6d51a90eb4dc0bbbb38ff3e1b28d3 : FAILURE in 5m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c3969bd27ecf419a873f51c9e395f89e : SUCCESS in 4m 36s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/86485aa1f68f43639759f721d40e433d : FAILURE in 32m 03s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/4853e682d409402da968faa9528027d6 : FAILURE in 47m 35s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"b0f14473c1bee3d4eb962e850d62feeda9dfa86b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2023-03-28 15:38:56.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d45573249c2138829be36050e8258a7855a14ff5","revisions":{"4b44c932ee55d4eefa953c19d025819fc4ebe8da":{"kind":"REWORK","_number":1,"created":"2021-10-08 17:39:12.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/36/813236/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/36/813236/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/1"}}},"commit":{"parents":[{"commit":"08d70a6c68e72c71248d970dcc733eda88d19db9","subject":"Don\u0027t display Munch objects in the output","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/08d70a6c68e72c71248d970dcc733eda88d19db9"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-10-08 17:13:50.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-10-08 17:18:54.000000000","tz":60},"subject":"utils: Remove unnecessary attribute check","message":"utils: Remove unnecessary attribute check\n\nThe \u0027get_osc_show_columns_for_sdk_resource\u0027 method was checking for the\npresence of an \u0027allow_get\u0027 attribute on the provided SDK resource. This\nseems to have been used as a sentinel to determine whether the provided\nresource was an instance of \u0027openstack.resource.Resource\u0027 or not.\nHowever, the \u0027allow_get\u0027 attribute is deprecated for removal and no one\nshould be passing anything else to this method.\n\nRemove the check and correct the docstring to better indicate what kind\nof object we expect.\n\nChange-Id: Ib39cae4895aef3297b48ef9ff0d13ada6b7b586e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/4b44c932ee55d4eefa953c19d025819fc4ebe8da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/4b44c932ee55d4eefa953c19d025819fc4ebe8da"}]},"branch":"refs/heads/master"},"d45573249c2138829be36050e8258a7855a14ff5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-10-13 11:50:32.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/36/813236/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/36/813236/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/36/813236/2"}}},"commit":{"parents":[{"commit":"8eaec2bc210cebc087017b67edd2d4d481925d6e","subject":"Don\u0027t display Munch objects in the output","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/8eaec2bc210cebc087017b67edd2d4d481925d6e"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-10-08 17:13:50.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-10-13 11:39:15.000000000","tz":60},"subject":"utils: Remove unnecessary attribute check","message":"utils: Remove unnecessary attribute check\n\nThe \u0027get_osc_show_columns_for_sdk_resource\u0027 method was checking for the\npresence of an \u0027allow_get\u0027 attribute on the provided SDK resource. This\nseems to have been used as a sentinel to determine whether the provided\nresource was an instance of \u0027openstack.resource.Resource\u0027 or not.\nHowever, the \u0027allow_get\u0027 attribute is deprecated for removal and no one\nshould be passing anything else to this method.\n\nRemove the check and correct the docstring to better indicate what kind\nof object we expect.\n\nChange-Id: Ib39cae4895aef3297b48ef9ff0d13ada6b7b586e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/d45573249c2138829be36050e8258a7855a14ff5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/d45573249c2138829be36050e8258a7855a14ff5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}