)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2227675950c9b5d898b241c3b6150cc4654799c7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"manual sanitizing.   For instance, when running `openstack complete`,"},{"line_number":11,"context_line":"it appends the following two lines:"},{"line_number":12,"context_line":"~~~"},{"line_number":13,"context_line":"complete -F _openstack openstack"},{"line_number":14,"context_line":"2022-05-10 12:50:25.052 863 INFO osc_lib.shell [-] END return value: 0"},{"line_number":15,"context_line":"~~~"},{"line_number":16,"context_line":"and in the current .spec file, we manually remove the `complete -F`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ad89c5b9_1f17728c","line":13,"updated":"2022-08-22 17:00:47.000000000","message":"This line is completely valid and is what actually activates the generated completions, I don\u0027t understand why you would consider it as wrong.","commit_id":"dab28833921b5464016480b9894e6caf12fb3d9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2227675950c9b5d898b241c3b6150cc4654799c7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"it appends the following two lines:"},{"line_number":12,"context_line":"~~~"},{"line_number":13,"context_line":"complete -F _openstack openstack"},{"line_number":14,"context_line":"2022-05-10 12:50:25.052 863 INFO osc_lib.shell [-] END return value: 0"},{"line_number":15,"context_line":"~~~"},{"line_number":16,"context_line":"and in the current .spec file, we manually remove the `complete -F`"},{"line_number":17,"context_line":"line but we still get that LOG.info output in train at least.  This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a5075535_d456192c","line":14,"updated":"2022-08-22 17:00:47.000000000","message":"This line should be seen on stderr and not on stdout and thus should not affect anything you generate.","commit_id":"dab28833921b5464016480b9894e6caf12fb3d9c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2227675950c9b5d898b241c3b6150cc4654799c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3df777bd_56a60f04","updated":"2022-08-22 17:00:47.000000000","message":"I didn\u0027t get to review the patch on master, so discussing it here. Can you explain how exactly the current behavior is broken for you?","commit_id":"dab28833921b5464016480b9894e6caf12fb3d9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8cd548b2065605fb900180304688de0ede86c48b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f3d9f52_819a7f6e","updated":"2022-10-10 19:34:45.000000000","message":"proposed a revert of the master patch now https://review.opendev.org/c/openstack/osc-lib/+/860890","commit_id":"85806cab8351961ccfa16d5d730fbc0493218d1e"}],"osc_lib/shell.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fcc5e20e5251e268f300c048cc9436c1aee038a0","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            return ret_val"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        finally:"},{"line_number":147,"context_line":"            if \u0027complete\u0027 not in argv:"},{"line_number":148,"context_line":"                self.log.info(\"END return value: %s\", ret_val)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def init_profile(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"84f55699_05808193","line":147,"updated":"2022-08-22 17:10:56.000000000","message":"FWIW I\u0027m also concerned by the lack of specifity of this check. Like it will also filter the log message for something like \"openstack user show complete\".","commit_id":"dab28833921b5464016480b9894e6caf12fb3d9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fcc5e20e5251e268f300c048cc9436c1aee038a0","unresolved":true,"context_lines":[{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        # Parent __init__ parses argv into self.options"},{"line_number":398,"context_line":"        super(OpenStackShell, self).initialize_app(argv)"},{"line_number":399,"context_line":"        self.log.info(\"START with options: %s\","},{"line_number":400,"context_line":"                      strutils.mask_password(\" \".join(self.command_options)))"},{"line_number":401,"context_line":"        self.log.debug(\"options: %s\","},{"line_number":402,"context_line":"                       strutils.mask_password(self.options))"}],"source_content_type":"text/x-python","patch_set":1,"id":"aa2f7da0_d12a4d09","line":399,"updated":"2022-08-22 17:10:56.000000000","message":"I\u0027m also wondering why this patch doesn\u0027t look at this line, too. Its output should land in the same location as the END","commit_id":"dab28833921b5464016480b9894e6caf12fb3d9c"}]}