)]}'
{"id":"openstack%2Fosc-lib~953637","triplet_id":"openstack%2Fosc-lib~master~Id7061bf410931001eaa8a2eb4a242fb146054d0e","project":"openstack/osc-lib","branch":"master","topic":"pyproject","hashtags":[],"change_id":"Id7061bf410931001eaa8a2eb4a242fb146054d0e","subject":"mypy: Enable strict mode","status":"MERGED","created":"2025-06-27 17:25:26.000000000","updated":"2025-06-27 19:28:19.000000000","submitted":"2025-06-27 19:27:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"953637-pyproject","meta_rev_id":"4a813040531184b3123db1f787089f906d8271ea","_number":953637,"virtual_id_number":953637,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-06-27 19:27:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2025-06-27 17:25:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2025-06-27 17:25:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-27 18:15:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"120f5eb95c55abfc66ba8e6fcfaa34c11361d04f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-06-27 17:25:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"84bbdf9111b511662e1be98779e8e02b2f6b0dd7","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-06-27 17:25:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7475ab4dad87ee5d90d9de17bda92bc854748542","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 18:15:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9da1f84845704de4a5c1f6a5096e06d6\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/11262a42d0ae428ca1e59ffba9f57e59 : SUCCESS in 3m 34s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/e7c938bae4174ed08d61f37f0ec193d1 : SUCCESS in 2m 47s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/c8f10a7fed814155b426d42f6a3df9af : SUCCESS in 1m 43s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/6acdf4be7e384305b4919ec1a82c38b0 : SUCCESS in 4m 48s (non-voting)\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/71743cbe20764823b698d9a0822c5eb2 : SUCCESS in 6m 00s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/ec6c93d5a8bb4b78b3bd1cf899ba9612 : SUCCESS in 8m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aacb540956244cfe9cfa8db1c933f386 : SUCCESS in 3m 23s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/11b5eefd8d68416d9f141cd08607e81c : SUCCESS in 49m 41s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/d51c5b8b428a4777833029913d21fcac : SUCCESS in 40m 20s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0727601adb5141cb3abebd309ba1ccc9ebca501a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 18:19:55.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4c8b13a71e41f2f9531a54921cf10ea2961bccfd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 19:27:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a94cf02f367f47aa9db130eb82971f67\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/38594f17f6fc495ab054e17792730b58 : SUCCESS in 5m 35s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/dc2b92d8873e4db39c8f34dba65aa4f3 : SUCCESS in 2m 47s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/a7cad5c6eb1c44699f50b2c1ca00e57b : SUCCESS in 1m 45s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/d1de33bef7e14ed79a177b82c031930b : SUCCESS in 3m 44s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/f7b106dd74574073bd7f844e21898fa5 : SUCCESS in 9m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30c3d5d8dcff48f6a21c107848fbf9f4 : SUCCESS in 2m 25s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/b54452e1afc74eb192dc9aa32dd43ce1 : SUCCESS in 1h 03m 14s","accounts_in_message":[],"_revision_number":1},{"id":"0153b0509b3b84b087fde76c8b7e721928170583","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 19:27:31.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"4a813040531184b3123db1f787089f906d8271ea","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 19:28:19.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2ad9b5d578e640049988265b6492b003\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b88c3d9f6dde45e19da33b05aeaf706f : SUCCESS in 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"33968f15ce82d9b236cb7a34efa0396ce9472ade","revisions":{"33968f15ce82d9b236cb7a34efa0396ce9472ade":{"kind":"REWORK","_number":1,"created":"2025-06-27 17:25:26.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/37/953637/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/37/953637/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/37/953637/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/37/953637/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/37/953637/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/37/953637/1"}}},"commit":{"parents":[{"commit":"49bbd096cb62ab168fa6818c7cb972a486fdfb12","subject":"Remove duplicate Python version declarations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/49bbd096cb62ab168fa6818c7cb972a486fdfb12"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-06-27 17:14:32.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-06-27 17:25:14.000000000","tz":60},"subject":"mypy: Enable strict mode","message":"mypy: Enable strict mode\n\nThis is the same as what we were doing.\n\nChange-Id: Id7061bf410931001eaa8a2eb4a242fb146054d0e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/33968f15ce82d9b236cb7a34efa0396ce9472ade"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/33968f15ce82d9b236cb7a34efa0396ce9472ade"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}