)]}'
{"id":"openstack%2Fosc-lib~970673","triplet_id":"openstack%2Fosc-lib~master~Ic2b1e88f02526581c7662d037228fc0e6539084a","project":"openstack/osc-lib","branch":"master","topic":"typing","hashtags":[],"change_id":"Ic2b1e88f02526581c7662d037228fc0e6539084a","subject":"typing: Use Mapping, not dict","status":"MERGED","created":"2025-12-11 18:42:59.000000000","updated":"2025-12-11 21:30:42.000000000","submitted":"2025-12-11 21:29:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"970673-typing","meta_rev_id":"17e9272e3521134ff4ac28c8a9217ae0311460a2","_number":970673,"virtual_id_number":970673,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-12-11 21:29:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":2,"date":"2025-12-11 19:16:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":1,"date":"2025-12-11 19:16:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-11 20:00:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a8cf1a196ae8c871e97233624493bf34a75d341d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-11 18:42:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d63789fe7fe0b0b05478b0909a6a6ef0d7fe4e45","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2025-12-11 19:16:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"df6428aa929ca762d0a916e70bcf7e5e6ee83d9a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-11 20:00:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/d250cb3edd53446d9c8db3bd26151e4a\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b421189542714f39a08769c25dabc92f : SUCCESS in 4m 06s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/73f335c17c5d4aa78e19cb5eb71ca633 : SUCCESS in 2m 19s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/06e5fb79eb254f69be761862a34030d3 : SUCCESS in 3m 39s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/db094f289a1e4a9da2682e668b529a2f : SUCCESS in 4m 32s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/23d159a07728439b8afa319159d6e62b : SUCCESS in 3m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3f8670dd4dbf4e03aeb1d7db394d51f1 : SUCCESS in 3m 31s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/45390d59823a41cf9f489602521ce953 : SUCCESS in 45m 46s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/b28bee0a2d3642f2bef2a4adc38335c3 : SUCCESS in 1h 12m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3697ddad33fb89db7a0f836cccc42eae8f0ccc35","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-11 20:07:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d17ea27bf79a369df3799cce0a15e37435e65fc7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-11 21:29:12.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5c5c02ca7dbc4dd183b7e73784b1fa81\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9217efe572b8445dae22eefcdcee26f2 : SUCCESS in 2m 33s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/7cb6ce16930745fe96a1943c2de6b83b : SUCCESS in 2m 11s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/b2c046947eaf494ab63c6846dabae459 : SUCCESS in 4m 37s\n- osc-tox-py310-tips https://zuul.opendev.org/t/openstack/build/94606b23dc194ad487cce2b5cf9c4f3f : SUCCESS in 4m 21s\n- osc-tox-py313-tips https://zuul.opendev.org/t/openstack/build/0fe0f1fb4ae84a4b958de85a59c48ebc : SUCCESS in 6m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/20214f3ebe074779b2534182f05431c8 : SUCCESS in 2m 24s\n- osc-functional-devstack https://zuul.opendev.org/t/openstack/build/94543e3c94d64b508a1de4f01d2b1028 : SUCCESS in 42m 04s","accounts_in_message":[],"_revision_number":1},{"id":"1a6aca448cd92a2272efb261ebb9b48c971a98c8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-11 21:29:12.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"17e9272e3521134ff4ac28c8a9217ae0311460a2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-11 21:30:42.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/016a6e4a046042e8991d4cd840fba30e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1024136407dd42a7825fc17de132094a : SUCCESS in 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"edac60e6b7ac874f41b12c508e6e32672622941d","revisions":{"edac60e6b7ac874f41b12c508e6e32672622941d":{"kind":"REWORK","_number":1,"created":"2025-12-11 18:42:59.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/73/970673/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osc-lib","ref":"refs/changes/73/970673/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/73/970673/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/73/970673/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osc-lib refs/changes/73/970673/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osc-lib refs/changes/73/970673/1"}}},"commit":{"parents":[{"commit":"009a567f8fb3a7d34d9b736f74e6e67f86df9073","subject":"Run mypy from tox","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/009a567f8fb3a7d34d9b736f74e6e67f86df9073"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-11 14:49:37.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2025-12-11 18:42:50.000000000","tz":0},"subject":"typing: Use Mapping, not dict","message":"typing: Use Mapping, not dict\n\ndict is invariant. Mapping is not.\n\nChange-Id: Ic2b1e88f02526581c7662d037228fc0e6539084a\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/edac60e6b7ac874f41b12c508e6e32672622941d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osc-lib/commit/edac60e6b7ac874f41b12c508e6e32672622941d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}