)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3f26238fc2eb467a73d34f94d1a4a6d8e308630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac67b8dd_8e4351c5","updated":"2026-04-27 09:06:30.000000000","message":"-1 to catch attention","commit_id":"cb81aafb47439c3c80f88573f59bbdc8dcb65ef2"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"355110a3604aba7f2ac673bf5d21af668d6b23bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e8eeee2e_1b12f38c","updated":"2026-04-25 20:13:54.000000000","message":"Recheck Zuul forgot about this","commit_id":"cb81aafb47439c3c80f88573f59bbdc8dcb65ef2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71831c52b8f2ca36c1ea7b5fd371cfd6f2533c6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85e07ee6_9e3deb28","updated":"2026-04-27 15:10:21.000000000","message":"Assuming CI is happy","commit_id":"a5aaf2fae9741805c7c8e2f7573c7d356f30cbdc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f92b31665c94e59a4ce6828d6c5974ac8f96c4a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"504acce9_6d3fa3ed","updated":"2026-04-27 16:17:48.000000000","message":"Failures look real, sadly. Should be an easy mock to fix though. We have good machinery in place for mocking API versions in OSC proper, though it likely doesn\u0027t need to be as complicated as that here.","commit_id":"a5aaf2fae9741805c7c8e2f7573c7d356f30cbdc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7d255ed3d320716f5b17143adebe0e44c8cf8fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28a17169_80677b6b","updated":"2026-04-28 09:43:38.000000000","message":"Fixed the test failures","commit_id":"70c39a6b454ffb19e099ee34e6e5e761d0b262e4"}],"osc_lib/cli/identity.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"86f04f856a1d2cc7c55e9988b95cfb6c7be7017f","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack import connection"},{"line_number":18,"context_line":"from openstack import exceptions"},{"line_number":19,"context_line":"from openstack.identity.v3 import _proxy as identity_v3_proxy"},{"line_number":20,"context_line":"from openstack.identity.v3 import project"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib.i18n import _"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c79f380_56c3ad64","line":19,"updated":"2026-04-27 10:19:46.000000000","message":"I have a change up to make `Proxy` an attribute of the `openstack.\u003cservice\u003e.\u003cversion\u003e` module (import it inside `__init__.py`). I should probably get that merged sooner rather than later to avoid these imports from private modules building up everywhere. Though in this case, it shouldn\u0027t be needed if you make the change below","commit_id":"cb81aafb47439c3c80f88573f59bbdc8dcb65ef2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3f26238fc2eb467a73d34f94d1a4a6d8e308630","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        identity_client \u003d cast("},{"line_number":72,"context_line":"            identity_v3_proxy.Proxy, sdk_connection.identity"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        if domain_name_or_id:"},{"line_number":75,"context_line":"            domain \u003d identity_client.find_domain(  # type: ignore[no-untyped-call]"},{"line_number":76,"context_line":"                domain_name_or_id, ignore_missing\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"9e204eab_d7e02fba","line":73,"updated":"2026-04-27 09:06:30.000000000","message":"Rather than doing this, could you use `openstack.utils.ensure_service_version` from sdk? There are a few examples of this used in OSC itself.","commit_id":"cb81aafb47439c3c80f88573f59bbdc8dcb65ef2"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"70d3f96027dca449f0299df93bab65f925f71512","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        identity_client \u003d cast("},{"line_number":72,"context_line":"            identity_v3_proxy.Proxy, sdk_connection.identity"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        if domain_name_or_id:"},{"line_number":75,"context_line":"            domain \u003d identity_client.find_domain(  # type: ignore[no-untyped-call]"},{"line_number":76,"context_line":"                domain_name_or_id, ignore_missing\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"bedda7d8_3c33af04","line":73,"in_reply_to":"92cb4979_3f7ade4c","updated":"2026-04-27 14:35:00.000000000","message":"Done","commit_id":"cb81aafb47439c3c80f88573f59bbdc8dcb65ef2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9296d1f531cd109abf143d81a333916379c22a62","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    try:"},{"line_number":71,"context_line":"        identity_client \u003d cast("},{"line_number":72,"context_line":"            identity_v3_proxy.Proxy, sdk_connection.identity"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        if domain_name_or_id:"},{"line_number":75,"context_line":"            domain \u003d identity_client.find_domain(  # type: ignore[no-untyped-call]"},{"line_number":76,"context_line":"                domain_name_or_id, ignore_missing\u003dFalse"}],"source_content_type":"text/x-python","patch_set":2,"id":"92cb4979_3f7ade4c","line":73,"in_reply_to":"9e204eab_d7e02fba","updated":"2026-04-27 10:07:59.000000000","message":"note that you\u0027ll need to bump openstacksdk (and maybe make it a dependency?) if you do this","commit_id":"cb81aafb47439c3c80f88573f59bbdc8dcb65ef2"}]}