)]}'
{"osc_placement/resources/inventory.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8829b934ee4f16b90f7818d13e4c4b42902d0780","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ff52f3f_7b52c369","updated":"2017-04-13 17:23:27.000000000","message":"If/when you add support for PUT /resource_providers/{uuid}/inventories (which sets all the inventory on one rp) you\u0027ll need to add in support for including resource_provider_generation in the request.","commit_id":"eea868dd542d3199a2b68925433906317fa7b7bb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8829b934ee4f16b90f7818d13e4c4b42902d0780","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE_URL \u003d \u0027/resource_providers/{uuid}/inventories\u0027"},{"line_number":19,"context_line":"PER_CLASS_URL \u003d \u0027/resource_providers/{uuid}/inventories/{resource_class}\u0027"},{"line_number":20,"context_line":"FIELDS \u003d (\u0027allocation_ratio\u0027, \u0027min_unit\u0027, \u0027max_unit\u0027, \u0027reserved\u0027,"},{"line_number":21,"context_line":"          \u0027step_size\u0027, \u0027total\u0027)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_3bb55b32","line":19,"updated":"2017-04-13 17:23:27.000000000","message":"reuse BASE_URL and concatenate?","commit_id":"eea868dd542d3199a2b68925433906317fa7b7bb"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"aebe361a856792ea078cef4ab03ce64263e3d11a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE_URL \u003d \u0027/resource_providers/{uuid}/inventories\u0027"},{"line_number":19,"context_line":"PER_CLASS_URL \u003d \u0027/resource_providers/{uuid}/inventories/{resource_class}\u0027"},{"line_number":20,"context_line":"FIELDS \u003d (\u0027allocation_ratio\u0027, \u0027min_unit\u0027, \u0027max_unit\u0027, \u0027reserved\u0027,"},{"line_number":21,"context_line":"          \u0027step_size\u0027, \u0027total\u0027)"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_0007d41e","line":19,"in_reply_to":"9ff52f3f_3bb55b32","updated":"2017-04-19 08:45:49.000000000","message":"Done","commit_id":"eea868dd542d3199a2b68925433906317fa7b7bb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8829b934ee4f16b90f7818d13e4c4b42902d0780","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \u0027--total\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\u0027\u003ctotal\u003e\u0027,"},{"line_number":43,"context_line":"            type\u003dint,"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        parser.add_argument("},{"line_number":46,"context_line":"            \u0027--reserved\u0027,"},{"line_number":47,"context_line":"            metavar\u003d\u0027\u003creserved\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_3bed5bef","line":44,"updated":"2017-04-13 17:23:27.000000000","message":"Is there a way to indicate that uuid, resource class and total are required? The rest are optional and will have reasonable defaults set on the server side.","commit_id":"eea868dd542d3199a2b68925433906317fa7b7bb"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"aebe361a856792ea078cef4ab03ce64263e3d11a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \u0027--total\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\u0027\u003ctotal\u003e\u0027,"},{"line_number":43,"context_line":"            type\u003dint,"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        parser.add_argument("},{"line_number":46,"context_line":"            \u0027--reserved\u0027,"},{"line_number":47,"context_line":"            metavar\u003d\u0027\u003creserved\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_7b6f6dc5","line":44,"in_reply_to":"9ff52f3f_3bed5bef","updated":"2017-04-19 08:45:49.000000000","message":"Good point. Done.","commit_id":"eea868dd542d3199a2b68925433906317fa7b7bb"}],"osc_placement/resources/resource_provider.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8829b934ee4f16b90f7818d13e4c4b42902d0780","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \u0027--name\u0027,"},{"line_number":68,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":69,"context_line":"            help\u003d\u0027name of the resource provider\u0027"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return parser"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_fbe133d2","line":70,"updated":"2017-04-13 17:23:27.000000000","message":"I guess there\u0027s some DRYing up you can do here and above, eventually.","commit_id":"eea868dd542d3199a2b68925433906317fa7b7bb"}]}
