)]}'
{"osc_placement/resources/allocation_candidate.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"38a96462ba98bc6841528edc001454dfd5d2c56d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        params \u003d {\u0027resources\u0027: \u0027,\u0027.join("},{"line_number":50,"context_line":"            resource.replace(\u0027\u003d\u0027, \u0027:\u0027) for resource in parsed_args.resource)}"},{"line_number":51,"context_line":"        resp \u003d http.request(\u0027GET\u0027, BASE_URL, params\u003dparams).json()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        rps \u003d {}"},{"line_number":54,"context_line":"        for rp_uuid, resources in resp[\u0027provider_summaries\u0027].items():"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff6b8bd7_6089e624","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":43},"updated":"2018-03-05 08:35:52.000000000","message":"GET on the (plural) base resource is conventionally translates to \u0027list\u0027 in the CLI. That is: \u0027openstack allocation candidate list\u0027, not \u0027show\u0027.","commit_id":"b0a8c4bc1a8544a3459c55e062837a698453bd1a"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"5719310339c5b99aefdadc93e0fb0f19b230bbea","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        params \u003d {\u0027resources\u0027: \u0027,\u0027.join("},{"line_number":50,"context_line":"            resource.replace(\u0027\u003d\u0027, \u0027:\u0027) for resource in parsed_args.resource)}"},{"line_number":51,"context_line":"        resp \u003d http.request(\u0027GET\u0027, BASE_URL, params\u003dparams).json()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        rps \u003d {}"},{"line_number":54,"context_line":"        for rp_uuid, resources in resp[\u0027provider_summaries\u0027].items():"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff6b8bd7_991edb0a","line":51,"range":{"start_line":51,"start_character":28,"end_line":51,"end_character":43},"in_reply_to":"ff6b8bd7_6089e624","updated":"2018-03-06 16:04:53.000000000","message":"Do not remember why I came to that name, fixed.\nI rebased your patches but doc strings and commit messages are still need to be fixed.","commit_id":"b0a8c4bc1a8544a3459c55e062837a698453bd1a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b186ddc50c02c5d6a274925ce785b76f7ad8a47d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            metavar\u003d\u0027\u003cresource_class\u003e\u003d\u003cvalue\u003e\u0027,"},{"line_number":39,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"},{"line_number":41,"context_line":"            help\u003d\u0027String representing required resource.\u0027"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":19,"id":"9f6a8fd7_0eaf9294","line":41,"range":{"start_line":41,"start_character":18,"end_line":41,"end_character":56},"updated":"2018-04-19 13:17:19.000000000","message":"I would add some extended help, like:\n\n\"String representing required resource. A comma separated list of strings indicating an amount of resource of a specified class that providers in each allocation request must collectively have the capacity and availability to serve\" (quoted from https://developer.openstack.org/api-ref/placement/#list-allocation-candidates)\n\"example: --resource VCPU\u003d1,MEMORY_MB\u003d100\"","commit_id":"bed70c223af3e945f9d174924fc56218888bd421"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"422008ab7fed872d685ed040f530087debb7df97","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            metavar\u003d\u0027\u003cresource_class\u003e\u003d\u003cvalue\u003e\u0027,"},{"line_number":39,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"},{"line_number":41,"context_line":"            help\u003d\u0027String representing required resource.\u0027"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_7c689121","line":41,"range":{"start_line":41,"start_character":18,"end_line":41,"end_character":56},"in_reply_to":"9f6a8fd7_0eaf9294","updated":"2018-06-28 16:00:32.000000000","message":"Good point, done.","commit_id":"bed70c223af3e945f9d174924fc56218888bd421"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"38b9f17649ea865636d2e2bc45a20263c318c057","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE_URL \u003d \u0027/allocation_candidates\u0027"},{"line_number":19,"context_line":"FIELDS \u003d (\u0027request no\u0027, \u0027allocation\u0027,"},{"line_number":20,"context_line":"          \u0027resource provider\u0027, \u0027resource\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_42c28755","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":21},"updated":"2018-06-28 20:03:20.000000000","message":"Is this short for \u0027request number\u0027? I wonder if we should just call this \u0027index\u0027 or something?","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f3230535347aa5caee33b64058356b6e26a1568a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE_URL \u003d \u0027/allocation_candidates\u0027"},{"line_number":19,"context_line":"FIELDS \u003d (\u0027request no\u0027, \u0027allocation\u0027,"},{"line_number":20,"context_line":"          \u0027resource provider\u0027, \u0027resource\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_91d54b4a","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":21},"in_reply_to":"5f7c97a3_42c28755","updated":"2018-06-29 01:22:26.000000000","message":"See below for suggestions on renaming a couple of the fields.","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96675bf8e6f32fefc062edcbac59b9a3aaa643a7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BASE_URL \u003d \u0027/allocation_candidates\u0027"},{"line_number":19,"context_line":"FIELDS \u003d (\u0027request no\u0027, \u0027allocation\u0027,"},{"line_number":20,"context_line":"          \u0027resource provider\u0027, \u0027resource\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_11637b43","line":19,"range":{"start_line":19,"start_character":11,"end_line":19,"end_character":21},"in_reply_to":"5f7c97a3_91d54b4a","updated":"2018-06-29 12:15:31.000000000","message":"Done","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"942e12b3f3586e12f3fd36bcd16ea5c05fd9790f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          \u0027resource provider\u0027, \u0027resource\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ListAllocationCandidate(command.Lister, version.CheckerMixin):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"\"\"List allocation candidates."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_d3a670c1","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":66},"updated":"2018-06-28 18:37:58.000000000","message":"Where do we actually check the version being used?","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f3230535347aa5caee33b64058356b6e26a1568a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          \u0027resource provider\u0027, \u0027resource\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ListAllocationCandidate(command.Lister, version.CheckerMixin):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"\"\"List allocation candidates."},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_51dfb365","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":66},"in_reply_to":"5f7c97a3_d3a670c1","updated":"2018-06-29 01:22:26.000000000","message":"We don\u0027t:\n\nstack@rocky:~$ openstack allocation candidate list --resource VCPU\u003d1 --resource MEMORY_MB\u003d1024 --resource DISK_GB\u003d20\nNot found (HTTP 404)\nstack@rocky:~$","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"38b9f17649ea865636d2e2bc45a20263c318c057","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"\"\"List allocation candidates."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Returns a dictionary representing a collection of allocation"},{"line_number":28,"context_line":"    requests and resource provider summaries."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This command requires at least ``--os-placement-api-version 1.10``."}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_22a8ab76","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":24},"updated":"2018-06-28 20:03:20.000000000","message":"I see this is copied from the API reference but it seems we should re-word this a bit to explain how the table output works and what it means.\n\nFor example, the API reference says:\n\n\"Each allocation request has information to form a PUT /allocations/{consumer_uuid} request to claim resources against a related set of resource providers.\"\n\nSo we could translate that to an \"openstack resource provider allocation set\" request.\n\nAnd we can add:\n\n\"As several allocation requests are available it’s necessary to select one. To make a decision, resource provider summaries are provided with the inventory/capacity information.\"\n\nI think it would be good to have an example table in here and then explain how it\u0027s read, like the provider used/capacity field.","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f3230535347aa5caee33b64058356b6e26a1568a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"\"\"List allocation candidates."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Returns a dictionary representing a collection of allocation"},{"line_number":28,"context_line":"    requests and resource provider summaries."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This command requires at least ``--os-placement-api-version 1.10``."}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_b1c72799","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":24},"in_reply_to":"5f7c97a3_22a8ab76","updated":"2018-06-29 01:22:26.000000000","message":"We could touch up this example and then provide it here and explain it:\n\nhttp://paste.openstack.org/show/724562/","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96675bf8e6f32fefc062edcbac59b9a3aaa643a7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    \"\"\"List allocation candidates."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Returns a dictionary representing a collection of allocation"},{"line_number":28,"context_line":"    requests and resource provider summaries."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This command requires at least ``--os-placement-api-version 1.10``."}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_f15d9f7c","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":24},"in_reply_to":"5f7c97a3_b1c72799","updated":"2018-06-29 12:15:31.000000000","message":"Done","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46873482e64101ecbb9fa714daf088497d8b49a3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser \u003d super(ListAllocationCandidate, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("},{"line_number":37,"context_line":"            \u0027--resource\u0027,"},{"line_number":38,"context_line":"            metavar\u003d\u0027\u003cresource_class\u003e\u003d\u003cvalue\u003e\u0027,"},{"line_number":39,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_d141830c","line":37,"updated":"2018-06-29 01:35:49.000000000","message":"It\u0027s possible to run the command without specifying any of these and then you just get an error back from the server - it would be nicer to check and fail client-side for not specifying at least one resource.","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96675bf8e6f32fefc062edcbac59b9a3aaa643a7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser \u003d super(ListAllocationCandidate, self).get_parser(prog_name)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        parser.add_argument("},{"line_number":37,"context_line":"            \u0027--resource\u0027,"},{"line_number":38,"context_line":"            metavar\u003d\u0027\u003cresource_class\u003e\u003d\u003cvalue\u003e\u0027,"},{"line_number":39,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":40,"context_line":"            default\u003d[],"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_516fb327","line":37,"in_reply_to":"5f7c97a3_d141830c","updated":"2018-06-29 12:15:31.000000000","message":"Done","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d80d29f14a07c95e09c9a7268d7b18df12abd54","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        return parser"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def take_action(self, parsed_args):"},{"line_number":53,"context_line":"        http \u003d self.app.client_manager.placement"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        params \u003d {\u0027resources\u0027: \u0027,\u0027.join("}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_7370bc41","line":52,"updated":"2018-06-28 18:39:44.000000000","message":"You need @version.check(version.ge(\u00271.10\u0027)) here right?","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96675bf8e6f32fefc062edcbac59b9a3aaa643a7","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        return parser"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def take_action(self, parsed_args):"},{"line_number":53,"context_line":"        http \u003d self.app.client_manager.placement"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        params \u003d {\u0027resources\u0027: \u0027,\u0027.join("}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_31723714","line":52,"in_reply_to":"5f7c97a3_7370bc41","updated":"2018-06-29 12:15:31.000000000","message":"Done","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5a30901f10472856ce5b975db66b793b545b1b0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    for rc, value in allocation[\u0027resources\u0027].items())"},{"line_number":71,"context_line":"                rows.append([i + 1, req, rp, rps[rp]])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return FIELDS, rows"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_02156f9b","line":73,"updated":"2018-06-28 20:08:18.000000000","message":"Thinking out loud, it\u0027s hard to translate this API to a shell output, but what this really is, is a couple of things:\n\n1. the allocation requests are things you can use to issue \"openstack resource provider allocation set\"\n\n2. the provider summaries are a mix of \"openstack resource provider inventory show\" (really just the \"total\" field from that output for the capacity) and \"openstack resource provider usage show\" which is the \u0027used\u0027 value you\u0027re specifying here for used/capacity.\n\nSo we\u0027re kind of generating a report for the output and I wonder if we could formulate that output to sort of mirror the output for those other existing commands as a kind of meta command? I\u0027ll play with this locally and see if I can come up with something.","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f3230535347aa5caee33b64058356b6e26a1568a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    for rc, value in allocation[\u0027resources\u0027].items())"},{"line_number":71,"context_line":"                rows.append([i + 1, req, rp, rps[rp]])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return FIELDS, rows"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_d1f3c308","line":73,"in_reply_to":"5f7c97a3_02156f9b","updated":"2018-06-29 01:22:26.000000000","message":"OK so this is what we get for the various commands (single node devstack):\n\nhttp://paste.openstack.org/show/724562/\n\nThat\u0027s not bad. As noted, I\u0027d probably tweak the headers to be something like \"index\" or just \"#\" instead of \"request no\".\n\nAs for the \u0027resource\u0027 column, I\u0027d probably call that \u0027current inventory used/capacity\u0027 so it\u0027s more clear what those values are.\n\nIf we make those tweaks to the field headers I\u0027m OK with the current table format.","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96675bf8e6f32fefc062edcbac59b9a3aaa643a7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    for rc, value in allocation[\u0027resources\u0027].items())"},{"line_number":71,"context_line":"                rows.append([i + 1, req, rp, rps[rp]])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        return FIELDS, rows"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_b157275b","line":73,"in_reply_to":"5f7c97a3_d1f3c308","updated":"2018-06-29 12:15:31.000000000","message":"Done","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f040a3cd42ce758f81927e586886ac5a89c7abcf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    to issue an \"openstack resource provider allocation set\" request to claim"},{"line_number":31,"context_line":"    resources against a related set of resource providers."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    As several allocation requests are available it’s necessary to select one."},{"line_number":34,"context_line":"    To make a decision, resource provider summaries are provided with the"},{"line_number":35,"context_line":"    inventory/capacity information."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"5f7c97a3_70fe5fb0","line":33,"range":{"start_line":33,"start_character":51,"end_line":33,"end_character":52},"updated":"2018-06-29 12:17:58.000000000","message":"This might be the unicode error.","commit_id":"e96918c642d06c401874e1feef224c89a2497a28"}],"osc_placement/tests/functional/test_allocation_candidate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"38b9f17649ea865636d2e2bc45a20263c318c057","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    return \u0027,\u0027.join(sorted(resource.split(\u0027,\u0027)))"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TestAllocationCandidate(base.BaseTestCase):"},{"line_number":23,"context_line":"    VERSION \u003d \u00271.10\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_list_empty(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_42be07af","line":22,"updated":"2018-06-28 20:03:20.000000000","message":"It would be good to have a test that runs the new command with 1.9 since the version check was missed.","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"38b9f17649ea865636d2e2bc45a20263c318c057","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertEqual("},{"line_number":81,"context_line":"            rps[rp2[\u0027uuid\u0027]][\u0027request no\u0027], rps[rp1[\u0027uuid\u0027]][\u0027request no\u0027])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_fail_if_unknow_rc(self):"},{"line_number":84,"context_line":"        self.assertCommandFailed("},{"line_number":85,"context_line":"            \u0027No such resource\u0027, self.allocation_candidate_list, \u0027UNKNOWN\u003d10\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f7c97a3_c2b217e6","line":83,"range":{"start_line":83,"start_character":21,"end_line":83,"end_character":27},"updated":"2018-06-28 20:03:20.000000000","message":"unknown","commit_id":"8565870fc960f0d901bb83b72a15f345fc0b20c1"}],"setup.cfg":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b1b54a5700175712bf1b48dbcc1973109b6b50b3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    resource_provider_trait_list \u003d osc_placement.resources.trait:ListResourceProviderTrait"},{"line_number":57,"context_line":"    resource_provider_trait_set \u003d osc_placement.resources.trait:SetResourceProviderTrait"},{"line_number":58,"context_line":"    resource_provider_trait_delete \u003d osc_placement.resources.trait:DeleteResourceProviderTrait"},{"line_number":59,"context_line":"    allocation_candidate_list \u003d osc_placement.resources.allocation_candidate:ListAllocationCandidate"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[build_sphinx]"},{"line_number":62,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":38,"id":"5f7c97a3_03d23afe","line":59,"updated":"2018-06-29 18:21:04.000000000","message":"Arguably we could name this \"openstack resource allocation candidate list\" since allocation candidates aren\u0027t really a resource in the API, but this is probably unique enough that it\u0027s not going to overlap with any other command namespace in the OSC universe.","commit_id":"fabe0017b2ac963fac1ddbbc5928a42642fcaf50"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"249f27ae0658706a6edee37f7db2af7eba976148","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    resource_provider_trait_list \u003d osc_placement.resources.trait:ListResourceProviderTrait"},{"line_number":57,"context_line":"    resource_provider_trait_set \u003d osc_placement.resources.trait:SetResourceProviderTrait"},{"line_number":58,"context_line":"    resource_provider_trait_delete \u003d osc_placement.resources.trait:DeleteResourceProviderTrait"},{"line_number":59,"context_line":"    allocation_candidate_list \u003d osc_placement.resources.allocation_candidate:ListAllocationCandidate"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[build_sphinx]"},{"line_number":62,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":38,"id":"5f7c97a3_a316e657","line":59,"in_reply_to":"5f7c97a3_03d23afe","updated":"2018-06-29 18:36:14.000000000","message":"yeah, I think `openstack allocation candidate list` is good.","commit_id":"fabe0017b2ac963fac1ddbbc5928a42642fcaf50"}]}
