)]}'
{"osc_placement/tests/functional/hooks/post_test_hook.sh":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"f8bd396511ac93109831442fa3f4637cfeda97ac","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export OSCPLACEMENT_DIR\u003d\"$BASE/new/osc-placement\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"sudo chown -R zuul:zuul $OSCPLACEMENT_DIR"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Go to the osc-placement dir"},{"line_number":34,"context_line":"cd $OSCPLACEMENT_DIR"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df7087c5_2714b443","line":31,"range":{"start_line":31,"start_character":19,"end_line":31,"end_character":23},"updated":"2018-03-14 13:23:10.000000000","message":"is stack group needed?","commit_id":"473f9369e36fc5370d4ffd5d177cefe0bfce4c3d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"63cdd9a7820070f6cf278b9b32b74ae878df75a7","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export OSCPLACEMENT_DIR\u003d\"$BASE/new/osc-placement\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"sudo chown -R zuul:zuul $OSCPLACEMENT_DIR"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Go to the osc-placement dir"},{"line_number":34,"context_line":"cd $OSCPLACEMENT_DIR"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df7087c5_d33ec7b6","line":31,"range":{"start_line":31,"start_character":19,"end_line":31,"end_character":23},"in_reply_to":"df7087c5_2714b443","updated":"2018-03-15 07:24:44.000000000","message":"Why do you need the chown at all? This should all be ok. Does it work if you remove the chowns?","commit_id":"473f9369e36fc5370d4ffd5d177cefe0bfce4c3d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"931ef8ceec54a842240914e8b4007a51d9ea2631","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"export OSCPLACEMENT_DIR\u003d\"$BASE/new/osc-placement\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"sudo chown -R zuul:zuul $OSCPLACEMENT_DIR"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Go to the osc-placement dir"},{"line_number":34,"context_line":"cd $OSCPLACEMENT_DIR"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df7087c5_86975d3b","line":31,"range":{"start_line":31,"start_character":19,"end_line":31,"end_character":23},"in_reply_to":"df7087c5_d33ec7b6","updated":"2018-03-19 09:51:14.000000000","message":"@Andrey: Done.\n\n@Andreas: In ps1 I removed every sudo call, but that way I got a \u0027Permission denied error\u0027. The logs are still available.\n\nNow analyzing the logs a bit more I think I managed to remove all sudo invocations but one. For my current understanding of the reason please see the commit message. If you know how to remove the last one, let me know please.\n\nThe use of sudo in post_test_hook is quite widespread despite likely beeing needless. eg: Ia3f2646bd3b5fa87c90c8dac57117fd29d73706b","commit_id":"473f9369e36fc5370d4ffd5d177cefe0bfce4c3d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"63cdd9a7820070f6cf278b9b32b74ae878df75a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"set +e"},{"line_number":39,"context_line":"# Preserve env for OS_ credentials"},{"line_number":40,"context_line":"source $BASE/new/devstack/openrc admin admin"},{"line_number":41,"context_line":"sudo -E -H -u zuul tox -e ${TOX_ENV:-functional}"},{"line_number":42,"context_line":"EXIT_CODE\u003d$?"},{"line_number":43,"context_line":"set -e"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df7087c5_33794393","line":41,"updated":"2018-03-15 07:24:44.000000000","message":"Again, why is the sudo needed?","commit_id":"473f9369e36fc5370d4ffd5d177cefe0bfce4c3d"}]}
