)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"26c14135a05ac3af1716a2e09e81b4b43ce9a2af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix error message in test assert"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch I5857e927a830914c96e040936804e322baccc24c changed the"},{"line_number":10,"context_line":"error message emited by placement and that broke the functional"},{"line_number":11,"context_line":"test of the client as it was asserting the old error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If5fc16d50af1f8f60735ab81d1f5d138c9ad104b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_b0cb9751","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":20},"updated":"2018-05-07 11:57:22.000000000","message":"nit: emitted","commit_id":"191b0eb335393b3086bdd4335cb08b13dce2f1ba"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac140483ef470c2b43b4cb6dbc08419d5151e35b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix error message in test assert"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The patch I5857e927a830914c96e040936804e322baccc24c changed the"},{"line_number":10,"context_line":"error message emited by placement and that broke the functional"},{"line_number":11,"context_line":"test of the client as it was asserting the old error message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If5fc16d50af1f8f60735ab81d1f5d138c9ad104b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_6bff3834","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":20},"in_reply_to":"5f7c97a3_b0cb9751","updated":"2018-05-08 10:51:34.000000000","message":"Done","commit_id":"191b0eb335393b3086bdd4335cb08b13dce2f1ba"}],"osc_placement/tests/functional/test_resource_provider.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"26c14135a05ac3af1716a2e09e81b4b43ce9a2af","unresolved":false,"context_lines":[{"line_number":156,"context_line":"class TestResourceProvider14(base.BaseTestCase):"},{"line_number":157,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_fail_if_incorrect_aggregate_uuid(self):"},{"line_number":160,"context_line":"        # aggregate_uuid requires the uuid like format"},{"line_number":161,"context_line":"        self.assertCommandFailed("},{"line_number":162,"context_line":"            \"Invalid query string parameters: Expected \u0027member_of\u0027 parameter \""},{"line_number":163,"context_line":"            \"to contain valid UUID(s)\", self.resource_provider_list,"},{"line_number":164,"context_line":"            aggregate_uuids\u003d[\u0027fake_uuid\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_return_empty_list_for_nonexistent_aggregate(self):"},{"line_number":167,"context_line":"        self.resource_provider_create()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_50bd63b5","line":164,"range":{"start_line":159,"start_character":0,"end_line":164,"end_character":42},"updated":"2018-05-07 11:57:22.000000000","message":"I\u0027m not sure why we have this test here in the first place. IMO we test nova functionality here, not osc-placement functionality. That\u0027s why an error message change in nova broke osc-placement. I would just drop this test instead.","commit_id":"191b0eb335393b3086bdd4335cb08b13dce2f1ba"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac140483ef470c2b43b4cb6dbc08419d5151e35b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"class TestResourceProvider14(base.BaseTestCase):"},{"line_number":157,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_fail_if_incorrect_aggregate_uuid(self):"},{"line_number":160,"context_line":"        # aggregate_uuid requires the uuid like format"},{"line_number":161,"context_line":"        self.assertCommandFailed("},{"line_number":162,"context_line":"            \"Invalid query string parameters: Expected \u0027member_of\u0027 parameter \""},{"line_number":163,"context_line":"            \"to contain valid UUID(s)\", self.resource_provider_list,"},{"line_number":164,"context_line":"            aggregate_uuids\u003d[\u0027fake_uuid\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_return_empty_list_for_nonexistent_aggregate(self):"},{"line_number":167,"context_line":"        self.resource_provider_create()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_abed508c","line":164,"range":{"start_line":159,"start_character":0,"end_line":164,"end_character":42},"in_reply_to":"5f7c97a3_50bd63b5","updated":"2018-05-08 10:51:34.000000000","message":"You are right this test does not check any client functionality. So I removed it as you suggested.","commit_id":"191b0eb335393b3086bdd4335cb08b13dce2f1ba"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"76874a209d20319857c7dbb103010888fc6c68b0","unresolved":false,"context_lines":[{"line_number":156,"context_line":"class TestResourceProvider14(base.BaseTestCase):"},{"line_number":157,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_fail_if_incorrect_aggregate_uuid(self):"},{"line_number":160,"context_line":"        # aggregate_uuid requires the uuid like format"},{"line_number":161,"context_line":"        self.assertCommandFailed("},{"line_number":162,"context_line":"            \"Invalid query string parameters: Expected \u0027member_of\u0027 parameter \""},{"line_number":163,"context_line":"            \"to contain valid UUID(s)\", self.resource_provider_list,"},{"line_number":164,"context_line":"            aggregate_uuids\u003d[\u0027fake_uuid\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_return_empty_list_for_nonexistent_aggregate(self):"},{"line_number":167,"context_line":"        self.resource_provider_create()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cd9e9662","line":164,"range":{"start_line":159,"start_character":0,"end_line":164,"end_character":42},"in_reply_to":"5f7c97a3_abed508c","updated":"2018-05-08 19:20:10.000000000","message":"Yeah, at best this could be testing whether the CLI correctly propagates any error returned by the server -- and should be done generically with a fake server error.","commit_id":"191b0eb335393b3086bdd4335cb08b13dce2f1ba"}]}