)]}'
{"osc_placement/tests/functional/test_inventory.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"d7904e79eac9ee664cab38a1068ca8cfad48f0d7","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _test_dry_run(self, agg, rps, old_inventories, amend\u003dFalse):"},{"line_number":256,"context_line":"        self.resource_inventory_set("},{"line_number":257,"context_line":"            agg,"},{"line_number":258,"context_line":"            \u0027VCPU:allocation_ratio\u003d5.0\u0027,"},{"line_number":259,"context_line":"            \u0027MEMORY_MB:allocation_ratio\u003d6.0\u0027,"},{"line_number":260,"context_line":"            \u0027DISK_GB:allocation_ratio\u003d7.0\u0027,"},{"line_number":261,"context_line":"            aggregate\u003dTrue, amend\u003damend, dry_run\u003dTrue)"},{"line_number":262,"context_line":"        # Verify the inventories weren\u0027t changed (--dry-run)"},{"line_number":263,"context_line":"        for i in range(2):"},{"line_number":264,"context_line":"            resp \u003d self.resource_inventory_list(rps[i][\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_47b9f712","line":261,"range":{"start_line":256,"start_character":0,"end_line":261,"end_character":54},"updated":"2019-08-14 08:49:15.000000000","message":"Any chance to verify the response of this function?","commit_id":"498901d7ffba66ef5070ee6b705aac10aa6d18e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66de0f8fd39609fe85adee0a05f475df0d9d308c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            \u0027fake_uuid\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class TestSetInventory(base.BaseTestCase):"},{"line_number":80,"context_line":"    def test_fail_if_no_rp(self):"},{"line_number":81,"context_line":"        exc \u003d self.assertRaises("},{"line_number":82,"context_line":"            base.CommandException,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_5b3bb9cf","line":79,"range":{"start_line":79,"start_character":6,"end_line":79,"end_character":22},"updated":"2019-09-04 20:57:54.000000000","message":"Could we also have a simple --dry-run test in here so it\u0027s testing the non-1.3 non-aggregate usage of --dry-run?","commit_id":"f3ec0f575ca8f1edd147fe3124882064732d107a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bd9706d2d0118788c8031e822f634d17a253a9c7","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            \u0027DISK_GB:allocation_ratio\u003d7.0\u0027,"},{"line_number":284,"context_line":"            aggregate\u003dTrue, amend\u003damend, dry_run\u003dTrue)"},{"line_number":285,"context_line":"        # Verify the inventories weren\u0027t changed (--dry-run)"},{"line_number":286,"context_line":"        for i in range(2):"},{"line_number":287,"context_line":"            resp \u003d self.resource_inventory_list(rps[i][\u0027uuid\u0027])"},{"line_number":288,"context_line":"            self.assertDictEqual(old_inventories[i],"},{"line_number":289,"context_line":"                                 {r[\u0027resource_class\u0027]: r for r in resp})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_e04bd083","line":286,"range":{"start_line":286,"start_character":17,"end_line":286,"end_character":25},"updated":"2019-09-04 20:52:07.000000000","message":"This is oddly specific - why wouldn\u0027t this just be len(rps) or use enumerate(rps)?","commit_id":"f3ec0f575ca8f1edd147fe3124882064732d107a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f242de9ca2aa5eb0afcd8fdcf509101ed607d180","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            \u0027DISK_GB:allocation_ratio\u003d7.0\u0027,"},{"line_number":284,"context_line":"            aggregate\u003dTrue, amend\u003damend, dry_run\u003dTrue)"},{"line_number":285,"context_line":"        # Verify the inventories weren\u0027t changed (--dry-run)"},{"line_number":286,"context_line":"        for i in range(2):"},{"line_number":287,"context_line":"            resp \u003d self.resource_inventory_list(rps[i][\u0027uuid\u0027])"},{"line_number":288,"context_line":"            self.assertDictEqual(old_inventories[i],"},{"line_number":289,"context_line":"                                 {r[\u0027resource_class\u0027]: r for r in resp})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_fb014505","line":286,"range":{"start_line":286,"start_character":17,"end_line":286,"end_character":25},"in_reply_to":"7faddb67_e04bd083","updated":"2019-09-04 20:55:31.000000000","message":"I needed an index for old_inventories, so enumerate would also work and be more appropriate.","commit_id":"f3ec0f575ca8f1edd147fe3124882064732d107a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"95e5a1e217ea27b52a9584594010085824207de0","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            self.assertIn(\u0027resource_provider\u0027, rp)"},{"line_number":418,"context_line":"        new_inventories \u003d self._get_expected_inventories(old_invs,"},{"line_number":419,"context_line":"                                                         new_resources)"},{"line_number":420,"context_line":"        for i in range(2):"},{"line_number":421,"context_line":"            resp \u003d self.resource_inventory_list(rps[i][\u0027uuid\u0027])"},{"line_number":422,"context_line":"            self.assertDictEqual(new_inventories[i],"},{"line_number":423,"context_line":"                                 {r[\u0027resource_class\u0027]: r for r in resp})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_fba385af","line":420,"range":{"start_line":420,"start_character":17,"end_line":420,"end_character":25},"updated":"2019-09-04 21:07:40.000000000","message":"Your nemesis got past over here btw.","commit_id":"f3ec0f575ca8f1edd147fe3124882064732d107a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"99aecddc7a968729c0a8680f37803617aeeaff7b","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            self.assertIn(\u0027resource_provider\u0027, rp)"},{"line_number":418,"context_line":"        new_inventories \u003d self._get_expected_inventories(old_invs,"},{"line_number":419,"context_line":"                                                         new_resources)"},{"line_number":420,"context_line":"        for i in range(2):"},{"line_number":421,"context_line":"            resp \u003d self.resource_inventory_list(rps[i][\u0027uuid\u0027])"},{"line_number":422,"context_line":"            self.assertDictEqual(new_inventories[i],"},{"line_number":423,"context_line":"                                 {r[\u0027resource_class\u0027]: r for r in resp})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_2646e051","line":420,"range":{"start_line":420,"start_character":17,"end_line":420,"end_character":25},"in_reply_to":"7faddb67_fba385af","updated":"2019-09-04 21:36:12.000000000","message":"Blarg. Less problematic since we\u0027re calling _setup_two_resource_providers_in_aggregate here so there is some linkage, but the new helper method doesn\u0027t have that obvious link.","commit_id":"f3ec0f575ca8f1edd147fe3124882064732d107a"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"ede732f25169404f84d1ef0045af25c1ea67470c","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            \u0027VCPU:allocation_ratio\u003d5.0\u0027,"},{"line_number":315,"context_line":"            \u0027MEMORY_MB:allocation_ratio\u003d6.0\u0027,"},{"line_number":316,"context_line":"            \u0027DISK_GB:allocation_ratio\u003d7.0\u0027,"},{"line_number":317,"context_line":"            aggregate\u003dTrue, amend\u003damend, dry_run\u003dTrue)"},{"line_number":318,"context_line":"        # Verify the inventories weren\u0027t changed (--dry-run)"},{"line_number":319,"context_line":"        for i, rp in enumerate(rps):"},{"line_number":320,"context_line":"            resp \u003d self.resource_inventory_list(rp[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_ec5506fa","line":317,"updated":"2019-09-05 04:35:19.000000000","message":"Can we add a test to verify the result of this command?","commit_id":"5cf7d77ab4c7499410182f9d09a7c0554b10c4da"}]}