)]}'
{"osc_placement/tests/functional/base.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bc8a00d7dd9c09927377619fd71d7a15953518fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        for name in RESET_LOGGING:"},{"line_number":81,"context_line":"            logging.getLogger(name).setLevel(logging.WARNING)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def openstack(self, cmd, may_fail\u003dFalse, use_json\u003dFalse, warning\u003dFalse):"},{"line_number":84,"context_line":"        to_exec \u003d []"},{"line_number":85,"context_line":"        # Make all requests as a noauth admin user."},{"line_number":86,"context_line":"        to_exec +\u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_814bcd5c","line":83,"range":{"start_line":83,"start_character":61,"end_line":83,"end_character":68},"updated":"2020-01-13 12:14:03.000000000","message":"I would call it \"may_print_to_stderr\" for multiple reasons, 1) it could follow the pattern from \"may_fail\"\n2) in theory other than warning can also be printed to stderr","commit_id":"df07d184ecf8395f2b7f67351b52bf81eb1d4acf"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"559d407710afb857ffa326f2ad630fb9970bb570","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        for name in RESET_LOGGING:"},{"line_number":81,"context_line":"            logging.getLogger(name).setLevel(logging.WARNING)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def openstack(self, cmd, may_fail\u003dFalse, use_json\u003dFalse, warning\u003dFalse):"},{"line_number":84,"context_line":"        to_exec \u003d []"},{"line_number":85,"context_line":"        # Make all requests as a noauth admin user."},{"line_number":86,"context_line":"        to_exec +\u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_0b3a8fc4","line":83,"range":{"start_line":83,"start_character":61,"end_line":83,"end_character":68},"in_reply_to":"3fa7e38b_814bcd5c","updated":"2020-01-14 06:09:44.000000000","message":"Done","commit_id":"df07d184ecf8395f2b7f67351b52bf81eb1d4acf"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"654a8ecb73c0d382d0672f5e1dff1e9314f918f9","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if may_print_to_stderr:"},{"line_number":128,"context_line":"            return output, error"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            if error:"},{"line_number":131,"context_line":"                msg \u003d (\u0027Test code error - The command did not fail but it \u0027"},{"line_number":132,"context_line":"                       \u0027has a warning message. Set the \"may_print_to_stderr\"\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_7dd417bd","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":12},"updated":"2020-01-14 19:52:13.000000000","message":"nit: redundant","commit_id":"0c750f450b3b470494dc53db102082bd987e3bc7"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6e6ec8474cec44071da978bd5a6479b5b722e8f","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        if may_print_to_stderr:"},{"line_number":128,"context_line":"            return output, error"},{"line_number":129,"context_line":"        else:"},{"line_number":130,"context_line":"            if error:"},{"line_number":131,"context_line":"                msg \u003d (\u0027Test code error - The command did not fail but it \u0027"},{"line_number":132,"context_line":"                       \u0027has a warning message. Set the \"may_print_to_stderr\"\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5efd8e3a","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":12},"in_reply_to":"3fa7e38b_7dd417bd","updated":"2020-01-15 01:16:43.000000000","message":"Good eye. Done.","commit_id":"0c750f450b3b470494dc53db102082bd987e3bc7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"654a8ecb73c0d382d0672f5e1dff1e9314f918f9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                msg \u003d (\u0027Test code error - The command did not fail but it \u0027"},{"line_number":132,"context_line":"                       \u0027has a warning message. Set the \"may_print_to_stderr\"\u0027"},{"line_number":133,"context_line":"                       \u0027argument to true to get and validate the message:\\n\u0027"},{"line_number":134,"context_line":"                       \u0027Command: \"%s\"\\nmay_print_to_stderr: %s\u0027) % ("},{"line_number":135,"context_line":"                    \u0027 \u0027.join(to_exec), error)"},{"line_number":136,"context_line":"                raise CommandException(msg, cmd\u003d\u0027 \u0027.join(to_exec))"},{"line_number":137,"context_line":"            return output"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_fde9e781","line":134,"range":{"start_line":134,"start_character":39,"end_line":134,"end_character":58},"updated":"2020-01-14 19:52:13.000000000","message":"This should be just `stderr` or `error`.\n\n[Later] Looks like maybe an overenthusiastic search/replace from an earlier patch set.","commit_id":"0c750f450b3b470494dc53db102082bd987e3bc7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"654a8ecb73c0d382d0672f5e1dff1e9314f918f9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                msg \u003d (\u0027Test code error - The command did not fail but it \u0027"},{"line_number":132,"context_line":"                       \u0027has a warning message. Set the \"may_print_to_stderr\"\u0027"},{"line_number":133,"context_line":"                       \u0027argument to true to get and validate the message:\\n\u0027"},{"line_number":134,"context_line":"                       \u0027Command: \"%s\"\\nmay_print_to_stderr: %s\u0027) % ("},{"line_number":135,"context_line":"                    \u0027 \u0027.join(to_exec), error)"},{"line_number":136,"context_line":"                raise CommandException(msg, cmd\u003d\u0027 \u0027.join(to_exec))"},{"line_number":137,"context_line":"            return output"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_fd8ec7d5","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":37},"updated":"2020-01-14 19:52:13.000000000","message":"is this redundant with whatever the `cmd` kwarg feeds into?","commit_id":"0c750f450b3b470494dc53db102082bd987e3bc7"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6e6ec8474cec44071da978bd5a6479b5b722e8f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                msg \u003d (\u0027Test code error - The command did not fail but it \u0027"},{"line_number":132,"context_line":"                       \u0027has a warning message. Set the \"may_print_to_stderr\"\u0027"},{"line_number":133,"context_line":"                       \u0027argument to true to get and validate the message:\\n\u0027"},{"line_number":134,"context_line":"                       \u0027Command: \"%s\"\\nmay_print_to_stderr: %s\u0027) % ("},{"line_number":135,"context_line":"                    \u0027 \u0027.join(to_exec), error)"},{"line_number":136,"context_line":"                raise CommandException(msg, cmd\u003d\u0027 \u0027.join(to_exec))"},{"line_number":137,"context_line":"            return output"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_793744dd","line":134,"range":{"start_line":134,"start_character":24,"end_line":134,"end_character":37},"in_reply_to":"3fa7e38b_fd8ec7d5","updated":"2020-01-15 01:16:43.000000000","message":"\u003e is this redundant with whatever the `cmd` kwarg feeds into?\n\nI did this in the same way now it does at L120.\n\nThe `cmd` kwarg is put into the CommandException [1] but not displayed, so what this displays is like this:\n\n  osc_placement.tests.functional.base.CommandException: Test code error - The command did not fail but it has a warning message. Set the \"may_print_to_stderr\"argument to true to get and validate the message:\n    Command: \"--os-endpoint http://9f8a18b2-524e-412b-be22-373ae0fa3c3e/placement --os-token admin --os-auth-type admin_token resource provider allocation set --allocation rp\u003d3f868afe-7e4b-4047-b2ed-6da70de5d704,VCPU\u003d2 --allocation rp\u003d3f868afe-7e4b-4047-b2ed-6da70de5d704,MEMORY_MB\u003d512 9737e7e8-78e7-4d9c-aecd-3fb06dcf7bb2 --project-id fake-project --user-id fake-user -f json\"\n    stderr: --project-id and --user-id options do not affect allocation for --os-placement-api-version less than 1.8\n\n[1] https://github.com/openstack/osc-placement/blob/066fe939ebb06aa5994993d833dc8c47b1b82c0f/osc_placement/tests/functional/base.py#L52","commit_id":"0c750f450b3b470494dc53db102082bd987e3bc7"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6e6ec8474cec44071da978bd5a6479b5b722e8f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                msg \u003d (\u0027Test code error - The command did not fail but it \u0027"},{"line_number":132,"context_line":"                       \u0027has a warning message. Set the \"may_print_to_stderr\"\u0027"},{"line_number":133,"context_line":"                       \u0027argument to true to get and validate the message:\\n\u0027"},{"line_number":134,"context_line":"                       \u0027Command: \"%s\"\\nmay_print_to_stderr: %s\u0027) % ("},{"line_number":135,"context_line":"                    \u0027 \u0027.join(to_exec), error)"},{"line_number":136,"context_line":"                raise CommandException(msg, cmd\u003d\u0027 \u0027.join(to_exec))"},{"line_number":137,"context_line":"            return output"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_19441048","line":134,"range":{"start_line":134,"start_character":39,"end_line":134,"end_character":58},"in_reply_to":"3fa7e38b_fde9e781","updated":"2020-01-15 01:16:43.000000000","message":"\u003e This should be just `stderr` or `error`.\n\nDone","commit_id":"0c750f450b3b470494dc53db102082bd987e3bc7"}]}