)]}'
{"osc_placement/resources/reshaper.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2f263d83edd618ab1c39622d430c2bf3069629","unresolved":true,"context_lines":[{"line_number":37,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":38,"context_line":"        return name, value"},{"line_number":39,"context_line":"    raise exceptions.CommandError(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_current_inventories(http, rp):"},{"line_number":43,"context_line":"    url \u003d INVENTORY_URL.format(uuid\u003drp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"e5ec164f_f0bd9b87","line":40,"updated":"2021-05-19 14:50:51.000000000","message":"nit: This could have been done as a custom argparse type or action. Not a huge advantage other than the error would raise sooner in the process (at parse time)","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3105e637f21007068252645b4e5d1a44c32f3176","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":38,"context_line":"        return name, value"},{"line_number":39,"context_line":"    raise exceptions.CommandError(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_current_inventories(http, rp):"},{"line_number":43,"context_line":"    url \u003d INVENTORY_URL.format(uuid\u003drp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"af2ad50c_87b8b38a","line":40,"in_reply_to":"c5782e80_f58e990d","updated":"2021-05-31 11:05:17.000000000","message":"Ack","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"31b4e8b482a8a6fd8533b5c405de81905a6a755a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":38,"context_line":"        return name, value"},{"line_number":39,"context_line":"    raise exceptions.CommandError(msg)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def get_current_inventories(http, rp):"},{"line_number":43,"context_line":"    url \u003d INVENTORY_URL.format(uuid\u003drp)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c5782e80_f58e990d","line":40,"in_reply_to":"e5ec164f_f0bd9b87","updated":"2021-05-30 02:18:25.000000000","message":"Agreed that it would be more elegant. Let me think about that fix at another time.","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2f263d83edd618ab1c39622d430c2bf3069629","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            help\u003d\u0027UUID of the consumer\u0027"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--src-rp\u0027,"},{"line_number":88,"context_line":"            metavar\u003d\u0027\u003crp_uuid\u003e\u0027,"},{"line_number":89,"context_line":"            dest\u003d\u0027src_rp\u0027,"},{"line_number":90,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"16d56a45_825dc2fa","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":21},"updated":"2021-05-19 14:50:51.000000000","message":"Typically OSC doesn\u0027t abbreviate things like this (if anything it\u0027s too terse) so I don\u0027t think plugins should abbreviate them either. Any reason we couldn\u0027t just call this \u0027--source-provider\u0027 or, if we wanted to keep it brief, simply \u0027--source\u0027?","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"31b4e8b482a8a6fd8533b5c405de81905a6a755a","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            help\u003d\u0027UUID of the consumer\u0027"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--src-rp\u0027,"},{"line_number":88,"context_line":"            metavar\u003d\u0027\u003crp_uuid\u003e\u0027,"},{"line_number":89,"context_line":"            dest\u003d\u0027src_rp\u0027,"},{"line_number":90,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"19da6cc8_7bc07635","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":21},"in_reply_to":"16d56a45_825dc2fa","updated":"2021-05-30 02:18:25.000000000","message":"Good spot. I prefer \"--source-provider\", which is more self-descriptive","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3105e637f21007068252645b4e5d1a44c32f3176","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            help\u003d\u0027UUID of the consumer\u0027"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--src-rp\u0027,"},{"line_number":88,"context_line":"            metavar\u003d\u0027\u003crp_uuid\u003e\u0027,"},{"line_number":89,"context_line":"            dest\u003d\u0027src_rp\u0027,"},{"line_number":90,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"8f4d7b1c_13500527","line":87,"range":{"start_line":87,"start_character":13,"end_line":87,"end_character":21},"in_reply_to":"19da6cc8_7bc07635","updated":"2021-05-31 11:05:17.000000000","message":"Ack","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2f263d83edd618ab1c39622d430c2bf3069629","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                 \u0027``--remove VCPU\u003d4 --remove MEMORY_MB\u003d2048``\u0027"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \u0027--dst-rp\u0027,"},{"line_number":109,"context_line":"            metavar\u003d\u0027\u003crp_uuid\u003e\u0027,"},{"line_number":110,"context_line":"            dest\u003d\u0027dst_rp\u0027,"},{"line_number":111,"context_line":"            help\u003d\u0027UUID of a resource provider to which to add the \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9e192590_090aea32","line":108,"updated":"2021-05-19 14:50:51.000000000","message":"ditto","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"31b4e8b482a8a6fd8533b5c405de81905a6a755a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                 \u0027``--remove VCPU\u003d4 --remove MEMORY_MB\u003d2048``\u0027"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \u0027--dst-rp\u0027,"},{"line_number":109,"context_line":"            metavar\u003d\u0027\u003crp_uuid\u003e\u0027,"},{"line_number":110,"context_line":"            dest\u003d\u0027dst_rp\u0027,"},{"line_number":111,"context_line":"            help\u003d\u0027UUID of a resource provider to which to add the \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ff235e4_0038178e","line":108,"in_reply_to":"9e192590_090aea32","updated":"2021-05-30 02:18:25.000000000","message":"Done","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2f263d83edd618ab1c39622d430c2bf3069629","unresolved":true,"context_lines":[{"line_number":180,"context_line":"                            \u0027consumer\u0027: consumer_uuid, \u0027rp\u0027: src_rp,"},{"line_number":181,"context_line":"                            \u0027rc\u0027: resource_class}"},{"line_number":182,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":183,"context_line":"            if remove_amount \u003c 0:"},{"line_number":184,"context_line":"                # The removal amount was omitted by user."},{"line_number":185,"context_line":"                # Let\u0027s remove all the allocation for this resource class"},{"line_number":186,"context_line":"                remove_amount \u003d old_amount"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a439f68_6ae1a03a","line":183,"updated":"2021-05-19 14:50:51.000000000","message":"So this is relying on us returning -1 in \u0027parse_resource_argument\u0027 above to indicate \"no amount specified\". I wonder if it would be clearer to explicitly check for this value?","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"31b4e8b482a8a6fd8533b5c405de81905a6a755a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                            \u0027consumer\u0027: consumer_uuid, \u0027rp\u0027: src_rp,"},{"line_number":181,"context_line":"                            \u0027rc\u0027: resource_class}"},{"line_number":182,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":183,"context_line":"            if remove_amount \u003c 0:"},{"line_number":184,"context_line":"                # The removal amount was omitted by user."},{"line_number":185,"context_line":"                # Let\u0027s remove all the allocation for this resource class"},{"line_number":186,"context_line":"                remove_amount \u003d old_amount"}],"source_content_type":"text/x-python","patch_set":9,"id":"d35f2be5_aef25ae8","line":183,"in_reply_to":"7a439f68_6ae1a03a","updated":"2021-05-30 02:18:25.000000000","message":"Done","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2f263d83edd618ab1c39622d430c2bf3069629","unresolved":true,"context_lines":[{"line_number":230,"context_line":"        add_list \u003d dict(["},{"line_number":231,"context_line":"            parse_resource_argument(rc) for rc in resources_to_add])"},{"line_number":232,"context_line":"        for resource_class, add_amount in add_list.items():"},{"line_number":233,"context_line":"            if add_amount \u003c 0:"},{"line_number":234,"context_line":"                # The additional amount was omitted by user. Then we add"},{"line_number":235,"context_line":"                # removed amount of this resource class for allocations"},{"line_number":236,"context_line":"                # and inventories."}],"source_content_type":"text/x-python","patch_set":9,"id":"876e2592_12a5c370","line":233,"updated":"2021-05-19 14:50:51.000000000","message":"ditto","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"31b4e8b482a8a6fd8533b5c405de81905a6a755a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        add_list \u003d dict(["},{"line_number":231,"context_line":"            parse_resource_argument(rc) for rc in resources_to_add])"},{"line_number":232,"context_line":"        for resource_class, add_amount in add_list.items():"},{"line_number":233,"context_line":"            if add_amount \u003c 0:"},{"line_number":234,"context_line":"                # The additional amount was omitted by user. Then we add"},{"line_number":235,"context_line":"                # removed amount of this resource class for allocations"},{"line_number":236,"context_line":"                # and inventories."}],"source_content_type":"text/x-python","patch_set":9,"id":"608fa768_dd519fb5","line":233,"in_reply_to":"876e2592_12a5c370","updated":"2021-05-30 02:18:25.000000000","message":"Done","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"}],"setup.cfg":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f2f263d83edd618ab1c39622d430c2bf3069629","unresolved":true,"context_lines":[{"line_number":60,"context_line":"    resource_provider_trait_set \u003d osc_placement.resources.trait:SetResourceProviderTrait"},{"line_number":61,"context_line":"    resource_provider_trait_delete \u003d osc_placement.resources.trait:DeleteResourceProviderTrait"},{"line_number":62,"context_line":"    allocation_candidate_list \u003d osc_placement.resources.allocation_candidate:ListAllocationCandidate"},{"line_number":63,"context_line":"    resource_provider_allocation_reshape \u003d osc_placement.resources.reshaper:Reshape"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"801666f3_45f59608","line":63,"updated":"2021-05-19 14:50:51.000000000","message":"nit: could you group this with the other \u0027resource_provider_allocation_*\u0027 commands above?","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"31b4e8b482a8a6fd8533b5c405de81905a6a755a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    resource_provider_trait_set \u003d osc_placement.resources.trait:SetResourceProviderTrait"},{"line_number":61,"context_line":"    resource_provider_trait_delete \u003d osc_placement.resources.trait:DeleteResourceProviderTrait"},{"line_number":62,"context_line":"    allocation_candidate_list \u003d osc_placement.resources.allocation_candidate:ListAllocationCandidate"},{"line_number":63,"context_line":"    resource_provider_allocation_reshape \u003d osc_placement.resources.reshaper:Reshape"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"dc8c591c_7e9134c5","line":63,"in_reply_to":"801666f3_45f59608","updated":"2021-05-30 02:18:25.000000000","message":"Done","commit_id":"f3bac06af6ce79118258234250a67d578cd83a67"}]}