)]}'
{"osc_placement/tests/unit/test_version.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9bbb89e51961ae531e1c4eb68022d28c757cf49b","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            t.check_version, version.lt(\u00271.2\u0027))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_max_version_consistency(self):"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def _convert_to_tuple(str):"},{"line_number":109,"context_line":"            return tuple(map(int, str.split(\".\")))"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"58ee88b1_b94c63c2","side":"PARENT","line":107,"updated":"2021-06-03 09:23:54.000000000","message":"nit: unrelated","commit_id":"37e47afc88b188a338e3cb70adcf87bac513d4ef"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"67ef3099efc1b8687e5d2fa467711d8ae70f17d2","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            t.check_version, version.lt(\u00271.2\u0027))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_max_version_consistency(self):"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def _convert_to_tuple(str):"},{"line_number":109,"context_line":"            return tuple(map(int, str.split(\".\")))"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b945aeb1_a8d545ee","side":"PARENT","line":107,"in_reply_to":"58ee88b1_b94c63c2","updated":"2021-06-03 19:18:32.000000000","message":"yep i intally \n\nfactored out _convert_to_tuple into a staitc method and then realised i did not need it\ni undid it but looks like  i deleted a line ill fix this when i respin.","commit_id":"37e47afc88b188a338e3cb70adcf87bac513d4ef"}],"osc_placement/version.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ff5681961104b0e8510ac0c4de14b00b121acff9","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            return MAX_VERSION_NO_GAP"},{"line_number":144,"context_line":"        version \u003d obj.app.client_manager.placement.api_version"},{"line_number":145,"context_line":"    except AttributeError:"},{"line_number":146,"context_line":"        # resource does not have api_version attr when docs are generated"},{"line_number":147,"context_line":"        # so let\u0027s use the minimal one"},{"line_number":148,"context_line":"        version \u003d SUPPORTED_VERSIONS[0]"},{"line_number":149,"context_line":"    return version"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"080bcc30_9316b24d","line":148,"range":{"start_line":146,"start_character":7,"end_line":148,"end_character":39},"updated":"2021-06-02 17:59:05.000000000","message":"would it make more sense to use the max version there too.\n\nthis is loaded as part of the cliff sphinx extension but im not sure its actully used but defaulting to oldest seams odd for docs.","commit_id":"3e14ebc9388a06619bbd0e494acc9890aca66c79"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"83329e9c6b4f14be82a92fa416617ffeda21e86d","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            return MAX_VERSION_NO_GAP"},{"line_number":144,"context_line":"        version \u003d obj.app.client_manager.placement.api_version"},{"line_number":145,"context_line":"    except AttributeError:"},{"line_number":146,"context_line":"        # resource does not have api_version attr when docs are generated"},{"line_number":147,"context_line":"        # so let\u0027s use the minimal one"},{"line_number":148,"context_line":"        version \u003d SUPPORTED_VERSIONS[0]"},{"line_number":149,"context_line":"    return version"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"16dc1a2a_d10a6f4c","line":148,"range":{"start_line":146,"start_character":7,"end_line":148,"end_character":39},"in_reply_to":"080bcc30_9316b24d","updated":"2021-06-02 18:00:34.000000000","message":"Agree, I would assume latest not oldest for doc generation...","commit_id":"3e14ebc9388a06619bbd0e494acc9890aca66c79"}]}