)]}'
{".zuul.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7024761d2db74ee72d99a94e4f4a32de2f724509","unresolved":false,"context_lines":[{"line_number":15,"context_line":"              - openstack/placement"},{"line_number":16,"context_line":"        - openstack-tox-functional-py310:"},{"line_number":17,"context_line":"            required-projects:"},{"line_number":18,"context_line":"              - openstack/placement"},{"line_number":19,"context_line":"            voting: False"},{"line_number":20,"context_line":"    gate:"},{"line_number":21,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ee2403f8_fef740e6","line":18,"updated":"2023-01-24 15:16:07.000000000","message":"these \u0027required-projects\u0027 entries ensure that the placement is cloned and checked out to the stable/\u003ccurrent_branch\u003e respectively.","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"}],"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0b8db98bf0b582fdaf585de441fedb5387f03332","unresolved":true,"context_lines":[{"line_number":26,"context_line":"- https://github.com/openstack/nova/blob/26f24b7086855bc8f57059d618060cc5844dca15/tox.ini#L64"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I4e3e5732411639054baaa9211a29e2e2c8210ac0"},{"line_number":29,"context_line":"(cherry picked from commit 90ecfa92f030a6370658430ca3bbc6273f7ea487)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e6153dc2_cf778bf7","line":29,"updated":"2023-02-20 11:56:11.000000000","message":"nit: this is not the latest patch (PS3 removed basepython related changes)","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"57fb46ac100cb58d5eaa4a196af0c7e69a45d1bf","unresolved":false,"context_lines":[{"line_number":26,"context_line":"- https://github.com/openstack/nova/blob/26f24b7086855bc8f57059d618060cc5844dca15/tox.ini#L64"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I4e3e5732411639054baaa9211a29e2e2c8210ac0"},{"line_number":29,"context_line":"(cherry picked from commit 90ecfa92f030a6370658430ca3bbc6273f7ea487)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"26942ceb_37dd5232","line":29,"in_reply_to":"20aab917_026330f3","updated":"2023-03-13 18:50:14.000000000","message":"well, the cherry picked patch hash could have been updated as well, but anyway, we don\u0027t have here the backport validator job, so the gate won\u0027t fail on this as it would in nova.","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9f4d6ab55804329fafa4cbe5a7f6c08b6fd319d9","unresolved":true,"context_lines":[{"line_number":26,"context_line":"- https://github.com/openstack/nova/blob/26f24b7086855bc8f57059d618060cc5844dca15/tox.ini#L64"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I4e3e5732411639054baaa9211a29e2e2c8210ac0"},{"line_number":29,"context_line":"(cherry picked from commit 90ecfa92f030a6370658430ca3bbc6273f7ea487)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"20aab917_026330f3","line":29,"in_reply_to":"e6153dc2_cf778bf7","updated":"2023-03-06 22:05:34.000000000","message":"right, those changes of removing basepython is applicable on master only for tox\u003e\u003d4 and on stable branches we have pinned tox\u003c4 so those changes are not needed.\n\nI will update it as note in commit msg","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"57fb46ac100cb58d5eaa4a196af0c7e69a45d1bf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"same way as nova functional tests doing"},{"line_number":26,"context_line":"- https://github.com/openstack/nova/blob/26f24b7086855bc8f57059d618060cc5844dca15/tox.ini#L64"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"During this backport, removing basepython changes are not applicable on stable as we have"},{"line_number":29,"context_line":"pinned stable branches for tox\u003c4."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I4e3e5732411639054baaa9211a29e2e2c8210ac0"},{"line_number":32,"context_line":"(cherry picked from commit 90ecfa92f030a6370658430ca3bbc6273f7ea487)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff3a1bbd_56a920e8","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":33},"updated":"2023-03-13 18:50:14.000000000","message":"This describes the changes compared to original merged patch. Thanks!","commit_id":"d4036554f044f548d6ba460db0114c0fd7469f7b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0b8db98bf0b582fdaf585de441fedb5387f03332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f40ab7b9_630840bb","updated":"2023-02-20 11:56:11.000000000","message":"Sorry @Ghanshyam for not answering earlier. The \u0027\u003e\u003d1.0.0\u0027 confused me a bit, but anyway, this patch works as intended (that is, it installs the development version of placement, for example: \u0027Successfully installed openstack-placement-8.0.1.dev2\u0027).\n\nNevertheless, the cherry pick has an issue. Though I think the missed part is not needed, but please confirm that it is missing intentionally (probably a \u0027note\u0027 in the commit message would clear the situation).","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"27b6bfc50e79cb745d5d993371f2b496bd4d3035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdb29918_12bab182","updated":"2023-02-20 08:43:38.000000000","message":"recheck - to get fresh logs","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"57fb46ac100cb58d5eaa4a196af0c7e69a45d1bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5a2d977_7086a12e","updated":"2023-03-13 18:50:14.000000000","message":"The changes, compared to the original patch, are described in the commit message. Thanks. Rest of the cherry picked code looks good.","commit_id":"d4036554f044f548d6ba460db0114c0fd7469f7b"}],"tox.ini":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7024761d2db74ee72d99a94e4f4a32de2f724509","unresolved":true,"context_lines":[{"line_number":42,"context_line":"deps \u003d"},{"line_number":43,"context_line":"  {[testenv]deps}"},{"line_number":44,"context_line":"  openstack-placement\u003e\u003d1.0.0"},{"line_number":45,"context_line":"commands \u003d stestr --test-path\u003d./osc_placement/tests/functional run {posargs}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:functional-py38]"},{"line_number":48,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"00daab4a_25803707","line":45,"updated":"2023-01-24 15:16:07.000000000","message":"Actually I think on the zuul job we are using the latest state of the given stable branch for placement. The problem is only when we want to run this test locally, am I right?\n\nSome projects introduced *-dev tox targets, where the required dependency is used differently than in Zuul, but to imitate zuul\u0027s behavior.\n\nSo however this is one possible workaround, keep in mind that this does not test against the latest state of placement on the given branch.","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"78392a8a9c711327b5d8100aa0b66e02f61c4340","unresolved":true,"context_lines":[{"line_number":42,"context_line":"deps \u003d"},{"line_number":43,"context_line":"  {[testenv]deps}"},{"line_number":44,"context_line":"  openstack-placement\u003e\u003d1.0.0"},{"line_number":45,"context_line":"commands \u003d stestr --test-path\u003d./osc_placement/tests/functional run {posargs}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[testenv:functional-py38]"},{"line_number":48,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":3,"id":"6f65b343_af69ba39","line":45,"in_reply_to":"00daab4a_25803707","updated":"2023-01-25 02:12:58.000000000","message":"that is right, and for local run we can change it to any particular version we want to test with even the master placement (as mentioned in comment).","commit_id":"3f2a80b68331d774947d0716151daaf0bfb94ac1"}]}
