)]}'
{"openstack/common/rpc/impl_zmq.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0388acd12fab275838ab2a706cb11e13a28e50eb","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        self.reactor \u003d ZmqReactor(conf)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _consume_fanout(self, reactor, topic, proxy, bind\u003dFalse):"},{"line_number":503,"context_line":"        for topic, host in matchmaker.queues(\"publishers~%s\" % (topic, )):"},{"line_number":504,"context_line":"            inaddr \u003d \"tcp://%s:%s\" % (host, CONF.rpc_zmq_port)"},{"line_number":505,"context_line":"            reactor.register(proxy, inaddr, zmq.SUB, in_bind\u003dbind)"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FVKc%3D","side":"PARENT","line":503,"updated":"2012-09-20 19:10:00.000000000","message":"When calling this from declare_topic_consumer(), the argument to matchmaker.queues() will end up being \u0027publishers~publishers~\u003ctopic\u003e\u0027.  That\u0027s accurate and desired?","commit_id":"032bf345ea593e97fcc07e23c1725ba5f4b612d0"},{"author":{"_account_id":159,"name":"Eric Windisch","email":"ewindisch@docker.com","username":"ewindisch"},"unresolved":false,"context_lines":[{"line_number":500,"context_line":"        self.reactor \u003d ZmqReactor(conf)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _consume_fanout(self, reactor, topic, proxy, bind\u003dFalse):"},{"line_number":503,"context_line":"        for topic, host in matchmaker.queues(\"publishers~%s\" % (topic, )):"},{"line_number":504,"context_line":"            inaddr \u003d \"tcp://%s:%s\" % (host, CONF.rpc_zmq_port)"},{"line_number":505,"context_line":"            reactor.register(proxy, inaddr, zmq.SUB, in_bind\u003dbind)"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FVJ0%3D","side":"PARENT","line":503,"in_reply_to":"AAAALH%2F%2FVKc%3D","updated":"2012-09-20 19:19:49.000000000","message":"No, but I don\u0027t think it actually breaks anything. I\u0027ll see about fixing this.","commit_id":"032bf345ea593e97fcc07e23c1725ba5f4b612d0"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0388acd12fab275838ab2a706cb11e13a28e50eb","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            return"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        reactor \u003d CallbackReactor(CONF, callback)"},{"line_number":534,"context_line":"        self._consume_fanout(reactor, \"publishers~%s\" % (topic, ), None,"},{"line_number":535,"context_line":"                             bind\u003dFalse)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def create_consumer(self, topic, proxy, fanout\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAALH%2F%2FVKs%3D","line":534,"updated":"2012-09-20 18:54:00.000000000","message":"Should this 2nd arg just be \u0027topic\u0027 ?   I haven\u0027t studied this full code, but I notice that _consume_fanout has this same publishers~%s logic.","commit_id":"a6793d90762e2e415115ff1ab023425bd890cb01"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"unresolved":false,"context_lines":[{"line_number":522,"context_line":"                               queue_name\u003dNone):"},{"line_number":523,"context_line":"        \"\"\"declare_topic_consumer is a private method, but"},{"line_number":524,"context_line":"           it is being used by Quantum (Folsom)."},{"line_number":525,"context_line":"           This has been added compatibility."},{"line_number":526,"context_line":"        \"\"\""},{"line_number":527,"context_line":"        # Only consume on the base topic name."},{"line_number":528,"context_line":"        topic \u003d topic.split(\u0027.\u0027, 1)[0]"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAALH%2F%2FU%2Bw%3D","line":525,"updated":"2012-09-20 21:46:17.000000000","message":"The style of this docstring is very different from the other ones. Perhaps it should be a # NOTE(). also: s/added/added for/","commit_id":"d5095d7effe79c1dcf19a67ff03e00a454662830"}]}
