)]}'
{"openstack/common/apiclient/client.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9e7cefc72a741ab3cb609f91375cd7d07cee50ed","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \"\u0027%s\u0027\" % url,"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if self.verify is False:"},{"line_number":127,"context_line":"            string_parts.insert(1, \u0027--insecure\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for element in kwargs[\u0027headers\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6a05f40e","line":126,"updated":"2015-01-06 20:10:00.000000000","message":"This should be:\n\n  if not self.verify:","commit_id":"6ad90b53617048ba1f750a61a97fdbb69a1ca4ad"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"b729635472f5246c2d4be6b7cdc8b992484d74a4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \"\u0027%s\u0027\" % url,"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if self.verify is False:"},{"line_number":127,"context_line":"            string_parts.insert(1, \u0027--insecure\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for element in kwargs[\u0027headers\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_5bf8014a","line":126,"in_reply_to":"3a961159_6a05f40e","updated":"2015-01-07 17:10:58.000000000","message":"Hi, Doug Hellmann\n\nThanks for your review.\n\nI\u0027m just a bit worried about how requests.session.Session will deal with verify when it is set to None or something weird such as 0, 1, \u0027something\u0027, and etc\n\nIs it better if we check verify in __init__ and kwargs, using oslo.utils.strutils.bool_from_string? But maybe not this patch\u0027s job.","commit_id":"6ad90b53617048ba1f750a61a97fdbb69a1ca4ad"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"87a66bc2e354ff9790486dbc094c27869c9e0472","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \"\u0027%s\u0027\" % url,"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if not kwargs.get(\u0027verify\u0027, self.verify):"},{"line_number":127,"context_line":"            string_parts.insert(1, \u0027--insecure\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for element in kwargs[\u0027headers\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_cc18d177","line":126,"updated":"2015-03-06 15:45:50.000000000","message":"In my earlier comment I was just pointing out that the logic was backwards. I don\u0027t understand the use of kwargs here. We have a verify attribute set in __init__(), right?","commit_id":"d0addf8ba02097f365aebab6f45b5ed411fec4da"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f062e32503e39162db3bf4ab127ac926ba800159","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \"\u0027%s\u0027\" % url,"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if not kwargs.get(\u0027verify\u0027, self.verify):"},{"line_number":127,"context_line":"            string_parts.insert(1, \u0027--insecure\u0027)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        for element in kwargs[\u0027headers\u0027]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f1c5458e","line":126,"in_reply_to":"9a80dd14_cc18d177","updated":"2015-03-09 01:40:58.000000000","message":"the kwargs is passed via request() method in L189, which means user can overwrite the verify settings in each call, so we should extract verify field firstly, if it is not set, then check self.verify","commit_id":"d0addf8ba02097f365aebab6f45b5ed411fec4da"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"f062e32503e39162db3bf4ab127ac926ba800159","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            kwargs[\"headers\"][\"Forwarded\"] \u003d \"for\u003d%s;by\u003d%s\" % ("},{"line_number":181,"context_line":"                self.original_ip, self.user_agent)"},{"line_number":182,"context_line":"        if self.timeout is not None:"},{"line_number":183,"context_line":"            kwargs.setdefault(\"timeout\", self.timeout)"},{"line_number":184,"context_line":"        kwargs.setdefault(\"verify\", self.verify)"},{"line_number":185,"context_line":"        if self.cert is not None:"},{"line_number":186,"context_line":"            kwargs.setdefault(\"cert\", self.cert)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_11c3b989","line":183,"updated":"2015-03-09 01:40:58.000000000","message":"if kwargs doesn\u0027t have verify field, then use client\u0027s verify attribute","commit_id":"d0addf8ba02097f365aebab6f45b5ed411fec4da"}]}