)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"418b9fc8b036a0351cca5e548074247ef30ea37e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate sqlalchemy utils from Nova."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These utils are usefull for database schema migrations"},{"line_number":10,"context_line":"and can be reused in other projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"blueprint oslo-sqlalchemy-utils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPX%2F%2F%2FU4%3D","line":9,"updated":"2013-06-04 13:26:10.000000000","message":"usefull -\u003e useful","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d5e7ad4cab21e33a57e79c2de8671b8ef72ee1db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate sqlalchemy utils from Nova."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These utils are usefull for database schema migrations"},{"line_number":10,"context_line":"and can be reused in other projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"blueprint oslo-sqlalchemy-utils"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPX%2F%2F%2FPs%3D","line":9,"in_reply_to":"AAAAPX%2F%2F%2FU4%3D","updated":"2013-06-04 13:59:47.000000000","message":"Done","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"}],"openstack/common/db/sqlalchemy/utils.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    return Table(name, metadata, autoload\u003dTrue)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class InsertFromSelect(UpdateBase):"},{"line_number":169,"context_line":"    def __init__(self, table, select):"},{"line_number":170,"context_line":"        self.table \u003d table"},{"line_number":171,"context_line":"        self.select \u003d select"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FxSk%3D","line":168,"updated":"2013-06-21 19:26:06.000000000","message":"Docstring?","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    return Table(name, metadata, autoload\u003dTrue)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class InsertFromSelect(UpdateBase):"},{"line_number":169,"context_line":"    def __init__(self, table, select):"},{"line_number":170,"context_line":"        self.table \u003d table"},{"line_number":171,"context_line":"        self.select \u003d select"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FoKQ%3D","line":168,"in_reply_to":"AAAAPn%2F%2FxSk%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"@compiles(InsertFromSelect)"},{"line_number":175,"context_line":"def visit_insert_from_select(element, compiler, **kw):"},{"line_number":176,"context_line":"    return \"INSERT INTO %s %s\" % ("},{"line_number":177,"context_line":"        compiler.process(element.table, asfrom\u003dTrue),"},{"line_number":178,"context_line":"        compiler.process(element.select))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FxSg%3D","line":175,"updated":"2013-06-21 19:26:06.000000000","message":"Docstring?","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"@compiles(InsertFromSelect)"},{"line_number":175,"context_line":"def visit_insert_from_select(element, compiler, **kw):"},{"line_number":176,"context_line":"    return \"INSERT INTO %s %s\" % ("},{"line_number":177,"context_line":"        compiler.process(element.table, asfrom\u003dTrue),"},{"line_number":178,"context_line":"        compiler.process(element.select))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FoKM%3D","line":175,"in_reply_to":"AAAAPn%2F%2FxSg%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"def drop_old_duplicate_entries_from_table(migrate_engine, table_name,"},{"line_number":199,"context_line":"                                          use_soft_delete, *uc_column_names):"},{"line_number":200,"context_line":"    \"\"\"Drop all old rows having the same values for columns in uc_columns.\"\"\""},{"line_number":201,"context_line":"    meta \u003d MetaData()"},{"line_number":202,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw%2Bw%3D","line":200,"updated":"2013-06-21 19:26:06.000000000","message":"Could you expand this docstring to describe the types of the arguments needed and how they are used? The names are pretty good, and I can figure it out from reading the code, but using this function incorrectly could be pretty dangerous.","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"def drop_old_duplicate_entries_from_table(migrate_engine, table_name,"},{"line_number":199,"context_line":"                                          use_soft_delete, *uc_column_names):"},{"line_number":200,"context_line":"    \"\"\"Drop all old rows having the same values for columns in uc_columns.\"\"\""},{"line_number":201,"context_line":"    meta \u003d MetaData()"},{"line_number":202,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FoMk%3D","line":200,"in_reply_to":"AAAAPn%2F%2Fw%2Bw%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    columns_for_group_by \u003d [table.c[name] for name in uc_column_names]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    columns_for_select \u003d [func.max(table.c.id)]"},{"line_number":208,"context_line":"    columns_for_select.extend(list(columns_for_group_by))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    duplicated_rows_select \u003d select(columns_for_select,"},{"line_number":211,"context_line":"                                    group_by\u003dcolumns_for_group_by,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw%2Bs%3D","line":208,"updated":"2013-06-21 19:26:06.000000000","message":"columns_for_group_by is already a list so you don\u0027t need to turn it into one here","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    columns_for_group_by \u003d [table.c[name] for name in uc_column_names]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    columns_for_select \u003d [func.max(table.c.id)]"},{"line_number":208,"context_line":"    columns_for_select.extend(list(columns_for_group_by))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    duplicated_rows_select \u003d select(columns_for_select,"},{"line_number":211,"context_line":"                                    group_by\u003dcolumns_for_group_by,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Foms%3D","line":208,"in_reply_to":"AAAAPn%2F%2Fw%2Bs%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        rows_to_delete_select \u003d select([table.c.id]).where(delete_condition)"},{"line_number":221,"context_line":"        for row in migrate_engine.execute(rows_to_delete_select).fetchall():"},{"line_number":222,"context_line":"            LOG.info(_(\"Deleted duplicated row with id: %(id)s from table: \""},{"line_number":223,"context_line":"                       \"%(table)s\") % dict(id\u003drow[0], table\u003dtable_name))"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if use_soft_delete:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw%2BE%3D","line":222,"updated":"2013-06-21 19:26:06.000000000","message":"This log message is using the past tense, but the work it describes isn\u0027t done yet. You could make it \"Deleting\" or move the logging to the end of the method (while still fetching the data on line 220).","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        rows_to_delete_select \u003d select([table.c.id]).where(delete_condition)"},{"line_number":221,"context_line":"        for row in migrate_engine.execute(rows_to_delete_select).fetchall():"},{"line_number":222,"context_line":"            LOG.info(_(\"Deleted duplicated row with id: %(id)s from table: \""},{"line_number":223,"context_line":"                       \"%(table)s\") % dict(id\u003drow[0], table\u003dtable_name))"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if use_soft_delete:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FoMo%3D","line":222,"in_reply_to":"AAAAPn%2F%2Fw%2BE%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                       \"%(table)s\") % dict(id\u003drow[0], table\u003dtable_name))"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if use_soft_delete:"},{"line_number":226,"context_line":"            delete_statement \u003d table.update().\\"},{"line_number":227,"context_line":"                where(delete_condition).\\"},{"line_number":228,"context_line":"                values({"},{"line_number":229,"context_line":"                    \u0027deleted\u0027: literal_column(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw98%3D","line":226,"updated":"2013-06-21 19:26:06.000000000","message":"I don\u0027t see any special logic to prevent updating rows that were soft-deleted in a previous call. That could result in loss of data (because the deleted_at column will have the wrong value).","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                       \"%(table)s\") % dict(id\u003drow[0], table\u003dtable_name))"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if use_soft_delete:"},{"line_number":226,"context_line":"            delete_statement \u003d table.update().\\"},{"line_number":227,"context_line":"                where(delete_condition).\\"},{"line_number":228,"context_line":"                values({"},{"line_number":229,"context_line":"                    \u0027deleted\u0027: literal_column(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fn%2FI%3D","line":226,"in_reply_to":"AAAAPn%2F%2Fw98%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        migrate_engine.execute(delete_statement)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def check_shadow_table(migrate_engine, table_name):"},{"line_number":239,"context_line":"    \"\"\"Check shadow table and it\u0027s columns"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    This method checks that table with ``table_name`` and corresponding shadow"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw9U%3D","line":238,"updated":"2013-06-21 19:26:06.000000000","message":"This function name isn\u0027t sufficiently descriptive of what is being done. There are a lot of \"checks\" that could be performed.\n\nHow about verify_shadow_table_definition_matches()?","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        migrate_engine.execute(delete_statement)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"def check_shadow_table(migrate_engine, table_name):"},{"line_number":239,"context_line":"    \"\"\"Check shadow table and it\u0027s columns"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    This method checks that table with ``table_name`` and corresponding shadow"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FonI%3D","line":238,"in_reply_to":"AAAAPn%2F%2Fw9U%3D","updated":"2013-06-26 14:31:19.000000000","message":"I\u0027m not sure because this function uses in `nova/tests/`.","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    shadow_table \u003d Table(_SHADOW_TABLE_PREFIX + table_name, meta,"},{"line_number":249,"context_line":"                         autoload\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    columns \u003d dict([(c.name, c) for c in table.columns])"},{"line_number":252,"context_line":"    shadow_columns \u003d dict([(c.name, c) for c in shadow_table.columns])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    for name, column in columns.iteritems():"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw9E%3D","line":251,"updated":"2013-06-21 19:26:06.000000000","message":"On lines 251 and 252, the list comprehensions can be converted to generator expressions by removing the [].","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    shadow_table \u003d Table(_SHADOW_TABLE_PREFIX + table_name, meta,"},{"line_number":249,"context_line":"                         autoload\u003dTrue)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    columns \u003d dict([(c.name, c) for c in table.columns])"},{"line_number":252,"context_line":"    shadow_columns \u003d dict([(c.name, c) for c in shadow_table.columns])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    for name, column in columns.iteritems():"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FonU%3D","line":251,"in_reply_to":"AAAAPn%2F%2Fw9E%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"533250f5e73d70c217d9520b122fa15af760dd03","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    columns \u003d dict([(c.name, c) for c in table.columns])"},{"line_number":252,"context_line":"    shadow_columns \u003d dict([(c.name, c) for c in shadow_table.columns])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    for name, column in columns.iteritems():"},{"line_number":255,"context_line":"        if name not in shadow_columns:"},{"line_number":256,"context_line":"            raise exception.OpenstackException(message\u003d_("},{"line_number":257,"context_line":"                \"Missing column %(table)s.%(column)s in shadow table\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fw8k%3D","line":254,"updated":"2013-06-21 19:26:06.000000000","message":"Would it be more useful to build a list of the differences and then raise a single exception? I\u0027m not sure who is using this function, but if they only get one error at a time and the table definitions are not consistent in several ways, they may grow annoyed at having to make one change at a time.","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"0d58845632d24562e243997b71ec87a7d85798f0","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    columns \u003d dict([(c.name, c) for c in table.columns])"},{"line_number":252,"context_line":"    shadow_columns \u003d dict([(c.name, c) for c in shadow_table.columns])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    for name, column in columns.iteritems():"},{"line_number":255,"context_line":"        if name not in shadow_columns:"},{"line_number":256,"context_line":"            raise exception.OpenstackException(message\u003d_("},{"line_number":257,"context_line":"                \"Missing column %(table)s.%(column)s in shadow table\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fonc%3D","line":254,"in_reply_to":"AAAAPn%2F%2Fw8k%3D","updated":"2013-06-26 14:31:19.000000000","message":"Done","commit_id":"c1c2e3a58e1d025c8c37a4fa9ce6edf7c9c64c2f"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6d6b248989f3b583d33e682b16f5e7f82e4ef1aa","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        column \u003d col_name_col_instance[column_name]"},{"line_number":180,"context_line":"    except KeyError:"},{"line_number":181,"context_line":"        msg \u003d _(\"Please specify column %s in col_name_col_instance \""},{"line_number":182,"context_line":"                \"param. It is required because column has unsupported \""},{"line_number":183,"context_line":"                \"type by sqlite).\")"},{"line_number":184,"context_line":"        raise exception.OpenstackException(message\u003dmsg % column_name)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAP3%2F%2Fnwk%3D","line":182,"updated":"2013-07-15 19:00:12.000000000","message":"\"has a type sqlite does not support\"","commit_id":"3972c3f494ca7c12e4b9c250a9c2f916165bb6fa"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6d6b248989f3b583d33e682b16f5e7f82e4ef1aa","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    if not isinstance(column, Column):"},{"line_number":187,"context_line":"        msg \u003d _(\"col_name_col_instance param has wrong type of \""},{"line_number":188,"context_line":"                \"column instance for column %s It should be instance \""},{"line_number":189,"context_line":"                \"of sqlalchemy.Column.\")"},{"line_number":190,"context_line":"        raise exception.OpenstackException(message\u003dmsg % column_name)"},{"line_number":191,"context_line":"    return column"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAP3%2F%2FnwU%3D","line":188,"updated":"2013-07-15 19:00:12.000000000","message":"need a . between %s and It\n\n  column %s. It\n\nalso add \"an\" before instance:\n\n  It should be an instance","commit_id":"3972c3f494ca7c12e4b9c250a9c2f916165bb6fa"}],"tests/unit/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"418b9fc8b036a0351cca5e548074247ef30ea37e","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def _have_mysql(user, passwd, database):"},{"line_number":68,"context_line":"    present \u003d os.environ.get(\u0027NOVA_TEST_MYSQL_PRESENT\u0027)"},{"line_number":69,"context_line":"    if present is None:"},{"line_number":70,"context_line":"        return _is_backend_avail(\u0027mysql\u0027, user, passwd, database)"},{"line_number":71,"context_line":"    return present.lower() in (\u0027\u0027, \u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FUc%3D","line":68,"updated":"2013-06-04 13:26:10.000000000","message":"should this be OSLO_TEST_MYSQL_PRESENT?","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d5e7ad4cab21e33a57e79c2de8671b8ef72ee1db","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def _have_mysql(user, passwd, database):"},{"line_number":68,"context_line":"    present \u003d os.environ.get(\u0027NOVA_TEST_MYSQL_PRESENT\u0027)"},{"line_number":69,"context_line":"    if present is None:"},{"line_number":70,"context_line":"        return _is_backend_avail(\u0027mysql\u0027, user, passwd, database)"},{"line_number":71,"context_line":"    return present.lower() in (\u0027\u0027, \u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FOU%3D","line":68,"in_reply_to":"AAAAPX%2F%2F%2FUc%3D","updated":"2013-06-04 13:59:47.000000000","message":"Thanks for pointing this out! :)\nThis variable should be used in different projects so I guess that name `TEST_MYSQL_PRESENT` is more appropriate.","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"418b9fc8b036a0351cca5e548074247ef30ea37e","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def _have_postgresql(user, passwd, database):"},{"line_number":75,"context_line":"    present \u003d os.environ.get(\u0027NOVA_TEST_POSTGRESQL_PRESENT\u0027)"},{"line_number":76,"context_line":"    if present is None:"},{"line_number":77,"context_line":"        return _is_backend_avail(\u0027postgres\u0027, user, passwd, database)"},{"line_number":78,"context_line":"    return present.lower() in (\u0027\u0027, \u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FUQ%3D","line":75,"updated":"2013-06-04 13:26:10.000000000","message":"NOVA -\u003e OSLO","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d5e7ad4cab21e33a57e79c2de8671b8ef72ee1db","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"def _have_postgresql(user, passwd, database):"},{"line_number":75,"context_line":"    present \u003d os.environ.get(\u0027NOVA_TEST_POSTGRESQL_PRESENT\u0027)"},{"line_number":76,"context_line":"    if present is None:"},{"line_number":77,"context_line":"        return _is_backend_avail(\u0027postgres\u0027, user, passwd, database)"},{"line_number":78,"context_line":"    return present.lower() in (\u0027\u0027, \u0027true\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FOM%3D","line":75,"in_reply_to":"AAAAPX%2F%2F%2FUQ%3D","updated":"2013-06-04 13:59:47.000000000","message":"ditto","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"418b9fc8b036a0351cca5e548074247ef30ea37e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.DEFAULT_CONFIG_FILE \u003d os.path.join(os.path.dirname(__file__),"},{"line_number":102,"context_line":"                                                \u0027test_migrations.conf\u0027)"},{"line_number":103,"context_line":"        # Test machines can set the NOVA_TEST_MIGRATIONS_CONF variable"},{"line_number":104,"context_line":"        # to override the location of the config file for migration testing"},{"line_number":105,"context_line":"        self.CONFIG_FILE_PATH \u003d os.environ.get(\u0027NOVA_TEST_MIGRATIONS_CONF\u0027,"},{"line_number":106,"context_line":"                                               self.DEFAULT_CONFIG_FILE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FUM%3D","line":103,"updated":"2013-06-04 13:26:10.000000000","message":"NOVA -\u003e OSLO","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d5e7ad4cab21e33a57e79c2de8671b8ef72ee1db","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.DEFAULT_CONFIG_FILE \u003d os.path.join(os.path.dirname(__file__),"},{"line_number":102,"context_line":"                                                \u0027test_migrations.conf\u0027)"},{"line_number":103,"context_line":"        # Test machines can set the NOVA_TEST_MIGRATIONS_CONF variable"},{"line_number":104,"context_line":"        # to override the location of the config file for migration testing"},{"line_number":105,"context_line":"        self.CONFIG_FILE_PATH \u003d os.environ.get(\u0027NOVA_TEST_MIGRATIONS_CONF\u0027,"},{"line_number":106,"context_line":"                                               self.DEFAULT_CONFIG_FILE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FNc%3D","line":103,"in_reply_to":"AAAAPX%2F%2F%2FUM%3D","updated":"2013-06-04 13:59:47.000000000","message":"ditto","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"418b9fc8b036a0351cca5e548074247ef30ea37e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                \u0027test_migrations.conf\u0027)"},{"line_number":103,"context_line":"        # Test machines can set the NOVA_TEST_MIGRATIONS_CONF variable"},{"line_number":104,"context_line":"        # to override the location of the config file for migration testing"},{"line_number":105,"context_line":"        self.CONFIG_FILE_PATH \u003d os.environ.get(\u0027NOVA_TEST_MIGRATIONS_CONF\u0027,"},{"line_number":106,"context_line":"                                               self.DEFAULT_CONFIG_FILE)"},{"line_number":107,"context_line":"        self.test_databases \u003d {}"},{"line_number":108,"context_line":"        self.migration_api \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FUE%3D","line":105,"updated":"2013-06-04 13:26:10.000000000","message":"NOVA -\u003e OSLO","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d5e7ad4cab21e33a57e79c2de8671b8ef72ee1db","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                                \u0027test_migrations.conf\u0027)"},{"line_number":103,"context_line":"        # Test machines can set the NOVA_TEST_MIGRATIONS_CONF variable"},{"line_number":104,"context_line":"        # to override the location of the config file for migration testing"},{"line_number":105,"context_line":"        self.CONFIG_FILE_PATH \u003d os.environ.get(\u0027NOVA_TEST_MIGRATIONS_CONF\u0027,"},{"line_number":106,"context_line":"                                               self.DEFAULT_CONFIG_FILE)"},{"line_number":107,"context_line":"        self.test_databases \u003d {}"},{"line_number":108,"context_line":"        self.migration_api \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2FNU%3D","line":105,"in_reply_to":"AAAAPX%2F%2F%2FUE%3D","updated":"2013-06-04 13:59:47.000000000","message":"ditto","commit_id":"6d2cb473135e906d3ec954e07b82bf1429aa2a4e"}]}
