)]}'
{"openstack/common/gettextutils.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"8a4f379b5b4c4e4b5d642e8b362764c63966f932","unresolved":false,"context_lines":[{"line_number":94,"context_line":"_LC \u003d functools.partial(_log_translation, level\u003d\u0027critical\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def install(domain, lazy\u003dFalse):"},{"line_number":98,"context_line":"    \"\"\"Install a _() function using the given translation domain."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Given a translation domain, install a _() function using gettext\u0027s"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9k1s%3D","line":97,"updated":"2014-02-05 23:12:06.000000000","message":"I\u0027m not sure we\u0027re really encouraging projects to use install anymore, but I\u0027m pretty sure some are and this isn\u0027t going to install the new log level translations.  Do we want to do that?","commit_id":"75859934119bf2879cf76ac6139aaa33be27fa32"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"352ec165dde474bf047431c187f8fd0961af6f5b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"_LC \u003d functools.partial(_log_translation, level\u003d\u0027critical\u0027)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def install(domain, lazy\u003dFalse):"},{"line_number":98,"context_line":"    \"\"\"Install a _() function using the given translation domain."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Given a translation domain, install a _() function using gettext\u0027s"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9fjA%3D","line":97,"in_reply_to":"AAAAUH%2F9k1s%3D","updated":"2014-02-06 15:03:08.000000000","message":"Good point. It\u0027s probably best if we remove install() entirely, so that we can ensure each use of _() is looking in the right domain. Do you think it\u0027s better to go ahead and install the new functions and then drop install() later, or just leave them out entirely and drop install() later?","commit_id":"75859934119bf2879cf76ac6139aaa33be27fa32"}],"tests/unit/test_gettext.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"928fbbfb3bd473acf0455b6e72d3fd5a2c9bb78f","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        self.assertEqual(\u0027oslo-log-\u0027 + self.level, result.domain)"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"class TestTranslations(gettext.GNUTranslations):"},{"line_number":706,"context_line":"    \"\"\"A test GNUTranslations class that takes a map of msg -\u003e translations.\"\"\""},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"    def __init__(self, translations):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FdeQ%3D","line":705,"updated":"2014-01-13 17:43:33.000000000","message":"This seems to be a duplicate of https://github.com/openstack/oslo-incubator/blob/master/tests/unit/fakes.py#L39\n\nIs there a reason we need separate copies?","commit_id":"390141efdb27fb6384e4a53964d24fb77cb2ab0c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"8a4f379b5b4c4e4b5d642e8b362764c63966f932","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        self.assertEqual(\u0027oslo-log-\u0027 + self.level, result.domain)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"class TestTranslations(gettext.GNUTranslations):"},{"line_number":760,"context_line":"    \"\"\"A test GNUTranslations class that takes a map of msg -\u003e translations.\"\"\""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def __init__(self, translations):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9kv8%3D","line":759,"updated":"2014-02-05 23:12:06.000000000","message":"This still appears to be basically a copy of FakeTranslations from the fakes.py file: https://github.com/openstack/oslo-incubator/blob/master/tests/unit/fakes.py#L40\n\nDo we not want to use fakes here for some reason?\n\nAlso, I don\u0027t see it used anywhere.","commit_id":"75859934119bf2879cf76ac6139aaa33be27fa32"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e1544252bbbdb6931a972b5d5c52a531231d1413","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        self.assertEqual(\u0027oslo-log-\u0027 + self.level, result.domain)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"class TestTranslations(gettext.GNUTranslations):"},{"line_number":760,"context_line":"    \"\"\"A test GNUTranslations class that takes a map of msg -\u003e translations.\"\"\""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def __init__(self, translations):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9cu4%3D","line":759,"in_reply_to":"AAAAUH%2F9fiE%3D","updated":"2014-02-06 20:48:25.000000000","message":"Apparently this was copy-pasta. It isn\u0027t even being used.","commit_id":"75859934119bf2879cf76ac6139aaa33be27fa32"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"352ec165dde474bf047431c187f8fd0961af6f5b","unresolved":false,"context_lines":[{"line_number":756,"context_line":"        self.assertEqual(\u0027oslo-log-\u0027 + self.level, result.domain)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"class TestTranslations(gettext.GNUTranslations):"},{"line_number":760,"context_line":"    \"\"\"A test GNUTranslations class that takes a map of msg -\u003e translations.\"\"\""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def __init__(self, translations):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9fiE%3D","line":759,"in_reply_to":"AAAAUH%2F9kv8%3D","updated":"2014-02-06 15:03:08.000000000","message":"It has been long enough that I\u0027ll have to look at those more closely to see why I did it this way.","commit_id":"75859934119bf2879cf76ac6139aaa33be27fa32"}]}