)]}'
{"openstack/common/processutils.py":[{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"bb90a0b30df69979fe33066e540c8e7de7a62589","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        cmd \u003d shlex.split(root_helper) + list(cmd)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    cmd \u003d map(str, cmd)"},{"line_number":154,"context_line":"    process_env \u003d os.environ.copy()"},{"line_number":155,"context_line":"    process_env.update(dict(env_variables))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    while attempts \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F7fE%3D","line":154,"updated":"2014-04-08 12:48:50.000000000","message":"I have a question to the folks about copying the current environment. Should processutils take care of that or that is a user\u0027s duty?\n\nBy copying the current environment here we make easier to launch the process in general cases but will make it impossible to launch the processes with the environment that only contains user\u0027s variables.","commit_id":"a385bd3d7d1b32b1c7e396d78f6efe19f15a7e8b"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"7b694d9232fc3291cc40ff3f1573a940164a0a1e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        cmd \u003d shlex.split(root_helper) + list(cmd)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    cmd \u003d map(str, cmd)"},{"line_number":154,"context_line":"    process_env \u003d os.environ.copy()"},{"line_number":155,"context_line":"    process_env.update(dict(env_variables))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    while attempts \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F5p4%3D","line":154,"in_reply_to":"AAAAWn%2F%2F6J4%3D","updated":"2014-04-08 16:17:19.000000000","message":"Agree. I was thinking about this approach before uploading the patch but decided to ask someone for their opinion first.","commit_id":"a385bd3d7d1b32b1c7e396d78f6efe19f15a7e8b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d02a7e5079c41674d220061307b38d039aaaaf8f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        cmd \u003d shlex.split(root_helper) + list(cmd)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    cmd \u003d map(str, cmd)"},{"line_number":154,"context_line":"    process_env \u003d os.environ.copy()"},{"line_number":155,"context_line":"    process_env.update(dict(env_variables))"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    while attempts \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWn%2F%2F6J4%3D","line":154,"in_reply_to":"AAAAWn%2F%2F7fE%3D","updated":"2014-04-08 15:12:57.000000000","message":"Copying the variables here also makes it impossible to remove the definition of a variable. It could be made blank, but couldn\u0027t be unset entirely. Would it be better to follow Popen()\u0027s default behavior and leave env\u003dNone if no environment is passed in and replace env with exactly what the caller provides otherwise?","commit_id":"a385bd3d7d1b32b1c7e396d78f6efe19f15a7e8b"}],"tests/unit/test_processutils.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"7fc638f5ff045d9088c85d862d63fb13aaf31d01","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        out, err \u003d processutils.execute(\u0027/usr/bin/env\u0027, env_variables\u003denv_vars)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertIn(var_value, out)"},{"line_number":209,"context_line":"        self.assertIn(var_name, out)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def fake_execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2F1XA%3D","line":209,"updated":"2014-04-10 04:15:19.000000000","message":"Use self.assertIn(\u0027SUPER_UNIQUE_VAR\u003dThe answer is 42\u0027, out)  ?","commit_id":"78076731cc2c3fb6429c16a676ec4187dbced950"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"d918dac90481db515237e2cce91be9785529eb6e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        out, err \u003d processutils.execute(\u0027/usr/bin/env\u0027, env_variables\u003denv_vars)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertIn(var_value, out)"},{"line_number":209,"context_line":"        self.assertIn(var_name, out)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def fake_execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FuIo%3D","line":209,"in_reply_to":"AAAAW3%2F%2F1XA%3D","updated":"2014-04-10 21:08:33.000000000","message":"Yes, it would be safer to ensure that the variable is assigned the expected value.","commit_id":"78076731cc2c3fb6429c16a676ec4187dbced950"},{"author":{"_account_id":6623,"name":"Roman Prykhodchenko","email":"me@romcheg.me","username":"prykhodchenko"},"change_message_id":"bfcac0d6af90409fe74479f137f7c5f3f1c091bc","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        out, err \u003d processutils.execute(\u0027/usr/bin/env\u0027, env_variables\u003denv_vars)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        self.assertIn(var_value, out)"},{"line_number":209,"context_line":"        self.assertIn(var_name, out)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def fake_execute(*cmd, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAW3%2F%2FuHg%3D","line":209,"in_reply_to":"AAAAW3%2F%2FuIo%3D","updated":"2014-04-10 21:10:40.000000000","message":"Agree, will change in the next patch set.","commit_id":"78076731cc2c3fb6429c16a676ec4187dbced950"}]}
