)]}'
{"specs/juno/policy-configuration-directories.rst":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"07bf0fb139b73016c399113beb345bfdc59e2ab1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_c32c4a05","line":30,"updated":"2014-07-03 05:53:54.000000000","message":"question: will following still be true if we use proposed method in this spec?\n\nfrom https://review.openstack.org/#/c/92325/3/specs/juno/extension-level-policy-as-default-v3-api.rst\n\nExtension rule: compute_extension:v3:[extension_name]\nAction rule: compute_extension:v3:[extension_name]:[action_name]\nIf deployer want to set same rule for all the API in an extension, deployer\njust need write a rule for extension. Then that rule will apply to all the API\nin that extensions.\nIf deployer want to change rule for one of API in that extension, it only\nneed write an action policy rule for that API. Then it will override the rule\nof extension.\nFor example:\n\"compute_extension:v3:os-aggregates\": \"rule:admin_api\",\n\"compute_extension:v3:os-aggregates:set_metadata\": \"role:maintainer\"\nThis means the rule of APIs except set_metadata in os-aggregates extension\nis \"rule:admin_api\". For set_metadata, the rule is \"role:maintainer\".","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7de5dddfb798ac87ce758ae3c9da422d074e97fb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_f89ad861","line":30,"in_reply_to":"baada198_c32c4a05","updated":"2014-07-03 07:20:25.000000000","message":"I feel if we implement policy.d, that specs will confuse for users. Maybe I just write an extension level policy rule, but there maybe a action level rule in other policy files, and that hard for users to maintenance that.","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8327a141b441875f064f26387b2f40c567eed250","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_d8999420","line":30,"in_reply_to":"baada198_f89ad861","updated":"2014-07-03 07:30:36.000000000","message":"ok , they need to explicitly write the policy for each action in the policy.d file if they want to overwrite the rule, got it","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"07bf0fb139b73016c399113beb345bfdc59e2ab1","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Documentation Impact"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_c389aa27","line":110,"updated":"2014-07-03 05:53:54.000000000","message":"I think at least we need to mention doc update for users and operators","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8327a141b441875f064f26387b2f40c567eed250","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Documentation Impact"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_d8cb541c","line":110,"in_reply_to":"baada198_38cff080","updated":"2014-07-03 07:30:36.000000000","message":"yes, I agree, but we may need mention something here? \nor oslo don\u0027t need it? \nIMHO doc must be updated in each project adopt this change :)","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7de5dddfb798ac87ce758ae3c9da422d074e97fb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Documentation Impact"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_38cff080","line":110,"in_reply_to":"baada198_c389aa27","updated":"2014-07-03 07:20:25.000000000","message":"Should we update doc when we import this into specific project? I guess we didn\u0027t have user and operator doc for oslo project","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c0a927475eba3e8d49ed3935da62ceb74c851c0d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Documentation Impact"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"None"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_6ee8c210","line":110,"in_reply_to":"baada198_d8cb541c","updated":"2014-07-03 08:10:37.000000000","message":"ok, let update some note at here.","commit_id":"8ff214ebb2fad51e35a039a5e7812ddc9cbe2716"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_0ff2c705","line":29,"updated":"2014-07-03 19:23:36.000000000","message":"Do the files need to have a common file extension so we can find them? For example, oslo.config looks for files ending in \".conf\". Should we use something like \".policy\"?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_8715d44a","line":29,"in_reply_to":"baada198_0ff2c705","updated":"2014-07-04 02:42:15.000000000","message":"My initial feeling is without file extension is more convenient for user. user needn\u0027t to check the document for what the file extension.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_2f24ebad","line":30,"updated":"2014-07-03 19:23:36.000000000","message":"It seems like spreading rules across files may give us more opportunities for conflicting rule definitions that are hard to track down just because they are in different files. You\u0027ve described the order the policies will be evaluated clearly, but do we need to consider issuing warnings when we detect potential conflicts?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_ca38b3d5","line":30,"in_reply_to":"baada198_2f24ebad","updated":"2014-07-04 02:42:15.000000000","message":"The rules is override by order, so it\u0027s hard to say which is conflicting rule definitions. Or maybe I didn\u0027t understand the meaning of conflicting rule definitions, did you have some example for this?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"57f0874c86cd06a7497ad36d0a2b63454b60c05b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_ed29ea8a","line":30,"in_reply_to":"baada198_5fdeffdd","updated":"2014-07-07 02:42:36.000000000","message":"If the user defines two permission for same action in same file, the last one will override the previous. That is json.loads\u0027 behavior. We can change this. But I guess it should be a separated propose.\n\nIf the user defines two permission for same action in different file, we shouldn\u0027t consider it as conflict, we want it to override by order, that is our expected.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c602e6c54170d48bb9c20a44b9dfe3a063520019","unresolved":false,"context_lines":[{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Alternatives"},{"line_number":33,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_5fdeffdd","line":30,"in_reply_to":"baada198_ca38b3d5","updated":"2014-07-06 18:13:53.000000000","message":"Suppose the user defines two permission rules for the same action or object. Is that allowed? Should we warn the user of a possible mis-configuration? What happens now if they do this in the rules file?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":43,"context_line":"---------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The policy rules will be loaded from specified directories. If those"},{"line_number":46,"context_line":"directories have appropriate permissions, there won\u0027t have any security issue."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Performance Impact"},{"line_number":49,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_cf844f60","line":46,"updated":"2014-07-03 19:23:36.000000000","message":"You\u0027re probably right that this isn\u0027t any different from the single policy file, but since we are scanning the directory we may need to be a little more careful. Do we need to document what permissions to use?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"---------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"The policy rules will be loaded from specified directories. If those"},{"line_number":46,"context_line":"directories have appropriate permissions, there won\u0027t have any security issue."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Performance Impact"},{"line_number":49,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_4a54a3fe","line":46,"in_reply_to":"baada198_cf844f60","updated":"2014-07-04 02:42:15.000000000","message":"ok, we can document one suggested permissions.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Milestones"},{"line_number":78,"context_line":"----------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Target Milestone for completion: Juno"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Work Items"},{"line_number":83,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_8f3257f0","line":80,"updated":"2014-07-03 19:23:36.000000000","message":"I think at this point in the schedule Juno-3 is the most likely milestone.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"Milestones"},{"line_number":78,"context_line":"----------"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"Target Milestone for completion: Juno"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Work Items"},{"line_number":83,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_0a462b4f","line":80,"in_reply_to":"baada198_8f3257f0","updated":"2014-07-04 02:42:15.000000000","message":"ok, thanks","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Work Items"},{"line_number":83,"context_line":"----------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"This change only need one single patch."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Incubation"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_af463b4d","line":85,"updated":"2014-07-03 19:23:36.000000000","message":"Can you provide more detail about which file(s) need to change, and maybe which classes or functions? The point of asking for a list of work items is to ensure that the plan is fully thought out before code starts landing, and so we can understand the nature of the changes when reviewing them.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"Work Items"},{"line_number":83,"context_line":"----------"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"This change only need one single patch."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Incubation"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_4a7bc38b","line":85,"in_reply_to":"baada198_af463b4d","updated":"2014-07-04 02:42:15.000000000","message":"will update, thanks","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Adoption"},{"line_number":93,"context_line":"--------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"All the openstack projects can utilize this feature."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Library"},{"line_number":98,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_6f67c3e9","line":95,"updated":"2014-07-03 19:23:36.000000000","message":"Which project has asked for it?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"Adoption"},{"line_number":93,"context_line":"--------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"All the openstack projects can utilize this feature."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Library"},{"line_number":98,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_aa69bfbf","line":95,"in_reply_to":"baada198_6f67c3e9","updated":"2014-07-04 02:42:15.000000000","message":"I\u0027m going to improve policy for nova. This can be used by most of openstack project. will update.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Documentation Impact"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The new option should be documented at configuration documents."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_efa2f3fb","line":110,"updated":"2014-07-03 19:23:36.000000000","message":"We also need to update any guides that describe how to write policies to explain how multiple policy files are combined to build up the full set of rules. Where is that documented?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"Documentation Impact"},{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The new option should be documented at configuration documents."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Dependencies"},{"line_number":113,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_ca94338d","line":110,"in_reply_to":"baada198_efa2f3fb","updated":"2014-07-04 02:42:15.000000000","message":"yea, there isn\u0027t a doc for this. I guess http://docs.openstack.org/icehouse/config-reference/content/ this good place for it.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"004961666e12caeb376972faaf8f7649e055aa90","unresolved":false,"context_lines":[{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"https://etherpad.openstack.org/p/juno-nova-devops"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. note::"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_cf01af06","line":120,"updated":"2014-07-03 19:23:36.000000000","message":"The reference to policies on line 55 just says \"easier configuration of policy file\". Is there more detail somewhere?","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bcaf5211dc5131bf5915afcf10f8499609b1e57c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"References"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"https://etherpad.openstack.org/p/juno-nova-devops"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. note::"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_6ac887a8","line":120,"in_reply_to":"baada198_cf01af06","updated":"2014-07-04 02:42:15.000000000","message":"Actually I hear this from John. In summit, the policy.d is mentioned somewhere. But I couldn\u0027t find it. I only know there are some complain for policy. So paste it at here to prove, operator want  a better way to config policy.","commit_id":"bfc2849113078c60934fda715d349ec593014b11"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"45cdd75d0bbd0b2ed0878c924cbb250b07785e20","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Add new configuration option:"},{"line_number":25,"context_line":"policy_configuration_directoires \u003d [list of directories]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_0475f030","line":27,"updated":"2014-07-08 01:25:55.000000000","message":"\"directoires\" should be \"directories\"\n\nI\u0027m seeing this typo in a few places (line 24, 27, etc)","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"289b34773b6b4a081226edcc4e71f1afa016cf4e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Add new configuration option:"},{"line_number":25,"context_line":"policy_configuration_directoires \u003d [list of directories]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\u0027policy_configuration_directoires\u0027 accept a list of directoires. Those"},{"line_number":28,"context_line":"directories will be iterated by order. The files in those directories will be"},{"line_number":29,"context_line":"loaded by alphabet order, and the rules will be overrided by that order. The"},{"line_number":30,"context_line":"sub-directories will be ignore."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_879e6205","line":27,"in_reply_to":"baada198_0475f030","updated":"2014-07-08 02:22:38.000000000","message":"thanks, will update","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"45cdd75d0bbd0b2ed0878c924cbb250b07785e20","unresolved":false,"context_lines":[{"line_number":53,"context_line":"------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"This change need iterated a list of directories, that will slow down the"},{"line_number":56,"context_line":"init/reload of policy rules. But that won\u0027t be an issue."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Configuration Impact"},{"line_number":59,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_c4a5b8a2","line":56,"updated":"2014-07-08 01:25:55.000000000","message":"Suggest removing \"But that wont be an issue.\" it isn\u0027t really needed.","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"289b34773b6b4a081226edcc4e71f1afa016cf4e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"------------------"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"This change need iterated a list of directories, that will slow down the"},{"line_number":56,"context_line":"init/reload of policy rules. But that won\u0027t be an issue."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Configuration Impact"},{"line_number":59,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_4707ea81","line":56,"in_reply_to":"baada198_c4a5b8a2","updated":"2014-07-08 02:22:38.000000000","message":"Done","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"45cdd75d0bbd0b2ed0878c924cbb250b07785e20","unresolved":false,"context_lines":[{"line_number":59,"context_line":"--------------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"This change introduce new configuration option:"},{"line_number":62,"context_line":"policy_definition_path \u003d [list of directories]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default value is \u0027policy.d\u0027. The option is convenient for deployer"},{"line_number":65,"context_line":"change where to store the policy config files."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_24a754a8","line":62,"updated":"2014-07-08 01:25:55.000000000","message":"I assume this is a ListOpt. Suggest being specific on the option type.","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"289b34773b6b4a081226edcc4e71f1afa016cf4e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"--------------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"This change introduce new configuration option:"},{"line_number":62,"context_line":"policy_definition_path \u003d [list of directories]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default value is \u0027policy.d\u0027. The option is convenient for deployer"},{"line_number":65,"context_line":"change where to store the policy config files."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_a700c666","line":62,"in_reply_to":"baada198_24a754a8","updated":"2014-07-08 02:22:38.000000000","message":"yes, it is ListOpt, thanks, will update.","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"45cdd75d0bbd0b2ed0878c924cbb250b07785e20","unresolved":false,"context_lines":[{"line_number":62,"context_line":"policy_definition_path \u003d [list of directories]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default value is \u0027policy.d\u0027. The option is convenient for deployer"},{"line_number":65,"context_line":"change where to store the policy config files."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer Impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_04ac108b","line":65,"updated":"2014-07-08 01:25:55.000000000","message":"\u0027policy.d\u0027 or \u0027/etc/policy.d\u0027 or ? what is the initial lookup location? Suggest being explicit about the default and where that default will start from to perform the lookup.","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"289b34773b6b4a081226edcc4e71f1afa016cf4e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"policy_definition_path \u003d [list of directories]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default value is \u0027policy.d\u0027. The option is convenient for deployer"},{"line_number":65,"context_line":"change where to store the policy config files."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer Impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_a7460679","line":65,"in_reply_to":"baada198_04ac108b","updated":"2014-07-08 02:22:38.000000000","message":"the default value should be \u0027policy.d\u0027, just like \u0027policy_file\u0027\u0027 default value is \u0027policy.json\u0027. The path will be find as below: https://github.com/openstack/oslo-incubator/blob/master/openstack/common/policy.py#L254","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"fc7874ab1c6057e2bd9e4e69ad9026fde669c0b0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"policy_definition_path \u003d [list of directories]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default value is \u0027policy.d\u0027. The option is convenient for deployer"},{"line_number":65,"context_line":"change where to store the policy config files."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Developer Impact"},{"line_number":68,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_c7277ac8","line":65,"in_reply_to":"baada198_a7460679","updated":"2014-07-08 02:23:58.000000000","message":"Great! suggest specifying that you\u0027ll use the same lookup as \u0027policy_file\u0027.","commit_id":"0bb0dfbaad6f30f2ff40a603d311b7aef2045b43"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"9b4c53ba8f0e2eea9e50d6197bceee951d3a7182","unresolved":false,"context_lines":[{"line_number":21,"context_line":"that loaded from policy configuration directories will override the default"},{"line_number":22,"context_line":"policy rules from \u0027policy_file\u0027."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Add new configuration option:"},{"line_number":25,"context_line":"cfg.ListOpt(\u0027policy_configuration_directories\u0027, default\u003d[\u0027policy.d\u0027],"},{"line_number":26,"context_line":"            help\u003d_(\u0027The directories of policy configuration\u0027))"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_d2d816f1","line":24,"updated":"2014-07-08 03:06:28.000000000","message":"If you add a new line here and indent the cfg.ListOpt it should resolve the doc build errors.","commit_id":"8c03bf7623cc155fe80066b2c451d5b92f9899b4"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cc193c917d77d47c3953a92d4df739a7c5a31e50","unresolved":false,"context_lines":[{"line_number":21,"context_line":"that loaded from policy configuration directories will override the default"},{"line_number":22,"context_line":"policy rules from \u0027policy_file\u0027."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Add new configuration option:"},{"line_number":25,"context_line":"cfg.ListOpt(\u0027policy_configuration_directories\u0027, default\u003d[\u0027policy.d\u0027],"},{"line_number":26,"context_line":"            help\u003d_(\u0027The directories of policy configuration\u0027))"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_18e1cf29","line":24,"in_reply_to":"baada198_d2d816f1","updated":"2014-07-08 04:20:09.000000000","message":"thanks!","commit_id":"8c03bf7623cc155fe80066b2c451d5b92f9899b4"}]}