)]}'
{"specs/juno/policy-compare-kind-with-match.rst":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"62abbf9caedc6fac981a180cfb49a7a5ab19599c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For example, if rule in policy.json is configured as:"},{"line_number":11,"context_line":"\u0027sample_rule\u0027: \u0027test_1234:%(test_key)s\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"then test_1234 \u003d\u003d %(test_key)s should return True if %(test_key)s has"},{"line_number":14,"context_line":"value \u0027test_1234\u0027,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"where \u0027test_1234\u0027 is \u0027kind\u0027 and \u0027%(test_key)s\u0027 is \u0027match\u0027."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_4b4f3334","line":13,"updated":"2014-07-14 10:19:15.000000000","message":"s/has/equals ?","commit_id":"69d6944d6945c710da71e9c508bfda4d6b993945"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4b722a12bc58a83f5fa265de57f7f3cdf351f801","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For example, if rule in policy.json is configured as:"},{"line_number":11,"context_line":"\u0027sample_rule\u0027: \u0027test_1234:%(test_key)s\u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"then test_1234 \u003d\u003d %(test_key)s should return True if %(test_key)s has"},{"line_number":14,"context_line":"value \u0027test_1234\u0027,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"where \u0027test_1234\u0027 is \u0027kind\u0027 and \u0027%(test_key)s\u0027 is \u0027match\u0027."}],"source_content_type":"text/x-rst","patch_set":4,"id":"baada198_b64748a2","line":13,"in_reply_to":"baada198_4b4f3334","updated":"2014-07-14 10:37:36.000000000","message":"Done","commit_id":"69d6944d6945c710da71e9c508bfda4d6b993945"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ea0cd29085ed3f25fb0891ce8005ca4f12e57b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"policy.json - Comparing kind against match"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/oslo/+spec/policy-compare-kind-with-match"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_f9974ce9","line":2,"updated":"2014-07-17 18:19:42.000000000","message":"I\u0027m not sure if \"kind\" and \"match\" are aspects of the policy that are widely understand and just not familiar to me, or if those are implementation details. Could you find a title that describes what this spec is for with more detail?","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"66d658e30268c8ccfc15e69c640a6b346e7822cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"policy.json - Comparing kind against match"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"https://blueprints.launchpad.net/oslo/+spec/policy-compare-kind-with-match"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_c77b2f27","line":2,"in_reply_to":"baada198_f9974ce9","updated":"2014-07-21 08:55:01.000000000","message":"Policies - Add new rule check for comparing the parameters","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"8662b6c853b1f031e97b4382b514d3785d3a9a8f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"then test_1234 \u003d\u003d %(test_key)s should return True if %(test_key)s equals to"},{"line_number":14,"context_line":"\u0027test_1234\u0027,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"where \u0027test_1234\u0027 is \u0027kind\u0027 and \u0027%(test_key)s\u0027 is \u0027match\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_d7032874","line":16,"updated":"2014-07-17 22:24:05.000000000","message":"I don\u0027t think I like this terminology.  This is basically an equality check - one half of the : needs to match the other half, where one half is a parameter.  In fact, I would even suggest changing the syntax to be something like:\n\n  \u0027sample_rule\u0027: \u0027test_1234\u003d\u003d%(test_key)s\u0027\n\nSo I would call it something like EqualityCheck or ParameterEqualityCheck, if I\u0027m understanding right.  But I echo Doug\u0027s comments below about not seeing the whole picture here, so I would love to see some more explanation of how this differs from existing functionality.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a3874c961d4df2257bb3ad9d9b377db304ce1e19","unresolved":false,"context_lines":[{"line_number":13,"context_line":"then test_1234 \u003d\u003d %(test_key)s should return True if %(test_key)s equals to"},{"line_number":14,"context_line":"\u0027test_1234\u0027,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"where \u0027test_1234\u0027 is \u0027kind\u0027 and \u0027%(test_key)s\u0027 is \u0027match\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_a25b8984","line":16,"in_reply_to":"baada198_8795b733","updated":"2014-07-21 09:14:33.000000000","message":"I will add a new class ParameterEqualityCheck which will do the equality check.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"66d658e30268c8ccfc15e69c640a6b346e7822cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"then test_1234 \u003d\u003d %(test_key)s should return True if %(test_key)s equals to"},{"line_number":14,"context_line":"\u0027test_1234\u0027,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"where \u0027test_1234\u0027 is \u0027kind\u0027 and \u0027%(test_key)s\u0027 is \u0027match\u0027."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Problem description"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_8795b733","line":16,"in_reply_to":"baada198_d7032874","updated":"2014-07-21 08:55:01.000000000","message":"Ben your understanding is correct.\n\n\u0027sample_rule\u0027: \u0027test_1234\u003d\u003d%(test_key)s\u0027 makes more sense","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ea0cd29085ed3f25fb0891ce8005ca4f12e57b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"instance properties, you need to pass these properties explicitly through the"},{"line_number":26,"context_line":"\u0027credential\u0027 dictionary, otherwise \u0027KeyError\u0027 will be raised as this"},{"line_number":27,"context_line":"information is not present in the \u0027credential\u0027 dictionary and the particular"},{"line_number":28,"context_line":"policy rule will not work as per expectation."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_190c0094","line":28,"updated":"2014-07-17 18:19:42.000000000","message":"It isn\u0027t clear how this change makes it so the values no longer need to be passed explicitly. Can you elaborate on that? Maybe providing an example of how doing this is implemented now, and how that implementation would be different?","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ea0cd29085ed3f25fb0891ce8005ca4f12e57b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"In GenericCheck class, we will add a simple check to compare \u0027kind\u0027 with"},{"line_number":34,"context_line":"\u0027match\u0027. If this comparison is matched then it will return True or else"},{"line_number":35,"context_line":"it will compare using \u0027credential\u0027 dictionary."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"For example, ::"},{"line_number":38,"context_line":"    if self.kind \u003d\u003d match: ::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_3ca8d2da","line":35,"updated":"2014-07-17 18:19:42.000000000","message":"The leftval value is already derived from the kind. I don\u0027t understand how this proposal means to change that. An example, as mentioned above, might help me understand.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ea0cd29085ed3f25fb0891ce8005ca4f12e57b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"it will compare using \u0027credential\u0027 dictionary."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"For example, ::"},{"line_number":38,"context_line":"    if self.kind \u003d\u003d match: ::"},{"line_number":39,"context_line":"        return True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_fc01fa04","line":38,"updated":"2014-07-17 18:19:42.000000000","message":"I think you want a blank line before this line and then remove the trailing ::.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"66d658e30268c8ccfc15e69c640a6b346e7822cd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"it will compare using \u0027credential\u0027 dictionary."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"For example, ::"},{"line_number":38,"context_line":"    if self.kind \u003d\u003d match: ::"},{"line_number":39,"context_line":"        return True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_c73ecf28","line":38,"in_reply_to":"baada198_fc01fa04","updated":"2014-07-21 08:55:01.000000000","message":"Done","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ea0cd29085ed3f25fb0891ce8005ca4f12e57b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"----------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Target Milestone for completion:"},{"line_number":89,"context_line":"    Juno-2"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Work Items"},{"line_number":92,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_79f25c9c","line":89,"updated":"2014-07-17 18:19:42.000000000","message":"This should change to at least j-3.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"66d658e30268c8ccfc15e69c640a6b346e7822cd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"----------"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Target Milestone for completion:"},{"line_number":89,"context_line":"    Juno-2"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Work Items"},{"line_number":92,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_47c71f12","line":89,"in_reply_to":"baada198_79f25c9c","updated":"2014-07-21 08:55:01.000000000","message":"I have the implementation ready along with unit tests, I will be able to commit the changes asap.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"19ea0cd29085ed3f25fb0891ce8005ca4f12e57b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Documentation Impact"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dependencies"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_596cb836","line":119,"updated":"2014-07-17 18:19:42.000000000","message":"This new behavior needs to be documented somewhere. Is there a manual with instructions for writing policy files?","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"66d658e30268c8ccfc15e69c640a6b346e7822cd","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Documentation Impact"},{"line_number":117,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Dependencies"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_a7455b70","line":119,"in_reply_to":"baada198_596cb836","updated":"2014-07-21 08:55:01.000000000","message":"http://docs.openstack.org/developer/glance/policies.html\n\nthis is the only document I have referred.","commit_id":"281b2e7b09ea942e4feece40d1322de6c94a582a"}]}