)]}'
{"specs/juno/trusted-messaging.rst":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"08f4fbe6f8547f54a69a98f7033f009a3433d3a3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"use of python-kiteclient. This plugin will use Kite mechanisms to secure the"},{"line_number":58,"context_line":"message body, adding both encryption and authentication. Please see information"},{"line_number":59,"context_line":"about Kite for specifics on how this is achieved, however some select"},{"line_number":60,"context_line":"information is presented below."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_2be022f9","line":60,"updated":"2014-10-27 21:11:16.000000000","message":"Do you intend to include both plugins in oslo.messaging, or will the kite-based plugin live in another package to be installed separately?","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"bb12ef3dcd7a742c10ef24ff6dd56ba86150189c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"use of python-kiteclient. This plugin will use Kite mechanisms to secure the"},{"line_number":58,"context_line":"message body, adding both encryption and authentication. Please see information"},{"line_number":59,"context_line":"about Kite for specifics on how this is achieved, however some select"},{"line_number":60,"context_line":"information is presented below."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_7b356245","line":60,"in_reply_to":"7a8c0949_2ddd4271","updated":"2014-11-10 11:27:44.000000000","message":"Agreed, the Kite based plugin should be moved into the kite-client project. Only the pass-through plugin will be packaged in oslo.messaging directly.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"use of python-kiteclient. This plugin will use Kite mechanisms to secure the"},{"line_number":58,"context_line":"message body, adding both encryption and authentication. Please see information"},{"line_number":59,"context_line":"about Kite for specifics on how this is achieved, however some select"},{"line_number":60,"context_line":"information is presented below."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_2ddd4271","line":60,"in_reply_to":"9aa7fdbe_2be022f9","updated":"2014-10-31 14:40:15.000000000","message":"As i can see, it should come as separate package. As i can recall this is a common strategy for third-party tools like Kite.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"The alternative approach to message security would be to modify the transport"},{"line_number":66,"context_line":"layer itself, rather than using a plugin. It was decided that a plugin was"},{"line_number":67,"context_line":"cleaner to implement and significantly less invasive to existing olso.messaging"},{"line_number":68,"context_line":"code and features."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Impact on Existing APIs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_6de74a41","line":67,"updated":"2014-10-31 14:40:15.000000000","message":"oslo.messaging","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"08f4fbe6f8547f54a69a98f7033f009a3433d3a3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"The alternative approach to message security would be to modify the transport"},{"line_number":66,"context_line":"layer itself, rather than using a plugin. It was decided that a plugin was"},{"line_number":67,"context_line":"cleaner to implement and significantly less invasive to existing olso.messaging"},{"line_number":68,"context_line":"code and features."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Impact on Existing APIs"},{"line_number":71,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_0b26fe67","line":68,"updated":"2014-10-27 21:11:16.000000000","message":"Another alternative is to invoke the plugin at a lower level, so the entire message can be secured. It sounds like that was rejected because of the amount of change in oslo.messaging?","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"bb12ef3dcd7a742c10ef24ff6dd56ba86150189c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"The alternative approach to message security would be to modify the transport"},{"line_number":66,"context_line":"layer itself, rather than using a plugin. It was decided that a plugin was"},{"line_number":67,"context_line":"cleaner to implement and significantly less invasive to existing olso.messaging"},{"line_number":68,"context_line":"code and features."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Impact on Existing APIs"},{"line_number":71,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_fb76b205","line":68,"in_reply_to":"9aa7fdbe_0b26fe67","updated":"2014-11-10 11:27:44.000000000","message":"correct, working at this level is much less invasive to the existing system.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"08f4fbe6f8547f54a69a98f7033f009a3433d3a3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Impact on Existing APIs"},{"line_number":71,"context_line":"-----------------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Adding the plugin framework requires the addition of a SecurityPolicyBase"},{"line_number":74,"context_line":"abstract base class to the public API. To accompany this class a number of new"},{"line_number":75,"context_line":"exception types will been added, derived from the existing MessageException"},{"line_number":76,"context_line":"base. A new entry point \u0027oslo.messaging.security\u0027 will also be defined that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_8bacae8d","line":73,"updated":"2014-10-27 21:11:16.000000000","message":"Have you thought about what the API for that class needs to look like, yet?","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"bb12ef3dcd7a742c10ef24ff6dd56ba86150189c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"Impact on Existing APIs"},{"line_number":71,"context_line":"-----------------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Adding the plugin framework requires the addition of a SecurityPolicyBase"},{"line_number":74,"context_line":"abstract base class to the public API. To accompany this class a number of new"},{"line_number":75,"context_line":"exception types will been added, derived from the existing MessageException"},{"line_number":76,"context_line":"base. A new entry point \u0027oslo.messaging.security\u0027 will also be defined that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_db501661","line":73,"in_reply_to":"9aa7fdbe_8bacae8d","updated":"2014-11-10 11:27:44.000000000","message":"please see the code patch here: https://review.openstack.org/#/c/109806/","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"08f4fbe6f8547f54a69a98f7033f009a3433d3a3","unresolved":false,"context_lines":[{"line_number":145,"context_line":"- port, The kite port number."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"All Kite plugin options will live within the configuration group:"},{"line_number":148,"context_line":"- \u0027message_security_kite\u0027."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Developer Impact"},{"line_number":151,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_eb953a33","line":148,"updated":"2014-10-27 21:11:16.000000000","message":"We may want that to be \u0027oslo.messaging.security.kite\u0027 to be consistent with the pattern we\u0027re developing. See http://docs.openstack.org/developer/stevedore/tutorial/naming.html","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"bb12ef3dcd7a742c10ef24ff6dd56ba86150189c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"- port, The kite port number."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"All Kite plugin options will live within the configuration group:"},{"line_number":148,"context_line":"- \u0027message_security_kite\u0027."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Developer Impact"},{"line_number":151,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_3bee7a8c","line":148,"in_reply_to":"7a8c0949_0dd0864f","updated":"2014-11-10 11:27:44.000000000","message":"agreed, this should obey the convention.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"- port, The kite port number."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"All Kite plugin options will live within the configuration group:"},{"line_number":148,"context_line":"- \u0027message_security_kite\u0027."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Developer Impact"},{"line_number":151,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_0dd0864f","line":148,"in_reply_to":"9aa7fdbe_eb953a33","updated":"2014-10-31 14:40:15.000000000","message":"+1","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"08f4fbe6f8547f54a69a98f7033f009a3433d3a3","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"If no plugin is specified then there is no impact. If a security plugin is"},{"line_number":154,"context_line":"required then all mechanisms are internal to that plugin and oslo.messaging and"},{"line_number":155,"context_line":"so will not affect client code."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"If using the Kite plugin then a Kite server must be available. Other plugins"},{"line_number":158,"context_line":"may add requirements specific to their individual needs."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9aa7fdbe_6ba14a93","line":155,"updated":"2014-10-27 21:11:16.000000000","message":"Will received messages be given any extra fields related to the new security? For example, a certified sender ID or something like that?","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"bb12ef3dcd7a742c10ef24ff6dd56ba86150189c","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"If no plugin is specified then there is no impact. If a security plugin is"},{"line_number":154,"context_line":"required then all mechanisms are internal to that plugin and oslo.messaging and"},{"line_number":155,"context_line":"so will not affect client code."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"If using the Kite plugin then a Kite server must be available. Other plugins"},{"line_number":158,"context_line":"may add requirements specific to their individual needs."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_3eaae770","line":155,"in_reply_to":"7a8c0949_2d72a27c","updated":"2014-11-10 11:27:44.000000000","message":"Very good question, in order to send a message secured with the kite plugin the transmitting peer must have requested a ticket from Kite. This requires an appropriate Keystone session, so can we consider the sender trusted in this scenario? Regardless, a sender field is included with the signed secure message and I should document this explicitly.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"If no plugin is specified then there is no impact. If a security plugin is"},{"line_number":154,"context_line":"required then all mechanisms are internal to that plugin and oslo.messaging and"},{"line_number":155,"context_line":"so will not affect client code."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"If using the Kite plugin then a Kite server must be available. Other plugins"},{"line_number":158,"context_line":"may add requirements specific to their individual needs."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_2d72a27c","line":155,"in_reply_to":"9aa7fdbe_6ba14a93","updated":"2014-10-31 14:40:15.000000000","message":"Good question. Because this is a potential place for security breaks. We have to be sure that income message was send by really trusted site.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"--------------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Integration tests should be run against a Kite server if desired. However, if"},{"line_number":164,"context_line":"using the pass-through plugin then Unit Testing is sufficient."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Implementation"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_2df9c2c8","line":164,"updated":"2014-10-31 14:40:15.000000000","message":"I\u0027d suggest to rephrase this one.\n\n\nFor example, for pass-through pluging unit tests would be added due to absent workflow impact.\nBut for other security plugings functional tests are allowed.\n\nsomething like that.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"bb12ef3dcd7a742c10ef24ff6dd56ba86150189c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"--------------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Integration tests should be run against a Kite server if desired. However, if"},{"line_number":164,"context_line":"using the pass-through plugin then Unit Testing is sufficient."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Implementation"},{"line_number":167,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_1bf9be4d","line":164,"in_reply_to":"7a8c0949_2df9c2c8","updated":"2014-11-10 11:27:44.000000000","message":"sure, I\u0027ll revise this.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Milestones"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Target Milestone for completion:"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Work Items"},{"line_number":184,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_6d1aea18","line":181,"updated":"2014-10-31 14:40:15.000000000","message":"please mention milestone.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"- Creation of the secure messaging plugin framework"},{"line_number":187,"context_line":"- Creation of the plugins (Kite, pass-through)"},{"line_number":188,"context_line":"- Addition of ticket caching for Kite plugin"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Incubation"},{"line_number":191,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_8d1716ed","line":188,"updated":"2014-10-31 14:40:15.000000000","message":"testing.","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"c02867df32037ba1c2fe5f3c793a653a9a3b644e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"Incubation"},{"line_number":191,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"None"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"Documentation Impact"},{"line_number":196,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8c0949_cdd83e56","line":193,"updated":"2014-10-31 14:40:15.000000000","message":"was Kite incubated?","commit_id":"cfe8a1c3d9db98f9c46cf9a1016dbb304724b287"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"e85c21804560e75a1b6e188cf4285c4353f6f607","unresolved":false,"context_lines":[{"line_number":205,"context_line":"Incubation"},{"line_number":206,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"????"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"Documentation Impact"},{"line_number":211,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a890539_76ec5890","line":208,"updated":"2014-11-12 14:36:35.000000000","message":"Apologies, I\u0027m not sure what to put in this section. if anyone could give input that would be great.","commit_id":"15d3dc2d77bc957486075ff838c7c90689fc1722"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"260f7b8f867c555cf443cca601ea64bb4f94f281","unresolved":false,"context_lines":[{"line_number":12,"context_line":"well as notifications. Messages are not well protected in OpenStack today. Once"},{"line_number":13,"context_line":"a message is on the queue, no further authorization checks of that message are"},{"line_number":14,"context_line":"performed. Any peer with access to the queue may post messages and no"},{"line_number":15,"context_line":"authentication is done to validate the message sender or recipient."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Proposed change"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_9e3980f4","line":15,"updated":"2015-06-19 02:46:50.000000000","message":"This doesn\u0027t really describe the problem it just states the situation.\n\nIt needs something like \u0027this architecture permits cascade failures where a compromised nova-compute host can pretend to be a nova-conductor and spawn maliciously configured VMs at will on other hosts.\u0027","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"cdba28ac598c798d577bc82e257d79ff9a4af602","unresolved":false,"context_lines":[{"line_number":43,"context_line":"should be part of the security layer itself. By authenticating messages any"},{"line_number":44,"context_line":"tampering with the transport information becomes obvious, i.e. messages"},{"line_number":45,"context_line":"received by, or claiming to originate from a false peer will fail to"},{"line_number":46,"context_line":"authenticate properly."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the plugin interface is introduced to oslo.messaging the actual security"},{"line_number":49,"context_line":"features will need to be added. These features will be packaged up into"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_cd0b257b","line":46,"updated":"2014-11-18 01:10:25.000000000","message":"I dont think this is correct. The \u0027body\u0027 is only a part of the message, there is also the context which typically contains info  like the current auth token. \n\nIf we are going to sign the message we need to sign the entire message.\n\nIdeally looking at rpc_common.serialize there are two parts: oslo.version and oslo.message. The \u0027encrypt\u0027 flag available in kite should encrypt the entire oslo.message section. The metadata and signature will then need to be added at that top layer and the signature should span oslo.version, the encrypted oslo.message and (name guess) oslo.secure_metadata.\n\nIn my tests though this is fairly difficult with the structure of the library as there are modifications to the message even in the driver layer (like adding _msg_id fields) which we would should sign.","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"260f7b8f867c555cf443cca601ea64bb4f94f281","unresolved":false,"context_lines":[{"line_number":43,"context_line":"should be part of the security layer itself. By authenticating messages any"},{"line_number":44,"context_line":"tampering with the transport information becomes obvious, i.e. messages"},{"line_number":45,"context_line":"received by, or claiming to originate from a false peer will fail to"},{"line_number":46,"context_line":"authenticate properly."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the plugin interface is introduced to oslo.messaging the actual security"},{"line_number":49,"context_line":"features will need to be added. These features will be packaged up into"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_be132464","line":46,"in_reply_to":"5a890539_813ab8e4","updated":"2015-06-19 02:46:50.000000000","message":"Also there are proposals to change the message format to e.g. msgpack, and we need to cater to that. I don\u0027t know that it causes an issue, but please be aware of it.","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"cd771112978b7dfdac6d4a88cf1d9536d7550dca","unresolved":false,"context_lines":[{"line_number":43,"context_line":"should be part of the security layer itself. By authenticating messages any"},{"line_number":44,"context_line":"tampering with the transport information becomes obvious, i.e. messages"},{"line_number":45,"context_line":"received by, or claiming to originate from a false peer will fail to"},{"line_number":46,"context_line":"authenticate properly."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Once the plugin interface is introduced to oslo.messaging the actual security"},{"line_number":49,"context_line":"features will need to be added. These features will be packaged up into"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_813ab8e4","line":46,"in_reply_to":"5a890539_cd0b257b","updated":"2014-11-18 13:35:07.000000000","message":"humm, yes I see. It becomes difficult to maintain transport stuff and security stuff as orthogonal elements when driver details like the _msg_id need to be signed. I guess it\u0027s not inconceivable that differing drivers may also want to add their own specific fields to the message as well.\n\nAs you say, this becomes fairly difficult. Some more experimentation is probably needed here.","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"260f7b8f867c555cf443cca601ea64bb4f94f281","unresolved":false,"context_lines":[{"line_number":58,"context_line":"This plugin will use Kite mechanisms to secure the message body, adding both"},{"line_number":59,"context_line":"encryption and authentication. Please see information about Kite for specifics"},{"line_number":60,"context_line":"on how this is achieved, however some select information is presented below."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Alternatives"},{"line_number":63,"context_line":"------------"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_71662dee","line":61,"updated":"2015-06-19 02:46:50.000000000","message":"And having presented a possible attack above I think we should say here how this addresses it - secured messaging doesn\u0027t itself stop a compute host impersonating a conductor...","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"92ddbda9d07cb5b161f8cac9c17019ce38f61611","unresolved":false,"context_lines":[{"line_number":94,"context_line":"be subject to export restrictions or compliancy issues."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Finally, the Kite server represents a potential single failure point. If Kite"},{"line_number":97,"context_line":"is unreachable for some reason then message communications will quickly fail."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"It should also be noted that this proposed change will not provide security for"},{"line_number":100,"context_line":"notifications and is limited in scope to call and cast style messages."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_f7249061","line":97,"updated":"2014-11-13 21:12:34.000000000","message":"What is the mitigation for that? Should messages fail to send, or should we fall back to sending them insecurely to keep the rest of the services online?","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"cd771112978b7dfdac6d4a88cf1d9536d7550dca","unresolved":false,"context_lines":[{"line_number":94,"context_line":"be subject to export restrictions or compliancy issues."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"Finally, the Kite server represents a potential single failure point. If Kite"},{"line_number":97,"context_line":"is unreachable for some reason then message communications will quickly fail."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"It should also be noted that this proposed change will not provide security for"},{"line_number":100,"context_line":"notifications and is limited in scope to call and cast style messages."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_5c2c3799","line":97,"in_reply_to":"5a890539_f7249061","updated":"2014-11-18 13:35:07.000000000","message":"I think this becomes a matter of policy, the deployer should decide if it is appropriate to send clear messages in a failure situation or not. I guess we should allow a configuration choice.","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"92ddbda9d07cb5b161f8cac9c17019ce38f61611","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The exact performance impact of this change will depend on the plugin being"},{"line_number":106,"context_line":"used. If no plugin is requested or the pass-through plugin is used then there"},{"line_number":107,"context_line":"will be no meaningful performance impact."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The Kite plugin will have a performance impact that stems from the use of"},{"line_number":110,"context_line":"cryptographic routines to secure the message body when sending and to decipher"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_b7d5a81d","line":107,"updated":"2014-11-13 21:12:34.000000000","message":"Can we make the pass-through the default, and not provide an option to not pass a plugin in the code?","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"cd771112978b7dfdac6d4a88cf1d9536d7550dca","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"The exact performance impact of this change will depend on the plugin being"},{"line_number":106,"context_line":"used. If no plugin is requested or the pass-through plugin is used then there"},{"line_number":107,"context_line":"will be no meaningful performance impact."},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"The Kite plugin will have a performance impact that stems from the use of"},{"line_number":110,"context_line":"cryptographic routines to secure the message body when sending and to decipher"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_5cefd71d","line":107,"in_reply_to":"5a890539_b7d5a81d","updated":"2014-11-18 13:35:07.000000000","message":"we could, though I\u0027m not sure what we gain by doing this? the pass-through is intended for testing and logging, rather than as a noop plugin. Im totally open to the option of making it the default choice and always requiring a plugin, I\u0027m just not sure why we would want that.","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"92ddbda9d07cb5b161f8cac9c17019ce38f61611","unresolved":false,"context_lines":[{"line_number":192,"context_line":"----------"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Target Milestone for completion:"},{"line_number":195,"context_line":"  Kilo"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Work Items"},{"line_number":198,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_37d37805","line":195,"updated":"2014-11-13 21:12:34.000000000","message":"Kilo is the name of the release cycle. This is probably a Kilo-2 feature, to give us time to set up functional tests. Does that timing seem OK for you?","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"cd771112978b7dfdac6d4a88cf1d9536d7550dca","unresolved":false,"context_lines":[{"line_number":192,"context_line":"----------"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Target Milestone for completion:"},{"line_number":195,"context_line":"  Kilo"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Work Items"},{"line_number":198,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a890539_9c43ff11","line":195,"in_reply_to":"5a890539_37d37805","updated":"2014-11-18 13:35:07.000000000","message":"that seems fairly reasonable","commit_id":"44049c7c7ce181bca3504b8fe1a0b246bfa6cbe8"}]}