)]}'
{"specs/liberty/oslo.messaging-remove-double-reply.rst":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"06cbcacfc673a1fc3ea19246fa9f61de7516e875","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Documentation Impact"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Inform deployer about futur incompatibilly with a too old oslo.messaging version"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aca2d91_f86e202e","line":145,"updated":"2015-05-07 14:28:17.000000000","message":"Nit: \u0027future\u0027","commit_id":"d70141094369ce67f03c2e68ec30df4938446c86"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"3c51a81910c770203abd7075f05b7cf021074e53","unresolved":false,"context_lines":[{"line_number":142,"context_line":"Documentation Impact"},{"line_number":143,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Inform deployer about futur incompatibilly with a too old oslo.messaging version"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Dependencies"},{"line_number":148,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1aca2d91_5c04c848","line":145,"in_reply_to":"1aca2d91_f86e202e","updated":"2015-05-08 09:25:08.000000000","message":"Done","commit_id":"d70141094369ce67f03c2e68ec30df4938446c86"},{"author":{"_account_id":14421,"name":"Alexey Khivin","email":"akhivin@gmail.com","username":"akhivin"},"change_message_id":"2a5dcdb91d188733a78bcedda75d57b68259f4a6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"the attribute \"result\" OR \"ending\" the new one will have \"result\" AND"},{"line_number":61,"context_line":"\"ending\"."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Any other idea are welcome."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Note that issue is in the RPC call replies code. In case of rolling upgrade, we"},{"line_number":66,"context_line":"have to think about the fact that the client will wait message that can"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_05acb0eb","line":63,"updated":"2015-05-08 13:21:48.000000000","message":"ideas","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"12e6ce8bb8b134bd3e96bc531e9c31cd24a7d24d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"the attribute \"result\" OR \"ending\" the new one will have \"result\" AND"},{"line_number":61,"context_line":"\"ending\"."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Any other idea are welcome."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Note that issue is in the RPC call replies code. In case of rolling upgrade, we"},{"line_number":66,"context_line":"have to think about the fact that the client will wait message that can"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_a664e221","line":63,"in_reply_to":"1aca2d91_05acb0eb","updated":"2015-05-08 14:46:13.000000000","message":"Done","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":14421,"name":"Alexey Khivin","email":"akhivin@gmail.com","username":"akhivin"},"change_message_id":"2a5dcdb91d188733a78bcedda75d57b68259f4a6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Note that issue is in the RPC call replies code. In case of rolling upgrade, we"},{"line_number":66,"context_line":"have to think about the fact that the client will wait message that can"},{"line_number":67,"context_line":"come from same or upper version of oslo.messaging. We already do not support"},{"line_number":68,"context_line":"lower version from the application PoV."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Or from the server point of view, we will send reply that must be"},{"line_number":71,"context_line":"understandable by a wide panel of versions."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_5a45e314","line":68,"updated":"2015-05-08 13:21:48.000000000","message":"versions(?)","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"12e6ce8bb8b134bd3e96bc531e9c31cd24a7d24d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Note that issue is in the RPC call replies code. In case of rolling upgrade, we"},{"line_number":66,"context_line":"have to think about the fact that the client will wait message that can"},{"line_number":67,"context_line":"come from same or upper version of oslo.messaging. We already do not support"},{"line_number":68,"context_line":"lower version from the application PoV."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Or from the server point of view, we will send reply that must be"},{"line_number":71,"context_line":"understandable by a wide panel of versions."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_666eca02","line":68,"in_reply_to":"1aca2d91_5a45e314","updated":"2015-05-08 14:46:13.000000000","message":"Done","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":14421,"name":"Alexey Khivin","email":"akhivin@gmail.com","username":"akhivin"},"change_message_id":"2a5dcdb91d188733a78bcedda75d57b68259f4a6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"(Because we need to change RabbitMQ queue attributes or move a queue to"},{"line_number":76,"context_line":"another exchange)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The main goal is to choice the version limit for backward compatibility and use"},{"line_number":79,"context_line":"the same kind of deprecation in other change like this one."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Impact on Existing APIs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_5a13a30d","line":78,"updated":"2015-05-08 13:21:48.000000000","message":"Maybe: The main goal is to choose the last supported version in the sense of backward compatibility","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"12e6ce8bb8b134bd3e96bc531e9c31cd24a7d24d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"(Because we need to change RabbitMQ queue attributes or move a queue to"},{"line_number":76,"context_line":"another exchange)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The main goal is to choice the version limit for backward compatibility and use"},{"line_number":79,"context_line":"the same kind of deprecation in other change like this one."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Impact on Existing APIs"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_861c4678","line":78,"in_reply_to":"1aca2d91_5a13a30d","updated":"2015-05-08 14:46:13.000000000","message":"not sure, it\u0027s sound\u0027s like a question to @sileht","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":14421,"name":"Alexey Khivin","email":"akhivin@gmail.com","username":"akhivin"},"change_message_id":"2a5dcdb91d188733a78bcedda75d57b68259f4a6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"another exchange)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The main goal is to choice the version limit for backward compatibility and use"},{"line_number":79,"context_line":"the same kind of deprecation in other change like this one."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Impact on Existing APIs"},{"line_number":82,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_faf26fd1","line":79,"updated":"2015-05-08 13:21:48.000000000","message":"changes","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"12e6ce8bb8b134bd3e96bc531e9c31cd24a7d24d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"another exchange)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"The main goal is to choice the version limit for backward compatibility and use"},{"line_number":79,"context_line":"the same kind of deprecation in other change like this one."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Impact on Existing APIs"},{"line_number":82,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1aca2d91_e659ba5b","line":79,"in_reply_to":"1aca2d91_faf26fd1","updated":"2015-05-08 14:46:13.000000000","message":"Done","commit_id":"0f2afa525197c50466f29a4c11f57fc90a79504b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"de992ed309ace4b12254245be1362d9caec095e4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"see [1]_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"It becomes useless to double RPC messages for each call, so we are going to"},{"line_number":19,"context_line":"remove the second AMQP message sending."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change will be not backward compatible, so we have to choice how we handle"},{"line_number":22,"context_line":"this backward compatibility and the deprecation. This spec is the proposed"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_a6f9cc4f","line":19,"updated":"2015-05-12 16:39:43.000000000","message":"Why is this now useless? Do we no longer support providing a generator as the payload?","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"493362a98309d594285741c25bebaf5e771b50c9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"see [1]_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"It becomes useless to double RPC messages for each call, so we are going to"},{"line_number":19,"context_line":"remove the second AMQP message sending."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change will be not backward compatible, so we have to choice how we handle"},{"line_number":22,"context_line":"this backward compatibility and the deprecation. This spec is the proposed"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_58908443","line":19,"in_reply_to":"9a0c5dc1_8963791a","updated":"2015-05-13 12:57:36.000000000","message":"OK","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"848672f616776e8e580e04392a8ac650d8545eed","unresolved":false,"context_lines":[{"line_number":16,"context_line":"see [1]_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"It becomes useless to double RPC messages for each call, so we are going to"},{"line_number":19,"context_line":"remove the second AMQP message sending."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change will be not backward compatible, so we have to choice how we handle"},{"line_number":22,"context_line":"this backward compatibility and the deprecation. This spec is the proposed"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_7d2b5b83","line":19,"in_reply_to":"9a0c5dc1_a6f9cc4f","updated":"2015-05-12 18:02:17.000000000","message":"At the moment we are sending reply with data and then reply with ending. See link -  https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqpdriver.py#L72-L75","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"698ae3951608dba7ce277c34385f4e6af24c10a8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"see [1]_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"It becomes useless to double RPC messages for each call, so we are going to"},{"line_number":19,"context_line":"remove the second AMQP message sending."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This change will be not backward compatible, so we have to choice how we handle"},{"line_number":22,"context_line":"this backward compatibility and the deprecation. This spec is the proposed"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_8963791a","line":19,"in_reply_to":"9a0c5dc1_a6f9cc4f","updated":"2015-05-13 07:49:11.000000000","message":"Yes that was never supported by oslo.messaging, but only by the old rpc API of oslo-incubator.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"de992ed309ace4b12254245be1362d9caec095e4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"We change the ReplyWaiters to handle reply in one message and two messages,"},{"line_number":32,"context_line":"like it does [2]_."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We create a hidden boolean configuration option, defaulted to False."},{"line_number":35,"context_line":"If this one is True, we sent the reply in one message otherwise we keep the"},{"line_number":36,"context_line":"current behavior of two messages."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_6965e543","line":34,"updated":"2015-05-12 16:39:43.000000000","message":"How will the option be \"hidden\"? And why not make it a regular option and build the deprecation period into it from the beginning?","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"848672f616776e8e580e04392a8ac650d8545eed","unresolved":false,"context_lines":[{"line_number":31,"context_line":"We change the ReplyWaiters to handle reply in one message and two messages,"},{"line_number":32,"context_line":"like it does [2]_."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We create a hidden boolean configuration option, defaulted to False."},{"line_number":35,"context_line":"If this one is True, we sent the reply in one message otherwise we keep the"},{"line_number":36,"context_line":"current behavior of two messages."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_b25222dc","line":34,"in_reply_to":"9a0c5dc1_6965e543","updated":"2015-05-12 18:02:17.000000000","message":"I\u0027m not really sure, that this is operator\u0027s deal - to select RPC reply count. But anyway this can be discussed.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"698ae3951608dba7ce277c34385f4e6af24c10a8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"We change the ReplyWaiters to handle reply in one message and two messages,"},{"line_number":32,"context_line":"like it does [2]_."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We create a hidden boolean configuration option, defaulted to False."},{"line_number":35,"context_line":"If this one is True, we sent the reply in one message otherwise we keep the"},{"line_number":36,"context_line":"current behavior of two messages."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_a92cfdab","line":34,"in_reply_to":"9a0c5dc1_6965e543","updated":"2015-05-13 07:49:11.000000000","message":"Regular deprecated option looks good, hidden doesn\u0027t exists.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"de992ed309ace4b12254245be1362d9caec095e4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"This configuration option will allow us to test the old and the future behavior"},{"line_number":39,"context_line":"into our tests suite. And allow to enable this new behavior earlier."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"In N (or M) release cycle:"},{"line_number":42,"context_line":"--------------------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We remove this option and support only the reply in one message."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_29f80de5","line":41,"updated":"2015-05-12 16:39:43.000000000","message":"We should decide which release, so the plan is clear.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"848672f616776e8e580e04392a8ac650d8545eed","unresolved":false,"context_lines":[{"line_number":38,"context_line":"This configuration option will allow us to test the old and the future behavior"},{"line_number":39,"context_line":"into our tests suite. And allow to enable this new behavior earlier."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"In N (or M) release cycle:"},{"line_number":42,"context_line":"--------------------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We remove this option and support only the reply in one message."}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_f2c1ba81","line":41,"in_reply_to":"9a0c5dc1_29f80de5","updated":"2015-05-12 18:02:17.000000000","message":"+1. How should we discuss it?","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"de992ed309ace4b12254245be1362d9caec095e4","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We remove this option and support only the reply in one message."},{"line_number":45,"context_line":"This will break backward compatibility with oslo.messaging\u003c\u003dkilo and"},{"line_number":46,"context_line":"oslo-incubator RPC legacy code."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_49d101cd","line":46,"updated":"2015-05-12 16:39:43.000000000","message":"We may need another step where we have a version of the library with the option\u0027s default changed to enable the new behavior.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"848672f616776e8e580e04392a8ac650d8545eed","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We remove this option and support only the reply in one message."},{"line_number":45,"context_line":"This will break backward compatibility with oslo.messaging\u003c\u003dkilo and"},{"line_number":46,"context_line":"oslo-incubator RPC legacy code."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_32cf52b2","line":46,"in_reply_to":"9a0c5dc1_49d101cd","updated":"2015-05-12 18:02:17.000000000","message":"Agreed. Should we mention this point in spec?","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"698ae3951608dba7ce277c34385f4e6af24c10a8","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We remove this option and support only the reply in one message."},{"line_number":45,"context_line":"This will break backward compatibility with oslo.messaging\u003c\u003dkilo and"},{"line_number":46,"context_line":"oslo-incubator RPC legacy code."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_6c65f343","line":46,"in_reply_to":"9a0c5dc1_49d101cd","updated":"2015-05-13 07:49:11.000000000","message":"Plan for the rolling upgrade. N can always talk to N+1 and the reverse.\n\nIn K:\n\n* rpc-server sends reply in two messages, can reply to \u003c\u003d L+1\n* rpc-client expects replies in two messages, can receive replies from compute nodes \u003c\u003d L \n\nIn L: Implementation of new behavior, but keep default behavior by default.\n\n* rpc-server sends reply in two messages, can reply to \u003c\u003d L+1\n* rpc-client expects replies in two messages or one message, can receive replies from all versions\n\nIn L+1: enable the new behavior and remove the config option\n\n* rpc-server sends reply in one messages, can reply to \u003e\u003d L\n* rpc-client expects replies in two messages or one messages from all versions \n\nIn L+2: remove legacy code that allow to receive replies from \u003c\u003d  L\n\n* rpc-server sends reply in one messages, can reply to \u003e\u003d L+1\n* rpc-client expects replies in one messages, can receive replies from  \u003e\u003d L+1\n\nWe can imagine that the rpc-server is a compute and a rpc-client the scheduler for example.\n\nThis option is only dedicated for early adopter and for testing. This is not need in normal upgrade workflow.\nAnd must  be removed at the same times we enable it to be sure that deployed cloud with L+1 will not break when they are upgraded to L+2 because\nthey are enforcing the old behavior.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"493362a98309d594285741c25bebaf5e771b50c9","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"We remove this option and support only the reply in one message."},{"line_number":45,"context_line":"This will break backward compatibility with oslo.messaging\u003c\u003dkilo and"},{"line_number":46,"context_line":"oslo-incubator RPC legacy code."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Alternatives"},{"line_number":49,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_78c0e82a","line":46,"in_reply_to":"9a0c5dc1_6c65f343","updated":"2015-05-13 12:57:36.000000000","message":"This is excellent detail. Would you add it to the body of the spec? I think it also answers the question above about N or M.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"de992ed309ace4b12254245be1362d9caec095e4","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"We must test that the new ReplyWaiters code can handle reply that come from"},{"line_number":114,"context_line":"a oslo.messaging version that sent reply in one message and from the one"},{"line_number":115,"context_line":"that sent the reply into two messages."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Implementation"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_c6584059","line":115,"updated":"2015-05-12 16:39:43.000000000","message":"How will we do that? Are unit tests sufficient, or do we need a new functional test job?","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"848672f616776e8e580e04392a8ac650d8545eed","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"We must test that the new ReplyWaiters code can handle reply that come from"},{"line_number":114,"context_line":"a oslo.messaging version that sent reply in one message and from the one"},{"line_number":115,"context_line":"that sent the reply into two messages."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Implementation"},{"line_number":118,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a0c5dc1_f2dada77","line":115,"in_reply_to":"9a0c5dc1_c6584059","updated":"2015-05-12 18:02:17.000000000","message":"it can be added either to unittests or to functional tests (or to both). I\u0027ll investigate the best way to test it.","commit_id":"977229830524dda12a1e27f11a4b8c91752deedf"}]}