)]}'
{"specs/liberty/taskflow-stack-trace-on-exception.rst":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"307a946938445259734427353902129bbadeb89a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      File \"/usr/lib/python2.7/json/encoder.py\", line 270, in iterencode"},{"line_number":70,"context_line":"        return _iterencode(o, 0)"},{"line_number":71,"context_line":"    ValueError: Circular reference detected"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Proposed change"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_8b4b0d87","line":72,"updated":"2015-05-28 18:48:23.000000000","message":"Another few examples:\n\nhttp://paste.openstack.org/show/242766/\n\nhttp://paste.openstack.org/show/242765/","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4dd34d5709458393405288110b19bab8ca3783b2","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"Upon encountering errors Taskflow should provide both the Flow/Task call stack"},{"line_number":77,"context_line":"history as well as the specific Python Exception."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Detailed format / look\u0026feel TBD"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_2b009965","line":78,"updated":"2015-05-28 18:40:30.000000000","message":"A question, since a failure can happen at multiple tasks (in parallel/remote execution); what format is shown, is it a snapshot of the current engine state of when it (the task) was found to have failed, or is it a lazy formatting (or something else?).","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"55017052a653c4b552277f2cf1ee08770533e683","unresolved":false,"context_lines":[{"line_number":76,"context_line":"Upon encountering errors Taskflow should provide both the Flow/Task call stack"},{"line_number":77,"context_line":"history as well as the specific Python Exception."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Detailed format / look\u0026feel TBD"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_1eac908a","line":79,"updated":"2015-06-19 02:21:07.000000000","message":"Important consideration - be sure not to capture security relevant local variables.","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4da3a47e579feee64d5ea382faa2fda41a22fb3a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"history as well as the specific Python Exception."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Detailed format / look\u0026feel TBD"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"Alternatives"},{"line_number":82,"context_line":"------------"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_abdfe9d4","line":80,"updated":"2015-05-28 18:45:21.000000000","message":"Something to look at/reference (if u find it useful):\n\nhttps://hg.python.org/cpython/file/b4cbecbc0781/Lib/traceback.py (something similar/better might be nice).","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"d26cdd7006fa615a0cac9a3f00a57b5a8f832fd3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"trace in the log"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"* This is useful for when the flow starts and completes on a single worker"},{"line_number":95,"context_line":"  instance in a single run, however this will not always hold true"},{"line_number":96,"context_line":"* Notifier is also a more advanced usage of taskflow, which is a problem"},{"line_number":97,"context_line":"  considering the current issue of adoption with taskflow is how complex it is"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_fd66c8eb","line":95,"updated":"2015-05-28 19:05:47.000000000","message":".","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4dd34d5709458393405288110b19bab8ca3783b2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"* This is useful for when the flow starts and completes on a single worker"},{"line_number":95,"context_line":"  instance in a single run, however this will not always hold true"},{"line_number":96,"context_line":"* Notifier is also a more advanced usage of taskflow, which is a problem"},{"line_number":97,"context_line":"  considering the current issue of adoption with taskflow is how complex it is"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Impact on Existing APIs"},{"line_number":100,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_0ba5dda0","line":97,"updated":"2015-05-28 18:40:30.000000000","message":"Hmmm, I wonder if that\u0027s a useful description of the current issue. I could say other things:\n\n\u0027the current issue of adoption with taskflow is people not spending enough time asking questions\u0027, or \u0027the current issue of adoption with taskflow is people not spending enough time asking reading the docs\u0027 or \u0027the current issue of adoption with taskflow is people not spending enough time doing things other then vendor code\u0027 .... \n\nI\u0027d almost think leaving this out might be better, since its IMHo to hard to know what the current issue of adoption/other really is (certain people seem to have adopted it just fine) ;-)","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"60e53bceaba1ab80928cbf231d04e48a6a31de07","unresolved":false,"context_lines":[{"line_number":94,"context_line":"* This is useful for when the flow starts and completes on a single worker"},{"line_number":95,"context_line":"  instance in a single run, however this will not always hold true"},{"line_number":96,"context_line":"* Notifier is also a more advanced usage of taskflow, which is a problem"},{"line_number":97,"context_line":"  considering the current issue of adoption with taskflow is how complex it is"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Impact on Existing APIs"},{"line_number":100,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_eb24c10d","line":97,"in_reply_to":"7a016987_0ba5dda0","updated":"2015-05-28 18:41:56.000000000","message":"How about just leave it at \u0027Notifier is also a more advanced usage of taskflow.\u0027 ?","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"d26cdd7006fa615a0cac9a3f00a57b5a8f832fd3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"* This is useful for when the flow starts and completes on a single worker"},{"line_number":95,"context_line":"  instance in a single run, however this will not always hold true"},{"line_number":96,"context_line":"* Notifier is also a more advanced usage of taskflow, which is a problem"},{"line_number":97,"context_line":"  considering the current issue of adoption with taskflow is how complex it is"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Impact on Existing APIs"},{"line_number":100,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_9dea340e","line":97,"in_reply_to":"7a016987_eb24c10d","updated":"2015-05-28 19:05:47.000000000","message":"Or if you want to please provide a precise example of how notifier works http://docs.openstack.org/developer/taskflow/notifications.html\n\nAnother concern which people have is lots of debug statements from taskflow. We should make sure these notifications just display valid ones.","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"d26cdd7006fa615a0cac9a3f00a57b5a8f832fd3","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Failures/Exceptions will require more time to collect flow trace information"},{"line_number":113,"context_line":"and format that information in a meaningful way, whereas previously the"},{"line_number":114,"context_line":"Exception was simply trickled up to the log."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Configuration Impact"},{"line_number":117,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_3d5a20f3","line":114,"updated":"2015-05-28 19:05:47.000000000","message":"If you have a WIP...providing an estimate (some numbers) will be great. We completely believe that this is something useful but if we can quantify it with numbers it will be nice IMHO.","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"55017052a653c4b552277f2cf1ee08770533e683","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Failures/Exceptions will require more time to collect flow trace information"},{"line_number":113,"context_line":"and format that information in a meaningful way, whereas previously the"},{"line_number":114,"context_line":"Exception was simply trickled up to the log."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Configuration Impact"},{"line_number":117,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa32b979_1eda5017","line":114,"in_reply_to":"7a016987_3d5a20f3","updated":"2015-06-19 02:21:07.000000000","message":"Collecting only on failure will be insigificantly slower. If you have enough failures that it matters, thats more of a problem IMO.","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"4dd34d5709458393405288110b19bab8ca3783b2","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The purpose of this change is to improve the end user developer experience for"},{"line_number":125,"context_line":"Taskflow, and hopefully reduce some of the support needs for Taskflow devs by"},{"line_number":126,"context_line":"providing hints to Taskflow users where the errors are in their Task code."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"Testing Impact"},{"line_number":129,"context_line":"--------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_0bfa7d75","line":126,"updated":"2015-05-28 18:40:30.000000000","message":"+1","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"d26cdd7006fa615a0cac9a3f00a57b5a8f832fd3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"--------------"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Unit tests should be sufficient as the changes will result in additional debug"},{"line_number":132,"context_line":"data on failures.  Unit tests that induce failures should result in trace"},{"line_number":133,"context_line":"information being provided."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Implementation"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a016987_9dd47420","line":132,"updated":"2015-05-28 19:05:47.000000000","message":"Extra space","commit_id":"817b510d285e38c3e90d726ce3578d2f54e89cab"}]}
